Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
DaanHoogland closed pull request #13692: conditional import in case we are using xcpng 8.3 URL: https://github.com/apache/cloudstack/pull/13692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
mvds-bbtk commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5732504031 Thanks for providing this fix but for production use this is merely a very temporary workaround since a lot of functionality is lost that depends on lvhdutil. The loss of the ability to create templates from volumes or snapshots or taking snapshots all together means a serious degradation of operations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
weizhouapache commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5615464096 > @DaanHoogland @Pearl1594 > > The latest commit has fixed the issue with SystemVM's with fully patched xcp-ng 8.3 > > However, we see certain operations failing > > 1. Creating template from volume > 2. Create template from snapshot. > > Failure seen in the xensource.log on xcp-ng is below > > ``` > Aug 14 12:00:38 ref-trl-12214-x-mol9-prashanth-reddy-xs1 xapi: [error||6364 :::80|dispatch:host.call_plugin D:eb5bec0c5ac1|backtrace] host.call_plugin R:c6658c7122b8 failed with exception Server_error(XENAPI_PLUGIN_FAILURE, [ non-zero exit; ; Traceback (most recent call last):\x0A File "/etc/xapi.d/plugins/vmopsSnapshot", line 34, in \x0Aimport lvhdutil\x0AModuleNotFoundError: No module named 'lvhdutil'\x0A ]) > Aug 14 12:00:38 ref-trl-12214-x-mol9-prashanth-reddy-xs1 xapi: [error||6364 :::80|dispatch:host.call_plugin D:eb5bec0c5ac1|backtrace] Raised Server_error(XENAPI_PLUGIN_FAILURE, [ non-zero exit; ; Traceback (most recent call last):\x0A File "/etc/xapi.d/plugins/vmopsSnapshot", line 34, in \x0Aimport lvhdutil\x0AModuleNotFoundError: No module named 'lvhdutil'\x0A ]) > ``` > > I think we need to have guard fix in vmopsSnapshot as well. > > Note: this is only fix for xcp-ng 8.3 with SM module reverted. For future versions of xcp-ng ( where lvhdutil is removed), we need fix as suggested here [#13292 (comment)](https://github.com/apache/cloudstack/issues/13292#issuecomment-4683013183) @DaanHoogland I think @prashanthr2 is right, the changes need to be applied on other files too ``` # git grep lvhdutil scripts/vm/hypervisor/xenserver/cloud-plugin-storage:import lvhdutil scripts/vm/hypervisor/xenserver/cloud-plugin-storage:primarySRDir = lvhdutil.VG_PREFIX + primaryStorageSRUuid scripts/vm/hypervisor/xenserver/cloud-plugin-storage:return os.path.join(lvhdutil.VG_LOCATION, primarySRDir) scripts/vm/hypervisor/xenserver/cloud-plugin-storage:vhdInfo = vhdutil.getVHDInfoLVM(lvName, lvhdutil.extractUuid, vgName) scripts/vm/hypervisor/xenserver/cloud-plugin-storage:parentUUID = vhdutil.getParent(path, lvhdutil.extractUuid) scripts/vm/hypervisor/xenserver/vmopsSnapshot:import lvhdutil scripts/vm/hypervisor/xenserver/vmopsSnapshot:vhdInfo = vhdutil.getVHDInfoLVM(lvName, lvhdutil.extractUuid, vgName) scripts/vm/hypervisor/xenserver/vmopsSnapshot:parentUUID = vhdutil.getParent(path, lvhdutil.extractUuid) scripts/vm/hypervisor/xenserver/vmopsSnapshot:primarySRDir = lvhdutil.VG_PREFIX + primaryStorageSRUuid scripts/vm/hypervisor/xenserver/vmopsSnapshot:return os.path.join(lvhdutil.VG_LOCATION, primarySRDir) scripts/vm/hypervisor/xenserver/xenserver84/cloud-plugin-storage:import lvhdutil scripts/vm/hypervisor/xenserver/xenserver84/cloud-plugin-storage: primarySRDir = lvhdutil.VG_PREFIX + primaryStorageSRUuid scripts/vm/hypervisor/xenserver/xenserver84/cloud-plugin-storage: return os.path.join(lvhdutil.VG_LOCATION, primarySRDir) scripts/vm/hypervisor/xenserver/xenserver84/cloud-plugin-storage: vhdInfo = vhdutil.getVHDInfoLVM(lvName, lvhdutil.extractUuid, vgName) scripts/vm/hypervisor/xenserver/xenserver84/cloud-plugin-storage: parentUUID = vhdutil.getParent(path, lvhdutil.extractUuid) scripts/vm/hypervisor/xenserver/xenserver84/vmopsSnapshot:import lvhdutil scripts/vm/hypervisor/xenserver/xenserver84/vmopsSnapshot:vhdInfo = vhdutil.getVHDInfoLVM(lvName, lvhdutil.extractUuid, vgName) scripts/vm/hypervisor/xenserver/xenserver84/vmopsSnapshot: parentUUID = vhdutil.getParent(path, lvhdutil.extractUuid) scripts/vm/hypervisor/xenserver/xenserver84/vmopsSnapshot: primarySRDir = lvhdutil.VG_PREFIX + primaryStorageSRUuid scripts/vm/hypervisor/xenserver/xenserver84/vmopsSnapshot:return os.path.join(lvhdutil.VG_LOCATION, primarySRDir) ``` just a note that these changes only bypass the lvhdutil import issue. lvhdutil is still used in some cases, so we may need to further investigate the potential impact of not importing it. ideally, all usage of lvhdutil could eventually be replaced with other methods. Perhaps @olivierlambert could provide some advice on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
DaanHoogland commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5492278483 ping @prashanthr2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
DaanHoogland commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5424750266 @prashanthr2 , are these issues arising from this fix? if not let’s adress them in new issues/PRs if so, please explain further why we cannot merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
prashanthr2 commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5293118620 @DaanHoogland @Pearl1594 The latest commit has fixed the issue with SystemVM's with fully patched xcp-ng 8.3 However, we see certain operations failing 1. Creating template from volume 2. Create template from snapshot. Failure seen in the xensource.log on xcp-ng is below ``` Aug 14 12:00:38 ref-trl-12214-x-mol9-prashanth-reddy-xs1 xapi: [error||6364 :::80|dispatch:host.call_plugin D:eb5bec0c5ac1|backtrace] host.call_plugin R:c6658c7122b8 failed with exception Server_error(XENAPI_PLUGIN_FAILURE, [ non-zero exit; ; Traceback (most recent call last):\x0A File "/etc/xapi.d/plugins/vmopsSnapshot", line 34, in \x0Aimport lvhdutil\x0AModuleNotFoundError: No module named 'lvhdutil'\x0A ]) Aug 14 12:00:38 ref-trl-12214-x-mol9-prashanth-reddy-xs1 xapi: [error||6364 :::80|dispatch:host.call_plugin D:eb5bec0c5ac1|backtrace] Raised Server_error(XENAPI_PLUGIN_FAILURE, [ non-zero exit; ; Traceback (most recent call last):\x0A File "/etc/xapi.d/plugins/vmopsSnapshot", line 34, in \x0Aimport lvhdutil\x0AModuleNotFoundError: No module named 'lvhdutil'\x0A ]) ``` I think we need to have guard fix in vmopsSnapshot as well. Note: this is only fix for xcp-ng 8.3 with SM module reverted. For future versions of xcp-ng ( where lvhdutil is removed), we need fix as suggested here https://github.com/apache/cloudstack/issues/13292#issuecomment-4683013183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
blueorangutan commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5071602000 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
sonarqubecloud[bot] commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5071076845 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13692) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13692&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13692&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=13692&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13692&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13692&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13692) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
blueorangutan commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5070846818 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
Pearl1594 commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5070829997 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] conditional import in case we are using xcpng 8.3 [cloudstack]
codecov[bot] commented on PR #13692: URL: https://github.com/apache/cloudstack/pull/13692#issuecomment-5070504637 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13692?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.69%. Comparing base ([`0339f31`](https://app.codecov.io/gh/apache/cloudstack/commit/0339f31fb5e94727a32aaeb1fdeb3c333ee5fd83?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afb5eed`](https://app.codecov.io/gh/apache/cloudstack/commit/afb5eed77d5edfb915b6ff1f3c70f08ac87d8792?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0339f31) and HEAD (afb5eed). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (0339f31) | HEAD (afb5eed) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.22 #13692 +/- ## = - Coverage 17.69%3.69% -14.01% = Files 5925 449 -5476 Lines53353438176 -495358 Branches 65273 7072-58201 = - Hits 94421 1409-93012 + Misses 42843436580 -391854 + Partials 10679 187-10492 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13692/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.69% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/13692?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
