Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
borisstoyanov merged PR #12032: URL: https://github.com/apache/cloudstack/pull/12032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
blueorangutan commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3717947370 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
DaanHoogland commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3715030489 ubuntu build issue with maven... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
blueorangutan commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3714882305 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
blueorangutan commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3714654414 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
DaanHoogland commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3714652440 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
sureshanaparti commented on code in PR #12032:
URL: https://github.com/apache/cloudstack/pull/12032#discussion_r2664454561
##
plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/hypervisor/OvmResourceBase.java:
##
@@ -362,7 +362,7 @@ protected void setupServer() throws IOException {
sshConnection = SSHCmdHelper.acquireAuthorizedConnection(_ip,
_username, _password);
if (sshConnection == null) {
-throw new CloudRuntimeException(String.format("Cannot connect to
ovm host(IP=%1$s, username=%2$s, password=%3$s", _ip, _username, _password));
+throw new CloudRuntimeException(String.format("Cannot connect to
ovm host(IP=%1$s, username=%2$s, password=*)", _ip, _username));
Review Comment:
```suggestion
throw new CloudRuntimeException(String.format("Cannot connect to
ovm host(IP=%1$s, username=%2$s)", _ip, _username));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
blueorangutan commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3713868827 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
YLChen-007 commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3713708382 > @YLChen-007 , this code will be deprecated, but it is low risk so let’s merge . (the ovm plugin is about to be deprecated) I got it. Thank your response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
blueorangutan commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3713663308 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
DaanHoogland commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3713657318 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
DaanHoogland commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3713655157 @YLChen-007 , this code will be deprecated, but it is low risk so let’s merge . (the ovm plugin is about to be deprecated) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
abh1sar commented on code in PR #12032:
URL: https://github.com/apache/cloudstack/pull/12032#discussion_r2655046462
##
plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/hypervisor/OvmResourceBase.java:
##
@@ -362,7 +362,7 @@ protected void setupServer() throws IOException {
sshConnection = SSHCmdHelper.acquireAuthorizedConnection(_ip,
_username, _password);
if (sshConnection == null) {
-throw new CloudRuntimeException(String.format("Cannot connect to
ovm host(IP=%1$s, username=%2$s, password=%3$s", _ip, _username, _password));
+throw new CloudRuntimeException(String.format("Cannot connect to
ovm host(IP=%1$s, username=%2$s, password=*", _ip, _username));
Review Comment:
```suggestion
throw new CloudRuntimeException(String.format("Cannot connect to
ovm host(IP=%1$s, username=%2$s, password=*)", _ip, _username));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]
codecov[bot] commented on PR #12032: URL: https://github.com/apache/cloudstack/pull/12032#issuecomment-3510412203 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12032?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.00%. Comparing base ([`e90e436`](https://app.codecov.io/gh/apache/cloudstack/commit/e90e436ef873100b1916c80c0309c1eefcc4a265?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7e7ba5c`](https://app.codecov.io/gh/apache/cloudstack/commit/7e7ba5c295775b9f8aa10f5bc95ff38e6e988551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on 4.20. > :exclamation: There is a different number of reports uploaded between BASE (e90e436) and HEAD (7e7ba5c). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (e90e436) | HEAD (7e7ba5c) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #12032 +/- ## = - Coverage 16.18%4.00% -12.19% = Files 5657 402 -5255 Lines49846632665 -465801 Branches 60491 5808-54683 = - Hits 80696 1309-79387 + Misses 40878931203 -377586 + Partials 8981 153 -8828 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12032/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12032?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
