Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
DaanHoogland merged PR #11327: URL: https://github.com/apache/cloudstack/pull/11327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3648183915 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3648029342 @RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
RosiKyu commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3648028204 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3646691415 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3646062169 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3645622617 @RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
RosiKyu commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3645614727 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3641147613 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3639086756 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3638730168 @rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
rosi-shapeblue commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3638726851 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3501920419 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3501457452 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
weizhouapache commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3501449489 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
weizhouapache commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3501448752 discussed with @shwstppr , I made some changes on this PR on the name convention of autoscale Windows VM now the vm name and display name look like https://github.com/user-attachments/assets/128a36bf-689a-416a-a545-18bc5650a000"; /> the last 6 letters are the same in the two names. they are generated by `RandomStringUtils.random` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3355076802 Added doc PR: https://github.com/apache/cloudstack-documentation/pull/575 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3355357320 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3381779333 @DaanHoogland based on the latest comments I think we would need changes in naming implementation. I would close this for now for a different solution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352541059 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on code in PR #11327:
URL: https://github.com/apache/cloudstack/pull/11327#discussion_r2412959628
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1954,13 +1960,46 @@ public void updateVmDetails(Map
deployParams, Map 15 ? valid.substring(valid.length()
- 15) : valid;
+if (!hostName.isEmpty() && !Character.isLetter(hostName.charAt(0))) {
+for (int i = 0; i < hostName.length(); i++) {
+if (Character.isLetter(hostName.charAt(i))) {
+hostName = hostName.charAt(i) + hostName.substring(i + 1);
+break;
+}
+}
+if (!Character.isLetter(hostName.charAt(0))) {
+hostName = hostName.length() < 15 ? "a" + hostName : "a" +
hostName.substring(1);
+}
+}
+return hostName;
+}
+
+protected boolean isWindowsOs(VirtualMachineTemplate template) {
+GuestOSVO guestOSVO = guestOSDao.findById(template.getGuestOSId());
+if (guestOSVO == null) {
+return false;
+}
+String osName = StringUtils.firstNonBlank(guestOSVO.getName(),
guestOSVO.getDisplayName());
+if (StringUtils.isBlank(osName)) {
+return false;
+}
+return osName.toLowerCase().contains("windows");
+}
+
+protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO asGroup, VirtualMachineTemplate
template) {
+boolean isWindows = isWindowsOs(template);
String vmHostNameSuffix = "-" + asGroup.getNextVmSeq() + "-" +
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-return VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+if (!isWindows || name.length() <= 15) {
Review Comment:
Documentation PR is there already
https://github.com/apache/cloudstack-documentation/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
abh1sar commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3351313667 @shwstppr I am getting this NPE with a Windows10 qcow2 template. Not sure if I did something wrong. I have a mixed kvm, vmware env. https://github.com/user-attachments/assets/aca4854c-1225-4aac-879a-3b5c492b9704"; /> https://github.com/user-attachments/assets/26305f98-6358-4d0c-a1c5-208f2375455f"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352015345 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
weizhouapache commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352731764 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352159340 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3355030388 Thanks @abh1sar. (I've also added minor refactoring to not consider OS as Windows if both name and display_name turn out to be NULL) Will check and update regarding documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
vishesh92 commented on code in PR #11327:
URL: https://github.com/apache/cloudstack/pull/11327#discussion_r2394158431
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1954,13 +1960,46 @@ public void updateVmDetails(Map
deployParams, Map 15 ? valid.substring(valid.length()
- 15) : valid;
+if (!hostName.isEmpty() && !Character.isLetter(hostName.charAt(0))) {
+for (int i = 0; i < hostName.length(); i++) {
+if (Character.isLetter(hostName.charAt(i))) {
+hostName = hostName.charAt(i) + hostName.substring(i + 1);
+break;
+}
+}
+if (!Character.isLetter(hostName.charAt(0))) {
+hostName = hostName.length() < 15 ? "a" + hostName : "a" +
hostName.substring(1);
+}
+}
+return hostName;
+}
+
+protected boolean isWindowsOs(VirtualMachineTemplate template) {
+GuestOSVO guestOSVO = guestOSDao.findById(template.getGuestOSId());
+if (guestOSVO == null) {
+return false;
+}
+String osName = StringUtils.firstNonBlank(guestOSVO.getName(),
guestOSVO.getDisplayName());
+if (StringUtils.isBlank(osName)) {
+return false;
+}
+return osName.toLowerCase().contains("windows");
+}
+
+protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO asGroup, VirtualMachineTemplate
template) {
+boolean isWindows = isWindowsOs(template);
String vmHostNameSuffix = "-" + asGroup.getNextVmSeq() + "-" +
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-return VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
Review Comment:
Value for `VM_HOSTNAME_PREFIX` is `autoScaleVm-` which is 12 characters
leaving only 3 characters for the rest of the string. If we assume the ASG name
is 3 letters only, that itself will become 15 characters and won't be unique
for VMs.
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1954,13 +1960,46 @@ public void updateVmDetails(Map
deployParams, Map 15 ? valid.substring(valid.length()
- 15) : valid;
+if (!hostName.isEmpty() && !Character.isLetter(hostName.charAt(0))) {
+for (int i = 0; i < hostName.length(); i++) {
+if (Character.isLetter(hostName.charAt(i))) {
+hostName = hostName.charAt(i) + hostName.substring(i + 1);
+break;
+}
+}
+if (!Character.isLetter(hostName.charAt(0))) {
+hostName = hostName.length() < 15 ? "a" + hostName : "a" +
hostName.substring(1);
+}
+}
+return hostName;
+}
+
+protected boolean isWindowsOs(VirtualMachineTemplate template) {
+GuestOSVO guestOSVO = guestOSDao.findById(template.getGuestOSId());
+if (guestOSVO == null) {
+return false;
+}
+String osName = StringUtils.firstNonBlank(guestOSVO.getName(),
guestOSVO.getDisplayName());
+if (StringUtils.isBlank(osName)) {
+return false;
+}
+return osName.toLowerCase().contains("windows");
+}
+
+protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO asGroup, VirtualMachineTemplate
template) {
+boolean isWindows = isWindowsOs(template);
String vmHostNameSuffix = "-" + asGroup.getNextVmSeq() + "-" +
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-return VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+if (!isWindows || name.length() <= 15) {
Review Comment:
IMO, we can get rid of the `name.length() <= 15` check.
`VM_HOSTNAME_RANDOM_SUFFIX_LENGTH` is set to 6. So, excluding the size of
ASG's name, `name.length` will always be at least 18 characters. So, this check
will always be false.
Also, let's use a constant instead of the number `15` or add some
documentation on from where did we arrive at the number 15.
--
This is an automated message from the Apache
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr closed pull request #11327: server: trim autoscale Windows VM hostname URL: https://github.com/apache/cloudstack/pull/11327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3355087290 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352738946 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3380736838 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3355379110 [SF] Trillian test result (tid-14488) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 59706 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11327-t14488-kvm-ol8.zip Smoke tests completed. 147 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3381144412 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352121414 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352694486 @abh1sar please try one again with new packages. Added a change. I didn't realize we store guest OSes with null name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
vishesh92 commented on code in PR #11327:
URL: https://github.com/apache/cloudstack/pull/11327#discussion_r2412965644
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1954,13 +1960,46 @@ public void updateVmDetails(Map
deployParams, Map 15 ? valid.substring(valid.length()
- 15) : valid;
+if (!hostName.isEmpty() && !Character.isLetter(hostName.charAt(0))) {
+for (int i = 0; i < hostName.length(); i++) {
+if (Character.isLetter(hostName.charAt(i))) {
+hostName = hostName.charAt(i) + hostName.substring(i + 1);
+break;
+}
+}
+if (!Character.isLetter(hostName.charAt(0))) {
+hostName = hostName.length() < 15 ? "a" + hostName : "a" +
hostName.substring(1);
+}
+}
+return hostName;
+}
+
+protected boolean isWindowsOs(VirtualMachineTemplate template) {
+GuestOSVO guestOSVO = guestOSDao.findById(template.getGuestOSId());
+if (guestOSVO == null) {
+return false;
+}
+String osName = StringUtils.firstNonBlank(guestOSVO.getName(),
guestOSVO.getDisplayName());
+if (StringUtils.isBlank(osName)) {
+return false;
+}
+return osName.toLowerCase().contains("windows");
+}
+
+protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO asGroup, VirtualMachineTemplate
template) {
+boolean isWindows = isWindowsOs(template);
String vmHostNameSuffix = "-" + asGroup.getNextVmSeq() + "-" +
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-return VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+if (!isWindows || name.length() <= 15) {
Review Comment:
I meant some documentation in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
abh1sar commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3354666288 @shwstppr please see if we need to add this to documentation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3380730457 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
DaanHoogland commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3381362480 @weizhouapache @shwstppr is this not ready yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
weizhouapache commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3381250654 > Tested on Windows and Linux VM. The Windows VM name is getting truncated correctly. > > https://private-user-images.githubusercontent.com/63767682/495985852-aab2ebd0-68c1-4c45-9e03-45c8ea5f6d35.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTk5MjEyNDksIm5iZiI6MTc1OTkyMDk0OSwicGF0aCI6Ii82Mzc2NzY4Mi80OTU5ODU4NTItYWFiMmViZDAtNjhjMS00YzQ1LTllMDMtNDVjOGVhNWY2ZDM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEwMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMDA4VDEwNTU0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5OTAwOTM1MGEyYTdjMThhOTlhYzg3MzE0N2YxZDg2YzI3Mzk4M2JhMmE3ODcyMTg3YTM0NTJjNDg3ZGIzNmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-aSUX-2Cr3PO4Y6GNCX2jdigZzYDCJEmshKtORuvLj4";> to be frank, I think the name is a bit confusing can we use a formatted shortname like `asgroup-xx` or `asg-xx-xx` instead ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352017366 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
vishesh92 commented on code in PR #11327:
URL: https://github.com/apache/cloudstack/pull/11327#discussion_r2394176500
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1954,13 +1960,46 @@ public void updateVmDetails(Map
deployParams, Map 15 ? valid.substring(valid.length()
- 15) : valid;
+if (!hostName.isEmpty() && !Character.isLetter(hostName.charAt(0))) {
+for (int i = 0; i < hostName.length(); i++) {
+if (Character.isLetter(hostName.charAt(i))) {
+hostName = hostName.charAt(i) + hostName.substring(i + 1);
+break;
+}
+}
+if (!Character.isLetter(hostName.charAt(0))) {
+hostName = hostName.length() < 15 ? "a" + hostName : "a" +
hostName.substring(1);
+}
+}
+return hostName;
+}
+
+protected boolean isWindowsOs(VirtualMachineTemplate template) {
+GuestOSVO guestOSVO = guestOSDao.findById(template.getGuestOSId());
+if (guestOSVO == null) {
+return false;
+}
+String osName = StringUtils.firstNonBlank(guestOSVO.getName(),
guestOSVO.getDisplayName());
+if (StringUtils.isBlank(osName)) {
+return false;
+}
+return osName.toLowerCase().contains("windows");
+}
+
+protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO asGroup, VirtualMachineTemplate
template) {
+boolean isWindows = isWindowsOs(template);
String vmHostNameSuffix = "-" + asGroup.getNextVmSeq() + "-" +
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-return VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
Review Comment:
Just noticed how we are truncating the string. ignore this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3352167501 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
DaanHoogland commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3290964593 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3273416609 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3273250816 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3273252309 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
weizhouapache commented on code in PR #11327:
URL: https://github.com/apache/cloudstack/pull/11327#discussion_r2300047784
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1968,12 +1968,19 @@ protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO as
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-String displayName = VM_HOSTNAME_PREFIX +
asGroup.getName().substring(0, subStringLength) + vmHostNameSuffix;
-String hostName = displayName;
-if (isWindows) {
-hostName = displayName.substring(Math.max(0, displayName.length()
- 15));
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+if (!isWindows) {
+return new Pair<>(name, name);
}
-return new Pair<>(hostName, displayName);
+String hostName = name.substring(Math.max(0, name.length() - 15));
+if (Character.isLetterOrDigit(hostName.charAt(0))) {
Review Comment:
it seems digit it not supported as first char ? @shwstppr
https://github.com/apache/cloudstack/blob/1272b130878d0d8eb73caad2963343082d4be3fc/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L4104-L4109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3222861969 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3222615131 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3222612779 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on code in PR #11327:
URL: https://github.com/apache/cloudstack/pull/11327#discussion_r2299756090
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1968,12 +1968,19 @@ protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO as
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-String displayName = VM_HOSTNAME_PREFIX +
asGroup.getName().substring(0, subStringLength) + vmHostNameSuffix;
-String hostName = displayName;
-if (isWindows) {
-hostName = displayName.substring(Math.max(0, displayName.length()
- 15));
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+if (!isWindows) {
+return new Pair<>(name, name);
}
-return new Pair<>(hostName, displayName);
+String hostName = name.substring(Math.max(0, name.length() - 15));
+if (Character.isLetterOrDigit(hostName.charAt(0))) {
+return new Pair<>(hostName, name);
+}
+String temp = name.substring(0, Math.max(0, name.length() -
15)).replaceAll("[^a-zA-Z0-9]", "");
Review Comment:
@DaanHoogland I don't think this case can happen.
The only user-defined part in the VM name is the name of the autoscale
group, and we've checks for that to only contain letters, numbers and hyphen.
checkAutoScaleVmGroupName` does that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
DaanHoogland commented on code in PR #11327:
URL: https://github.com/apache/cloudstack/pull/11327#discussion_r2298191664
##
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##
@@ -1968,12 +1968,19 @@ protected Pair
getNextVmHostAndDisplayName(AutoScaleVmGroupVO as
RandomStringUtils.random(VM_HOSTNAME_RANDOM_SUFFIX_LENGTH, 0,
0, true, false, (char[])null, new SecureRandom()).toLowerCase();
// Truncate vm group name because max length of vm name is 63
int subStringLength = Math.min(asGroup.getName().length(), 63 -
VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
-String displayName = VM_HOSTNAME_PREFIX +
asGroup.getName().substring(0, subStringLength) + vmHostNameSuffix;
-String hostName = displayName;
-if (isWindows) {
-hostName = displayName.substring(Math.max(0, displayName.length()
- 15));
+String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0,
subStringLength) + vmHostNameSuffix;
+if (!isWindows) {
+return new Pair<>(name, name);
}
-return new Pair<>(hostName, displayName);
+String hostName = name.substring(Math.max(0, name.length() - 15));
+if (Character.isLetterOrDigit(hostName.charAt(0))) {
+return new Pair<>(hostName, name);
+}
+String temp = name.substring(0, Math.max(0, name.length() -
15)).replaceAll("[^a-zA-Z0-9]", "");
Review Comment:
edge case: all of the last 15 chars are special chars or whitespace. I think
we better do a replace first and then take the last 15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
weizhouapache commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3219869927 > @weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same. @shwstppr looks ok to me. I could not find a better solution to be honest. is it possible the first letter is unaccepted (for example `-`) after the truncation ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3219816012 @weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
weizhouapache commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3219755388 @shwstppr is this ready for review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
github-actions[bot] commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3139677099 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3135418858 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
blueorangutan commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3135004127 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
shwstppr commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3135001139 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] server: trim autoscale Windows VM hostname [cloudstack]
codecov[bot] commented on PR #11327: URL: https://github.com/apache/cloudstack/pull/11327#issuecomment-3131780583 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11327?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.75%. Comparing base ([`86827f8`](https://app.codecov.io/gh/apache/cloudstack/commit/86827f871d24def41c5c8cf6d8b7bad910979a55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36e636a`](https://app.codecov.io/gh/apache/cloudstack/commit/36e636ae7a601b14fb3e4b1cbd9c76cb8a066a07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (86827f8) and HEAD (36e636a). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (86827f8) | HEAD (36e636a) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11327 +/- ## = - Coverage 17.17%3.75% -13.42% = Files 5869 436 -5433 Lines52159035535 -486055 Branches 63485 6447-57038 = - Hits 89562 1336-88226 + Misses 42196234039 -387923 + Partials 10066 160 -9906 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11327/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.75% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11327?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
