Re: [PR] upgrade: add unit tests from/to a security release [cloudstack]

2024-04-04 Thread via GitHub


rohityadavcloud merged PR #8870:
URL: https://github.com/apache/cloudstack/pull/8870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] upgrade: add unit tests from/to a security release [cloudstack]

2024-04-02 Thread via GitHub


weizhouapache commented on PR #8870:
URL: https://github.com/apache/cloudstack/pull/8870#issuecomment-2032583463

   > > This PR adds two unit tests
   > > 
   > 
   > no, it add three uinit tests ;)
   > 
   
   right..
   Let me update the description


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] upgrade: add unit tests from/to a security release [cloudstack]

2024-04-02 Thread via GitHub


DaanHoogland commented on PR #8870:
URL: https://github.com/apache/cloudstack/pull/8870#issuecomment-2032423572

   > This PR adds two unit tests
   > 
   
   no, it add three uinit tests ;)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] upgrade: add unit tests from/to a security release [cloudstack]

2024-04-02 Thread via GitHub


codecov-commenter commented on PR #8870:
URL: https://github.com/apache/cloudstack/pull/8870#issuecomment-2032019485

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8870?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 13.16%. Comparing base 
[(`8c62365`)](https://app.codecov.io/gh/apache/cloudstack/commit/8c62365dbb140feb8ab350724b4567f5ed449454?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`546222b`)](https://app.codecov.io/gh/apache/cloudstack/pull/8870?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff@@
   ##   4.18#8870   +/-   ##
   =
 Coverage 13.16%   13.16%   
   - Complexity 9203 9204+1 
   =
 Files  2724 2724   
 Lines258153   258153   
 Branches  4023640236   
   =
   + Hits  3398233991+9 
   + Misses   219866   219856   -10 
   - Partials   4305 4306+1 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8870?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] upgrade: add unit tests from/to a security release [cloudstack]

2024-04-02 Thread via GitHub


codecov[bot] commented on PR #8870:
URL: https://github.com/apache/cloudstack/pull/8870#issuecomment-2031911579

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8870?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 13.16%. Comparing base 
[(`8c62365`)](https://app.codecov.io/gh/apache/cloudstack/commit/8c62365dbb140feb8ab350724b4567f5ed449454?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`499be35`)](https://app.codecov.io/gh/apache/cloudstack/pull/8870?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff@@
   ##   4.18#8870   +/-   ##
   =
 Coverage 13.16%   13.16%   
   - Complexity 9203 9204+1 
   =
 Files  2724 2724   
 Lines258153   258153   
 Branches  4023640236   
   =
   + Hits  3398233991+9 
   + Misses   219866   219856   -10 
   - Partials   4305 4306+1 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8870?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org