Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
abh1sar merged PR #12881: URL: https://github.com/apache/cloudstack/pull/12881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4130810845 [SF] Trillian test result (tid-15727) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 54867 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12881-t15727-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4124827497 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
weizhouapache commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4124814055 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4124139533 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4123891372 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
abh1sar commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4123887077 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
Copilot commented on code in PR #12881:
URL: https://github.com/apache/cloudstack/pull/12881#discussion_r2985775169
##
engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql:
##
@@ -31,7 +31,7 @@ CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.account',
'api_key_access', 'boolean
CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.account',
'api_key_access', 'boolean DEFAULT NULL COMMENT "is api key access allowed for
the account" ');
-- Create a new group for Usage Server related configurations
-INSERT INTO `cloud`.`configuration_group` (`name`, `description`,
`precedence`) VALUES ('Usage Server', 'Usage Server related configuration', 9);
+INSERT IGNORE INTO `cloud`.`configuration_group` (`name`, `description`,
`precedence`) VALUES ('Usage Server', 'Usage Server related configuration', 9);
Review Comment:
Using `INSERT IGNORE` avoids the duplicate-key failure, but it also leaves
any existing `configuration_group` row unchanged (e.g., stale
`description`/`precedence`). Consider using an idempotent upsert (`INSERT ...
ON DUPLICATE KEY UPDATE ...`) or follow with an `UPDATE` to ensure the row
matches the expected values after the upgrade.
```suggestion
INSERT INTO `cloud`.`configuration_group` (`name`, `description`,
`precedence`)
VALUES ('Usage Server', 'Usage Server related configuration', 9)
ON DUPLICATE KEY UPDATE `description` = VALUES(`description`),
`precedence` = VALUES(`precedence`);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4123517046 [SF] Trillian test result (tid-15724) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 54476 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12881-t15724-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_vm_strict_tags_success | `Error` | 8.81 | test_vm_strict_host_tags.py test_02_migrate_vm_strict_tags_failure | `Error` | 3.62 | test_vm_strict_host_tags.py test_01_restore_vm_strict_tags_success | `Error` | 5.71 | test_vm_strict_host_tags.py test_02_restore_vm_strict_tags_failure | `Error` | 3.64 | test_vm_strict_host_tags.py test_01_scale_vm_strict_tags_success | `Error` | 5.78 | test_vm_strict_host_tags.py test_02_scale_vm_strict_tags_failure | `Error` | 3.70 | test_vm_strict_host_tags.py test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 3.65 | test_vm_strict_host_tags.py test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 9.80 | test_vm_strict_host_tags.py test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 10.90 | test_vm_strict_host_tags.py test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 7.06 | test_vm_strict_host_tags.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 7.35 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 138.71 | test_host_maintenance.py test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 93.03 | test_host_maintenance.py test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 1.15 | test_host_maintenance.py test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 1.16 | test_host_maintenance.py test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 1.14 | test_host_maintenance.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
weizhouapache commented on PR #12881:
URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4118563394
> Thanks @weizhouapache. Looks good. It's better to fix this logic rather
than adding an upgrade path which does nothing.
>
> Do you think we should still make sure that all the queries in the upgrade
path are idempotent?
>
> INSERT **IGNORE** INTO `cloud`.`configuration_group` (`name`,
`description`, `precedence`) VALUES ('Usage Server', 'Usage Server related
configuration', 9);
>
> from https://github.com/apache/cloudstack/pull/12875/changes
yes @abh1sar
it is better to apply the change, let me add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4118046566 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
weizhouapache commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4118043323 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4117942924 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
codecov[bot] commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4117580350 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12881?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.15%. Comparing base ([`c19630f`](https://app.codecov.io/gh/apache/cloudstack/commit/c19630f0a4f34a82a9414b9b6d16b5ec44b86860?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea89141`](https://app.codecov.io/gh/apache/cloudstack/commit/ea891417e2f53a077e99ecb1b82db165114c9d51?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (c19630f) and HEAD (ea89141). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (c19630f) | HEAD (ea89141) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #12881 +/- ## = - Coverage 16.25%4.15% -12.10% = Files 5664 404 -5260 Lines50046532966 -467499 Branches 60780 5893-54887 = - Hits 81338 1370-79968 + Misses 41003131420 -378611 + Partials 9096 176 -8920 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12881/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.15% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12881?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
blueorangutan commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4117543076 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] upgrade: skip the upgrade paths which are not needed [cloudstack]
weizhouapache commented on PR #12881: URL: https://github.com/apache/cloudstack/pull/12881#issuecomment-4117534791 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
