[09/10] [math] Remove redundant type arguments.

2016-09-20 Thread ggregory
http://git-wip-us.apache.org/repos/asf/commons-math/blob/762eb53f/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
 
b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
index 2dc6933..be89ef4 100644
--- 
a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
+++ 
b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
@@ -374,9 +374,9 @@ public class FieldRotation> 
implements Serializabl
 public FieldRotation(final RotationOrder order, final RotationConvention 
convention,
  final T alpha1, final T alpha2, final T alpha3) {
 final T one = alpha1.getField().getOne();
-final FieldRotation r1 = new FieldRotation(new 
FieldVector3D(one, order.getA1()), alpha1, convention);
-final FieldRotation r2 = new FieldRotation(new 
FieldVector3D(one, order.getA2()), alpha2, convention);
-final FieldRotation r3 = new FieldRotation(new 
FieldVector3D(one, order.getA3()), alpha3, convention);
+final FieldRotation r1 = new FieldRotation<>(new 
FieldVector3D<>(one, order.getA1()), alpha1, convention);
+final FieldRotation r2 = new FieldRotation<>(new 
FieldVector3D<>(one, order.getA2()), alpha2, convention);
+final FieldRotation r3 = new FieldRotation<>(new 
FieldVector3D<>(one, order.getA3()), alpha3, convention);
 final FieldRotation composed = r1.compose(r2.compose(r3, 
convention), convention);
 q0 = composed.q0;
 q1 = composed.q1;
@@ -453,7 +453,7 @@ public class FieldRotation> 
implements Serializabl
  * of the instance
  */
 public FieldRotation revert() {
-return new FieldRotation(q0.negate(), q1, q2, q3, false);
+return new FieldRotation<>(q0.negate(), q1, q2, q3, false);
 }
 
 /** Get the scalar coordinate of the quaternion.
@@ -509,17 +509,17 @@ public class FieldRotation> 
implements Serializabl
 final T squaredSine = 
q1.multiply(q1).add(q2.multiply(q2)).add(q3.multiply(q3));
 if (squaredSine.getReal() == 0) {
 final Field field = squaredSine.getField();
-return new FieldVector3D(convention == 
RotationConvention.VECTOR_OPERATOR ? field.getOne(): field.getOne().negate(),
+return new FieldVector3D<>(convention == 
RotationConvention.VECTOR_OPERATOR ? field.getOne(): field.getOne().negate(),
 field.getZero(),
 field.getZero());
 } else {
 final double sgn = convention == 
RotationConvention.VECTOR_OPERATOR ? +1 : -1;
 if (q0.getReal() < 0) {
 T inverse = squaredSine.sqrt().reciprocal().multiply(sgn);
-return new FieldVector3D(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
+return new FieldVector3D<>(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
 }
 final T inverse = 
squaredSine.sqrt().reciprocal().negate().multiply(sgn);
-return new FieldVector3D(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
+return new FieldVector3D<>(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
 }
 }
 
@@ -1032,7 +1032,7 @@ public class FieldRotation> 
implements Serializabl
  */
 private FieldVector3D vector(final double x, final double y, final 
double z) {
 final T zero = q0.getField().getZero();
-return new FieldVector3D(zero.add(x), zero.add(y), zero.add(z));
+return new FieldVector3D<>(zero.add(x), zero.add(y), zero.add(z));
 }
 
 /** Get the 3X3 matrix corresponding to the instance
@@ -1090,7 +1090,7 @@ public class FieldRotation> 
implements Serializabl
 
 final T s = q1.multiply(x).add(q2.multiply(y)).add(q3.multiply(z));
 
-return new 
FieldVector3D(q0.multiply(x.multiply(q0).subtract(q2.multiply(z).subtract(q3.multiply(y.add(s.multiply(q1)).multiply(2).subtract(x),
+return new 
FieldVector3D<>(q0.multiply(x.multiply(q0).subtract(q2.multiply(z).subtract(q3.multiply(y.add(s.multiply(q1)).multiply(2).subtract(x),
 
q0.multiply(y.multiply(q0).subtract(q3.multiply(x).subtract(q1.multiply(z.add(s.multiply(q2)).multiply(2).subtract(y),
 
q0.multiply(z.multiply(q0).subtract(q1.multiply(y).subtract(q2.multiply(x.add(s.multiply(q3)).multiply(2).subtract(z));
 
@@ -1108,7 +1108,7 @@ public class FieldRotation> 
implements Serializabl
 
 final T s = q1.multiply(x).add(q2.multiply(y)).add(q3.multiply(z));
 
-return new 

[09/10] [math] Remove redundant type arguments.

2016-09-20 Thread ggregory
http://git-wip-us.apache.org/repos/asf/commons-math/blob/8b5f4535/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
 
b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
index 2dc6933..be89ef4 100644
--- 
a/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
+++ 
b/src/main/java/org/apache/commons/math4/geometry/euclidean/threed/FieldRotation.java
@@ -374,9 +374,9 @@ public class FieldRotation> 
implements Serializabl
 public FieldRotation(final RotationOrder order, final RotationConvention 
convention,
  final T alpha1, final T alpha2, final T alpha3) {
 final T one = alpha1.getField().getOne();
-final FieldRotation r1 = new FieldRotation(new 
FieldVector3D(one, order.getA1()), alpha1, convention);
-final FieldRotation r2 = new FieldRotation(new 
FieldVector3D(one, order.getA2()), alpha2, convention);
-final FieldRotation r3 = new FieldRotation(new 
FieldVector3D(one, order.getA3()), alpha3, convention);
+final FieldRotation r1 = new FieldRotation<>(new 
FieldVector3D<>(one, order.getA1()), alpha1, convention);
+final FieldRotation r2 = new FieldRotation<>(new 
FieldVector3D<>(one, order.getA2()), alpha2, convention);
+final FieldRotation r3 = new FieldRotation<>(new 
FieldVector3D<>(one, order.getA3()), alpha3, convention);
 final FieldRotation composed = r1.compose(r2.compose(r3, 
convention), convention);
 q0 = composed.q0;
 q1 = composed.q1;
@@ -453,7 +453,7 @@ public class FieldRotation> 
implements Serializabl
  * of the instance
  */
 public FieldRotation revert() {
-return new FieldRotation(q0.negate(), q1, q2, q3, false);
+return new FieldRotation<>(q0.negate(), q1, q2, q3, false);
 }
 
 /** Get the scalar coordinate of the quaternion.
@@ -509,17 +509,17 @@ public class FieldRotation> 
implements Serializabl
 final T squaredSine = 
q1.multiply(q1).add(q2.multiply(q2)).add(q3.multiply(q3));
 if (squaredSine.getReal() == 0) {
 final Field field = squaredSine.getField();
-return new FieldVector3D(convention == 
RotationConvention.VECTOR_OPERATOR ? field.getOne(): field.getOne().negate(),
+return new FieldVector3D<>(convention == 
RotationConvention.VECTOR_OPERATOR ? field.getOne(): field.getOne().negate(),
 field.getZero(),
 field.getZero());
 } else {
 final double sgn = convention == 
RotationConvention.VECTOR_OPERATOR ? +1 : -1;
 if (q0.getReal() < 0) {
 T inverse = squaredSine.sqrt().reciprocal().multiply(sgn);
-return new FieldVector3D(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
+return new FieldVector3D<>(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
 }
 final T inverse = 
squaredSine.sqrt().reciprocal().negate().multiply(sgn);
-return new FieldVector3D(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
+return new FieldVector3D<>(q1.multiply(inverse), 
q2.multiply(inverse), q3.multiply(inverse));
 }
 }
 
@@ -1032,7 +1032,7 @@ public class FieldRotation> 
implements Serializabl
  */
 private FieldVector3D vector(final double x, final double y, final 
double z) {
 final T zero = q0.getField().getZero();
-return new FieldVector3D(zero.add(x), zero.add(y), zero.add(z));
+return new FieldVector3D<>(zero.add(x), zero.add(y), zero.add(z));
 }
 
 /** Get the 3X3 matrix corresponding to the instance
@@ -1090,7 +1090,7 @@ public class FieldRotation> 
implements Serializabl
 
 final T s = q1.multiply(x).add(q2.multiply(y)).add(q3.multiply(z));
 
-return new 
FieldVector3D(q0.multiply(x.multiply(q0).subtract(q2.multiply(z).subtract(q3.multiply(y.add(s.multiply(q1)).multiply(2).subtract(x),
+return new 
FieldVector3D<>(q0.multiply(x.multiply(q0).subtract(q2.multiply(z).subtract(q3.multiply(y.add(s.multiply(q1)).multiply(2).subtract(x),
 
q0.multiply(y.multiply(q0).subtract(q3.multiply(x).subtract(q1.multiply(z.add(s.multiply(q2)).multiply(2).subtract(y),
 
q0.multiply(z.multiply(q0).subtract(q1.multiply(y).subtract(q2.multiply(x.add(s.multiply(q3)).multiply(2).subtract(z));
 
@@ -1108,7 +1108,7 @@ public class FieldRotation> 
implements Serializabl
 
 final T s = q1.multiply(x).add(q2.multiply(y)).add(q3.multiply(z));
 
-return new