[GitHub] convey-gilbert opened a new pull request #92: First functional version of audio recorder on Windows devices implemented

2018-01-16 Thread GitBox
convey-gilbert opened a new pull request #92: First functional version of audio recorder on Windows devices implemented URL: https://github.com/apache/cordova-plugin-media-capture/pull/92 ### Platforms affected ### What does this PR do? ### What testing has

[GitHub] convey-gilbert commented on issue #92: First functional version of audio recorder on Windows devices implemented

2018-01-16 Thread GitBox
convey-gilbert commented on issue #92: First functional version of audio recorder on Windows devices implemented URL: https://github.com/apache/cordova-plugin-media-capture/pull/92#issuecomment-357932807 Pay attention to the new options Attribute used in captureAudio call

[GitHub] convey-gilbert commented on issue #92: First functional version of audio recorder on Windows devices implemented

2018-01-16 Thread GitBox
convey-gilbert commented on issue #92: First functional version of audio recorder on Windows devices implemented URL: https://github.com/apache/cordova-plugin-media-capture/pull/92#issuecomment-357936282 BTW. Looking at e.g. call of function captureAudio in this repo:

[GitHub] macdonst commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
macdonst commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358022454 @infil00p ah, now I see you already reviewed an earlier version of this PR. @johnlejardinnier in

[GitHub] johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358030465 @macdonst Thanks a lot ! Sorry i've closed previous PR because it was not made properly (Not

[GitHub] kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161819364 ## File path: src/android/SplashScreen.java ## @@ -410,4 +428,60

[GitHub] kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161819016 ## File path: README.md ## @@ -376,6 +376,23 @@ To disable the

[GitHub] kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161825874 ## File path: src/ios/CDVSplashScreen.m ## @@ -60,6 +60,63 @@ -

[GitHub] kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161820527 ## File path: src/ios/CDVSplashScreen.m ## @@ -60,6 +60,63 @@ -

[GitHub] kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161820219 ## File path: src/ios/CDVSplashScreen.m ## @@ -60,6 +60,63 @@ -

[GitHub] kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
kerrishotts commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161818781 ## File path: README.md ## @@ -376,6 +376,23 @@ To disable the

[GitHub] johnlejardinnier opened a new pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
johnlejardinnier opened a new pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148 ### Platforms affected Android and iOS ### What does this PR do? This is a feature to

[GitHub] macdonst commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen

2018-01-16 Thread GitBox
macdonst commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358021107 @johnlejardinnier Pretty cool PR. I've specifically called out some folks to review your PR.

[GitHub] wf9a5m75 opened a new pull request #428: CB-13788: (android) Specify the minimum required version of google play services for plugins

2018-01-16 Thread GitBox
wf9a5m75 opened a new pull request #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428 ### Platforms affected Android ### What does this PR do? Extends the `` tag

[GitHub] johnlejardinnier closed pull request #134: Feature to display app version on splashscreen

2018-01-16 Thread GitBox
johnlejardinnier closed pull request #134: Feature to display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] infil00p commented on issue #426: CB-13724: Bump Target SDK to API 27

2018-01-16 Thread GitBox
infil00p commented on issue #426: CB-13724: Bump Target SDK to API 27 URL: https://github.com/apache/cordova-android/pull/426#issuecomment-358077623 @jcesarmobile I know that you bumped everything to Tools 26. Giving you a heads up about Tools 27. The treadmill never ends!

[GitHub] jcesarmobile commented on issue #426: CB-13724: Bump Target SDK to API 27

2018-01-16 Thread GitBox
jcesarmobile commented on issue #426: CB-13724: Bump Target SDK to API 27 URL: https://github.com/apache/cordova-android/pull/426#issuecomment-358083671 No problem, travis will need an update anyway to install SDK 27 This is