[GitHub] dpa99c commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

dpa99c commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-358312390 @stevengill @agrieve @shazron @purplecabbage @jcesarmobile are any of you guys able to

[GitHub] infil00p closed pull request #246: Cb 13409 - Add more configurable options for toolbar in android and ios

infil00p closed pull request #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[cordova-plugin-inappbrowser] branch master updated (8e3f2f2 -> c80c338)

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git. from 8e3f2f2 Merge pull request #257 from jcesarmobile/CB-13746 add 8711ee3 CB-13409: Lets

[cordova-plugin-inappbrowser] 01/01: Merge pull request #246 from landsbankinn/CB-13409

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git commit c80c338e51657da600ee56af5079a125426dd00f Merge: 8e3f2f2 84a4644 Author: Joe Bowser

[GitHub] purplecabbage commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

purplecabbage commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-358393895 LGTM! @infil00p ?

[GitHub] purplecabbage commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11

purplecabbage commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358413194 Does this re-break iOS 10?

[GitHub] dpa99c commented on issue #245: CB-7179 (iOS): Finish off WKWebView implementation

dpa99c commented on issue #245: CB-7179 (iOS): Finish off WKWebView implementation URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358416278 @infil00p The [original apache/wkwebview

[cordova-android] 01/01: Merge pull request #426 from infil00p/api_level_bump

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 6cc4896690e73503a2281d7b63640f6d4ed5ffaa Merge: 673a677 0d16926 Author: Joe Bowser

[cordova-android] branch master updated (673a677 -> 6cc4896)

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 673a677 Merge pull request #427 from infil00p/deleteDeprecatedNdk add 5c93c21 CB-13724: Bump Target

[GitHub] infil00p commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins

infil00p commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428#issuecomment-358422233 @wf9a5m75 Your PR has failed eslint. You need to fix your eslint errors before I

[GitHub] infil00p commented on issue #250: Browser Close Controll

infil00p commented on issue #250: Browser Close Controll URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/250#issuecomment-358423473 @sjyMystery Which JIRA issue is this attached to? Why would you want to do this? As it stands, I can't accept this PR as is.

[GitHub] infil00p closed pull request #227: CB-12969 android: Added support for data URIs

infil00p closed pull request #227: CB-12969 android: Added support for data URIs URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/227 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] infil00p commented on issue #227: CB-12969 android: Added support for data URIs

infil00p commented on issue #227: CB-12969 android: Added support for data URIs URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/227#issuecomment-358426574 It looks like the PR got borked, and we can't accept it as is due to the conflict., Closing.

[GitHub] infil00p commented on issue #213: CB-12468 added ability to set|get default options;

infil00p commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-358427527 We don't merge if it doesn't merge cleanly, that's why it didn't get merged most likely.

[GitHub] infil00p closed pull request #426: CB-13724: Bump Target SDK to API 27

infil00p closed pull request #426: CB-13724: Bump Target SDK to API 27 URL: https://github.com/apache/cordova-android/pull/426 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] infil00p closed pull request #197: CB-12132: (android & ios) implement hidenotclose feature

infil00p closed pull request #197: CB-12132: (android & ios) implement hidenotclose feature URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] infil00p commented on issue #197: CB-12132: (android & ios) implement hidenotclose feature

infil00p commented on issue #197: CB-12132: (android & ios) implement hidenotclose feature URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#issuecomment-358428376 This hasn't been looked at in over a year and has conflicts, closing.

[GitHub] infil00p commented on issue #198: CB-12145: (android) Allow third party cookies if parameter set

infil00p commented on issue #198: CB-12145: (android) Allow third party cookies if parameter set URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/198#issuecomment-358428208 It looks like accepting another PR caused this to not merge cleanly. Can you update the branch on

[GitHub] dpa99c opened a new pull request #258: CB-13791: (android) Add Android support for a footer close button

dpa99c opened a new pull request #258: CB-13791: (android) Add Android support for a footer close button URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/258 ### Platforms affected Android ### What does this PR do? Adds support to Android for a

[GitHub] ssraza commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11

ssraza commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358421880 Not that I'm aware of...

[GitHub] infil00p commented on issue #233: android support for focusing (better) on inputs

infil00p commented on issue #233: android support for focusing (better) on inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/233#issuecomment-358426226 Closing due to lack of ICLA and CCLA. This is an

[GitHub] infil00p closed pull request #233: android support for focusing (better) on inputs

infil00p closed pull request #233: android support for focusing (better) on inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/233 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project

infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242#issuecomment-358424993 Sadly, this conflicts hard with the programmatic approach that people want to adopt, so I'm going to close this for now.

[GitHub] infil00p closed pull request #242: CB-13309: InAppBrowser as a Library Project

infil00p closed pull request #242: CB-13309: InAppBrowser as a Library Project URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project

infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242#issuecomment-358425257 Actually, I'll keep it open as a reference, but I don't have any time to work on this right now.

[GitHub] infil00p opened a new pull request #242: CB-13309: InAppBrowser as a Library Project

infil00p opened a new pull request #242: CB-13309: InAppBrowser as a Library Project URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242 ### Platforms affected Android ### What does this PR do? This changes the Android code so that the plugin is

[GitHub] infil00p commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

infil00p commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-358427936 I'd love to see this merged, but there's some conflicts that happened when we merged some new features in. If

[GitHub] infil00p commented on issue #243: CB-5758: (android/ios) support trusting self-signed certificates

infil00p commented on issue #243: CB-5758: (android/ios) support trusting self-signed certificates URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/243#issuecomment-358424711 Going to close this PR, since it needs a bit of a rethink.

[GitHub] infil00p closed pull request #243: CB-5758: (android/ios) support trusting self-signed certificates

infil00p closed pull request #243: CB-5758: (android/ios) support trusting self-signed certificates URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/243 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] infil00p commented on issue #238: added cookies support for Android and iOS

infil00p commented on issue #238: added cookies support for Android and iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/238#issuecomment-358425843 The conflcits and the eslint errors need to be fixed before we can evaluate and accept this. There also needs to be a

[GitHub] infil00p closed pull request #226: Added implementation for iOS clearSharedUrlCache()

infil00p closed pull request #226: Added implementation for iOS clearSharedUrlCache() URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/226 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] infil00p commented on issue #226: Added implementation for iOS clearSharedUrlCache()

infil00p commented on issue #226: Added implementation for iOS clearSharedUrlCache() URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/226#issuecomment-358426951 This is failing the CI for iOS, so something clearly broke. We can't accept this as is, sorry.

[GitHub] johnlejardinnier commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161987406 ## File path: src/android/SplashScreen.java ## @@ -410,4

[GitHub] jcesarmobile commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

jcesarmobile commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r162008238 ## File path: src/ios/CDVSplashScreen.m ## @@ -60,6 +60,63 @@ -

[GitHub] johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen

johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-358239026 @kerrishotts Thank you so much for your review. I will make some changes, then i'll push a

[GitHub] johnlejardinnier commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r161989736 ## File path: src/ios/CDVSplashScreen.m ## @@ -60,6 +60,63

[GitHub] ssraza commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11

ssraza commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358483103 Yep, let me try with this check shortly...

[GitHub] codecov-io commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins

codecov-io commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428#issuecomment-358457653 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/428?src=pr=h1)

[GitHub] purplecabbage commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11

purplecabbage commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358482320 ``` #if __IPHONE_OS_VERSION_MAX_ALLOWED < 11 /** Clipboard fix **/

[GitHub] purplecabbage commented on issue #104: generates a workspace instead of subproject

purplecabbage commented on issue #104: generates a workspace instead of subproject URL: https://github.com/apache/cordova-ios/pull/104#issuecomment-358559325 cordova-ios has supported workspaces+cocoapods for awhile now. Somehow this was never closed. Thanks for contributing.

[GitHub] purplecabbage closed pull request #187: Use "cdv_" prefixed scrollView for UIView to avoid conflicts

purplecabbage closed pull request #187: Use "cdv_" prefixed scrollView for UIView to avoid conflicts URL: https://github.com/apache/cordova-ios/pull/187 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] shazron commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11

shazron commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358559980 You need to do this at runtime. Jesse's check above will omit the code needed on older

[GitHub] purplecabbage commented on issue #187: Use "cdv_" prefixed scrollView for UIView to avoid conflicts

purplecabbage commented on issue #187: Use "cdv_" prefixed scrollView for UIView to avoid conflicts URL: https://github.com/apache/cordova-ios/pull/187#issuecomment-358560006 Closing this because it is stale. If you want to change cdv_srollView to cdv_scrollView, and rebase, then

[GitHub] shazron commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11

shazron commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-358559980 You need to do this at runtime. Jesse's check above will omit the code needed on older

[GitHub] purplecabbage closed pull request #343: CB-13513 (ios) Declare ProvisioningStyle as Automatic in project.pbxproj template.

purplecabbage closed pull request #343: CB-13513 (ios) Declare ProvisioningStyle as Automatic in project.pbxproj template. URL: https://github.com/apache/cordova-ios/pull/343 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[cordova-ios] 01/01: Merge pull request #343 from NextFaze/master

This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit fa41ae3915a2246ad6f7dff1a28895c4f760bcdf Merge: c88fbbf 5f2de97 Author: Jesse MacFadyen

[cordova-ios] branch master updated (c88fbbf -> fa41ae3)

This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from c88fbbf Merge pull request #351 from shaneomack91/patch-1 add 1c5e313 Add TargetAttributes

[GitHub] purplecabbage closed pull request #104: generates a workspace instead of subproject

purplecabbage closed pull request #104: generates a workspace instead of subproject URL: https://github.com/apache/cordova-ios/pull/104 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] purplecabbage closed pull request #351: Prevent a memory leak when converting to JSON

purplecabbage closed pull request #351: Prevent a memory leak when converting to JSON URL: https://github.com/apache/cordova-ios/pull/351 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[cordova-ios] 01/01: Merge pull request #351 from shaneomack91/patch-1

This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit c88fbbffa5ad7824635d33f0d16f6b5f32091d05 Merge: 4f873f7 e4c162b Author: Jesse MacFadyen

[cordova-ios] branch master updated (4f873f7 -> c88fbbf)

This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from 4f873f7 CB-13597: (ios) update podfile with ios version 9.0 add e4c162b Prevent a memory leak

[GitHub] infil00p commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

infil00p commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-358403915 Is there a docs PR that corresponds with this? This is a pretty big API change.

[GitHub] infil00p commented on issue #245: CB-7179 (iOS): Finish off WKWebView implementation

infil00p commented on issue #245: CB-7179 (iOS): Finish off WKWebView implementation URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/245#issuecomment-358406390 This needs to be cleaned up, since there's too many commits from other people in this PR. Can you do this PR

[GitHub] janpio commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

janpio commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-358406298 `README.md` is updated (with the added options), which is used to generated the docs at

[GitHub] johnlejardinnier commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & iOS): Display app version on splashscreen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r162004407 ## File path: src/ios/CDVSplashScreen.m ## @@ -60,6 +60,63