[GitHub] kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358981134 its not working in Phonegap Build This is an automated message

[GitHub] codecov-io commented on issue #429: CB-13800: Drop pre-KitKat specific code

codecov-io commented on issue #429: CB-13800: Drop pre-KitKat specific code URL: https://github.com/apache/cordova-android/pull/429#issuecomment-358963013 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=h1) Report > Merging

[GitHub] BBosman opened a new pull request #429: CB-13800: Drop pre-KitKat specific code

BBosman opened a new pull request #429: CB-13800: Drop pre-KitKat specific code URL: https://github.com/apache/cordova-android/pull/429 ### Platforms affected Android ### What does this PR do? With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.

[GitHub] willmero commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

willmero commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-358989090 WE ARE SO CLOSE! This is an automated

[GitHub] kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995703 just stating that thousands of PGB users will soon have problem building native iOS when they update this plugin however

[cordova-windows] branch master updated: CB-13641: support transparent splash screen background color. (#245)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/master by this push: new c288357 CB-13641: support transparent

[GitHub] janpio closed pull request #245: CB-13641: (windows) support transparent splash screen background color.

janpio closed pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358994990 thats true, but there is no way to add those params to the plist file with the latest update of PGB which more or less makes

[GitHub] jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995278 Yes, there is a way, you have to use `edit-config` tag as documented in the README.md

[GitHub] brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359022090 FYI I just did a squash and rebase in

[GitHub] brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359022090 FYI I just did a squash and rebase in

[GitHub] jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358993466 This just removes the usage description variables from the plugin.xml, so not sure how this "is not working in Phonegap

[GitHub] kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995703 just stating that thousands of PGB users will soon have problem when they update this plugin

[GitHub] IndieSW commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162665269 ## File path: template/www/cordova.js ## @@ -2064,7 +2064,7 @@

[GitHub] kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995532 edit-config doesn't work in the Phonegap Build version cli-7.1.0

[GitHub] janpio commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color.

janpio commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162663964 ## File path: template/www/cordova.js ## @@ -2064,7 +2064,7 @@

[GitHub] IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359014617 @janpio Thanks! This is an automated

[GitHub] janpio commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color.

janpio commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162669620 ## File path: template/www/cordova.js ## @@ -2064,7 +2064,7 @@

[GitHub] kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995703 just stating that thousands of PGB users will soon have problem building native iOS when they update this plugin

[GitHub] brodybits commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color.

brodybits commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162660144 ## File path: template/www/cordova.js ## @@ -2064,7 +2064,7 @@

[GitHub] IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359007743 Hi, @janpio, I think that got it. I'm still a little confused about why cordova.js is in the repo

[GitHub] IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359007743 Hi, @janpio, I think that got it. I'm still a little confused about why cordova.js is in the repo

[GitHub] jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions

jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358996934 edit-config used to work in PGB. If it's now broken in cli-7.1.0 report it to Adobe, this plugin is from Apache.

[GitHub] IndieSW commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162660627 ## File path: template/www/cordova.js ## @@ -2064,7 +2064,7 @@

[GitHub] brodybits commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color.

brodybits commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162662388 ## File path: template/www/cordova.js ## @@ -2064,7 +2064,7 @@

[GitHub] janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359013090 > I think that got it. Great. > I'm still a little confused about why cordova.js is in the

[GitHub] brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359017484 Another nit: I hope someone will rebase and squash. It would be nice to see the cleaned-up changes

[GitHub] janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359019900 I am just finding out if I may use the "Squash and merge" button in the Github UI or if I have use a CLI

[GitHub] janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359030057 I think that worked well enough :)

[GitHub] janpio closed pull request #240: CB-13155: Improved target parsing

janpio closed pull request #240: CB-13155: Improved target parsing URL: https://github.com/apache/cordova-windows/pull/240 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] janpio commented on issue #240: CB-13155: Improved target parsing

janpio commented on issue #240: CB-13155: Improved target parsing URL: https://github.com/apache/cordova-windows/pull/240#issuecomment-359042670 When checking the conflict, I noticed that `master` already has these changes, although a little bit differently formatted:

[GitHub] brodybits commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color.

brodybits commented on a change in pull request #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162686968 ## File path: template/www/cordova.js ## @@ -2064,7 +2064,7 @@

[cordova-android] 01/01: Merge pull request #429 from BBosman/cb13800

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit cc08e9d84a3f7cf76a623006c6a7e48814d74cec Merge: 6cc4896 075d381 Author: Joe Bowser

[GitHub] infil00p closed pull request #429: CB-13800: Drop pre-KitKat specific code

infil00p closed pull request #429: CB-13800: Drop pre-KitKat specific code URL: https://github.com/apache/cordova-android/pull/429 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] infil00p commented on issue #429: CB-13800: Drop pre-KitKat specific code

infil00p commented on issue #429: CB-13800: Drop pre-KitKat specific code URL: https://github.com/apache/cordova-android/pull/429#issuecomment-359060673 LGTM This is an automated message from the Apache Git Service. To

[cordova-android] branch master updated (6cc4896 -> cc08e9d)

This is an automated email from the ASF dual-hosted git repository. bowserj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 6cc4896 Merge pull request #426 from infil00p/api_level_bump add 075d381 CB-13800: (android) Drop

[cordova-coho] 01/01: Add Github UI as a merge option

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-github-ui-merge in repository https://gitbox.apache.org/repos/asf/cordova-coho.git commit e8207ab85448f0bb0d9bebe1d232f4ac2138fb81 Author: Jan Piotrowski

[cordova-coho] branch janpio-github-ui-merge created (now e8207ab)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-github-ui-merge in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. at e8207ab Add Github UI as a merge option This branch includes the following new commits:

[GitHub] janpio opened a new pull request #169: Add Github UI as a merge option

janpio opened a new pull request #169: Add Github UI as a merge option URL: https://github.com/apache/cordova-coho/pull/169 ... and move stuff around to make sense this way This is an automated message from the Apache Git

[GitHub] wf9a5m75 commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins

wf9a5m75 commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428#issuecomment-359086798 @infil00p ping

[GitHub] infil00p commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins

infil00p commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428#issuecomment-359104668 So, I'm only seeing this change to the system library mappings, and nothing that

[GitHub] IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359117563 Sounds like you need Windows 8 and Windows 10 and a simple app that uses the splash screen plugin.

[GitHub] wf9a5m75 closed pull request #428: CB-13788: (android) Specify the minimum required version of google play services for plugins

wf9a5m75 closed pull request #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] wf9a5m75 commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins

wf9a5m75 commented on issue #428: CB-13788: (android) Specify the minimum required version of google play services for plugins URL: https://github.com/apache/cordova-android/pull/428#issuecomment-359124084 Sorry, I changed my mind. I close this PR at once.

[GitHub] codecov-io commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11

codecov-io commented on issue #352: CB-13510: (iOS) Removed clipboard workaround, which was braking copy/paste functional iOS 11 URL: https://github.com/apache/cordova-ios/pull/352#issuecomment-349498236 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/352?src=pr=h1) Report >

[GitHub] IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359114357 @janpio Nice job! This is an automated

[GitHub] brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

brodybits commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359116351 > Good catch, @brodybits. Thanks for reviewing. Sure, haha. Any pointers how to test my

[GitHub] IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359114720 Good catch, @brodybits. Thanks for reviewing.

[GitHub] janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color.

janpio commented on issue #245: CB-13641: (windows) support transparent splash screen background color. URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-358905936 Hey @IndieSW, can you take a look at the conflict? If you resolve this, I think this is good to merge.