[GitHub] solaomosola opened a new pull request #234: Update README.md

2018-03-28 Thread GitBox
solaomosola opened a new pull request #234: Update README.md URL: https://github.com/apache/cordova-plugin-file/pull/234 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported

[GitHub] janpio commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

2018-03-28 Thread GitBox
janpio commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-377011311 Yep, the README and one `.m` conflict seem because of changes/additions with `toolbar.barStyle` and

[GitHub] infil00p commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

2018-03-28 Thread GitBox
infil00p commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-377003241 OK, I'm not totally clear on Obj-C, but did something similar get added by someone else? Why is this still

[GitHub] TheProgrammer2 opened a new issue #272: MsBuild Tool not found

2018-03-28 Thread GitBox
TheProgrammer2 opened a new issue #272: MsBuild Tool not found URL: https://github.com/apache/cordova-windows/issues/272 I had a problem with the MSBuild Tool for building an ionic project for windows. The reason for the problem might be that I have installed both, Visual Studio

[GitHub] dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377013624 I think the Makefile shouldn’t be part of the docs since Gulp is our standard way to do builds. I

[GitHub] dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377013624 I think the Makefile shouldn’t be part of the docs since Gulp is our standard way to do builds. I

[GitHub] gandhirajan opened a new pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
gandhirajan opened a new pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811 Added Make instructions for building and running website

[GitHub] janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r177868893 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15

[GitHub] janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r177868797 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15

[GitHub] janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r177868797 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15

[GitHub] infil00p commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

2018-03-28 Thread GitBox
infil00p commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-377003241 OK, I'm not totally clear on Obj-C, but did something similar get added by someone else?

[GitHub] janpio commented on issue #272: MsBuild Tool not found

2018-03-28 Thread GitBox
janpio commented on issue #272: MsBuild Tool not found URL: https://github.com/apache/cordova-windows/issues/272#issuecomment-377012426 Hi again :) The actual reason for this not working is probably that the MSBuild selection code somehow chose `C:\Program Files

[GitHub] janpio commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
janpio commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377014469 IMHO if there are two ways to do things, they should be documented.

[GitHub] dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section

2018-03-28 Thread GitBox
dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377013624 I think the Makefile shouldn’t be part of the docs since Gulp is our standard way to do builds. I

[GitHub] reidab commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view

2018-03-28 Thread GitBox
reidab commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser view URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-377059546 I just rebased the original branch onto master in my