[GitHub] dhruvdp opened a new issue #73: Difference between connections?

2018-09-25 Thread GitBox
dhruvdp opened a new issue #73: Difference between connections? URL: https://github.com/apache/cordova-plugin-network-information/issues/73 While using navigator['connection].type while connected to Verizon cellular 4g and local wifi, the plugin returns '4g' as the network type even though

[GitHub] knight9999 opened a new pull request #892: Add podspec

2018-09-25 Thread GitBox
knight opened a new pull request #892: Add podspec URL: https://github.com/apache/cordova-docs/pull/892 ### Platforms affected Documents (about iOS) ### What does this PR do? This PR is document part of following PRs

[GitHub] janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)

2018-09-25 Thread GitBox
janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424261183 Did I understand correctly that this probably does not apply only for this

[cordova-test-platform] branch master updated (31965d0 -> 9f44c72)

2018-09-25 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git. from 31965d0 Merge pull request #5 from raphinesse/fix-spec-promise-handling add 22b9d77 Do

[cordova-test-platform] 01/01: Merge pull request #4 from raphinesse/silence-output

2018-09-25 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git commit 9f44c72575e9ea09a0957b06b3c42cff2390 Merge: 31965d0 927ae6c Author: Raphael von der Grün

[cordova-test-platform] 01/01: Merge pull request #5 from raphinesse/fix-spec-promise-handling

2018-09-25 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git commit 31965d0816f8cf6a4221883204d1df49f497436d Merge: 1cce89a cddc8dc Author: Raphael von der Grün

[GitHub] ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)

2018-09-25 Thread GitBox
ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424280538 Anyone using prompt interface for the javascript-Java communication is

[cordova-test-platform] branch master updated (1cce89a -> 31965d0)

2018-09-25 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git. from 1cce89a Doc requirements for platform api expectations (#1) add fc0a8ab Use proper temp

[GitHub] janpio commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-25 Thread GitBox
janpio commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424261882 @499978920 Your first command is missing an `-- `. You need two of those before `buildflag` so it gets routed to `cordova` and not `ionic`.

[GitHub] Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

2018-09-25 Thread GitBox
Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424233907 @sdgpalm2 thanks, i'm really busy in this days. Also note that if you are editing an

[GitHub] jcesarmobile commented on issue #400: Why is config.xml not being merged?

2018-09-25 Thread GitBox
jcesarmobile commented on issue #400: Why is config.xml not being merged? URL: https://github.com/apache/cordova-ios/issues/400#issuecomment-424234313 You said you were writing a plugin, all plugins should have a plugin.xml, read the docs about plugin creation

[GitHub] SimoneMSR opened a new issue #304: Listen to click events

2018-09-25 Thread GitBox
SimoneMSR opened a new issue #304: Listen to click events URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/304 Is it possible somehow to listen to click events triggered within the InAppBrowser? This is an

[GitHub] 499978920 commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-25 Thread GitBox
499978920 commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424253916 when:`ionic cordova run ios --emulator --buildFlag="-UseModernBuildSystem=0"` > ** BUILD SUCCEEDED ** > > No target

[GitHub] 499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-25 Thread GitBox
499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424253916 **when**:`ionic cordova run ios --emulator --buildFlag="-UseModernBuildSystem=0"` > ** BUILD SUCCEEDED ** > > No

[GitHub] 499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-25 Thread GitBox
499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424253916 when:`ionic cordova run ios --emulator --buildFlag="-UseModernBuildSystem=0"` > ** BUILD SUCCEEDED ** > > No target

[GitHub] janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)

2018-09-25 Thread GitBox
janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424286393 I don't know - I was hoping you knew ;)

[GitHub] purplecabbage opened a new pull request #61: CB-13740 return expected promise resolving with array

2018-09-25 Thread GitBox
purplecabbage opened a new pull request #61: CB-13740 return expected promise resolving with array URL: https://github.com/apache/cordova-browser/pull/61 ### Platforms affected - browser ### What does this PR do? - returns what is expected, fixes error in cordova-cli where

[cordova-browser] branch master updated (f23c998 -> 5ce40e5)

2018-09-25 Thread purplecabbage
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git. from f23c998 Merge pull request #59 from raphinesse/remove-bundled-dependencies add 9a38451

[cordova-browser] 01/01: Merge pull request #61 from purplecabbage/CB-13740

2018-09-25 Thread purplecabbage
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git commit 5ce40e53e2ea2be61c78dd3c9c6b9f27c58cc80a Merge: f23c998 9a38451 Author: Jesse MacFadyen AuthorDate: Tue

[GitHub] purplecabbage closed pull request #61: CB-13740 return expected promise resolving with array

2018-09-25 Thread GitBox
purplecabbage closed pull request #61: CB-13740 return expected promise resolving with array URL: https://github.com/apache/cordova-browser/pull/61 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[cordova-cli] branch master updated (f8ed27c -> 890d336)

2018-09-25 Thread purplecabbage
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-cli.git. from f8ed27c Stub telemetry calls during all tests (#327) add f10a371 CB-13740 gracefully handle

[cordova-cli] 01/01: Merge pull request #335 from purplecabbage/CB-13740

2018-09-25 Thread purplecabbage
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-cli.git commit 890d336a29c586633b4cfa1f714c1afe5e604ac6 Merge: f8ed27c f10a371 Author: Jesse MacFadyen AuthorDate: Tue Sep

[GitHub] erisu edited a comment on issue #10: Cordova 9 release plan

2018-09-25 Thread GitBox
erisu edited a comment on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424577754 @raphinesse This release plan looks great and very detailed. The very important question: **When are we going to release Cordova 9?** Also adding

[cordova-lib] branch master updated: Dereference possible symlinks when copying plugin (#705)

2018-09-25 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-lib.git The following commit(s) were added to refs/heads/master by this push: new 3079853 Dereference possible symlinks

[GitHub] erisu commented on issue #10: Cordova 9 release plan

2018-09-25 Thread GitBox
erisu commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424586802 @dpogue **The CocoaPods improvement** is done and can be merged in now. `cordova-common` needs to be merged first. Then we need to release cordova-common

[GitHub] erisu edited a comment on issue #10: Cordova 9 release plan

2018-09-25 Thread GitBox
erisu edited a comment on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424586802 @dpogue **The CocoaPods improvement** is done and can be merged in now. 1. Merge `cordova-common` PR 2. Release `cordova-common` next major

[GitHub] dpogue commented on issue #10: Cordova 9 release plan

2018-09-25 Thread GitBox
dpogue commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424588550 I think the issue with the Android Gradle latest version is that the current projects are not compatible with the latest Android Studio. I believe newer

[cordova-android] branch master updated (73edf4d -> 8dfddef)

2018-09-25 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 73edf4d Update comments (#496) add e3eb933 GH-485: (android) Change deprecated "compile" to

[cordova-android] 01/01: Merge pull request #486 from jedrivisser/7.1.x

2018-09-25 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 8dfddef6f9f5d00fba591a2fbe8837ccebea49a7 Merge: 73edf4d e3eb933 Author: Darryl Pogue AuthorDate: Tue Sep 25

[GitHub] dpogue closed pull request #486: GH-485: (android) Replace deprecated "compile" with "implementation"

2018-09-25 Thread GitBox
dpogue closed pull request #486: GH-485: (android) Replace deprecated "compile" with "implementation" URL: https://github.com/apache/cordova-android/pull/486 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] erisu commented on issue #10: Cordova 9 release plan

2018-09-25 Thread GitBox
erisu commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424577754 @raphinesse This release plan looks great and very detailed. The very important question: **When are we going to release Cordova 9?** Also adding

[GitHub] sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

2018-09-25 Thread GitBox
sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424564468 @Stefano1964, code has beed code applied.

[GitHub] dpogue commented on issue #10: Cordova 9 release plan

2018-09-25 Thread GitBox
dpogue commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424581064 My list of remaining items looks something like this: * **Bridge WebView plugin for UIWebView/WKWebView** * **Update Xcode Project to be compatible with

[GitHub] dpogue commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-25 Thread GitBox
dpogue commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424362956 > Should we expect the UserModernBuildSystem=0 setting to also persist into the generated workspace, or is it always necessary to manually

[GitHub] Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

2018-09-25 Thread GitBox
Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in

[GitHub] Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

2018-09-25 Thread GitBox
Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in

[GitHub] jrmihalick commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-25 Thread GitBox
jrmihalick commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424338642 @dpogue I added the "-UseModernBuildSystem=0" flag to my build.json and that does address the problem we were having as mentioned on

[GitHub] ajayprakashshukla commented on issue #412: Unable to distribute with Xcode 10

2018-09-25 Thread GitBox
ajayprakashshukla commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-424346565 Using Legacy Build System you will be able to build archive with normal mobileprovision and Info.plist files

[GitHub] sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

2018-09-25 Thread GitBox
sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424359628 @Stefano1964, I've been using Asset Catalog Creator and did remove and replaced the xcassets, I

[GitHub] Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

2018-09-25 Thread GitBox
Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in

[GitHub] Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

2018-09-25 Thread GitBox
Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in landscape

[GitHub] ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)

2018-09-25 Thread GitBox
ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424370742 I implemented a fix that seems to work ok Instead of calling

[GitHub] jruizsulime commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-25 Thread GitBox
jruizsulime commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424374517 @dpogue Thanks for your comment, you save my time! This is an

[GitHub] vagishmm opened a new issue #305: 'loadstop' event stopped working in iOS 12.0

2018-09-25 Thread GitBox
vagishmm opened a new issue #305: 'loadstop' event stopped working in iOS 12.0 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/305 'loadstop' event is not working in iOS 12.0. Please help in this case. Thanks in advance.