[GitHub] ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

2018-11-14 Thread GitBox
ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438601158 Do you have a list of committers somewhere that would elligible for that

[GitHub] andaofei commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

2018-11-14 Thread GitBox
andaofei commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-438605960

[GitHub] andaofei commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

2018-11-14 Thread GitBox
andaofei commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-438605530 On Android, when setting footer to yes, the footer bar overlaps the WebView content,

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438608165 I think we will need to adapt pluginHandlers.js instead. Followup question is coming on #552.

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438610396 It's on android 7.1.1 This

[GitHub] brodybits edited a comment on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits edited a comment on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438608165 ~~I think we will need to adapt pluginHandlers.js instead.~~ Followup question is coming on

[GitHub] theMartux edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-14 Thread GitBox
theMartux edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-438623076 @ceeespinosa19 ciao. No. I did not use Ionic. The --buildFlag = "-UseModernBuildSystem = 0" command that you use in Cordova

[GitHub] ffMathy edited a comment on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

2018-11-14 Thread GitBox
ffMathy edited a comment on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438601158 Do you have a list of committers somewhere that would elligible for that

[GitHub] janpio commented on issue #94: check for required permission before video capture

2018-11-14 Thread GitBox
janpio commented on issue #94: check for required permission before video capture URL: https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438633790 Do you have a link handy? This is an automated

[GitHub] DavidWiesner commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
DavidWiesner commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438638629 Here is one [issue (CB-13615)](https://issues.apache.org/jira/browse/CB-13615) reflecting the new structure

[GitHub] DavidWiesner commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
DavidWiesner commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438640276 I think your commit is just fine. This was my prefered order and method. I hope the old location

[GitHub] ffMathy edited a comment on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

2018-11-14 Thread GitBox
ffMathy edited a comment on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438601158 Do you have a list of committers somewhere that would elligible for that

[GitHub] uerceg opened a new issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

2018-11-14 Thread GitBox
uerceg opened a new issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554 Hey guys. We have our plugin built for Cordova and the version on Github `master` branch is compatible with pre `android@7.0.0` platform version.

[GitHub] brodybits opened a new pull request #555: [WIP] 7.1.3 patch updates - proposed

2018-11-14 Thread GitBox
brodybits opened a new pull request #555: [WIP] 7.1.3 patch updates - proposed URL: https://github.com/apache/cordova-android/pull/555 * Remove obsolete check for JellyBean to work properly on Android Pie (GH-534) * GH-539 fix destination path fallback * GH-540 fix for source-file

[GitHub] janpio commented on issue #94: check for required permission before video capture

2018-11-14 Thread GitBox
janpio commented on issue #94: check for required permission before video capture URL: https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438652925 This PR here seems to have quite some more code and differentiates between different permissions being required.

[GitHub] Dwarfex commented on issue #109: Status bar is always white

2018-11-14 Thread GitBox
Dwarfex commented on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-438598518 @diegodotta I hoped so - but i already have added the plugin. - I use viewport-fit=cover - i use the splashscreen plugin with a ""

[GitHub] robert2206 opened a new issue #120: When getting location does'nt return anything or return empty error with a timeout (Android Oreo)

2018-11-14 Thread GitBox
robert2206 opened a new issue #120: When getting location does'nt return anything or return empty error with a timeout (Android Oreo) URL: https://github.com/apache/cordova-plugin-geolocation/issues/120 ``` this.geolocation.getCurrentPosition().then(location => {

[GitHub] ffMathy commented on issue #94: check for required permission before video capture

2018-11-14 Thread GitBox
ffMathy commented on issue #94: check for required permission before video capture URL: https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438643472 #95? This is an automated message from the

[GitHub] janpio commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

2018-11-14 Thread GitBox
janpio commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438600912 Short: No. Long: Materialize a Cordova committer with enough Android knowledge

[GitHub] theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-14 Thread GitBox
theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-438623076 @ceeespinosa19 ciao. No. I did not use Ionic. The --buildFlag = "-UseModernBuildSystem = 0" command that you use in Cordova is not

[GitHub] ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

2018-11-14 Thread GitBox
ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438623193 @jcesarmobile you (relatively) recently pushed an orientation fix for iOS. This

[GitHub] brodybits opened a new issue #905: Android build-extras.gradle location is outdated

2018-11-14 Thread GitBox
brodybits opened a new issue #905: Android build-extras.gradle location is outdated URL: https://github.com/apache/cordova-docs/issues/905 **Issue Type** [x] Bug [ ] Feature Request **Priority** [ ] Minor [x] Major [ ] Critical [ ] Blocker

[GitHub] DavidWiesner commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
DavidWiesner commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438628305 I know the structure has changed. But why also change the location of the build-extras.gradle? All other

[GitHub] DavidWiesner commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
DavidWiesner commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438632858 Ok I can update the pull request. Wich file should win in the case both files existing? Should the

[GitHub] janpio commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
janpio commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438632830 > But why also change the location of the build-extras.gradle? That was probably overlooked when changing the

[GitHub] janpio commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion

2018-11-14 Thread GitBox
janpio commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551#discussion_r233373993 ## File path: bin/templates/project/app/build.gradle ## @@ -117,7 +117,7 @@ if

[GitHub] janpio commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
janpio commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438599903 This would be a breaking change right now, so I guess it would be nicer to just check both locations?

[GitHub] afdev82 commented on issue #542: Resolve GH-539 & GH-540 on master

2018-11-14 Thread GitBox
afdev82 commented on issue #542: Resolve GH-539 & GH-540 on master URL: https://github.com/apache/cordova-android/pull/542#issuecomment-438599928 > This is not a breaking change as .jar/.aar files should be in lib-file tags, not in source-file tag. That's what we broke in cordova-android

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438616481 Expected behavior

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438615947 I've enclosed the screenshots :)

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438632037 I just pushed an update to PR #553 to check both locations.

[GitHub] codecov-io commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
codecov-io commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438634931 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/553?src=pr=h1) Report > Merging

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438635797 Good question. I thought we should run both files, didn't think about the ordering. I would

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438643092 From the history it looks like the work was done in PR #389. It seems like they did try to preserve

[GitHub] DavidWiesner commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
DavidWiesner commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438618200 In my case I did nothing with plugins. I just add a `platforms/android/build-extras.gradle` file manually

[GitHub] ffMathy commented on issue #94: check for required permission before video capture

2018-11-14 Thread GitBox
ffMathy commented on issue #94: check for required permission before video capture URL: https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438621676 I think this can be closed as it has been fixed elsewhere.

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438625258 That is because the Android project structure was changed in 7.0. I just raised

[GitHub] ManicMapple commented on issue #113: iOS - Media Files are stored in tmp

2018-11-14 Thread GitBox
ManicMapple commented on issue #113: iOS - Media Files are stored in tmp URL: https://github.com/apache/cordova-plugin-media-capture/issues/113#issuecomment-438627934 Having the same Problem, but here (ios 12) my captured video is not even accessible by the photos app. The file is

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438631866 I just pushed an update to support both locations, didn't test it yet.

[GitHub] janpio commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion

2018-11-14 Thread GitBox
janpio commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551#discussion_r233412172 ## File path: bin/templates/project/app/build.gradle ## @@ -117,7 +117,7 @@ if

[GitHub] brodybits commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion

2018-11-14 Thread GitBox
brodybits commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551#discussion_r233381601 ## File path: bin/templates/project/app/build.gradle ## @@ -117,7 +117,7 @@ if

[GitHub] DavidWiesner commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion

2018-11-14 Thread GitBox
DavidWiesner commented on a change in pull request #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551#discussion_r233385208 ## File path: bin/templates/project/app/build.gradle ## @@ -117,7 +117,7 @@ if

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

2018-11-14 Thread GitBox
brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438608925 Please show exactly exactly what you did in plugin.xml for both 6.4 and 7.1.2. I think we will have to fix

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438635134 Ahem, I see big screenshots - but not really what is going on and what is wrong. Could you resize

[GitHub] janpio commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

2018-11-14 Thread GitBox
janpio commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-438635299 @andaofei Please create a new issue for this problem. This will be ignored here.

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438645251 Thanks @DavidWiesner, would like to get review from one more member before merging. If someone

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438869673 Passes on Travis CI now, will watch for the result on AppVeyor. Hope we can get this finished soon.

[GitHub] brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js

2018-11-14 Thread GitBox
brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js URL: https://github.com/apache/cordova-android/pull/558#issuecomment-438845851 > Why is a PR with failing tests being merged? It is a build error, no actually failing tests. I deleted my branch right after

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

2018-11-14 Thread GitBox
brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438847411 Thanks @jcesarmobile for the detailed review! This is an

[GitHub] janpio commented on issue #194: onDestroy and dealloc ambiguity

2018-11-14 Thread GitBox
janpio commented on issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438839380 Yes, that sounds very reasonable. Maybe an additional [`MediaError`](https://github.com/apache/cordova-plugin-media#mediaerror)? Is

[GitHub] brodybits closed pull request #550: Fix for old plugins with non-Java sources (GH-547)

2018-11-14 Thread GitBox
brodybits closed pull request #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[cordova-android] branch master updated (53e1c1b -> 21ae48e)

2018-11-14 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 53e1c1b Set version & VERSION to 8.0.0-dev (coho) add 9d03e4e Fix tests of plugin files with new

[cordova-android] 01/01: Merge pull request #550 from brodybits/gh-547-bugfix

2018-11-14 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 21ae48eada2f1aebe970857c5d54eadcc91fd16d Merge: 53e1c1b a67bc75 Author: Chris Brody AuthorDate: Wed Nov 14

[GitHub] brodybits opened a new pull request #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
brodybits opened a new pull request #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559 This change should to give us a green build again. Rationale is that the eslint update introduced in

[GitHub] dpogue commented on issue #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
dpogue commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438866164 There might be an eslint ignore comment we can wrap around the version line to suppress the error?

[GitHub] brodybits closed pull request #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
brodybits closed pull request #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[cordova-android] branch master updated: eslint ignore version file (#559)

2018-11-14 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/master by this push: new f1396c7 eslint ignore version file

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438883292 Build is green, merging now This is an automated message

[GitHub] janpio commented on issue #558: Mark 8.0.0-dev

2018-11-14 Thread GitBox
janpio commented on issue #558: Mark 8.0.0-dev URL: https://github.com/apache/cordova-android/pull/558#issuecomment-438837496 Why is a PR with failing tests being merged? Why does this PR contain a lot more than it says in the PR title? Why does this PR refer to a WIP and unmerged

[GitHub] brodybits commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP

2018-11-14 Thread GitBox
brodybits commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438857403 > I don't see #551 fix in the resulting changes Just added it, thanks for catching it! FYI This PR is still marked as WIP

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438866450 > There might be an eslint ignore comment we can wrap around the version line to suppress the error? That would

[GitHub] dpolivy commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

2018-11-14 Thread GitBox
dpolivy commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438873097 I'm seeing a potentially similar issue with `UIWebView` on iOS 12: if you are scrolled to the bottom of the page

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-43302 > That would involve updating the cordova-coho tool. I may be wrong here. Not sure if I would favor an extra eslint

[GitHub] jcesarmobile commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP

2018-11-14 Thread GitBox
jcesarmobile commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438854815 I don't see https://github.com/apache/cordova-android/pull/551 fix in the resulting changes

[GitHub] brodybits closed pull request #199: [WIP] Add previous patch dependency note

2018-11-14 Thread GitBox
brodybits closed pull request #199: [WIP] Add previous patch dependency note URL: https://github.com/apache/cordova-coho/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438654430 sure!

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438654508 *cordova This is an

[GitHub] brodybits commented on issue #468: Update CordovaResourceApi.java

2018-11-14 Thread GitBox
brodybits commented on issue #468: Update CordovaResourceApi.java URL: https://github.com/apache/cordova-android/pull/468#issuecomment-438659079 Can we move some of this functionality into a plugin? This is an automated

[GitHub] janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12

2018-11-14 Thread GitBox
janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438664689 You are posting this in the Cordova plugin repository, not Ionic. Any specific reason why you are using the Ionic

[GitHub] uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

2018-11-14 Thread GitBox
uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438680723 Awesome guys, thanks for super quick reply. I tried @brodybits's flow with nightly build and it works like a charm. Nice.

[GitHub] brodybits closed pull request #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits closed pull request #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

2018-11-14 Thread GitBox
brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438678457 P.S. Once PR #550 is merged and released you should not need the cordova-8 changes in

[GitHub] janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

2018-11-14 Thread GitBox
janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438678478 (FYI: Can reproduce on Windows with same Cordova CLI version)

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

2018-11-14 Thread GitBox
brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438684105 > Is there a way to declare paths in `plugin.xml` in a way that it supports both, `cordova-android@6` and

[GitHub] OmarHassan25 commented on issue #173: App crashes on ANDROID 8 version

2018-11-14 Thread GitBox
OmarHassan25 commented on issue #173: App crashes on ANDROID 8 version URL: https://github.com/apache/cordova-plugin-contacts/issues/173#issuecomment-438661600 @duncan-c updated ContactManager.java solves the problem This

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

2018-11-14 Thread GitBox
brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438665079 > [...] it also has `.h` and `.c` files that are treated as `.java` files. > They were `src/c/common/mylib/parts` and he

[GitHub] janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438662302 And without the statusbar plugin, you get the same result as in the browser? I think

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-14 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438662302 And without the statusbar plugin, you get the same result as in the browser? I think it

[GitHub] janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12

2018-11-14 Thread GitBox
janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438675407 What version of `cordova-ios` are you using? The best way for us to reporoduce and later debug this issue

[GitHub] duncan-c edited a comment on issue #173: App crashes on ANDROID 8 version

2018-11-14 Thread GitBox
duncan-c edited a comment on issue #173: App crashes on ANDROID 8 version URL: https://github.com/apache/cordova-plugin-contacts/issues/173#issuecomment-434470449 Have done now: https://github.com/apache/cordova-plugin-contacts/pull/180 I wasn't sure if I should as the plugin is marked

[GitHub] Nazirovich opened a new issue #345: In App Browser - doesn't load webpage in iOS 12

2018-11-14 Thread GitBox
Nazirovich opened a new issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345 **Ionic version:** [ ] 1.x [ ] 2.x [X] 3.x **I'm submitting a ...** (check one with "x") [x ] bug report

[GitHub] Nazirovich commented on issue #345: In App Browser - doesn't load webpage in iOS 12

2018-11-14 Thread GitBox
Nazirovich commented on issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438667199 > You are posting this in the Cordova plugin repository, not Ionic. Any specific reason why you are using the

[GitHub] jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

2018-11-14 Thread GitBox
jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438669256 It knows nothing about any file extension at all, this PR is the one placing files based on the extension

[GitHub] thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

2018-11-14 Thread GitBox
thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821 My solution was use a plugin or any thing to detect the event on keyboard native hide, and on this

[GitHub] thepianist2 commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

2018-11-14 Thread GitBox
thepianist2 commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821 My solution was use a plugin or any thing to detect the event on keyboard native hide, and on this moment

[GitHub] uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

2018-11-14 Thread GitBox
uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438684410 Awesome. Thank you very much, will keep an eye on 7.1.3 official release and update plugin and docs accordingly. Cheers! 

[GitHub] thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

2018-11-14 Thread GitBox
thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821 My solution was use a plugin or any thing to detect the event on keyboard native hide, and on this

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-14 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438905081 Payments plugin is not supported here. For payments problem please raise a new issue on the payments plugin

[GitHub] artuska edited a comment on issue #260: File becomes [object Object] in FormData

2018-11-14 Thread GitBox
artuska edited a comment on issue #260: File becomes [object Object] in FormData URL: https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438918491 About the Blob. There are a lot of weird stuff here about the Blob in Cordova. I used some custom file chooser (do

[GitHub] artuska commented on issue #260: File becomes [object Object] in FormData

2018-11-14 Thread GitBox
artuska commented on issue #260: File becomes [object Object] in FormData URL: https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438907238 @Polypants in my case the reason why some Androids cannot select files from the file system and returns `null` is

[GitHub] artuska commented on issue #260: File becomes [object Object] in FormData

2018-11-14 Thread GitBox
artuska commented on issue #260: File becomes [object Object] in FormData URL: https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438918491 About the Blob. There are a lot of weird stuff here about the Blob in Cordova. I used some custom file chooser (do not

[GitHub] nagthgr8 commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-14 Thread GitBox
nagthgr8 commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438900353 Guys, can anyone help me understand why does build succeed on such breaking changes, the runtime failures are

[GitHub] brodybits commented on issue #555: 7.1.3 patch updates

2018-11-14 Thread GitBox
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438911311 I just finished testing the patch updates with some plugins listed in the OP description, quick review would be appreciated.

[GitHub] ECNU3D commented on issue #454: Use NSOperationQueue (GH-452)

2018-11-14 Thread GitBox
ECNU3D commented on issue #454: Use NSOperationQueue (GH-452) URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-438925110 @brodybits thanks, I will try to follow that document and post some plugin to demonstrate the issue.

[GitHub] blukis opened a new issue #560: Content-security-policy bug

2018-11-14 Thread GitBox
blukis opened a new issue #560: Content-security-policy bug URL: https://github.com/apache/cordova-android/issues/560 I believe I found an issue with content-security-policy in cordova environment... I have an app that includes this page in an iframe:

[GitHub] dpogue commented on issue #559: Ignore version file in eslint to resolve build error

2018-11-14 Thread GitBox
dpogue commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438935516 > I may be wrong here. Not sure if I would favor an extra eslint comment though. Build of `master` branch is green again,

[GitHub] brodybits opened a new issue #907: browser platform is missing from sections

2018-11-14 Thread GitBox
brodybits opened a new issue #907: browser platform is missing from sections URL: https://github.com/apache/cordova-docs/issues/907 **Issue Type** [x] Bug [ ] Feature Request **Priority** [ ] Minor [x] Major [ ] Critical [ ] Blocker

[cordova-docs] 01/01: Remove incorrect info for cordova-ios-bin/create

2018-11-14 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-ios-create-docfix in repository https://gitbox.apache.org/repos/asf/cordova-docs.git commit e9017e75c80a9749f26ce1b93166f5a36879703a Author: Chris Brody AuthorDate: Wed Nov 14

[cordova-docs] branch brodybits-ios-create-docfix created (now e9017e7)

2018-11-14 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-ios-create-docfix in repository https://gitbox.apache.org/repos/asf/cordova-docs.git. at e9017e7 Remove incorrect info for cordova-ios-bin/create This branch includes the

[GitHub] brodybits opened a new pull request #906: Remove incorrect info for cordova-ios-bin/create

2018-11-14 Thread GitBox
brodybits opened a new pull request #906: Remove incorrect info for cordova-ios-bin/create URL: https://github.com/apache/cordova-docs/pull/906 This is an automated message from the Apache Git Service. To respond to the

  1   2   >