[GitHub] danbeo95 opened a new issue #187: Access to contact lists on phone it was very slow after call save Method !

2018-11-16 Thread GitBox
danbeo95 opened a new issue #187: Access to contact lists on phone it was very slow after call save Method ! URL: https://github.com/apache/cordova-plugin-contacts/issues/187 Please support me ! When i call save() method to modify contact.It was sccucess.But i notify ,after that access

[GitHub] ippeiukai commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-16 Thread GitBox
ippeiukai commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477 I've just submitted a fix to another plugin. This one is a bit different because this behaviour of

[GitHub] ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-16 Thread GitBox
ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477 I've just submitted a fix to another plugin. This one is a bit different because this behaviour of

[GitHub] jeffreyvdhondel edited a comment on issue #373: Cannot take pictures on Android 8

2018-11-16 Thread GitBox
jeffreyvdhondel edited a comment on issue #373: Cannot take pictures on Android 8 URL: https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439313196 We had a problem kinda like this. So maybe this doesn't work for you. To fix this issue we had to edit the

[GitHub] janpio closed issue #186: Please support me ! When i call save() method to modify contact.It was sccucess.But i notify , after that access to contact lists on phone it was very slow .How can

2018-11-16 Thread GitBox
janpio closed issue #186: Please support me ! When i call save() method to modify contact.It was sccucess.But i notify ,after that access to contact lists on phone it was very slow .How can i fix it ? URL: https://github.com/apache/cordova-plugin-contacts/issues/186

[GitHub] janpio commented on issue #186: Please support me ! When i call save() method to modify contact.It was sccucess.But i notify , after that access to contact lists on phone it was very slow .Ho

2018-11-16 Thread GitBox
janpio commented on issue #186: Please support me ! When i call save() method to modify contact.It was sccucess.But i notify ,after that access to contact lists on phone it was very slow .How can i fix it ? URL: https://github.com/apache/cordova-plugin-contacts/issues/186#issuecomment-439316261

[GitHub] jeffreyvdhondel commented on issue #373: Cannot take pictures on Android 8

2018-11-16 Thread GitBox
jeffreyvdhondel commented on issue #373: Cannot take pictures on Android 8 URL: https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439313196 To fix this issue we had to edit the android manimanifest.xml. Located here:

[GitHub] ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-16 Thread GitBox
ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477 I've just submitted a fix to another plugin. This one is a bit different because this behaviour of

[GitHub] janpio commented on issue #909: update example on buildConfig

2018-11-16 Thread GitBox
janpio commented on issue #909: update example on buildConfig URL: https://github.com/apache/cordova-docs/pull/909#issuecomment-439367136 Why is it relevant to know here that `~` is the home directory on some systems? What does this have to do with buildConfig?

[GitHub] janpio commented on a change in pull request #563: [Fix] better support to find Home path for window

2018-11-16 Thread GitBox
janpio commented on a change in pull request #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#discussion_r234176797 ## File path: bin/templates/cordova/lib/build.js ## @@ -82,7 +82,9 @@ function parseOpts

[GitHub] danbeo95 commented on issue #187: Access to contact lists on phone it was very slow after call save Method !

2018-11-16 Thread GitBox
danbeo95 commented on issue #187: Access to contact lists on phone it was very slow after call save Method ! URL: https://github.com/apache/cordova-plugin-contacts/issues/187#issuecomment-439339184 @janpio can you support me ?

[GitHub] ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-16 Thread GitBox
ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477 I've just submitted a fix to another plugin. This one is a bit different because this behaviour of

[GitHub] janpio commented on issue #187: Access to contact lists on phone it was very slow after call save Method !

2018-11-16 Thread GitBox
janpio commented on issue #187: Access to contact lists on phone it was very slow after call save Method ! URL: https://github.com/apache/cordova-plugin-contacts/issues/187#issuecomment-439343999 No. (Don't mention people to pull them into your issue. If someone wants to respond, they

[GitHub] hiepxanh opened a new pull request #563: [Fix] better support to find Home path for window

2018-11-16 Thread GitBox
hiepxanh opened a new pull request #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563 ### Platforms affected Android, ios, Browser ### What does this PR do? I struggeling with home path every time changing build

[GitHub] hiepxanh opened a new pull request #909: update example on buildConfig

2018-11-16 Thread GitBox
hiepxanh opened a new pull request #909: update example on buildConfig URL: https://github.com/apache/cordova-docs/pull/909 ### Platforms affected Android ### What does this PR do? There is no tutorial or any example on google or the docs. I dont event know that `~` can relate

[GitHub] janpio edited a comment on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-16 Thread GitBox
janpio edited a comment on issue #119: Getting location with high accuracy taking time more than 4 mins URL: https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439368130 "same problem" as who? Original poster said that "Getting location with high accuracy

[GitHub] janpio commented on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-16 Thread GitBox
janpio commented on issue #119: Getting location with high accuracy taking time more than 4 mins URL: https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439368130 "same problem" as who? Original poster said that "Getting location with high accuracy taking time

[GitHub] janpio edited a comment on issue #563: [Fix] better support to find Home path for window

2018-11-16 Thread GitBox
janpio edited a comment on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439368754 Hm, first time I see this. Is the `~` behavior documented anywhere? Where did you learn that you can do it this way?

[GitHub] janpio commented on issue #563: [Fix] better support to find Home path for window

2018-11-16 Thread GitBox
janpio commented on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439368754 Hm, first time I see this. Is the `~` behavior documented anywhere? Where did you learn that you can do it this way?

[GitHub] easywasdev opened a new issue #376: UIImagePickerController cancel handling incorrect for iOS11+

2018-11-16 Thread GitBox
easywasdev opened a new issue #376: UIImagePickerController cancel handling incorrect for iOS11+ URL: https://github.com/apache/cordova-plugin-camera/issues/376 The way the plugin handles the user cancelling the UIImagePickerController is not correct for iOS11+. From iOS 11 Apple no

[GitHub] carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-16 Thread GitBox
carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins URL: https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439351124 Well I have the same problem, if I check the logs: 11-16 11:28:17.404 3420 21768 I

[GitHub] yaro08 commented on issue #342: Client digital certificate authentication doesn't work

2018-11-16 Thread GitBox
yaro08 commented on issue #342: Client digital certificate authentication doesn't work URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/342#issuecomment-439368909 If someone have this same problem: I achieved to solve this issue using this plugin with CordovaView

[GitHub] carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-16 Thread GitBox
carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins URL: https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439374624 Ye it took 15s for triggering error with no response, there is one missing line there, when

[GitHub] carliblaz edited a comment on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-16 Thread GitBox
carliblaz edited a comment on issue #119: Getting location with high accuracy taking time more than 4 mins URL: https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439351124 Well I have the same problem, if I check the logs: 11-16 11:28:17.404 3420 21768

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439377526 Oh right, there it is in white font. But it overlays the webview on my app, is this expected?

[GitHub] carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-16 Thread GitBox
carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins URL: https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439377641 Another example: 11-16 13:22:49.058 17763 17858 D GeolocationPlugin: We are entering

[GitHub] BuddyLReno commented on issue #197: Add durationUpdate callback

2018-11-16 Thread GitBox
BuddyLReno commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439400072 @janpio updated! Sorry about that! This is an automated message from the

[GitHub] gurolayanlar commented on issue #305: 'loadstop' event stopped working in iOS 12.0

2018-11-16 Thread GitBox
gurolayanlar commented on issue #305: 'loadstop' event stopped working in iOS 12.0 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/305#issuecomment-439400829 I have same problem, is there solved problem?

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439404536 Yeah that's expected because I've enabled screen overlay ;)

[GitHub] janpio commented on a change in pull request #197: Add durationUpdate callback

2018-11-16 Thread GitBox
janpio commented on a change in pull request #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234244621 ## File path: www/Media.js ## @@ -35,16 +35,22 @@ var mediaObjects = {}; * @param errorCallback The

[GitHub] theoafactor commented on issue #373: Cannot take pictures on Android 8

2018-11-16 Thread GitBox
theoafactor commented on issue #373: Cannot take pictures on Android 8 URL: https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439479882 @jeffreyvdhondel thanks but this does not work still.. This is an

[GitHub] BuddyLReno commented on a change in pull request #197: Add durationUpdate callback

2018-11-16 Thread GitBox
BuddyLReno commented on a change in pull request #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234239840 ## File path: www/Media.js ## @@ -35,16 +35,22 @@ var mediaObjects = {}; * @param errorCallback

[GitHub] ippeiukai commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

2018-11-16 Thread GitBox
ippeiukai commented on issue #47: Fix or remove undocumented plugin directory source-file behavior URL: https://github.com/apache/cordova/issues/47#issuecomment-439433236 @brodybits Thank you for following up. To me, it is a strange situation. `source-file` is meant for specifying

[GitHub] brodybits commented on issue #555: 7.1.3 patch updates

2018-11-16 Thread GitBox
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439447665 I just put the changes in almost the same order as they appear in master and removed "[WIP]" from the title, think it should be merged now. Any objections?

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439470466 Since, I've used StatusBar.overlaysWebView(true); , The Statusbar just overlays on top of

[GitHub] brodybits commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

2018-11-16 Thread GitBox
brodybits commented on issue #47: Fix or remove undocumented plugin directory source-file behavior URL: https://github.com/apache/cordova/issues/47#issuecomment-439435990 > Keeping and documenting is probably "easier" here In that case I think we should fix it for Android as well.

[GitHub] janpio commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

2018-11-16 Thread GitBox
janpio commented on issue #47: Fix or remove undocumented plugin directory source-file behavior URL: https://github.com/apache/cordova/issues/47#issuecomment-439469305 +1 for fix and document then This is an automated

[GitHub] janpio commented on issue #555: 7.1.3 patch updates

2018-11-16 Thread GitBox
janpio commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439471150 Maybe silly question, but what would be a way to compare `master` and this branch to see if the cherry-picked commits make sense and nothing is missing etc?

[GitHub] janpio commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

2018-11-16 Thread GitBox
janpio commented on issue #47: Fix or remove undocumented plugin directory source-file behavior URL: https://github.com/apache/cordova/issues/47#issuecomment-439428984 Keeping and documenting is probably "easier" here as there might be a unlimited number of plugins out there using it,

[GitHub] janpio commented on issue #67: CB-12024: Browser platform support

2018-11-16 Thread GitBox
janpio commented on issue #67: CB-12024: Browser platform support URL: https://github.com/apache/cordova-plugin-statusbar/pull/67#issuecomment-439442071 @dudeofawesome Could you have a look at my questions, I couldn't get this to work. Otherwise we would have to treat this PR as

[GitHub] janpio edited a comment on issue #555: 7.1.3 patch updates

2018-11-16 Thread GitBox
janpio edited a comment on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439471150 Maybe silly question, but what would be a way to compare `master` and this branch to see if the cherry-picked commits make sense and nothing is missing

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439479450 yeah exactly! yeah if I don't use Statusbar overlay even with the plugin added, it doesn't

[GitHub] BuddyLReno commented on a change in pull request #197: Add durationUpdate callback

2018-11-16 Thread GitBox
BuddyLReno commented on a change in pull request #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234240286 ## File path: www/Media.js ## @@ -35,16 +35,22 @@ var mediaObjects = {}; * @param errorCallback

[GitHub] BuddyLReno commented on issue #197: Add durationUpdate callback

2018-11-16 Thread GitBox
BuddyLReno commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439426503 Yes, I can elaborate. In the newer versions of android, after about five minutes of background activity, android shuts down the web

[GitHub] jcesarmobile commented on issue #555: 7.1.3 patch updates

2018-11-16 Thread GitBox
jcesarmobile commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439476178 No, because master have a lot more fixes that won't go into 7.1.3, so you can't directly compare Also no to 7.2.0, this is supposedly a patch, and

[GitHub] brodybits commented on issue #555: 7.1.3 patch updates

2018-11-16 Thread GitBox
brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439484841 I just updated the changes as follows: * moved a couple gradle updates to the end * added number of original PR on master where it was not present

[GitHub] janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439438487 Understood. --- The following answers: What is going on here? I

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439438487 Got it. --- The following answers: What is going on here? I duplicated the app

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439441478 Ok, this got me thinking: Is it really the presence of the plugin causing the behavior or is it

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears

2018-11-16 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439508422 Ok, so using `StatusBar.overlaysWebView(true)` makes the

[GitHub] dmonaldo commented on issue #306: InApp browser not support in iPhone X devices

2018-11-16 Thread GitBox
dmonaldo commented on issue #306: InApp browser not support in iPhone X devices URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/306#issuecomment-439515603 I'm also experiencing this issue. Are there any plans to fix this?

[GitHub] itsonit commented on issue #114: Not working on Android devices

2018-11-16 Thread GitBox
itsonit commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-439513362 @terminaltor ty for charing. 1st Test set with several android devices works well. 2nd Test will follow..

[GitHub] janpio commented on issue #111: Status bar don't overlay web view in Ionic

2018-11-16 Thread GitBox
janpio commented on issue #111: Status bar don't overlay web view in Ionic URL: https://github.com/apache/cordova-plugin-statusbar/issues/111#issuecomment-439508084 What plugin version are you using? What iOS version are you testing on? Did you remote debug the problem and inspect

[GitHub] BuddyLReno commented on issue #197: Add durationUpdate callback

2018-11-16 Thread GitBox
BuddyLReno commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439523985 Great! I'm getting ready to leave the office but I'll update the README later tonight after the kids go to bed. 

[GitHub] brunojs02 opened a new issue #111: Status bar don't overlay web view in Ionic

2018-11-16 Thread GitBox
brunojs02 opened a new issue #111: Status bar don't overlay web view in Ionic URL: https://github.com/apache/cordova-plugin-statusbar/issues/111 Ionic: 3.20.0 Cordova: 8.0.0 Cordova-ios: 4.5.5 Configurations: StatusBar.overlaysWebView(true); I want the status bar

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
janpio commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439523084 Ok, so https://github.com/apache/cordova-plugin-inappbrowser#inappbrowserclose does not actually work but

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439547110 sure, go at it, doesn't work: ``` /* * Licensed to the Apache Software Foundation (ASF) under

[GitHub] janpio commented on issue #197: Add durationUpdate callback

2018-11-16 Thread GitBox
janpio commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439521793 Ok, so https://github.com/apache/cordova-plugin-media#quick-example-2 doesn't actually work that well any more and one should use this new

[GitHub] janpio edited a comment on issue #197: Add durationUpdate callback

2018-11-16 Thread GitBox
janpio edited a comment on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439521793 I very much hoe so: I understood that https://github.com/apache/cordova-plugin-media#quick-example-2 doesn't actually work that well

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439551334 i also created a rep for you, please forgive me if i added too many files in there, i really have no idea

[GitHub] AutoAlert commented on issue #373: Cannot take pictures on Android 8

2018-11-16 Thread GitBox
AutoAlert commented on issue #373: Cannot take pictures on Android 8 URL: https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439537809 Hi @jeffreyvdhondel thanks for the response. I tried your suggestion but unfortunately it still does not work, still the same error.

[GitHub] brodybits opened a new issue #47: Fix or remove undocumented plugin directory source-file behavior

2018-11-16 Thread GitBox
brodybits opened a new issue #47: Fix or remove undocumented plugin directory source-file behavior URL: https://github.com/apache/cordova/issues/47 Triggered by @ippeiukai in : > [...] behaviour of

[GitHub] IonicOnCouch commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-16 Thread GitBox
IonicOnCouch commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439429729 @nagthgr8 Did you find a solution for the problem? I have the same Error...

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears

2018-11-16 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439589299 Yeah!! in iOS, it shrinks a little but still the

[GitHub] heidji commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

2018-11-16 Thread GitBox
heidji commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank? URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561306 i honestly don't care how the browser is called or what it looks like, as long as it

[GitHub] janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

2018-11-16 Thread GitBox
janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank? URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561039 I took the liberty to rewrite your feature request into a question on how to make this

[GitHub] keithdmoore commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
keithdmoore commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439561574 @janpio I am using ‘_blank’ and the close method leaves the inappbrowser running. It’s hidden but it’s

[GitHub] keithdmoore edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

2018-11-16 Thread GitBox
keithdmoore edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439566001 @janpio that’s pretty close to what I was seeing. It’s been awhile since I looked into

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439558045 @janpio okay thanks, will open an issue for my use case

[GitHub] heidji opened a new issue #347: Request: browser.close() should include URLs opened with '_system' and not only '_blank'

2018-11-16 Thread GitBox
heidji opened a new issue #347: Request: browser.close() should include URLs opened with '_system' and not only '_blank' URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347 After a lenghty discussion on

[GitHub] janpio commented on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

2018-11-16 Thread GitBox
janpio commented on issue #290: InAppBrowser will not destroy WebView when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439562745 Ok, so you actually have a different "problem" than @heidji had - good that we moved his to new

[GitHub] heidji commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

2018-11-16 Thread GitBox
heidji commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank? URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439564185 yes I suppose this could work, I will give it a go and let you know in a few days.

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439556413 actually i was mistaken about _blank not closing, but it's because also in my app _blank doesn't work: the

[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439556413 actually i was mistaken about _blank not closing, but it's because also in my app _blank doesn't work:

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
janpio commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439557264 @keithdmoore Did you original issue also refer to IAB using `_system`? The next step to debug this

[GitHub] janpio edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

2018-11-16 Thread GitBox
janpio edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439562745 Ok, so you actually have a different "problem" than @heidji had - good that we moved his to

[GitHub] janpio edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

2018-11-16 Thread GitBox
janpio edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439562745 Ok, so you actually have a different "problem" than @heidji had - good that we moved his to

[GitHub] janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

2018-11-16 Thread GitBox
janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank? URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439564435 It's one solution for the problem that many OAuth configurations only accept valid URLs

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
janpio commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439552612 Thanks, the repo is perfect. While checking it out, I had a look at the documentation. Something popped

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439553520 @janpio actually the behavior of _blank isn't useful to me, it opens inside the app itself and doesn't close

[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439553520 @janpio actually the behavior of _blank isn't useful to me, it opens inside the app itself and doesn't

[GitHub] ippeiukai commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

2018-11-16 Thread GitBox
ippeiukai commented on issue #47: Fix or remove undocumented plugin directory source-file behavior URL: https://github.com/apache/cordova/issues/47#issuecomment-439555481 > > Keeping and documenting is probably "easier" here > > In that case I think we should fix it for Android as

[GitHub] janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

2018-11-16 Thread GitBox
janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank? URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561958 I assume this means that my description of your usecase is still correct ;) So:

[GitHub] keithdmoore commented on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

2018-11-16 Thread GitBox
keithdmoore commented on issue #290: InAppBrowser will not destroy WebView when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439566001 @panpio that’s pretty close to what I was seeing. It’s been awhile since I looked into this

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439552895 i also suspected something similar, i think i can live with _blank :D

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

2018-11-16 Thread GitBox
janpio commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439554830 I can reproduce the behaviour you describe in the unchanged app. After adding some debugging and

[GitHub] janpio edited a comment on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

2018-11-16 Thread GitBox
janpio edited a comment on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank? URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561039 I took the liberty to rewrite your feature request into a question on how to

[GitHub] janpio commented on issue #197: Add durationUpdate callback

2018-11-16 Thread GitBox
janpio commented on issue #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439422019 (Thanks for the updates on the text, I cleaned up the comments a bit by hiding.) Interesting change. I understand both parts of what you

[GitHub] janpio commented on a change in pull request #197: Add durationUpdate callback

2018-11-16 Thread GitBox
janpio commented on a change in pull request #197: Add durationUpdate callback URL: https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234237200 ## File path: www/Media.js ## @@ -35,16 +35,22 @@ var mediaObjects = {}; * @param errorCallback The

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-16 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439421666 > So trying to fix this is definitely a patch @jcesarmobile I see your point now. I will update PR #555

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-16 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439472320 Sorry, I don't understand. Did you move the app top bar down a bit so it looks normal? If so,