[GitHub] regnete commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-19 Thread GitBox
regnete commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337814464 It looks like a bug to me. It should not be neccessary to specify "--buildConfig build.json" as this is the default.

[GitHub] fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337590400 Has anybody tried the 4.5.2 version? I still get the error > requires a provisioning profile with the Push

[GitHub] fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337590400 Has anybody tried the 4.5.2 version? I still get the error > requires a provisioning profile with the Push

[GitHub] fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337590400 Has anybody tried the 4.5.2 version? I still get the error > requires a provisioning profile with the Push

[GitHub] fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337590400 Has anybody tried the 4.5.2 version? I still get the error > requires a provisioning profile with the Push

[GitHub] regnete commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
regnete commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337597603 "packageType": "enterprise" works as expected but "packageType": "app-store" fails. I created an issue:

[GitHub] Defcon0 commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
Defcon0 commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337593766 Same here :?( This is an automated message from the Apache

[GitHub] timbru31 commented on issue #341: CB-12896: (ios) Update icon mapping

2017-10-19 Thread GitBox
timbru31 commented on issue #341: CB-12896: (ios) Update icon mapping URL: https://github.com/apache/cordova-ios/pull/341#issuecomment-337863153 Can we have a new release for this issue with the 80x80 icon? This breaks CI builds for us, since manual editing is required before a new app is

[GitHub] stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-18 Thread GitBox
stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-337673585 Common PRs have been merged. When testing this locally, you have to go into package.json of

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-18 Thread GitBox
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-337675034 @stevengill Doesn't npm linking cordova-common do the same thing?

[GitHub] stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-18 Thread GitBox
stevengill commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-337678844 I managed to npm link common into android but then when i added my local android to a cordova project, the way

[GitHub] fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337622799 I finally got it to work. So I added the build.json in my root project folder. My build.json ``` {

[GitHub] Defcon0 commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
Defcon0 commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337630213 Awesome, I'll try when I'm at home ;-) This is an automated

[GitHub] fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
fransyozef commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337622799 I finally got it to work. So I added the build.json in my root project folder. My build.json > { >

[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-18 Thread GitBox
codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-18 Thread GitBox
codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) Report > Merging

[GitHub] dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-18 Thread GitBox
dpogue commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-337685619 I ended up pointing cordova-android at the git master for cordova-common, but it all appears to be working now.

[GitHub] surajpindoria commented on issue #338: support for creating Xcode9 style exportOptions.plist

2017-10-18 Thread GitBox
surajpindoria commented on issue #338: support for creating Xcode9 style exportOptions.plist URL: https://github.com/apache/cordova-ios/pull/338#issuecomment-337746303 @fransyozef You should be able to use your build.json in a different folder if you format the command like: `cordova

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-19 Thread GitBox
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-338001365 Bad news: There's issues with the installation of the File Plugin, and cordova clean doesn't work properly, so

[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-19 Thread GitBox
codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) Report > Merging

[GitHub] pinkahd commented on issue #337: CB-13191: (ios) Support marketing icon

2017-10-24 Thread GitBox
pinkahd commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-338966460 I'm having the same issue I've added the correct lines in cordova config but it's not building under ios 4.5.2 downgraded to 4.5.1 and the

[GitHub] kungfucode-rex opened a new pull request #759: Update index.md

2017-11-12 Thread GitBox
kungfucode-rex opened a new pull request #759: Update index.md URL: https://github.com/apache/cordova-docs/pull/759 ### Platforms affected Android platform ### What does this PR do? Doc translation of Chinese for Android platform ### What testing has been done on

[GitHub] stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-15 Thread GitBox
stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151225869 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0

[GitHub] janpio closed pull request #739: CB-13323: Cordova-Android 6.3.0 Release Announcement

2017-11-15 Thread GitBox
janpio closed pull request #739: CB-13323: Cordova-Android 6.3.0 Release Announcement URL: https://github.com/apache/cordova-docs/pull/739 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] dpogue commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs

2017-11-15 Thread GitBox
dpogue commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-344690609 The `--automaticProvisioning` flag won't be available until the next iOS release

[GitHub] janpio commented on a change in pull request #722: Update index.md

2017-11-15 Thread GitBox
janpio commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151243239 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the following

[GitHub] infil00p opened a new pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR

2017-11-15 Thread GitBox
infil00p opened a new pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR URL: https://github.com/apache/cordova-android/pull/416 ### Platforms affected Cordova-Android ### What does this PR do? Fixes the Framework Gradle so that we can upload

[GitHub] infil00p closed pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR

2017-11-15 Thread GitBox
infil00p closed pull request #416: CB-13558: Upgrading the gradle so we can upload the AAR URL: https://github.com/apache/cordova-android/pull/416 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] stevengill closed pull request #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

2017-11-15 Thread GitBox
stevengill closed pull request #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761 This is an automated message from the Apache Git Service. To respond to the

[GitHub] stevengill commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

2017-11-15 Thread GitBox
stevengill commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344698544 I wouldn't worry about the failures too much. Lets merge it in and keep an eye on travis for master to see if that passes.

[GitHub] dblotsky commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-15 Thread GitBox
dblotsky commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344702130 @audreyso yep, the question about infra still remains open. Are Apache Infra OK with us having SVN

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

2017-11-15 Thread GitBox
janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first failing Travis CI build here please? No idea what is happening and why. Update

[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-11-15 Thread GitBox
codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) Report > Merging

[GitHub] stevengill commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs

2017-11-15 Thread GitBox
stevengill commented on issue #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762#issuecomment-344690096 LGTM. @dpogue ready to merge or wait until after next iOS release?

[GitHub] dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-15 Thread GitBox
dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151229142 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20

[GitHub] janpio commented on a change in pull request #722: Update index.md

2017-11-15 Thread GitBox
janpio commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151243239 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the following

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

2017-11-15 Thread GitBox
janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first failing Travis CI build here please? No idea what is happening and why. Update

[GitHub] codecov-io commented on issue #416: CB-13558: Upgrading the gradle so we can upload the AAR

2017-11-15 Thread GitBox
codecov-io commented on issue #416: CB-13558: Upgrading the gradle so we can upload the AAR URL: https://github.com/apache/cordova-android/pull/416#issuecomment-344684272 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/416?src=pr=h1) Report > Merging

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-15 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151228684 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-15 Thread GitBox
stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151231646 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-15 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151238364 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] varshatyagi commented on issue #214: CB-11248 InAppBrowser no focus on input text fields

2017-11-13 Thread GitBox
varshatyagi commented on issue #214: CB-11248 InAppBrowser no focus on input text fields URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/214#issuecomment-343874972 @candidoalbertosilva do you get the fix for 6.0.1 ? I am still struggling. Let me know if anyone have

[GitHub] jcesarmobile commented on issue #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller

2017-11-15 Thread GitBox
jcesarmobile commented on issue #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98#issuecomment-344748040 Merged, thanks for the PR!

[GitHub] jcesarmobile commented on issue #97: The problem of continuous call of beep()

2017-11-15 Thread GitBox
jcesarmobile commented on issue #97: The problem of continuous call of beep() URL: https://github.com/apache/cordova-plugin-dialogs/pull/97#issuecomment-344758930 Hi. You have created a pull request by mistake. Can you report the issue on issues.cordova.io?

[GitHub] jcesarmobile closed pull request #97: The problem of continuous call of beep()

2017-11-15 Thread GitBox
jcesarmobile closed pull request #97: The problem of continuous call of beep() URL: https://github.com/apache/cordova-plugin-dialogs/pull/97 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jcesarmobile closed pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller

2017-11-15 Thread GitBox
jcesarmobile closed pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950232 ## File path: doc/developing-the-website.md ## @@ -13,5 +13,14 @@

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950232 ## File path: doc/developing-the-website.md ## @@ -13,5 +13,14 @@

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150976912 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] janpio opened a new pull request #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

2017-11-14 Thread GitBox
janpio opened a new pull request #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761 - add link to gradle install instructions - add link to crosswalk project and issue (I created for this) - reword and restructure text a bit

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150976912 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150949639 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@

[GitHub] janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-14 Thread GitBox
janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150949639 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@

[GitHub] surajpindoria closed pull request #347: CB-13523: Add flag for Xcode-managed provisioning

2017-11-14 Thread GitBox
surajpindoria closed pull request #347: CB-13523: Add flag for Xcode-managed provisioning URL: https://github.com/apache/cordova-ios/pull/347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] Reneoh opened a new pull request #140: Update CDVSplashScreen.h

2017-11-15 Thread GitBox
Reneoh opened a new pull request #140: Update CDVSplashScreen.h URL: https://github.com/apache/cordova-plugin-splashscreen/pull/140 Added a BOOL for iPhoneX This is an automated message from the Apache Git Service. To respond

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

2017-11-15 Thread GitBox
janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first filaing Travis CI build here? No idea what is happening and why.

[GitHub] nadavmos commented on issue #139: Update CDVSplashScreen.m

2017-11-15 Thread GitBox
nadavmos commented on issue #139: Update CDVSplashScreen.m URL: https://github.com/apache/cordova-plugin-splashscreen/pull/139#issuecomment-344530591 you haven't pushed your changes in CDVSplashScreen.h This is an automated

[GitHub] janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post

2017-11-15 Thread GitBox
janpio commented on issue #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761#issuecomment-344536870 @audreyso Could you have a look at the first filaing Travis CI build here please? No idea what is happening and why.

[GitHub] dpogue opened a new pull request #762: CB-13523: Add automaticProvisioning to iOS signing docs

2017-11-14 Thread GitBox
dpogue opened a new pull request #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762 Docs side of https://github.com/apache/cordova-ios/commit/5cb8bd199fe8df85272678d6d4c6343dd080f2a3 Also tried to clean up the manual

[GitHub] heymartinadams opened a new pull request #763: See PR #722

2017-11-15 Thread GitBox
heymartinadams opened a new pull request #763: See PR #722 URL: https://github.com/apache/cordova-docs/pull/763 See: https://github.com/apache/cordova-docs/pull/722 This is an automated message from the Apache Git Service. To

[GitHub] DavidStrausz opened a new pull request #417: CB-13580: (android) fix build for multiple apks (different product flavors)

2017-11-15 Thread GitBox
DavidStrausz opened a new pull request #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417 ### Platforms affected cordova-android ### What does this PR do? This PR fixes the build if

[GitHub] codecov-io commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors)

2017-11-15 Thread GitBox
codecov-io commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-344782111 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/417?src=pr=h1) Report > Merging

[GitHub] jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X

2017-11-15 Thread GitBox
jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X URL: https://github.com/apache/cordova-plugin-statusbar/pull/87#issuecomment-344783469 Hi folks. In my Ionic v1 app, I've installed this PR, have `viewport-fit=cover` in my www/index.html,

[GitHub] jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X

2017-11-15 Thread GitBox
jay-b commented on issue #87: CB-13311: (iOS) Statusbar does not overlay correctly on iPhone X URL: https://github.com/apache/cordova-plugin-statusbar/pull/87#issuecomment-344783469 Hi folks. In my Ionic v1 app, I've installed this PR, have `viewport-fit=cover` in my www/index.html,

[GitHub] heymartinadams commented on a change in pull request #722: Update index.md

2017-11-15 Thread GitBox
heymartinadams commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151286945 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the

[GitHub] heymartinadams commented on a change in pull request #722: Update index.md

2017-11-15 Thread GitBox
heymartinadams commented on a change in pull request #722: Update index.md URL: https://github.com/apache/cordova-docs/pull/722#discussion_r151287002 ## File path: www/docs/en/6.x/guide/platforms/android/index.md ## @@ -310,7 +310,7 @@ To sign an app, you need the

[GitHub] alsorokin closed pull request #249: disable text selection

2017-11-27 Thread GitBox
alsorokin closed pull request #249: disable text selection URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/249 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] janpio commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios

2017-11-27 Thread GitBox
janpio commented on issue #246: Cb 13409 - Add more configurable options for toolbar in android and ios URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/246#issuecomment-347185840 Yes. This is an automated

[GitHub] Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X

2017-11-27 Thread GitBox
Drewster727 commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347213069 @EternallLight can you list the sizes? Kind of a pain, but I may try it...

[GitHub] EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X

2017-11-27 Thread GitBox
EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347098127 @Drewster727 I'm having the same issue. Updated to 4.5.4, the constraints fix seem to be already applied. Any

[GitHub] alsorokin commented on issue #249: disable text selection

2017-11-27 Thread GitBox
alsorokin commented on issue #249: disable text selection URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/249#issuecomment-347170947 You've created a pull request by mistake. Please ask questions on cordova.slack.com or stack overflow.

[GitHub] Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X

2017-11-27 Thread GitBox
Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347214473 I personally use [`cordova-splash`](https://github.com/AlexDisler/cordova-splash) to generate those automatically. Never

[GitHub] Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X

2017-11-27 Thread GitBox
Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347214473 I personally use https://github.com/AlexDisler/cordova-splash to generate those automatically. Never had any issue after

[GitHub] audreyso commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-27 Thread GitBox
audreyso commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-347258427 okay great i'll merge it in. thanks! This

[GitHub] maverickmishra opened a new pull request #166: CB-13065 : Updated cordova contacts plugin reference as inactive

2017-11-27 Thread GitBox
maverickmishra opened a new pull request #166: CB-13065 : Updated cordova contacts plugin reference as inactive URL: https://github.com/apache/cordova-coho/pull/166 Updated reference of cordova-plugin-contacts as inactive in cordova coho ### Checklist - [x] [Reported

[GitHub] EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X

2017-11-27 Thread GitBox
EternallLight commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X URL: https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-347222370 @Drewster727 I started with standard sizes as listen in the documentation: 2x* | universal | any |

[GitHub] maverickmishra opened a new pull request #771: CB-13066: Removed references of contacts plugin

2017-11-27 Thread GitBox
maverickmishra opened a new pull request #771: CB-13066: Removed references of contacts plugin URL: https://github.com/apache/cordova-docs/pull/771 Removed references of the contacts plugin from cordova - docs as part of the process of deprecating the cordova-plugin-contacts

[GitHub] audreyso closed pull request #760: CB-13543 : updated instructions/documentation around travis build/dep?

2017-11-27 Thread GitBox
audreyso closed pull request #760: CB-13543 : updated instructions/documentation around travis build/dep? URL: https://github.com/apache/cordova-docs/pull/760 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] macdonst closed pull request #771: CB-13066: Removed references of contacts plugin

2017-11-27 Thread GitBox
macdonst closed pull request #771: CB-13066: Removed references of contacts plugin URL: https://github.com/apache/cordova-docs/pull/771 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] infil00p closed pull request #407: WIP: CB-13297: Bumping Java compatibility to 1.8

2017-11-27 Thread GitBox
infil00p closed pull request #407: WIP: CB-13297: Bumping Java compatibility to 1.8 URL: https://github.com/apache/cordova-android/pull/407 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] maverickmishra closed pull request #134: CB-11855: (ios) Allow iOS to use hasPhoneNumber

2017-11-27 Thread GitBox
maverickmishra closed pull request #134: CB-11855: (ios) Allow iOS to use hasPhoneNumber URL: https://github.com/apache/cordova-plugin-contacts/pull/134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-11-27 Thread GitBox
codecov-io commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-316205218 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) Report > Merging

[GitHub] maverickmishra commented on issue #149: CB-11038 (Android) Search only among visible contacts

2017-11-27 Thread GitBox
maverickmishra commented on issue #149: CB-11038 (Android) Search only among visible contacts URL: https://github.com/apache/cordova-plugin-contacts/pull/149#issuecomment-347314515 This plugin is being deprecated. No more work will be done on this plugin by the Cordova development

[GitHub] maverickmishra opened a new pull request #773: CB-13608: Added blog post about deprecation of cordova-plugin-contacts

2017-11-27 Thread GitBox
maverickmishra opened a new pull request #773: CB-13608: Added blog post about deprecation of cordova-plugin-contacts URL: https://github.com/apache/cordova-docs/pull/773 Blog post that announces the deprecation of the cordova contacts plugin ### Checklist - [x] [Reported an

[GitHub] purplecabbage commented on issue #51: Windows phone contact picker filter

2017-11-27 Thread GitBox
purplecabbage commented on issue #51: Windows phone contact picker filter URL: https://github.com/apache/cordova-plugin-contacts/pull/51#issuecomment-347315480 ... not to mention the fact we don't support Windows Phone either ..

[GitHub] infil00p commented on issue #385: CB-12835: add a Context getter in CordovaInterface

2017-11-27 Thread GitBox
infil00p commented on issue #385: CB-12835: add a Context getter in CordovaInterface URL: https://github.com/apache/cordova-android/pull/385#issuecomment-347303547 Did anyone ever get around to writing that doc update? Anyone have the link to the PR?

[GitHub] infil00p commented on issue #352: CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors

2017-11-27 Thread GitBox
infil00p commented on issue #352: CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors URL: https://github.com/apache/cordova-android/pull/352#issuecomment-347300520 This works fine, merging into master. Need to do the monkeypatch to add to the StudioProjectCompat

[GitHub] infil00p closed pull request #352: CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors

2017-11-27 Thread GitBox
infil00p closed pull request #352: CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors URL: https://github.com/apache/cordova-android/pull/352 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] infil00p commented on issue #396: CB-12677: (android) added option for explicitly specifying path to An?

2017-11-27 Thread GitBox
infil00p commented on issue #396: CB-12677: (android) added option for explicitly specifying path to An? URL: https://github.com/apache/cordova-android/pull/396#issuecomment-347304023 Since 6.4.0 has been released, I'm going to close out this PR. We can't rely on the permissions or the

[GitHub] maverickmishra commented on issue #109: CB-10935: fix an issue of can not sync new contact into icloud which update new photo with ABPersonSetImageData()

2017-11-27 Thread GitBox
maverickmishra commented on issue #109: CB-10935: fix an issue of can not sync new contact into icloud which update new photo with ABPersonSetImageData() URL: https://github.com/apache/cordova-plugin-contacts/pull/109#issuecomment-347314352 This plugin is being deprecated. No more work

[GitHub] maverickmishra closed pull request #51: Windows phone contact picker filter

2017-11-27 Thread GitBox
maverickmishra closed pull request #51: Windows phone contact picker filter URL: https://github.com/apache/cordova-plugin-contacts/pull/51 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] maverickmishra closed pull request #109: CB-10935: fix an issue of can not sync new contact into icloud which update new photo with ABPersonSetImageData()

2017-11-27 Thread GitBox
maverickmishra closed pull request #109: CB-10935: fix an issue of can not sync new contact into icloud which update new photo with ABPersonSetImageData() URL: https://github.com/apache/cordova-plugin-contacts/pull/109 This is a PR merged from a forked repository. As GitHub hides the

[GitHub] maverickmishra closed pull request #88: CB-9348 Fetch phoneNumbers and emails from linked contacts

2017-11-27 Thread GitBox
maverickmishra closed pull request #88: CB-9348 Fetch phoneNumbers and emails from linked contacts URL: https://github.com/apache/cordova-plugin-contacts/pull/88 This is an automated message from the Apache Git Service. To

[GitHub] maverickmishra commented on issue #134: CB-11855: (ios) Allow iOS to use hasPhoneNumber

2017-11-27 Thread GitBox
maverickmishra commented on issue #134: CB-11855: (ios) Allow iOS to use hasPhoneNumber URL: https://github.com/apache/cordova-plugin-contacts/pull/134#issuecomment-347314455 This plugin is being deprecated. No more work will be done on this plugin by the Cordova development community.

[GitHub] maverickmishra commented on issue #51: Windows phone contact picker filter

2017-11-27 Thread GitBox
maverickmishra commented on issue #51: Windows phone contact picker filter URL: https://github.com/apache/cordova-plugin-contacts/pull/51#issuecomment-347314201 This plugin is being deprecated. No more work will be done on this plugin by the Cordova development community. You can continue

[GitHub] maverickmishra commented on issue #88: CB-9348 Fetch phoneNumbers and emails from linked contacts

2017-11-27 Thread GitBox
maverickmishra commented on issue #88: CB-9348 Fetch phoneNumbers and emails from linked contacts URL: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-347314288 This plugin is being deprecated. No more work will be done on this plugin by the Cordova development

[GitHub] macdonst closed pull request #166: CB-13065 : Updated cordova contacts plugin reference as inactive

2017-11-27 Thread GitBox
macdonst closed pull request #166: CB-13065 : Updated cordova contacts plugin reference as inactive URL: https://github.com/apache/cordova-coho/pull/166 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

  1   2   3   4   5   6   7   8   9   10   >