[GitHub] aszmyd commented on issue #31: Fix unlock
aszmyd commented on issue #31: Fix unlock URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/31#issuecomment-402367813 @jcesarmobile please see the steps described in jira ticket - https://issues.apache.org/jira/browse/CB-13983 Steps you describe does not automatically gets back "landscape" as after unlocking its up to phone to make the detection. Not sure why but the line `[[UIDevice currentDevice] setValue:[NSNumber numberWithInt:UIInterfaceOrientationUnknown] forKey:@"orientation"];` followed by `[UINavigationController attemptRotationToDeviceOrientation];` should in theory do the job. Original plugin covers you'r case because it keeps orientation "before lock" in local variable. So it forces phone to use it instead of allow it to recalculate. And because "last orientation" is being hard saved and restored, steps described in jira does not work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] aszmyd commented on issue #31: Fix unlock
aszmyd commented on issue #31: Fix unlock URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/31#issuecomment-380666335 As far as i've checked, iOS part of this does not have this "unlock" issue. We have an app that uses this approach on both iOS and Android and making this change has been driven by the bug just on Android side This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] aszmyd commented on issue #31: Fix unlock
aszmyd commented on issue #31: Fix unlock URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/31#issuecomment-380383042 @janpio i see the tests succeed. Can you merge this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] aszmyd commented on issue #31: Fix unlock
aszmyd commented on issue #31: Fix unlock URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/31#issuecomment-373683348 I actually dont know why Travis had failed. `The environment you requested was unavailable` error looks like missing something during test. Is it possible that my changes caused something like this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
