[GitHub] brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup

[GitBox]

brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-363913932
 
 
   This issue is fixed in 2e597ef1084088341b102d6e4c6a8ea465f7dce1 which will 
be in 5.1. But 5.1 is now held up due to some test failures as discussed in PR 
#246. Is it possible that we can cherry-pick 
2e597ef1084088341b102d6e4c6a8ea465f7dce1 on the `5.0.x` branch and release it 
there?
   
   I would like to see this resolved ASAP for Windows 8.1. I would be happy to 
raise a new PR to cherry-pick this on the `5.0.x` branch if it would help.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup

[GitBox]

brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-358879785
 
 
   > I went ahead and pushed the changes from this PR to the repo. At least it 
should work from master now.
   
   It works on Windows 8.1 from master, THANK YOU @alsorokin!
   
   I am still looking forward to the actual release (along with others).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup

[GitBox]

brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-358769082
 
 
   WORKAROUND HACK SOLUTION is to simply apply the changes in 
 for CB-12784 by hand:
   * replace `appView.titleBar` with `isWin10UWP` in `colorizeTitleBar` and 
`revertTitleBarColor` functions in cordova.js (right around the place where it 
crashes with the uncaught exception).
   
   Additional links:
   - Further description along with the workaround solution in 

   - CB-13796 () with duplicate 
report that I raised before finding this one (CB-13175 / 
)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup

[GitBox]

brodybits commented on issue #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239#issuecomment-358765260
 
 
   > @janpio there is no need to merge this PR, because the release process 
includes automatic update of cordova.js by coho.
   
   Can we PLEASE get this issue 
() resolved ASAP? I just wasted 
almost half a day making notes about this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org