[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345897 > Is this maybe related to the actually installed local versions of Windows SDK? I would think so > Could you both please

[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-12 Thread GitBox
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364948542 > What should I look for the "before" state? Without the proposed change I get the following _error_ output if I do `npm run

[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-12 Thread GitBox
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364948542 > What should I look for the "before" state? Without the proposed change I get the following output if I do `npm run test-e2e` in

[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-11 Thread GitBox
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364769143 > Ouch. We might want to look into that later ;) @janpio what are your results? Any different?

[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-11 Thread GitBox
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364767817 If I would do `cordova platform add https://github.com/apache/cordova-windows` in a new project then do `cordova requirements windows`

[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-10 Thread GitBox
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364709203 Works for me on both Visual Studio 2015 and Visual Studio 2017. Ship it!