[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439558045 @janpio okay thanks, will open an issue for my use case This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439556413 actually i was mistaken about _blank not closing, but it's because also in my app _blank doesn't work: the reason being that the external app having a callback with myapp:// scheme to return to the app, but in _blank this call never gets through. yes your rep works, but _blank doesn't work for me, it has to be an external browser with _system in order to call the custom URL scheme. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439553520 @janpio actually the behavior of _blank isn't useful to me, it opens inside the app itself and doesn't close either.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439552895 i also suspected something similar, i think i can live with _blank :D This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439551334 i also created a rep for you, please forgive me if i added too many files in there, i really have no idea about cordova in particular and it doesn't have a built in gitignore file: [replink](https://github.com/heidji/inappbrowsertest) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439547110 sure, go at it, doesn't work: ``` /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ var app = { // Application Constructor initialize: function() { document.addEventListener('deviceready', this.onDeviceReady.bind(this), false); }, // deviceready Event Handler // // Bind any cordova events here. Common events are: // 'pause', 'resume', etc. onDeviceReady: function() { this.receivedEvent('deviceready'); }, // Update DOM on a Received Event receivedEvent: function(id) { var parentElement = document.getElementById(id); var listeningElement = parentElement.querySelector('.listening'); var receivedElement = parentElement.querySelector('.received'); listeningElement.setAttribute('style', 'display:none;'); receivedElement.setAttribute('style', 'display:block;'); console.log('Received Event: ' + id); setTimeout(() => test(), 3000); } }; test = function () { var ref = cordova.InAppBrowser.open('https://www.google.com', '_system'); setTimeout(() => ref.close(), 3000); } app.initialize(); ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-434439417 ``` import {InAppBrowser} from "@ionic-native/in-app-browser"; let ref = window.open('https://www.example.com/', '_system'); this.globals.externalbrowser.close(); //does nothing ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()
heidji commented on issue #290: InAppBrowser will not close when invoking ref.close() URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-428661776 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org