janpio closed pull request #752: updated plugin.md
URL: https://github.com/apache/cordova-docs/pull/752
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/www/docs/en/dev/guide/platforms/android/plugin.md 
b/www/docs/en/dev/guide/platforms/android/plugin.md
index a2ce45a66..a6fd71cc0 100644
--- a/www/docs/en/dev/guide/platforms/android/plugin.md
+++ b/www/docs/en/dev/guide/platforms/android/plugin.md
@@ -301,7 +301,7 @@ was the focus of the Cordova-Android 5.0.0 release.
 The permissions that need to be handled at runtime can be found in the Android 
Developer
 documentation [here][permissions-guide].
 
-As far as a plugin is concerned, the permission can be requested by calling 
the permission method, which signature is as follows:
+As far as a plugin is concerned, the permission can be requested by calling 
the permission method; the signature of which is as follows:
 
 ```java
 cordova.requestPermission(CordovaPlugin plugin, int requestCode, String 
permission);
@@ -341,7 +341,7 @@ protected void getReadPermission(int requestCode)
 }
 ```
 
-This will call the activity and cause a prompt to appear asking for the 
permission.  Once the user has the permission, the result must be handled with 
the `onRequestPermissionResult` method, which
+This will call the activity and cause a prompt to appear, asking for the 
permission.  Once the user has the permission, the result must be handled with 
the `onRequestPermissionResult` method, which
 every plugin should override.  An example of this can be found below:
 
 ```java
@@ -371,7 +371,7 @@ public void onRequestPermissionResult(int requestCode, 
String[] permissions,
 }
 ```
 
-The switch statement above would return from the prompt and depending on the 
requestCode that was passed in, it would call the method.  It should be noted 
that permission prompts may stack if the execution is not handled correctly, 
and that this should be avoided.
+The switch statement above would return from the prompt and, depending on the 
requestCode that was passed in, would call the respective method.  It should be 
noted that permission prompts may stack if the execution is not handled 
correctly, and that this should be avoided.
 
 In addition to asking for permission for a single permission, it is also 
possible to request permissions for an entire group by defining the permissions 
array, as what is done with the Geolocation plugin:
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to