[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365446627 #254 is now in a state to be tested and reviewed. This is an automated

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365388649 See https://github.com/apache/cordova-windows/pull/254 as a replacement. Would be nice if you could check that out and run it locally to

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365383160 Problem is that `prepare` is not available on the command line... so I had to implement that. Will open an issue and PR later.

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575 So I installed my branch which is giving me errors on running the test. On `cordova platform add ...` it creates a

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365348748 Can confirm, I currently only have `10.0.16299.0` (newest) installed. These tests only succeed if I change it to that version. Let

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345308 Unfortunately I can not confirm that changing the value to `...10586...` fixes the issue: ``` C:\Program Files (x86)\Microsoft

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365344461 I can now confirm this error message with (only) Visual Studio 2017 installed: ``` C:\Program Files (x86)\Microsoft Visual

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-13 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-12 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364938297 This turned out to be a bigger problem than expected. It is not a blocking issue at https://issues.apache.org/jira/browse/CB-13870

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-11 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364770895 None right now, just setting up to test/release tomorrow and wanted to make sure I know which combination is known good ;)

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-11 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364768966 Ouch. We might want to look into that later ;) This is an automated

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

2018-02-11 Thread GitBox
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364766938 What does `cordova requirements windows` return for you? This is an