[GitHub] [incubator-daffodil] mbeckerle commented on pull request #388: Scalafix ProcedureSyntax

mbeckerle commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646000121 Once we incorporate this fix, are there compiler options that we can put into build.sbt to insure we don't end up adding the obsolete construct back again?

[GitHub] [incubator-daffodil] jw3 opened a new pull request #388: Scalafix ProcedureSyntax

jw3 opened a new pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388 Use Scalafix `ProcedureSyntax` rule to fix the deprecated procedure syntax usage. DAFFODIL-1673 This is an automated

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #387: DAFFODIL-2349: fixed overflow ArithmeticException when totalDigits >= 10

stevedlawrence commented on a change in pull request #387: URL: https://github.com/apache/incubator-daffodil/pull/387#discussion_r442195870 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala ## @@ -455,10 +455,9 @@ final class

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #387: DAFFODIL-2349: fixed overflow ArithmeticException when totalDigits >= 10

stevedlawrence commented on a change in pull request #387: URL: https://github.com/apache/incubator-daffodil/pull/387#discussion_r442290976 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala ## @@ -455,10 +455,9 @@ final class

[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #388: Scalafix ProcedureSyntax

stevedlawrence commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646016837 Based on https://github.com/scala/scala/pull/3076/, it looks like the ``-Xfuture`` scalacOption enables a check for this. Not sure what other checks this flag

[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646034718 Looking into the failures. It appears Scalafix skipped rewriting tests, causing failed compilation when running tests + Xfuture.

[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646064513 Eh, I see it skipped some integration tests too This is an automated message from the Apache Git

[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646015309 It looks like this syntax is deprecated by default starting in 2.13., however for pre 2.13 we would have to use the `-Xfuture` flag (which was noted in jira). I

[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646101061 It might have been easier for this task, given the complex layout of this project, to just specify the root directory rather than trying to use sbt project mappings

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #388: Scalafix ProcedureSyntax

stevedlawrence merged pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (DAFFODIL-1673) code quality: use non-deprecated syntax for methods that don't return a value

[ https://issues.apache.org/jira/browse/DAFFODIL-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence resolved DAFFODIL-1673. -- Fix Version/s: 3.0.0 Resolution: Fixed Fixed in commit