[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

2020-06-18 Thread GitBox
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646101061 It might have been easier for this task, given the complex layout of this project, to just specify the root directory rather than trying to use sbt project mappings

[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

2020-06-18 Thread GitBox
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646064513 Eh, I see it skipped some integration tests too This is an automated message from the Apache Git

[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

2020-06-18 Thread GitBox
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646034718 Looking into the failures. It appears Scalafix skipped rewriting tests, causing failed compilation when running tests + Xfuture.

[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax

2020-06-18 Thread GitBox
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646015309 It looks like this syntax is deprecated by default starting in 2.13., however for pre 2.13 we would have to use the `-Xfuture` flag (which was noted in jira). I