[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646101061 It might have been easier for this task, given the complex layout of this project, to just specify the root directory rather than trying to use sbt project mappings `sbt "scalafix ProcedureSyntax -f /home/path/to/incubator-daffodil"` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646064513 Eh, I see it skipped some integration tests too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646034718 Looking into the failures. It appears Scalafix skipped rewriting tests, causing failed compilation when running tests + Xfuture. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
jw3 commented on pull request #388: URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646015309 It looks like this syntax is deprecated by default starting in 2.13., however for pre 2.13 we would have to use the `-Xfuture` flag (which was noted in jira). I just tested with `-Xfuture` locally in both this PR branch and master and get expected behavior - compile fails in master - compile succeeds in PR branch - compile fails in PR branch if procedure syntax is used Will add that option in another commit on this PR. Offhand I am not sure what else -Xfuture could impact... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
