[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3077: [BUG] repeated task name in one flow

2020-07-26 Thread GitBox
yangyichao-mango commented on issue #3077: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3077#issuecomment-663963423 Hi~, This bug is easy to fix, anyone who are interested about fixing this bug, please leave a message.

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3304: [Test][server] Fix Test ContextConfiguration error.

2020-07-26 Thread GitBox
yangyichao-mango commented on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663982547 LGTM. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on issue #3177: [BUG] The shellTask scheduler reruns the date expression in the script to the current system time

2020-07-26 Thread GitBox
yangyichao-mango edited a comment on issue #3177: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3177#issuecomment-663961952 > > This parameter will only return the current timestamp. What you said should be the function of `supplementing data`. > > For example, when

[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new pull request #3312: [Fix-3177][worker] Fix the system time params invalid error

2020-07-26 Thread GitBox
yangyichao-mango opened a new pull request #3312: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3312 ## What is the purpose of the pull request *Fix the system time params invalid error* #3177 ## Brief change log - *Set the timeParams to globalParams

[GitHub] [incubator-dolphinscheduler] yangyichao-mango closed pull request #3312: [Fix-3177][worker] Fix the system time params invalid error

2020-07-26 Thread GitBox
yangyichao-mango closed pull request #3312: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on issue #3177: [BUG] The shellTask scheduler reruns the date expression in the script to the current system time

2020-07-26 Thread GitBox
yangyichao-mango edited a comment on issue #3177: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3177#issuecomment-663961952 > > This parameter will only return the current timestamp. What you said should be the function of `supplementing data`. > > For example, when

[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new pull request #3313: [Improvement][api] Refactor the transaction rollbackfor runtimeexception

2020-07-26 Thread GitBox
yangyichao-mango opened a new pull request #3313: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3313 ## What is the purpose of the pull request *Improvement the transaction manage* This is an

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3177: [BUG] The shellTask scheduler reruns the date expression in the script to the current system time

2020-07-26 Thread GitBox
yangyichao-mango commented on issue #3177: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3177#issuecomment-663961952 > > This parameter will only return the current timestamp. What you said should be the function of `supplementing data`. > > For example, when a user

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3071: [Feature] locate the specified task in a workflow

2020-07-26 Thread GitBox
yangyichao-mango commented on issue #3071: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3071#issuecomment-663963716 Tag: could be closed. @yangyichao-mango This is an automated message from the Apache

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3061: [QUESTION] task submit succuess but can't continue

2020-07-26 Thread GitBox
yangyichao-mango commented on issue #3061: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3061#issuecomment-663963931 Hi, Has this problem been solved? Tag: could be closed. @yangyichao-mango

[GitHub] [incubator-dolphinscheduler] wa-ooo commented on issue #3177: [BUG] The shellTask scheduler reruns the date expression in the script to the current system time

2020-07-26 Thread GitBox
wa-ooo commented on issue #3177: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3177#issuecomment-663987973 > > > This parameter will only return the current timestamp. What you said should be the function of `supplementing data`. > > > For example, when a user needs

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3313: [Improvement][api] Refactor the transaction rollbackfor runtimeexception

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3313: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3313#issuecomment-663989493 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3313=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3313: [Improvement][api] Refactor the transaction rollbackfor runtimeexception

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3313: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3313#issuecomment-663989493 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3313=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3313: [Improvement][api] Refactor the transaction rollbackfor runtimeexception

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3313: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3313#issuecomment-664074374 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3313=false=BUG)

[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
break60 commented on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664085026 Please resolve conflicting files This is an automated message from the Apache Git Service.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3308: [Feature]add presto datasource support

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308#issuecomment-663847096 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3308: [Feature]add presto datasource support

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308#issuecomment-664075598 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=BUG)

[GitHub] [incubator-dolphinscheduler] RedemptionC opened a new pull request #3315: add feature : query top n success process instance order by running duration

2020-07-26 Thread GitBox
RedemptionC opened a new pull request #3315: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3315 ### What is the purpose of the pull request close (#3191) ### Brief change log * add function in ProcessInstanceController.java , ProcessInstanceService.java ,

[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
break60 commented on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664099021 Your two files are missing commas This is an automated message from the Apache Git Service.

[GitHub] [incubator-dolphinscheduler] break60 edited a comment on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
break60 edited a comment on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664099021 Your two files are missing commas ![image](https://user-images.githubusercontent.com/55787491/88500660-e68d9200-cffb-11ea-81fa-6a052b91d1de.png)

[GitHub] [incubator-dolphinscheduler] RedemptionC commented on a change in pull request #3290: add feature: query top n process instance order by running duration

2020-07-26 Thread GitBox
RedemptionC commented on a change in pull request #3290: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3290#discussion_r460594702 ## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java ## @@ -98,6

[GitHub] [incubator-dolphinscheduler] RedemptionC closed pull request #3290: add feature: query top n process instance order by running duration

2020-07-26 Thread GitBox
RedemptionC closed pull request #3290: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3306: [Fix-3256][ui] Fix admin user info update error

2020-07-26 Thread GitBox
break60 commented on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-664082150 The createUser.vue page has no changes, please revert back This is an automated message

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664096151 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3073=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3308: [Feature]add presto datasource support

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308#issuecomment-664096541 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3315: add feature : query top n success process instance order by running duration

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3315: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3315#issuecomment-664094654 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3315=false=BUG)

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #3273: [Bug][Module Name] Bug title dolphinscheduler keytab认证bug

2020-07-26 Thread GitBox
xingchun-chen commented on issue #3273: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3273#issuecomment-664081115 Can you write the solution , and close the issue   This is an automated message

[GitHub] [incubator-dolphinscheduler] rockxsj commented on pull request #3308: [Feature]add presto datasource support

2020-07-26 Thread GitBox
rockxsj commented on pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308#issuecomment-664073506 > Good job, adding a new jar requires sending an email to dev and getting approval from PPMC. At the same time, you can refer to the following article to

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3308: [Feature]add presto datasource support

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308#issuecomment-664075598 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-659443687 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3073=false=BUG)

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #2767: Task instance log cannot be updated

2020-07-26 Thread GitBox
qiaozhanwei commented on issue #2767: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2767#issuecomment-664087678 @xingchun-chen have other advice ? This is an automated message from the Apache Git Service.

[GitHub] [incubator-dolphinscheduler] vanilla111 opened a new issue #3314: [Question] Why "Failed to load ApplicationContext" when running tests locally

2020-07-26 Thread GitBox
vanilla111 opened a new issue #3314: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3314 # Why "Failed to load ApplicationContext" when running tests locally The first is the test command I ran: ``` mvn test -pl dolphinscheduler-server -Dtest

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664102939 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3073=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664102619 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3073=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3315: add feature : query top n success process instance order by running duration

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3315: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3315#issuecomment-664094654 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3315=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3315: add feature : query top n success process instance order by running duration

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3315: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3315#issuecomment-664101927 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3315=false=BUG)

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on pull request #3306: [Fix-3256][ui] Fix admin user info update error

2020-07-26 Thread GitBox
xingchun-chen commented on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-664093866 @wuchunfu e2e failure problem, you can comment out the case of deleting the user, because the search element on github is not easy to locate

[GitHub] [incubator-dolphinscheduler] zixi0825 commented on a change in pull request #3243: [Fix] [Server] Fix the spell error and add log in SqlTask

2020-07-26 Thread GitBox
zixi0825 commented on a change in pull request #3243: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3243#discussion_r460628616 ## File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java ## @@ -87,7

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3315: add feature : query top n success process instance order by running duration

2020-07-26 Thread GitBox
CalvinKirs commented on pull request #3315: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3315#issuecomment-664103800 Hi, have you encountered any problems? You can add me to WeChat to communicate. My WeChat is Kris_Evil

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664102619 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3073=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3073: adds waterdrop plugin

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3073: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3073#issuecomment-664096151 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3073=false=BUG)

[GitHub] [incubator-dolphinscheduler] lenboo closed issue #2781: [BUG] cannot pause work flow when task state is "submit success"

2020-07-26 Thread GitBox
lenboo closed issue #2781: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3214: [Question] dependent task renamed

2020-07-26 Thread GitBox
yangyichao-mango commented on issue #3214: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3214#issuecomment-663954743 > Hi, > > 1.3.x version do not have this problem, we set the `process definition id` in `process_definition_json` of `dependent task`.[1] >