[GitHub] [incubator-dolphinscheduler] xingchun-chen edited a comment on issue #3663: In version 1.2.1,The task is killed, but the workflow status shows success

2020-09-07 Thread GitBox
xingchun-chen edited a comment on issue #3663: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3663#issuecomment-688056634 The workflow should be the kill state, can you describe the operation steps in detail. You can look at the status of the master and worker logs

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #3663: In version 1.2.1,The task is killed, but the workflow status shows success

2020-09-07 Thread GitBox
xingchun-chen commented on issue #3663: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3663#issuecomment-688056634 The workflow should be the kill state, can you describe the operation steps in detail  

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3601: [Feature-3189][alert,spi,dao,plugin-api] base code of dolphinscheduler spi and alert plugin implement

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3601: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3601#issuecomment-688058347 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3601=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3601: [Feature-3189][alert,spi,dao,plugin-api] base code of dolphinscheduler spi and alert plugin implement

2020-09-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3601: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3601#issuecomment-685420282 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3601=false=BUG)

[GitHub] [incubator-dolphinscheduler] JinyLeeChina opened a new pull request #3689: fix #3688, Optimization of table building statements

2020-09-07 Thread GitBox
JinyLeeChina opened a new pull request #3689: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3689 1. When executing MySQL table creation statement, it will report that the index length is not enough. this will happen: Index column size too large. The maximum column size

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3689: fix #3688, Optimization of table building statements

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3689: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3689#issuecomment-688600514 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3689=false=BUG)

[incubator-dolphinscheduler-website] branch asf-site updated: Automated deployment: Tue Sep 8 02:55:01 UTC 2020 cbee6c4069117943ac7e49d11dfb0a910baaa153

2020-09-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0c974c9

[GitHub] [incubator-dolphinscheduler-website] dailidong merged pull request #175: Add clickable links to documents

2020-09-07 Thread GitBox
dailidong merged pull request #175: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new issue #3693: [Improvement][ui] definition and instance bulk action buttons show changes

2020-09-07 Thread GitBox
zhuangchong opened a new issue #3693: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3693 **Describe the question** Change the display state of batch operation buttons in the workflow definition and instance, and click the state when the specific workflow definition

[GitHub] [incubator-dolphinscheduler] legen618 commented on pull request #3576: [Feature-3575][*] Force Task Success

2020-09-07 Thread GitBox
legen618 commented on pull request #3576: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3576#issuecomment-688632450 > Please resolve three code smell from sonar. There's still **two** code smells, but I think it's unnecessary to fix it. I'd like to explain in

[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on issue #3688: [Improvement][SQL optimization] Optimization of table building statements

2020-09-07 Thread GitBox
JinyLeeChina commented on issue #3688: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3688#issuecomment-688580520 I will fix it This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-dolphinscheduler] JinyLeeChina opened a new issue #3688: [Improvement][SQL optimization] Optimization of table building statements

2020-09-07 Thread GitBox
JinyLeeChina opened a new issue #3688: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3688 1. When executing MySQL table creation statement, it will report that the index length is not enough. this will happen: Index column size too large. The maximum column size is

[GitHub] [incubator-dolphinscheduler-website] Rubik-W merged pull request #173: [Fix][doc] Refactor wrong `workder` to `worker`

2020-09-07 Thread GitBox
Rubik-W merged pull request #173: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-dolphinscheduler-website] branch master updated: [Fix][doc] Refactor wrong `workder` to `worker` (#173)

2020-09-07 Thread wenhemin
This is an automated email from the ASF dual-hosted git repository. wenhemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler-website.git The following commit(s) were added to refs/heads/master by this push: new cbee6c4

[GitHub] [incubator-dolphinscheduler-website] lgcareer opened a new pull request #176: change upgrade file name from upgrade-escheduler.sh to upgrade-dolphinscheduler.sh

2020-09-07 Thread GitBox
lgcareer opened a new pull request #176: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/176 change upgrade file name from upgrade-escheduler.sh to upgrade-dolphinscheduler.sh This is an automated

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on issue #3641: [VOTE]next version what to do

2020-09-07 Thread GitBox
CalvinKirs commented on issue #3641: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3641#issuecomment-688595898 2:Alert module support service for other service invoke( @qiaozhanwei @gaojun2048 ) 3:SQL task support multiple sqls and parameter passing

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3692: fix: use shellformat(shfmt) and shellcheck fix mvnw

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3692: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3692#issuecomment-688610943 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3692=false=BUG)

[GitHub] [incubator-dolphinscheduler] felix-thinkingdata opened a new issue #3690: [Improvement][COMMON-netUtils] 获取本机ip策略问题 Get the native IP policy problem

2020-09-07 Thread GitBox
felix-thinkingdata opened a new issue #3690: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3690 *For better global communication, please give priority to using English description, thx! * *Please review

[GitHub] [incubator-dolphinscheduler-website] break60 opened a new pull request #175: Add clickable links to documents

2020-09-07 Thread GitBox
break60 opened a new pull request #175: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-dolphinscheduler-website] branch master updated: Add clickable links to documents

2020-09-07 Thread lidongdai
This is an automated email from the ASF dual-hosted git repository. lidongdai pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler-website.git The following commit(s) were added to refs/heads/master by this push: new bb94fc2 Add

[GitHub] [incubator-dolphinscheduler] xiagw opened a new pull request #3691: fix:Dockerfile user apk --no-cache

2020-09-07 Thread GitBox
xiagw opened a new pull request #3691: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3691 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a

[incubator-dolphinscheduler-website] branch asf-site updated: Automated deployment: Tue Sep 8 03:18:50 UTC 2020 ce451a1015e061d78aa9c33bdee8bd8011e4dc45

2020-09-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 1045640

[GitHub] [incubator-dolphinscheduler] xiagw opened a new pull request #3692: fix: use shellformat(shfmt) and shellcheck fix mvnw

2020-09-07 Thread GitBox
xiagw opened a new pull request #3692: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3692 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new pull request #3694: [Improvement-3693][ui] definition and instance bulk action buttons show changes

2020-09-07 Thread GitBox
zhuangchong opened a new pull request #3694: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3694 ## What is the purpose of the pull request #3693 Change the display state of batch operation buttons in the workflow definition and instance, and click the state when the

[incubator-dolphinscheduler-website] branch master updated (cbee6c4 -> ce451a1)

2020-09-07 Thread lidongdai
This is an automated email from the ASF dual-hosted git repository. lidongdai pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler-website.git. from cbee6c4 [Fix][doc] Refactor wrong `workder` to `worker` (#173) new 7343a92

[GitHub] [incubator-dolphinscheduler-website] dailidong merged pull request #171: 1.3.1 User manual adds English documents

2020-09-07 Thread GitBox
dailidong merged pull request #171: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-dolphinscheduler] gaojun2048 closed issue #3678: [Improvement][checkstyle] add checkstyle to branch alert_plugin_design

2020-09-07 Thread GitBox
gaojun2048 closed issue #3678: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3576: [Feature-3575][*] Force Task Success

2020-09-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3576: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3576#issuecomment-683316723 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3576=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3576: [Feature-3575][*] Force Task Success

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3576: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3576#issuecomment-688620109 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3576=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3694: [Improvement-3693][ui] definition and instance bulk action buttons show changes

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3694: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3694#issuecomment-688625233 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3694=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3683: [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3683: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3683#issuecomment-688099157 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3683=false=BUG)

[GitHub] [incubator-dolphinscheduler] 597365581 commented on issue #3662: [Feature][process_definition] process definition need to support parallel or serial choose.

2020-09-07 Thread GitBox
597365581 commented on issue #3662: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3662#issuecomment-688115568 > process definition need to support parallel or serial choose. > if is serial in dispatch,need to the previous process_instance execute complete,next

[GitHub] [incubator-dolphinscheduler] muzhongjiang removed a comment on pull request #3519: [Fix] fix bug #3487 Create folder duplicate name under multithreading

2020-09-07 Thread GitBox
muzhongjiang removed a comment on pull request #3519: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3519#issuecomment-688120061 > > > @Igcareer > > > > > > Hi,@muzhongjiang,So sory for response so late,I saw yangyichao-mango have pointed that should add upgrade

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3519: [Fix] fix bug #3487 Create folder duplicate name under multithreading

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3519: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3519#issuecomment-688143399 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3519=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3519: [Fix] fix bug #3487 Create folder duplicate name under multithreading

2020-09-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #3519: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3519#issuecomment-678353738 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3519=false=BUG)

[GitHub] [incubator-dolphinscheduler] break60 opened a new issue #3682: [Feature][ui] Add @form-create/element-ui plug-in

2020-09-07 Thread GitBox
break60 opened a new issue #3682: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-dolphinscheduler] muzhongjiang commented on pull request #3519: [Fix] fix bug #3487 Create folder duplicate name under multithreading

2020-09-07 Thread GitBox
muzhongjiang commented on pull request #3519: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3519#issuecomment-688120061 > > > @Igcareer > > > > > > Hi,@muzhongjiang,So sory for response so late,I saw yangyichao-mango have pointed that should add upgrade dir,You

[GitHub] [incubator-dolphinscheduler] muzhongjiang commented on pull request #3519: [Fix] fix bug #3487 Create folder duplicate name under multithreading

2020-09-07 Thread GitBox
muzhongjiang commented on pull request #3519: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3519#issuecomment-688125967 > > > @Igcareer > > > > > > Hi,@muzhongjiang,So sory for response so late,I saw yangyichao-mango have pointed that should add upgrade dir,You

[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #3683: [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo

2020-09-07 Thread GitBox
break60 opened a new pull request #3683: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3683 #3682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-dolphinscheduler] 597365581 commented on issue #3662: [Feature][process_definition] process definition need to support parallel or serial choose.

2020-09-07 Thread GitBox
597365581 commented on issue #3662: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3662#issuecomment-688211604 ![image](https://user-images.githubusercontent.com/62982788/92374771-c8ef3480-f132-11ea-8a82-dba7c3253754.png)

[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3684: [Feature][process_definition] process definition need to support parallel or serial choose

2020-09-07 Thread GitBox
break60 commented on pull request #3684: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3684#issuecomment-688212257 Why have so many files changed This is an automated message from the Apache Git Service. To

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3683: [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo

2020-09-07 Thread GitBox
yangyichao-mango commented on pull request #3683: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3683#issuecomment-688261374 +1 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3682: [Feature][ui] Add @form-create/element-ui plug-in

2020-09-07 Thread GitBox
yangyichao-mango commented on issue #3682: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3682#issuecomment-688261632 +1 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new issue #3686: [Improvement][service] ProcessService method name meets naming convention.

2020-09-07 Thread GitBox
zhuangchong opened a new issue #3686: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3686 **Describe the question** 1.ProcessService .delCommandByid Change to delCommandById 2.ProcessService .queryUdfFunListByids Change to queryUdfFunListByIds **Which version

[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3684: [Feature][process_definition] process definition need to support parallel or serial choose

2020-09-07 Thread GitBox
597365581 commented on pull request #3684: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3684#issuecomment-688241500 @break60 please confirm? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-dolphinscheduler] 597365581 opened a new pull request #3685: [Feature][process_definition] process definition need to support parallel or serial choose.

2020-09-07 Thread GitBox
597365581 opened a new pull request #3685: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3685 process definition need to support parallel or serial choose. if is serial in dispatch,need to the previous process_instance execute complete,next process_instance can to run。

[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3685: [Feature][process_definition] process definition need to support parallel or serial choose.

2020-09-07 Thread GitBox
597365581 commented on pull request #3685: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3685#issuecomment-688252315 ![image](https://user-images.githubusercontent.com/62982788/92381239-0b1d7380-f13d-11ea-82eb-e1ee928894cd.png)

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new pull request #3687: [Improvement-3686][service] ProcessService method name meets naming convention.

2020-09-07 Thread GitBox
zhuangchong opened a new pull request #3687: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3687 ## What is the purpose of the pull request #3686 ProcessService method name meets naming convention. ## Brief change log 1.ProcessService

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on pull request #3683: [Feature-3682][ui]Add form-create plug-in and alarm group management add sample demo

2020-09-07 Thread GitBox
zhuangchong commented on pull request #3683: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3683#issuecomment-688287460 +1 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3684: [Feature][process_definition] process definition need to support parallel or serial choose

2020-09-07 Thread GitBox
597365581 commented on pull request #3684: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3684#issuecomment-688221512 > Why have so many files changed I don't know,I only dev [Feature][process_definition] process definition need to support parallel or serial

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3685: [Feature][process_definition] process definition need to support parallel or serial choose.

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3685: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3685#issuecomment-688251384 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3685=false=BUG)

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3665: [Feature][ui] DS Plug-in add element-ui

2020-09-07 Thread GitBox
yangyichao-mango commented on issue #3665: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3665#issuecomment-688262769 +1 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-dolphinscheduler] 597365581 opened a new pull request #3684: [Feature][process_definition] process definition need to support parallel or serial choose

2020-09-07 Thread GitBox
597365581 opened a new pull request #3684: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3684 process definition need to support parallel or serial choose. if is serial in dispatch,need to the previous process_instance execute complete,next process_instance can to run。

[GitHub] [incubator-dolphinscheduler] 597365581 commented on issue #3662: [Feature][process_definition] process definition need to support parallel or serial choose.

2020-09-07 Thread GitBox
597365581 commented on issue #3662: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3662#issuecomment-688243566 @break60 please help to confirm This is an automated message from the Apache Git Service. To

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3687: [Improvement-3686][service] ProcessService method name meets naming convention.

2020-09-07 Thread GitBox
sonarcloud[bot] commented on pull request #3687: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3687#issuecomment-688272609 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3687=false=BUG)