[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299

2020-08-03 Thread GitBox 


JinyLeeChina commented on pull request #3300:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-668340296


   Update actions.js fixed #3351 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299

2020-07-29 Thread GitBox 


JinyLeeChina commented on pull request #3300:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-664733606


   I think we should be compatible with JSON with single quotation marks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299

2020-07-24 Thread GitBox 


JinyLeeChina commented on pull request #3300:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663386101


   Yes, I‘ve fixed 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299

2020-07-24 Thread GitBox 


JinyLeeChina commented on pull request #3300:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663365483


   > Fixed alert cannot be notified，when master or worker shutdown。
   > I think the reason for this is that Jackson can't parse JSON fields with 
single quotes.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org