[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256

2020-07-25 Thread GitBox 


wuchunfu commented on a change in pull request #3306:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471704



##
File path: 
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
   
 
 
-  {{$t('Phone')}}
+  *{{$t('Phone')}}

Review comment:
   I have revised and submitted.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256

2020-07-25 Thread GitBox 


wuchunfu commented on a change in pull request #3306:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471425



##
File path: 
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
   
 
 
-  {{$t('Phone')}}
+  *{{$t('Phone')}}

Review comment:
   OK, I'll revise it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256

2020-07-25 Thread GitBox 


wuchunfu commented on a change in pull request #3306:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471038



##
File path: 
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
   
 
 
-  {{$t('Phone')}}
+  *{{$t('Phone')}}

Review comment:
   I have modified the SQL file,





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256

2020-07-25 Thread GitBox 


wuchunfu commented on a change in pull request #3306:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460470915



##
File path: 
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
   
 
 
-  {{$t('Phone')}}
+  *{{$t('Phone')}}

Review comment:
   I think it is also necessary to add `*`  to remind 
users of this required item





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org