[GitHub] [incubator-doris] blackfox1983 commented on a change in pull request #3985: [Doris On ES] [Bug-Fix][Refactor] Fix potential null pointer exception and refactor function process logic

2020-06-30 Thread GitBox
blackfox1983 commented on a change in pull request #3985: URL: https://github.com/apache/incubator-doris/pull/3985#discussion_r447429719 ## File path: be/src/exec/es/es_predicate.cpp ## @@ -283,93 +283,91 @@ Status EsPredicate::build_disjuncts_list(const Expr* conjunct) {

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3990: [shell] Fix BUILD_TYPE not used bug

2020-06-30 Thread GitBox
acelyc111 opened a new pull request #3990: URL: https://github.com/apache/incubator-doris/pull/3990 We can build unit tests by specify BUILD_TYPE to DEBUG/RELEASE/LSAN/ASAN, and outputs in each mode will be placed to different directories, it will save time if rebuild in a same mode.

[GitHub] [incubator-doris] WingsGo edited a comment on pull request #3986: [Config]Allower use to config different thrift server model

2020-06-30 Thread GitBox
WingsGo edited a comment on pull request #3986: URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651743033 > Better to use a `string` instead of `int` type of this config. > And TSimpleServer seems unnecessary. use string is better and easy to understand, but

[GitHub] [incubator-doris] wuyunfeng commented on pull request #3985: [Doris On ES] [Bug-Fix][Refactor] Fix potential null pointer exception and refactor function process logic

2020-06-30 Thread GitBox
wuyunfeng commented on pull request #3985: URL: https://github.com/apache/incubator-doris/pull/3985#issuecomment-651743793 @blackfox1983 done This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] yangzhg opened a new issue #3989: UNIQUE_KEYS table data may not stable when user load data with multiple same key lines

2020-06-30 Thread GitBox
yangzhg opened a new issue #3989: URL: https://github.com/apache/incubator-doris/issues/3989 When importing data into UNIQUE_KEYS table , if there are rows with the same key in the data, when the amount of data is large, the rows with the same key may be distributed in different segments.

[GitHub] [incubator-doris] WingsGo commented on issue #3987: [Config]Allower use to config different thrift server model

2020-06-30 Thread GitBox
WingsGo commented on issue #3987: URL: https://github.com/apache/incubator-doris/issues/3987#issuecomment-651707896 There is an article discuss about different Thrift Server model

[GitHub] [incubator-doris] WingsGo commented on pull request #3986: [Config]Allower use to config different thrift server model

2020-06-30 Thread GitBox
WingsGo commented on pull request #3986: URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651743033 > Better to use a `string` instead of `int` type of this config. > And TSimpleServer seems unnecessary. use string is better, but Config have no check logic, we

[GitHub] [incubator-doris] morningman merged pull request #3938: (#3061) add user doc for build global dict

2020-06-30 Thread GitBox
morningman merged pull request #3938: URL: https://github.com/apache/incubator-doris/pull/3938 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-doris] branch master updated (f9a52f5 -> 210ee96)

2020-06-30 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from f9a52f5 [Bug] Insert may leak DeltaWriter when re-analyzed (#3973) add 210ee96 [SparkLoad]add

[GitHub] [incubator-doris] WingsGo opened a new pull request #3986: [Config]Allower use to config different thrift server model

2020-06-30 Thread GitBox
WingsGo opened a new pull request #3986: URL: https://github.com/apache/incubator-doris/pull/3986 Doris only support TThreadPoolServer model in thrift server, but the server model is not effective in some high concurrency scenario, so this PR introduced new config to allower use to

[GitHub] [incubator-doris] caiconghui opened a new issue #3988: [Proposal]Before drop db, table, partition should check whether there exits related commited txns ready to publish

2020-06-30 Thread GitBox
caiconghui opened a new issue #3988: URL: https://github.com/apache/incubator-doris/issues/3988 **Is your feature request related to a problem? Please describe.** Now, we drop db, table, partition without checking related commited txns, in order to get better performance, we don't

[GitHub] [incubator-doris] WingsGo opened a new issue #3987: [Config]Allower use to config different thrift server model

2020-06-30 Thread GitBox
WingsGo opened a new issue #3987: URL: https://github.com/apache/incubator-doris/issues/3987 Doris only support TThreadPoolServer model in thrift server, but the server model is not effective in some high concurrency scenario, and the server model is not easy to solve high concurrency

[GitHub] [incubator-doris] WingsGo commented on pull request #3986: [Config]Allower use to config different thrift server model

2020-06-30 Thread GitBox
WingsGo commented on pull request #3986: URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651682615 For #3987 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman commented on issue #3930: [Proposal] Doris support version column for REPLACE aggregate type

2020-06-30 Thread GitBox
morningman commented on issue #3930: URL: https://github.com/apache/incubator-doris/issues/3930#issuecomment-651858454 How to generate the value of the `version` column? Is is auto generated? Or it has to be in the user's origin load data?

[GitHub] [incubator-doris] morningman merged pull request #3979: [Bug] Fix bug that routine load task throw exception when calling afterVisible()

2020-06-30 Thread GitBox
morningman merged pull request #3979: URL: https://github.com/apache/incubator-doris/pull/3979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman closed issue #3980: [Bug][RoutineLoad] Routine load job being blocked by many COMMITTED tasks

2020-06-30 Thread GitBox
morningman closed issue #3980: URL: https://github.com/apache/incubator-doris/issues/3980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated (210ee96 -> 1bfb105)

2020-06-30 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 210ee96 [SparkLoad]add user doc for build global dict (#3938) add 1bfb105 [Bug] Fix bug that

[GitHub] [incubator-doris] morningman merged pull request #3894: [Enhancement] Make report version unchanged for publish task

2020-06-30 Thread GitBox
morningman merged pull request #3894: URL: https://github.com/apache/incubator-doris/pull/3894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman closed issue #3893: [Proposal] remove strict report version check of TabletReport

2020-06-30 Thread GitBox
morningman closed issue #3893: URL: https://github.com/apache/incubator-doris/issues/3893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] WingsGo commented on pull request #3986: [Config]Allower use to config different thrift server model

2020-06-30 Thread GitBox
WingsGo commented on pull request #3986: URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-652140409 > > > Better to use a `string` instead of `int` type of this config. > > > And TSimpleServer seems unnecessary. > > > > > > use string is better and easy to

[incubator-doris] branch master updated (1bfb105 -> fdcbea4)

2020-06-30 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 1bfb105 [Bug] Fix bug that routine load task throw exception when calling afterVisible() (#3979)

[GitHub] [incubator-doris] xy720 opened a new issue #3992: [Feature]Support cancel load jobs in batch

2020-06-30 Thread GitBox
xy720 opened a new issue #3992: URL: https://github.com/apache/incubator-doris/issues/3992 Related issue #2298 **Is your feature request related to a problem? Please describe.** As I cancel load jobs in the same pattern, I only cancel them one by one. **Describe the solution

[GitHub] [incubator-doris] HappenLee opened a new pull request #3991: Fix the problem of mem exec, when analytic eval node need to spill to disk with a low mem limit

2020-06-30 Thread GitBox
HappenLee opened a new pull request #3991: URL: https://github.com/apache/incubator-doris/pull/3991 [Bug] Fix the problem of mem exec, when analytic eval node need to spill to disk with a low mem limit. And clear_reservations of Analytic node reservation of block manager. [Running