[GitHub] [incubator-doris] morningman opened a new pull request #4010: [ShowIndex] Make Show Index stmt act same as MySQL behavior

2020-07-02 Thread GitBox
morningman opened a new pull request #4010: URL: https://github.com/apache/incubator-doris/pull/4010 `SHOW INDEX FROM db2.tbl1 FROM db1;` will be same as `SHOW INDEX FROM db1.tbl1;` This is an automated message from the

[GitHub] [incubator-doris] WingsGo opened a new issue #4007: [Bug]Schema Change from int type to varchar failed because miss some logic check

2020-07-02 Thread GitBox
WingsGo opened a new issue #4007: URL: https://github.com/apache/incubator-doris/issues/4007 **Describe the bug** Schema Change from int type to varchar failed because miss some logic check **To Reproduce** Steps to reproduce the behavior: 1. create a table with int type

[GitHub] [incubator-doris] caiconghui opened a new issue #4008: Delete statement need inPredicate support

2020-07-02 Thread GitBox
caiconghui opened a new issue #4008: URL: https://github.com/apache/incubator-doris/issues/4008 **Is your feature request related to a problem? Please describe.** Now, delete stament doesn't support inPredicate. **Describe the solution you'd like** Support inPredicate in delete

[GitHub] [incubator-doris] morningman merged pull request #3985: [Doris On ES] [Bug-Fix][Refactor] Fix potential null pointer exception and refactor function process logic

2020-07-02 Thread GitBox
morningman merged pull request #3985: URL: https://github.com/apache/incubator-doris/pull/3985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman closed issue #3984: [Bug of DOE]be accidental crashed

2020-07-02 Thread GitBox
morningman closed issue #3984: URL: https://github.com/apache/incubator-doris/issues/3984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated: [Doris On ES] [Bug-Fix][Refactor] Fix potential null pointer exception and refactor function process logic (#3985)

2020-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 1e813df [Doris On ES]

[GitHub] [incubator-doris] morningman commented on pull request #4006: [Feature] Support InPredicate in delete statement

2020-07-02 Thread GitBox
morningman commented on pull request #4006: URL: https://github.com/apache/incubator-doris/pull/4006#issuecomment-653043560 In fact, we are also trying to implement a batch delete function that can support the deletion of a large number of specified keys (including specifying multiple

[GitHub] [incubator-doris] caiconghui opened a new pull request #4006: [Feature] Support InPredicate in delete statement

2020-07-02 Thread GitBox
caiconghui opened a new pull request #4006: URL: https://github.com/apache/incubator-doris/pull/4006 This PR is to add inPredicate support to delete statement, and add max_allowed_in_element_num_of_delete variable to limit element num of InPredicate in delete statement.

[GitHub] [incubator-doris] caiconghui commented on pull request #4006: [Feature] Support InPredicate in delete statement

2020-07-02 Thread GitBox
caiconghui commented on pull request #4006: URL: https://github.com/apache/incubator-doris/pull/4006#issuecomment-653031083 for #4008 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] WingsGo opened a new pull request #4009: [Bug]Fix some schema change not work right

2020-07-02 Thread GitBox
WingsGo opened a new pull request #4009: URL: https://github.com/apache/incubator-doris/pull/4009 This CL mainly fix some schema change to varchar type not work right because forget to logic check && Add ConvertTypeResolver to add supported convert type in order to avoid forget logic

[GitHub] [incubator-doris] WingsGo commented on pull request #4009: [Bug]Fix some schema change not work right

2020-07-02 Thread GitBox
WingsGo commented on pull request #4009: URL: https://github.com/apache/incubator-doris/pull/4009#issuecomment-653030178 For #4007 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman commented on a change in pull request #4005: LRU cache for sql/partition cache #2581

2020-07-02 Thread GitBox
morningman commented on a change in pull request #4005: URL: https://github.com/apache/incubator-doris/pull/4005#discussion_r449113739 ## File path: be/src/common/config.h ## @@ -536,6 +536,15 @@ namespace config { // Whether to continue to start be when load tablet from

[GitHub] [incubator-doris] liutang123 opened a new pull request #4011: Remove rs when version conflict when insert to a tablet

2020-07-02 Thread GitBox
liutang123 opened a new pull request #4011: URL: https://github.com/apache/incubator-doris/pull/4011 For #3976 In this PR, when insert to a tablet, if the tablet has a different rs with the same version, remove it. This

[GitHub] [incubator-doris] liutang123 commented on pull request #4011: Remove rs when version conflict when insert to a tablet

2020-07-02 Thread GitBox
liutang123 commented on pull request #4011: URL: https://github.com/apache/incubator-doris/pull/4011#issuecomment-653102312 @chaoyli This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman commented on a change in pull request #4002: [Bug] Cancel the query if OlapScanner prepare failed

2020-07-02 Thread GitBox
morningman commented on a change in pull request #4002: URL: https://github.com/apache/incubator-doris/pull/4002#discussion_r449099844 ## File path: be/src/exec/olap_scan_node.cpp ## @@ -681,7 +681,11 @@ Status OlapScanNode::start_scan_thread(RuntimeState* state) {

[GitHub] [incubator-doris] liutang123 edited a comment on pull request #4011: Remove rs when version conflict when insert to a tablet

2020-07-02 Thread GitBox
liutang123 edited a comment on pull request #4011: URL: https://github.com/apache/incubator-doris/pull/4011#issuecomment-653102312 @chaoyli Now, should we prohibit insertion when `OLAP_ERR_PUSH_VERSION_ALREADY_EXIST` appears?

[GitHub] [incubator-doris] spaces-X commented on a change in pull request #4000: applyInnerJoinConditionReorganizeRule

2020-07-02 Thread GitBox
spaces-X commented on a change in pull request #4000: URL: https://github.com/apache/incubator-doris/pull/4000#discussion_r449353484 ## File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java ## @@ -816,9 +816,103 @@ protected void reorderTable(Analyzer analyzer)

[GitHub] [incubator-doris] WingsGo edited a comment on pull request #4009: [Bug]Fix some schema change not work right

2020-07-02 Thread GitBox
WingsGo edited a comment on pull request #4009: URL: https://github.com/apache/incubator-doris/pull/4009#issuecomment-653323183 > It's better add more discrete message in commit info like you issue. Ok, done, and I tested the schema change supported in doc, but I found that convert

[GitHub] [incubator-doris] funyeah commented on issue #3085: use datagrip connect fe error

2020-07-02 Thread GitBox
funyeah commented on issue #3085: URL: https://github.com/apache/incubator-doris/issues/3085#issuecomment-653348056 ![image](https://user-images.githubusercontent.com/19163232/86433315-fbdd0c80-bd2c-11ea-89d3-f7c7c4f80b24.png)

[GitHub] [incubator-doris] marising commented on a change in pull request #4005: LRU cache for sql/partition cache #2581

2020-07-02 Thread GitBox
marising commented on a change in pull request #4005: URL: https://github.com/apache/incubator-doris/pull/4005#discussion_r449336062 ## File path: be/src/util/doris_metrics.cpp ## @@ -161,6 +158,10 @@ DorisMetrics::DorisMetrics() : _name("doris_be"),

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #4012: [Doris On ES][refactor] refactor and enchanment ES sync meta logic

2020-07-02 Thread GitBox
wuyunfeng opened a new pull request #4012: URL: https://github.com/apache/incubator-doris/pull/4012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #4011: Remove rs when version conflict when insert to a tablet

2020-07-02 Thread GitBox
chaoyli commented on a change in pull request #4011: URL: https://github.com/apache/incubator-doris/pull/4011#discussion_r449348960 ## File path: be/src/olap/tablet.cpp ## @@ -826,6 +832,33 @@ void Tablet::_print_missed_versions(const std::vector& missed_versions)

[GitHub] [incubator-doris] chaoyli commented on pull request #4009: [Bug]Fix some schema change not work right

2020-07-02 Thread GitBox
chaoyli commented on pull request #4009: URL: https://github.com/apache/incubator-doris/pull/4009#issuecomment-653312988 It's better add more discrete message in commit info like you issue. This is an automated message from

[GitHub] [incubator-doris] WingsGo commented on pull request #4009: [Bug]Fix some schema change not work right

2020-07-02 Thread GitBox
WingsGo commented on pull request #4009: URL: https://github.com/apache/incubator-doris/pull/4009#issuecomment-653323183 > It's better add more discrete message in commit info like you issue. Ok, done, and I tested the schema change supported in doc, but I found that convert

[GitHub] [incubator-doris] WingsGo commented on pull request #4009: [Bug]Fix some schema change not work right

2020-07-02 Thread GitBox
WingsGo commented on pull request #4009: URL: https://github.com/apache/incubator-doris/pull/4009#issuecomment-653323967 In order to make review easiler, I will not add code format until review ended. This is an automated

[GitHub] [incubator-doris] chaoyli merged pull request #3990: [shell] Fix BUILD_TYPE not used bug

2020-07-02 Thread GitBox
chaoyli merged pull request #3990: URL: https://github.com/apache/incubator-doris/pull/3990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-doris] branch master updated (a16236f -> ab325f5)

2020-07-02 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from a16236f [refactor] Remove useless return value of class RowsetGraph (#3977) add ab325f5 [shell]

[incubator-doris] branch master updated (1e813df -> a16236f)

2020-07-02 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 1e813df [Doris On ES] [Bug-Fix][Refactor] Fix potential null pointer exception and refactor function

[GitHub] [incubator-doris] chaoyli merged pull request #3977: [refactor] Remove useless return value of class RowsetGraph

2020-07-02 Thread GitBox
chaoyli merged pull request #3977: URL: https://github.com/apache/incubator-doris/pull/3977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] chaoyli commented on pull request #4011: Remove rs when version conflict when insert to a tablet

2020-07-02 Thread GitBox
chaoyli commented on pull request #4011: URL: https://github.com/apache/incubator-doris/pull/4011#issuecomment-653307162 > @chaoyli Now, should we prohibit insertion when `OLAP_ERR_PUSH_VERSION_ALREADY_EXIST` appears? Your function will add little cost to remove

[GitHub] [incubator-doris] francisoliverlee closed pull request #4004: [Issue-fix-3963]Update doc for how to build fe on windows

2020-07-02 Thread GitBox
francisoliverlee closed pull request #4004: URL: https://github.com/apache/incubator-doris/pull/4004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] francisoliverlee commented on pull request #4004: [Issue-fix-3963]Update doc for how to build fe on windows

2020-07-02 Thread GitBox
francisoliverlee commented on pull request #4004: URL: https://github.com/apache/incubator-doris/pull/4004#issuecomment-652861300 fix already This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] marising opened a new pull request #4005: LRU cache for sql/partition cache #2581

2020-07-02 Thread GitBox
marising opened a new pull request #4005: URL: https://github.com/apache/incubator-doris/pull/4005 ## Features 1. Find the cache node by SQL Key, then find the corresponding partition data by Partition Key, and then decide whether to hit Cache by LastVersion and LastVersionTime 2.