[GitHub] [incubator-doris] WingsGo commented on a change in pull request #2763: [Alter]Add wait time while doing alter options
WingsGo commented on a change in pull request #2763: [Alter]Add wait time while doing alter options URL: https://github.com/apache/incubator-doris/pull/2763#discussion_r367510314 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java ## @@ -276,8 +276,9 @@ public void processAlterTable(AlterTableStmt stmt) throws UserException { if (olapTable.getState() != OlapTableState.NORMAL) { throw new DdlException("Table[" + table.getName() + "]'s state is not NORMAL. Do not allow doing ALTER ops"); } - -if (needTableStable) { + +// schema change job will wait until table become stable +if (needTableStable && !hasSchemaChange) { Review comment: @morningman Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on a change in pull request #2763: [Alter]Add wait time while doing alter options
WingsGo commented on a change in pull request #2763: [Alter]Add wait time while doing alter options URL: https://github.com/apache/incubator-doris/pull/2763#discussion_r366781873 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java ## @@ -273,6 +276,18 @@ public void processAlterTable(AlterTableStmt stmt) throws UserException { throw new DdlException("table with empty parition cannot do schema change. [" + tableName + "]"); } +// if table state is unhealthy, change table repair priority, and wait until repair finish or exceed timeout +if (olapTable.getState() != OlapTableState.NORMAL) { Review comment: @morningman Yes, you're right, I change the waiting logic to runPendingJob. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org