chaoyli commented on a change in pull request #2359: Improve SkipList memory
usage tracking
URL: https://github.com/apache/incubator-doris/pull/2359#discussion_r353034261
##########
File path: be/src/olap/memtable.h
##########
@@ -56,7 +61,13 @@ class MemTable {
RowCursorComparator _row_comparator;
std::unique_ptr<MemTracker> _mem_tracker;
- std::unique_ptr<MemPool> _mem_pool;
+ // This is a buffer, to hold the memory referenced by the rows that have
not
+ // been inserted into the SkipList
+ std::unique_ptr<MemPool> _tmp_mem_pool;
Review comment:
_buffer_pool may be better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
