Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
yiguolei merged PR #61205: URL: https://github.com/apache/doris/pull/61205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
github-actions[bot] commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4055914095 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
github-actions[bot] commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4055913746 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
hello-stephen commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4049009464 # BE Regression && UT Coverage Report Increment line coverage `100.00% (13/13)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/61205_418bd65cb49a50b72a1c1be60f098dd26a7f_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/61205_418bd65cb49a50b72a1c1be60f098dd26a7f_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.35% (25267/35414) | | Line Coverage | 53.95% (265720/492532) | | Region Coverage | 51.57% (219787/426200) | | Branch Coverage | 53.05% (94700/178517) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
hello-stephen commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4048963049 # BE UT Coverage Report Increment line coverage `100.00% (13/13)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/418bd65cb49a50b72a1c1be60f098dd26a7f_418bd65cb49a50b72a1c1be60f098dd26a7f/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/418bd65cb49a50b72a1c1be60f098dd26a7f_418bd65cb49a50b72a1c1be60f098dd26a7f/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.98% (19153/36153) | | Line Coverage | 36.17% (178386/493156) | | Region Coverage | 32.75% (138119/421709) | | Branch Coverage | 33.77% (60034/177756) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
freemandealer commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4047275286 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
doris-robot commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4036260565 # BE UT Coverage Report Increment line coverage `100.00% (14/14)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/f8aeaa3b4364408b1ccfc635c028805b6b240816_f8aeaa3b4364408b1ccfc635c028805b6b240816/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/f8aeaa3b4364408b1ccfc635c028805b6b240816_f8aeaa3b4364408b1ccfc635c028805b6b240816/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.00% (19156/36143) | | Line Coverage | 36.19% (178420/492992) | | Region Coverage | 32.76% (138175/421822) | | Branch Coverage | 33.79% (60060/177727) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
freemandealer commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4035881571 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
Thearas commented on PR #61205: URL: https://github.com/apache/doris/pull/61205#issuecomment-4035881282 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND (#60977) [doris]
freemandealer opened a new pull request, #61205: URL: https://github.com/apache/doris/pull/61205 Problem: In a rare restart window, BE can rebuild file-cache metadata in memory while the corresponding cache files are not yet durable on disk. If that metadata is also restored via LRU dump/load, blocks may appear as DOWNLOADED even though the local files are missing. Subsequent reads then produce false-positive cache hits, fail on local read, and repeatedly fall back to S3. This preserves correctness but causes avoidable cache thrashing and latency jitter. Root cause: The read path treated DOWNLOADED as a valid local hit source and fell back to remote reads on failure, but it did not actively invalidate stale metadata when the local cache file was gone. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
