Re: [PR] [fix](p0)Fix point query case [doris]

2025-07-18 Thread via GitHub


Jibing-Li merged PR #53488:
URL: https://github.com/apache/doris/pull/53488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](p0)Fix point query case [doris]

2025-07-18 Thread via GitHub


Jibing-Li commented on code in PR #53488:
URL: https://github.com/apache/doris/pull/53488#discussion_r2215632512


##
regression-test/suites/point_query_p0/test_point_query.groovy:
##
@@ -204,6 +204,7 @@ suite("test_point_query", "nonConcurrent") {
 """
 sleep(1);
 nprep_sql """ INSERT INTO ${tableName} VALUES(1235, 
120939.11130, "addd", "laooq", "2030-01-02", "2020-01-01 12:36:38", 22.822, 
"7022-01-01 11:30:38", 1, 1.299, [119291.19291], ["111", "222", "333"], 1) 
"""
+stmt = prepareStatement "select /*+ 
SET_VAR(enable_nereids_planner=true) */ * from ${tableName} where k1 = ? and k2 
= ? and k3 = ?"

Review Comment:
   Tested on MySql, it has the same behavior with Doris. The reason is the 
first prepare sql is `select * from xxx`, it caches all the columns of old 
schema. After schema change, the `select *` sql will get one more fields than 
the cached schema, which will cause array index out of bounds. If the sql gives 
a specific column name, the old prepareStatement object will be still good to 
use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](p0)Fix point query case [doris]

2025-07-18 Thread via GitHub


github-actions[bot] commented on PR #53488:
URL: https://github.com/apache/doris/pull/53488#issuecomment-3088849754

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](p0)Fix point query case [doris]

2025-07-18 Thread via GitHub


github-actions[bot] commented on PR #53488:
URL: https://github.com/apache/doris/pull/53488#issuecomment-3088849676

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](p0)Fix point query case [doris]

2025-07-17 Thread via GitHub


eldenmoon commented on code in PR #53488:
URL: https://github.com/apache/doris/pull/53488#discussion_r2214770216


##
regression-test/suites/point_query_p0/test_point_query.groovy:
##
@@ -204,6 +204,7 @@ suite("test_point_query", "nonConcurrent") {
 """
 sleep(1);
 nprep_sql """ INSERT INTO ${tableName} VALUES(1235, 
120939.11130, "addd", "laooq", "2030-01-02", "2020-01-01 12:36:38", 22.822, 
"7022-01-01 11:30:38", 1, 1.299, [119291.19291], ["111", "222", "333"], 1) 
"""
+stmt = prepareStatement "select /*+ 
SET_VAR(enable_nereids_planner=true) */ * from ${tableName} where k1 = ? and k2 
= ? and k3 = ?"

Review Comment:
   为什么发生schema change需要重新prepare,之前prepare好的就出问题了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](p0)Fix point query case [doris]

2025-07-17 Thread via GitHub


Jibing-Li commented on PR #53488:
URL: https://github.com/apache/doris/pull/53488#issuecomment-3085925938

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [fix](p0)Fix point query case [doris]

2025-07-17 Thread via GitHub


Jibing-Li commented on PR #53488:
URL: https://github.com/apache/doris/pull/53488#issuecomment-3084437521

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[PR] [fix](p0)Fix point query case [doris]

2025-07-17 Thread via GitHub


Jibing-Li opened a new pull request, #53488:
URL: https://github.com/apache/doris/pull/53488

   ### What problem does this PR solve?
   Fix point query case
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test 
   - [x] Regression test
   - [ ] Unit Test
   - [ ] Manual test (add detailed scripts or steps below)
   - [ ] No need to test or manual test. Explain why:
   - [ ] This is a refactor/code format and no logic has been changed.
   - [ ] Previous test can cover this change.
   - [ ] No code files have been changed.
   - [ ] Other reason 
   
   - Behavior changed:
   - [x] No.
   - [ ] Yes. 
   
   - Does this need documentation?
   - [x] No.
   - [ ] Yes. 
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]