Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
amorynan closed pull request #50273: [fix](serde) fix serde write_to_orc bufferlist URL: https://github.com/apache/doris/pull/50273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
github-actions[bot] commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2829253765 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
github-actions[bot] commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2829253735 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
hello-stephen commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2822367822 # BE Regression P0 && UT Coverage Report Increment line coverage `0.00% (0/2)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/50273_e4ac5579e7dfdab5080ef466c405f2a5b9c81e35_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/50273_e4ac5579e7dfdab5080ef466c405f2a5b9c81e35_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage || | Line Coverage || | Region Coverage || | Branch Coverage || -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
hello-stephen commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2822102895 # BE UT Coverage Report Increment line coverage `0.00% (0/2)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e4ac5579e7dfdab5080ef466c405f2a5b9c81e35_e4ac5579e7dfdab5080ef466c405f2a5b9c81e35/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e4ac5579e7dfdab5080ef466c405f2a5b9c81e35_e4ac5579e7dfdab5080ef466c405f2a5b9c81e35/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.55% (14539/27148) | | Line Coverage | 42.39% (126045/297353) | | Region Coverage | 41.19% (64405/156355) | | Branch Coverage | 35.76% (32371/90512) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
doris-robot commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2821963366 ClickBench: Total hot run time: 28.99 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e4ac5579e7dfdab5080ef466c405f2a5b9c81e35, data reload: false query1 0.040.030.03 query2 0.130.110.13 query3 0.250.200.19 query4 1.580.200.19 query5 0.600.580.59 query6 1.170.720.72 query7 0.020.020.02 query8 0.040.030.04 query9 0.560.520.51 query10 0.560.580.57 query11 0.160.110.11 query12 0.140.110.11 query13 0.630.600.60 query14 1.151.181.19 query15 0.860.840.85 query16 0.390.400.37 query17 1.021.071.00 query18 0.210.200.19 query19 1.871.781.84 query20 0.010.010.01 query21 15.39 0.890.53 query22 0.761.070.69 query23 14.99 1.400.61 query24 7.281.640.34 query25 0.360.260.06 query26 0.600.160.13 query27 0.050.050.05 query28 9.160.920.42 query29 12.55 3.993.32 query30 0.250.080.06 query31 2.830.610.39 query32 3.230.550.46 query33 2.983.013.02 query34 15.79 5.074.47 query35 4.544.564.53 query36 0.670.490.47 query37 0.090.060.06 query38 0.040.040.03 query39 0.030.020.03 query40 0.170.140.13 query41 0.080.020.02 query42 0.030.020.03 query43 0.040.030.04 Total cold run time: 103.3 s Total hot run time: 28.99 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
doris-robot commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2821949299 TPC-DS: Total hot run time: 192687 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e4ac5579e7dfdab5080ef466c405f2a5b9c81e35, data reload: false query1 1400108910441044 query2 6233180617991799 query3 10986 455445344534 query4 54518 25280 23708 23708 query5 5087592 468 468 query6 322 200 184 184 query7 4912520 288 288 query8 330 260 236 236 query9 5785257225902572 query10 421 319 261 261 query11 15141 15016 14810 14810 query12 158 115 105 105 query13 1049522 417 417 query14 10107 633062816281 query15 193 195 178 178 query16 7115708 535 535 query17 1074757 566 566 query18 1532415 300 300 query19 194 187 161 161 query20 127 122 123 122 query21 209 122 107 107 query22 4331446243224322 query23 34043 33367 33423 33367 query24 6603242324082408 query25 451 467 405 405 query26 672 281 155 155 query27 2142506 337 337 query28 3041215721512151 query29 568 550 439 439 query30 274 218 188 188 query31 873 888 768 768 query32 80 64 64 64 query33 473 367 308 308 query34 781 865 525 525 query35 818 859 749 749 query36 948 999 919 919 query37 114 104 78 78 query38 4271418041524152 query39 1521143414591434 query40 221 127 112 112 query41 59 57 59 57 query42 125 110 108 108 query43 494 491 519 491 query44 1343825 817 817 query45 185 187 173 173 query46 869 1026630 630 query47 1817187718131813 query48 398 448 334 334 query49 726 510 414 414 query50 651 711 408 408 query51 4179424742184218 query52 117 106 100 100 query53 235 277 187 187 query54 580 581 512 512 query55 87 80 79 79 query56 303 294 306 294 query57 1162116511331133 query58 266 255 271 255 query59 2591276926492649 query60 331 315 316 315 query61 130 145 129 129 query62 704 806 669 669 query63 231 189 179 179 query64 15511025711 711 query65 4445426342124212 query66 803 398 299 299 query67 15906 15507 15407 15407 query68 6794891 519 519 query69 541 319 273 273 query70 1207116011201120 query71 496 318 281 281 query72 5932464947224649 query73 1406581 342 342 query74 9116917088638863 query75 4099318126832683 query76 42511186743 743 query77 752 354 300 300 query78 998410157 92899289 query79 3372813 556 556 query80 626 501 451 451 query81 476 266 209 209 query82 449 126 91 91 query83 291 252 237 237 query84 294 101 85 85 query85 778 347 308 308 query86 356 308 283 283 query87 4365448442864286 query88 3342220922192209 query89 394 319 296 296 query90 2006200 206 200 query91 146 151 116 116 query92 71 63 62 62 query93 1709920 576 576 query94 671 412 303 303 query95 372 286 280 280 query96 497 567 274 274 query97 3146324431423142 query98 225 204 208 204 query99 1428139713071307 Total cold run time: 298998 ms Total hot run time: 192687 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
doris-robot commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2821920620 TPC-H: Total hot run time: 34010 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e4ac5579e7dfdab5080ef466c405f2a5b9c81e35, data reload: false -- Round 1 -- q1 26028 505150295029 q2 2063272 176 176 q3 10425 1260740 740 q4 10226 1033525 525 q5 7585238023972380 q6 189 168 137 137 q7 938 778 622 622 q8 9320128811061106 q9 6790516051265126 q10 6810232218951895 q11 481 299 261 261 q12 354 352 227 227 q13 17786 374431003100 q14 231 233 221 221 q15 529 486 483 483 q16 459 457 405 405 q17 599 868 349 349 q18 7555731070427042 q19 1642967 558 558 q20 347 351 227 227 q21 3935361224422442 q22 10641050959 959 Total cold run time: 115356 ms Total hot run time: 34010 ms - Round 2, with runtime_filter_mode=off - q1 5115518750575057 q2 243 332 233 233 q3 2135268723042304 q4 1400178514401440 q5 4449442744384427 q6 217 174 128 128 q7 1983196517891789 q8 2622255425342534 q9 7207732170037003 q10 3017320727142714 q11 582 522 503 503 q12 706 763 603 603 q13 3546395432933293 q14 281 292 280 280 q15 538 481 467 467 q16 469 515 456 456 q17 1170158414131413 q18 7854751074357435 q19 829 808 886 808 q20 2004208318101810 q21 5176484048174817 q22 10911039994 994 Total cold run time: 52634 ms Total hot run time: 50508 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
amorynan commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2821640214 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
doris-robot commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2820054037 ClickBench: Total hot run time: 29.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 4dd67d7c06efa5b9e4fee32698a973f2188b194d, data reload: false query1 0.040.040.04 query2 0.130.100.10 query3 0.270.200.20 query4 1.600.200.20 query5 0.580.560.59 query6 1.210.700.72 query7 0.030.020.02 query8 0.040.030.03 query9 0.580.540.51 query10 0.570.570.57 query11 0.160.110.11 query12 0.150.110.11 query13 0.620.600.59 query14 1.141.161.17 query15 0.870.850.84 query16 0.380.380.37 query17 1.001.011.00 query18 0.210.200.19 query19 1.901.801.82 query20 0.010.010.01 query21 15.39 0.910.55 query22 0.771.250.65 query23 14.91 1.400.61 query24 6.841.690.84 query25 0.480.200.09 query26 0.590.160.13 query27 0.050.050.04 query28 9.810.910.45 query29 12.57 3.913.32 query30 0.250.090.06 query31 2.850.600.38 query32 3.240.540.47 query33 3.013.033.10 query34 15.66 5.224.48 query35 4.494.564.50 query36 0.660.510.48 query37 0.090.060.06 query38 0.050.040.03 query39 0.030.030.02 query40 0.180.140.12 query41 0.070.020.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 103.54 s Total hot run time: 29.49 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
doris-robot commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2820047952 TPC-DS: Total hot run time: 185547 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 4dd67d7c06efa5b9e4fee32698a973f2188b194d, data reload: false query1 1001478 496 478 query2 6574180418021802 query3 6780220 218 218 query4 26533 23371 23536 23371 query5 4357613 454 454 query6 291 187 191 187 query7 4611494 284 284 query8 291 238 254 238 query9 8631255625712556 query10 477 316 262 262 query11 15348 15154 14745 14745 query12 146 110 103 103 query13 1644504 384 384 query14 8730610662506106 query15 195 190 171 171 query16 7137647 471 471 query17 1141746 593 593 query18 1988396 311 311 query19 188 189 163 163 query20 122 122 114 114 query21 213 121 106 106 query22 4176424641784178 query23 33920 32958 33061 32958 query24 8364242523932393 query25 565 497 425 425 query26 1252268 153 153 query27 2741489 330 330 query28 4379211021052105 query29 794 565 490 490 query30 276 213 179 179 query31 917 855 766 766 query32 75 61 61 61 query33 561 351 301 301 query34 780 845 506 506 query35 760 783 724 724 query36 934 994 918 918 query37 108 112 85 85 query38 4106415941994159 query39 1435143814091409 query40 211 121 111 111 query41 56 56 54 54 query42 125 107 113 107 query43 502 508 495 495 query44 1251780 787 780 query45 179 172 170 170 query46 821 1015611 611 query47 1732178917091709 query48 367 403 297 297 query49 770 505 418 418 query50 634 676 382 382 query51 4085419340714071 query52 106 110 97 97 query53 229 249 187 187 query54 569 575 490 490 query55 83 78 83 78 query56 305 290 298 290 query57 1119118010741074 query58 261 250 245 245 query59 2511267825182518 query60 319 314 318 314 query61 124 124 124 124 query62 802 727 674 674 query63 230 183 184 183 query64 4390988 716 716 query65 4366420642134206 query66 1136407 306 306 query67 16229 15367 15264 15264 query68 8639866 512 512 query69 469 297 261 261 query70 1231109710981097 query71 486 320 284 284 query72 5624465447324654 query73 707 580 336 336 query74 9020918087228722 query75 3966321726632663 query76 36121173743 743 query77 794 375 283 283 query78 997210102 93159315 query79 5817807 558 558 query80 660 513 426 426 query81 480 246 214 214 query82 719 123 96 96 query83 286 263 232 232 query84 292 100 94 94 query85 766 345 321 321 query86 332 306 291 291 query87 4382440543524352 query88 2758220021852185 query89 448 304 285 285 query90 1934208 202 202 query91 138 144 113 113 query92 76 62 56 56 query93 2988933 581 581 query94 666 410 302 302 query95 375 288 285 285 query96 479 579 271 271 query97 3162319730963096 query98 226 202 199 199 query99 1426137512901290 Total cold run time: 278983 ms Total hot run time: 185547 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
doris-robot commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2820027068 TPC-H: Total hot run time: 33988 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4dd67d7c06efa5b9e4fee32698a973f2188b194d, data reload: false -- Round 1 -- q1 25839 505150035003 q2 2075284 182 182 q3 10529 1220712 712 q4 10230 1020529 529 q5 8365245023992399 q6 180 160 132 132 q7 929 721 612 612 q8 9340135811101110 q9 6777508751285087 q10 6811230618731873 q11 485 281 282 281 q12 341 364 215 215 q13 17773 370531423142 q14 233 226 212 212 q15 528 486 478 478 q16 463 445 398 398 q17 591 873 360 360 q18 7715724371197119 q19 1670970 536 536 q20 332 326 212 212 q21 4232340724182418 q22 10411034978 978 Total cold run time: 116479 ms Total hot run time: 33988 ms - Round 2, with runtime_filter_mode=off - q1 5139511151225111 q2 235 333 229 229 q3 2219263223232323 q4 1396190615301530 q5 4565445543924392 q6 210 166 124 124 q7 1966187417421742 q8 2620254925112511 q9 7086711470437043 q10 3011321027922792 q11 568 492 478 478 q12 668 745 583 583 q13 3513393838363836 q14 273 288 274 274 q15 528 484 484 484 q16 482 515 464 464 q17 1145149914271427 q18 7754748773647364 q19 793 822 938 822 q20 1974205818221822 q21 5231467546044604 q22 1052103610461036 Total cold run time: 52428 ms Total hot run time: 50991 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
amorynan commented on PR #50273: URL: https://github.com/apache/doris/pull/50273#issuecomment-2819937147 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] [fix](serde) fix serde write_to_orc bufferlist [doris]
amorynan opened a new pull request, #50273: URL: https://github.com/apache/doris/pull/50273 ### What problem does this PR solve? All allocated memory references are stored in buffer_list When more space is needed, inside the function: allocate new memory free old memory Update bufferRef to point to new memory But buffer_list still retains references to the released memory Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
