Re: [PR] branch-4.0: [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues #60654 [doris]
airborne12 commented on PR #61013: URL: https://github.com/apache/doris/pull/61013#issuecomment-3994837069 Superseded by squashed backport PR #61028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] branch-4.0: [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues #60654 [doris]
airborne12 closed pull request #61013: branch-4.0: [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues #60654 URL: https://github.com/apache/doris/pull/61013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] branch-4.0: [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues #60654 [doris]
Thearas commented on PR #61013: URL: https://github.com/apache/doris/pull/61013#issuecomment-3992259563 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] branch-4.0: [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues #60654 [doris]
airborne12 opened a new pull request, #61013: URL: https://github.com/apache/doris/pull/61013 ## Summary - Cherry-pick of #60654 to branch-4.0 - Refactor SearchDslParser to single-phase ANTLR parsing - Fix ES compatibility issues - Add fieldIndexes support for variant subcolumn analyzer lookup - **Conflict resolution**: Adapted `SearchPredicate` constructor to branch-4.0's nullable handling (`setNullableFromNereids()` pattern instead of constructor parameter) ## Merge Order This is **PR 2/12** in the search() function pick chain. Depends on #61012 (#59747). ### Check List (For Author) - Test - [x] Regression test - [x] Unit Test - [ ] Manual test - [ ] No need to test - Behavior changed: - [ ] No. - [x] Yes. SearchDslParser refactored to single-phase ANTLR. - Does this need documentation? - [x] No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
