Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris-website]
zclllyybb merged PR #3130: URL: https://github.com/apache/doris-website/pull/3130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris-website]
linrrzqqq commented on code in PR #3130: URL: https://github.com/apache/doris-website/pull/3130#discussion_r2715450971 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/date-time-functions/timestamp.md: ## @@ -9,29 +9,34 @@ ## 描述 TIMESTAMP 将 符合 datetime 格式的字符串转换为 DATETIME 类型 +如果存在第二个时间类型的参数，则计算两参数相加的结果，然后以DATETIME类型的格式返回。 具体 datetime 格式请查看 [datetime 的转换](../../../../../current/sql-manual/basic-element/sql-data-types/conversion/datetime-conversion). -该函数与 mysql 中的 [timestamp 函数](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) 有些差异，doris 暂不支持带有第二个 time 参数进行日期时间增减。 +该函数与 mysql 中的 [timestamp 函数](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) 行为相同。 ## 语法 ```sql -TIMESTAMP(string) +TIMESTAMP([, ]) ``` ## 参数 | 参数 | 说明 | | | | -| `string` | 日期时间字符串类型 | +| `date_or_datetime_string` | 日期时间字符串类型 | +| `time_string` | 时间字符串类型 | ## 返回值 返回类型为 DATETIME。 -- 若输入为 date 字符串,则时间被设置为 00:00:00 -- 输入 NULL，返回 NULL +当输入参数数量为 1 时，返回将第一个参数转换为 DATETIME 类型的结果。 +当输入参数数量为 2 时，返回两参数相加的结果 + +- 若第一个参数输入为 date 字符串,则时间被设置为 00:00:00 +- 任一参数为 NULL或参数类型不匹配时，返回 NULL ## 举例 Review Comment: 原本这块就没有换行，从网页上看是正常的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris-website]
zclllyybb commented on code in PR #3130: URL: https://github.com/apache/doris-website/pull/3130#discussion_r2715395465 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/date-time-functions/timestamp.md: ## @@ -9,29 +9,34 @@ ## 描述 TIMESTAMP 将 符合 datetime 格式的字符串转换为 DATETIME 类型 +如果存在第二个时间类型的参数，则计算两参数相加的结果，然后以DATETIME类型的格式返回。 具体 datetime 格式请查看 [datetime 的转换](../../../../../current/sql-manual/basic-element/sql-data-types/conversion/datetime-conversion). -该函数与 mysql 中的 [timestamp 函数](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) 有些差异，doris 暂不支持带有第二个 time 参数进行日期时间增减。 +该函数与 mysql 中的 [timestamp 函数](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) 行为相同。 ## 语法 ```sql -TIMESTAMP(string) +TIMESTAMP([, ]) ``` ## 参数 | 参数 | 说明 | | | | -| `string` | 日期时间字符串类型 | +| `date_or_datetime_string` | 日期时间字符串类型 | +| `time_string` | 时间字符串类型 | ## 返回值 返回类型为 DATETIME。 -- 若输入为 date 字符串,则时间被设置为 00:00:00 -- 输入 NULL，返回 NULL +当输入参数数量为 1 时，返回将第一个参数转换为 DATETIME 类型的结果。 +当输入参数数量为 2 时，返回两参数相加的结果 + +- 若第一个参数输入为 date 字符串,则时间被设置为 00:00:00 +- 任一参数为 NULL或参数类型不匹配时，返回 NULL ## 举例 Review Comment: 这个地方没有换行，##会被正常识别为标题吗？还是会被识别为罗列环境的一部分？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris-website]
linrrzqqq commented on code in PR #3130: URL: https://github.com/apache/doris-website/pull/3130#discussion_r2715095957 ## docs/sql-manual/sql-functions/scalar-functions/date-time-functions/timestamp.md: ## @@ -12,29 +12,38 @@ ## Description The TIMESTAMP function converts a datetime format string to DATETIME type. +If a second time parameter exists, it calculates the sum of the two parameters and returns the result in DATETIME format. For specific datetime formats, please refer to [datetime conversion](../../../../sql-manual/basic-element/sql-data-types/conversion/datetime-conversion). -This function differs from the [timestamp function](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) in MySQL. Doris currently does not support a second time parameter for datetime addition/subtraction. +This function behaves the same way as the [timestamp function](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) in MySQL. + +:::note +Two parameter versions are supported from 4.0.3 Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris-website]
zclllyybb commented on code in PR #3130: URL: https://github.com/apache/doris-website/pull/3130#discussion_r2715090348 ## docs/sql-manual/sql-functions/scalar-functions/date-time-functions/timestamp.md: ## @@ -12,29 +12,38 @@ ## Description The TIMESTAMP function converts a datetime format string to DATETIME type. +If a second time parameter exists, it calculates the sum of the two parameters and returns the result in DATETIME format. For specific datetime formats, please refer to [datetime conversion](../../../../sql-manual/basic-element/sql-data-types/conversion/datetime-conversion). -This function differs from the [timestamp function](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) in MySQL. Doris currently does not support a second time parameter for datetime addition/subtraction. +This function behaves the same way as the [timestamp function](https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_timestamp) in MySQL. + +:::note +Two parameter versions are supported from 4.0.3 Review Comment: dev文档不需要标注 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
zclllyybb merged PR #58554: URL: https://github.com/apache/doris/pull/58554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
github-actions[bot] commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3764306834 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
github-actions[bot] commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3764306888 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3755103382 # FE Regression Coverage Report Increment line coverage ` 92.86% (13/14)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_26829947741b5553173c6affdeeaa8978b67f347_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_26829947741b5553173c6affdeeaa8978b67f347_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3754508854 ClickBench: Total hot run time: 27.09 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 26829947741b5553173c6affdeeaa8978b67f347, data reload: false query1 0.050.050.05 query2 0.110.050.05 query3 0.250.080.08 query4 1.640.110.11 query5 0.290.270.25 query6 1.140.660.65 query7 0.040.030.03 query8 0.050.040.04 query9 0.570.480.50 query10 0.540.540.54 query11 0.140.100.10 query12 0.140.100.10 query13 0.600.590.59 query14 0.940.940.95 query15 0.800.790.78 query16 0.420.390.41 query17 1.061.011.07 query18 0.230.220.21 query19 1.971.801.91 query20 0.020.010.02 query21 15.46 0.260.14 query22 5.080.050.05 query23 15.69 0.280.10 query24 1.130.621.06 query25 0.080.060.08 query26 0.140.120.13 query27 0.090.050.06 query28 4.671.080.88 query29 12.56 3.933.19 query30 0.270.130.13 query31 2.820.630.39 query32 3.240.570.45 query33 2.943.013.03 query34 16.19 5.104.42 query35 4.494.434.45 query36 0.660.500.48 query37 0.120.070.06 query38 0.080.040.04 query39 0.050.030.03 query40 0.170.140.14 query41 0.090.030.03 query42 0.050.030.03 query43 0.050.030.03 Total cold run time: 97.12 s Total hot run time: 27.09 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3754489403 TPC-DS: Total hot run time: 174178 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 26829947741b5553173c6affdeeaa8978b67f347, data reload: false query5 4388615 473 473 query6 342 232 230 230 query7 4216441 254 254 query8 354 258 237 237 query9 8737290528862886 query10 499 383 337 337 query11 15100 15102 14804 14804 query12 173 116 114 114 query13 1255496 375 375 query14 5813301228262826 query14_12720267227012672 query15 205 196 178 178 query16 984 484 475 475 query17 1122694 591 591 query18 2446440 346 346 query19 227 223 203 203 query20 124 116 115 115 query21 212 138 115 115 query22 3859406040714060 query23 16048 15588 15298 15298 query23_115422 15515 15455 15455 query24 7156155111721172 query24_11196120011821182 query25 557 476 437 437 query26 1247270 155 155 query27 2773440 277 277 query28 4576212921222122 query29 791 556 445 445 query30 317 246 213 213 query31 769 644 577 577 query32 94 76 76 76 query33 538 370 335 335 query34 928 873 572 572 query35 717 765 670 670 query36 845 904 768 768 query37 130 93 86 86 query38 2705263226222622 query39 799 747 730 730 query39_1706 723 715 715 query40 221 140 122 122 query41 68 63 63 63 query42 105 102 103 102 query43 478 424 443 424 query44 1316725 730 725 query45 188 194 176 176 query46 837 972 581 581 query47 1399142313661366 query48 310 314 233 233 query49 607 435 331 331 query50 626 262 199 199 query51 3806381737813781 query52 100 104 93 93 query53 309 322 264 264 query54 295 281 262 262 query55 82 85 77 77 query56 313 318 306 306 query57 1019971 949 949 query58 265 269 255 255 query59 2103213320102010 query60 340 323 310 310 query61 162 195 158 158 query62 387 356 340 340 query63 300 274 271 271 query64 50011277992 992 query65 3895370737263707 query66 1472432 311 311 query67 15602 15529 15472 15472 query68 25061083742 742 query69 448 356 325 325 query70 1033959 922 922 query71 325 316 290 290 query72 5396330033433300 query73 593 725 316 316 query74 8702873585608560 query75 2760282124832483 query76 22511054656 656 query77 366 381 313 313 query78 9870990491219121 query79 1397912 574 574 query80 1327590 522 522 query81 548 258 227 227 query82 1230145 111 111 query83 344 258 238 238 query84 257 108 96 96 query85 935 512 465 465 query86 422 298 291 291 query87 2910287927672767 query88 3521259225772577 query89 380 356 330 330 query90 1982167 156 156 query91 172 164 144 144 query92 76 75 70 70 query93 1087902 527 527 query94 654 324 296 296 query95 580 330 324 324 query96 656 493 233 233 query97 2363236523022302 query98 217 202 198 198 query99 602 587 498 498 Total cold run time: 247533 ms Total hot run time: 174178 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3754452360 TPC-H: Total hot run time: 31985 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 26829947741b5553173c6affdeeaa8978b67f347, data reload: false -- Round 1 -- q1 17642 423440354035 q2 2118349 250 250 q3 10153 1244728 728 q4 10190 829 303 303 q5 7497203318801880 q6 186 170 137 137 q7 920 790 656 656 q8 9281142911431143 q9 4817457245864572 q10 6725183414051405 q11 501 317 302 302 q12 719 756 624 624 q13 17769 384931043104 q14 286 293 274 274 q15 561 516 510 510 q16 689 691 635 635 q17 635 762 513 513 q18 6610644067596440 q19 980 1083643 643 q20 441 391 254 254 q21 3317259825042504 q22 1163109310731073 Total cold run time: 103200 ms Total hot run time: 31985 ms - Round 2, with runtime_filter_mode=off - q1 4278434943744349 q2 362 402 348 348 q3 2237281923942394 q4 1430185914441444 q5 4536441444584414 q6 207 175 128 128 q7 2007189817031703 q8 2511238026512380 q9 7308705970567056 q10 2449272323332333 q11 581 463 454 454 q12 716 770 625 625 q13 3597415032863286 q14 269 279 257 257 q15 516 480 477 477 q16 635 641 605 605 q17 1086125813001258 q18 7589741873437343 q19 813 760 764 760 q20 1884193217931793 q21 4583422041584158 q22 10691022980 980 Total cold run time: 50663 ms Total hot run time: 48545 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3754374865 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3732170659 # BE Regression && UT Coverage Report Increment line coverage `100% (0/0)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_fae7d48df0c84bde0de3ccf583858e189c54dd2a_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_fae7d48df0c84bde0de3ccf583858e189c54dd2a_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.89% (25850/34984) | | Line Coverage | 61.34% (275211/448643) | | Region Coverage | 56.48% (230802/408648) | | Branch Coverage | 58.25% (99167/170233) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3731954372 run nonConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3731471330 # BE Regression && UT Coverage Report Increment line coverage `100% (0/0)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_fae7d48df0c84bde0de3ccf583858e189c54dd2a_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_fae7d48df0c84bde0de3ccf583858e189c54dd2a_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.96% (25873/34984) | | Line Coverage | 61.41% (275504/448643) | | Region Coverage | 56.51% (230916/408648) | | Branch Coverage | 58.34% (99317/170233) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3730982958 # BE UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/fae7d48df0c84bde0de3ccf583858e189c54dd2a_fae7d48df0c84bde0de3ccf583858e189c54dd2a/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/fae7d48df0c84bde0de3ccf583858e189c54dd2a_fae7d48df0c84bde0de3ccf583858e189c54dd2a/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.05% (18987/35789) | | Line Coverage | 39.10% (175903/449876) | | Region Coverage | 33.68% (136251/404532) | | Branch Coverage | 34.71% (58897/169684) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3730863835 TPC-DS: Total hot run time: 172478 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit fae7d48df0c84bde0de3ccf583858e189c54dd2a, data reload: false query5 4865580 428 428 query6 329 219 206 206 query7 4235454 260 260 query8 323 251 231 231 query9 8763265426412641 query10 508 363 311 311 query11 15096 15236 14811 14811 query12 177 112 110 110 query13 1243457 390 390 query14 6211302227612761 query14_12693265626502650 query15 201 198 177 177 query16 3216490 456 456 query17 1082694 552 552 query18 2183418 317 317 query19 226 215 187 187 query20 121 114 112 112 query21 517 141 118 118 query22 4169396140263961 query23 15940 15604 15393 15393 query23_115465 15546 15442 15442 query24 7458151911651165 query24_11162115211691152 query25 590 431 374 374 query26 841 265 164 164 query27 2577441 286 286 query28 4516212421202120 query29 699 567 431 431 query30 344 238 212 212 query31 753 621 543 543 query32 72 72 64 64 query33 577 328 282 282 query34 855 856 519 519 query35 708 783 682 682 query36 867 843 787 787 query37 136 92 81 81 query38 2724272726642664 query39 752 760 732 732 query39_1720 741 704 704 query40 212 126 110 110 query41 65 61 61 61 query42 104 106 104 104 query43 452 450 431 431 query44 1283718 708 708 query45 188 185 175 175 query46 863 956 586 586 query47 1414145713991399 query48 314 328 242 242 query49 819 403 327 327 query50 621 268 203 203 query51 3806372837173717 query52 106 108 98 98 query53 293 334 270 270 query54 277 247 238 238 query55 80 79 70 70 query56 284 315 288 288 query57 1010980 934 934 query58 266 251 242 242 query59 1992213819821982 query60 330 318 295 295 query61 182 150 158 150 query62 396 362 307 307 query63 298 269 274 269 query64 3419128010271027 query65 3825379737863786 query66 1351396 302 302 query67 15293 14669 15782 14669 query68 27111009745 745 query69 499 353 312 312 query70 986 955 948 948 query71 313 296 272 272 query72 6236359136073591 query73 580 723 301 301 query74 8781873786468646 query75 2767280124502450 query76 19421047643 643 query77 351 371 301 301 query78 9874991590879087 query79 1054892 596 596 query80 1328581 552 552 query81 570 266 231 231 query82 1023139 104 104 query83 377 246 232 232 query84 260 111 105 105 query85 908 504 442 442 query86 416 320 295 295 query87 2895282027462746 query88 3238220222192202 query89 390 355 333 333 query90 1901154 147 147 query91 172 170 138 138 query92 66 63 64 63 query93 1055913 516 516 query94 640 292 278 278 query95 565 368 300 300 query96 580 459 202 202 query97 2355237022902290 query98 218 199 195 195 query99 629 598 479 479 Total cold run time: 248654 ms Total hot run time: 172478 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3730837949 TPC-H: Total hot run time: 31430 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit fae7d48df0c84bde0de3ccf583858e189c54dd2a, data reload: false -- Round 1 -- q1 17728 419241014101 q2 2521361 255 255 q3 10409 1293711 711 q4 10307 877 322 322 q5 7521210218401840 q6 187 175 137 137 q7 908 801 677 677 q8 9269136811551155 q9 4791449144974491 q10 7009180314101410 q11 625 302 289 289 q12 713 748 597 597 q13 18139 386030923092 q14 290 292 269 269 q15 603 515 508 508 q16 681 671 626 626 q17 671 750 533 533 q18 6670651363136313 q19 1163966 605 605 q20 394 353 250 250 q21 2978238522882288 q22 10221003961 961 Total cold run time: 104599 ms Total hot run time: 31430 ms - Round 2, with runtime_filter_mode=off - q1 4092404540784045 q2 335 412 315 315 q3 2112262422492249 q4 1336175513141314 q5 4095397540133975 q6 212 171 131 131 q7 1864214718151815 q8 2559240823782378 q9 7113723770807080 q10 2522278222792279 q11 565 480 449 449 q12 672 741 645 645 q13 3654407133593359 q14 286 298 282 282 q15 557 505 504 504 q16 834 671 614 614 q17 1130133514361335 q18 7835783178167816 q19 862 821 818 818 q20 1989208119441944 q21 4746449444124412 q22 10821067969 969 Total cold run time: 50452 ms Total hot run time: 48728 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
zclllyybb commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3730748223 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3727160625 TPC-DS: Total hot run time: 173758 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6f623a4e47babcd7476b5bde04a752a3013f2789, data reload: false query5 4792585 433 433 query6 336 230 207 207 query7 4210448 262 262 query8 328 238 246 238 query9 8754264226452642 query10 499 369 300 300 query11 15266 15202 14859 14859 query12 179 121 116 116 query13 1251479 356 356 query14 6443300327852785 query14_12666267226432643 query15 199 191 173 173 query16 968 457 465 457 query17 1052647 561 561 query18 2626422 337 337 query19 218 220 195 195 query20 121 121 113 113 query21 212 139 134 134 query22 4192431940774077 query23 16191 15776 15339 15339 query23_115433 15514 15568 15514 query24 7423154312111211 query24_11203117311841173 query25 535 466 389 389 query26 1236256 155 155 query27 2764453 289 289 query28 4555212221122112 query29 836 571 473 473 query30 307 246 212 212 query31 810 622 548 548 query32 77 70 66 66 query33 527 333 271 271 query34 879 900 527 527 query35 719 759 667 667 query36 854 875 780 780 query37 122 96 79 79 query38 2738273226662666 query39 774 758 760 758 query39_1728 743 716 716 query40 211 132 115 115 query41 65 61 61 61 query42 110 104 100 100 query43 431 448 438 438 query44 1305717 711 711 query45 186 178 177 177 query46 851 948 587 587 query47 1397143314381433 query48 306 319 236 236 query49 598 448 332 332 query50 632 265 196 196 query51 3753381138153811 query52 102 107 97 97 query53 289 326 274 274 query54 290 258 246 246 query55 77 72 67 67 query56 285 289 297 289 query57 10571057992 992 query58 267 246 251 246 query59 2005219620602060 query60 322 313 300 300 query61 163 161 159 159 query62 394 351 319 319 query63 302 268 274 268 query64 50051317997 997 query65 3816372037163716 query66 1399422 305 305 query67 15636 15516 14845 14845 query68 27361012747 747 query69 443 359 323 323 query70 991 987 973 973 query71 322 302 279 279 query72 5969364437083644 query73 583 708 300 300 query74 8902881386608660 query75 2786282024592459 query76 28661055634 634 query77 327 395 287 287 query78 9793993992719271 query79 1053957 578 578 query80 1294595 476 476 query81 540 266 236 236 query82 1277145 116 116 query83 339 253 236 236 query84 260 123 102 102 query85 981 538 468 468 query86 411 323 324 323 query87 2968290827782778 query88 3183220522152205 query89 386 351 338 338 query90 1933152 147 147 query91 179 173 173 173 query92 69 69 64 64 query93 929 872 523 523 query94 637 315 293 293 query95 559 321 300 300 query96 595 450 209 209 query97 2350242623132313 query98 208 212 196 196 query99 596 604 500 500 Total cold run time: 249712 ms Total hot run time: 173758 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3727142574 TPC-H: Total hot run time: 32151 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6f623a4e47babcd7476b5bde04a752a3013f2789, data reload: false -- Round 1 -- q1 17645 428840424042 q2 2005358 246 246 q3 10176 1293711 711 q4 10223 924 334 334 q5 7520216519051905 q6 214 172 138 138 q7 978 812 672 672 q8 9300142911721172 q9 4917455747004557 q10 6795182414191419 q11 498 302 298 298 q12 678 733 593 593 q13 17784 384831043104 q14 300 291 281 281 q15 593 535 524 524 q16 699 659 631 631 q17 717 892 420 420 q18 6735645569056455 q19 13911096670 670 q20 441 386 258 258 q21 3241277426632663 q22 1145105810621058 Total cold run time: 103995 ms Total hot run time: 32151 ms - Round 2, with runtime_filter_mode=off - q1 4394433742464246 q2 346 396 322 322 q3 2257280324762476 q4 1484185713971397 q5 4667449542854285 q6 218 170 128 128 q7 2062194217941794 q8 2558239224152392 q9 7126748871197119 q10 2516272222992299 q11 576 498 458 458 q12 701 764 590 590 q13 3624383130643064 q14 266 293 262 262 q15 530 488 485 485 q16 628 659 623 623 q17 1101129713441297 q18 7535744573667366 q19 841 812 821 812 q20 1902196717871787 q21 4593424841534153 q22 10841068975 975 Total cold run time: 51009 ms Total hot run time: 48330 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3727093780 # FE UT Coverage Report Increment line coverage ` 92.86% (13/14)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_6f623a4e47babcd7476b5bde04a752a3013f2789/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_6f623a4e47babcd7476b5bde04a752a3013f2789/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3726798900 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3724724398 TPC-DS: Total hot run time: 172807 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 82a6fa7cd0a38ebb19987e35372069f87bb300ba, data reload: false query5 4383596 434 434 query6 317 228 214 214 query7 4204448 267 267 query8 338 242 238 238 query9 8752265826552655 query10 489 364 318 318 query11 15176 15180 15115 15115 query12 170 114 113 113 query13 1267504 406 406 query14 5963294627602760 query14_12668262326492623 query15 203 193 179 179 query16 986 454 459 454 query17 1120686 581 581 query18 2455432 346 346 query19 228 226 207 207 query20 124 119 116 116 query21 220 140 120 120 query22 3991386340253863 query23 15990 15474 15356 15356 query23_115423 15303 15331 15303 query24 7623154211551155 query24_11173115812061158 query25 572 471 427 427 query26 1245270 162 162 query27 2763463 286 286 query28 4568214121272127 query29 839 565 473 473 query30 310 238 213 213 query31 767 629 569 569 query32 83 74 71 71 query33 564 378 292 292 query34 916 867 514 514 query35 725 758 684 684 query36 899 879 799 799 query37 130 93 73 73 query38 2787271526572657 query39 792 751 732 732 query39_1706 724 705 705 query40 215 128 116 116 query41 65 63 61 61 query42 115 101 111 101 query43 465 429 418 418 query44 1282716 708 708 query45 183 192 174 174 query46 835 950 585 585 query47 1375137712901290 query48 308 318 251 251 query49 601 417 332 332 query50 633 274 201 201 query51 3783377937203720 query52 103 111 96 96 query53 286 340 283 283 query54 275 250 245 245 query55 75 76 72 72 query56 274 278 280 278 query57 10341023942 942 query58 270 249 246 246 query59 2113212720992099 query60 313 352 295 295 query61 159 156 162 156 query62 389 362 331 331 query63 303 265 277 265 query64 50221304992 992 query65 3803376637273727 query66 1454414 306 306 query67 15071 15029 15326 15029 query68 6389981 700 700 query69 537 343 306 306 query70 1082958 922 922 query71 366 298 277 277 query72 5929348834793479 query73 755 713 297 297 query74 8797877886248624 query75 2837281324802480 query76 38431042625 625 query77 505 381 284 284 query78 9684989292329232 query79 1492895 582 582 query80 674 572 492 492 query81 503 258 224 224 query82 347 141 109 109 query83 258 265 241 241 query84 253 130 101 101 query85 943 536 466 466 query86 392 343 328 328 query87 2937283827552755 query88 3190221522152215 query89 398 353 322 322 query90 2102150 149 149 query91 176 168 150 150 query92 75 69 61 61 query93 1507909 528 528 query94 562 329 301 301 query95 578 373 299 299 query96 587 460 205 205 query97 2324236723222322 query98 234 194 198 194 query99 603 600 537 537 Total cold run time: 252671 ms Total hot run time: 172807 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3724680379 TPC-H: Total hot run time: 31166 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 82a6fa7cd0a38ebb19987e35372069f87bb300ba, data reload: false -- Round 1 -- q1 17617 418340494049 q2 2050358 235 235 q3 10158 1269701 701 q4 10215 899 318 318 q5 7550204118441844 q6 190 180 145 145 q7 932 778 657 657 q8 9276138311231123 q9 4819470445424542 q10 6804182714021402 q11 500 297 269 269 q12 661 757 595 595 q13 17784 385230593059 q14 296 294 279 279 q15 621 513 512 512 q16 692 664 651 651 q17 676 859 461 461 q18 6608676062706270 q19 1109968 598 598 q20 408 366 249 249 q21 2970243322722272 q22 1020988 935 935 Total cold run time: 102956 ms Total hot run time: 31166 ms - Round 2, with runtime_filter_mode=off - q1 4089403240394032 q2 332 387 320 320 q3 2108258622292229 q4 1334174913701370 q5 4118398240703982 q6 210 171 130 130 q7 1890178116771677 q8 2827249424002400 q9 7346713070957095 q10 2568268322622262 q11 557 477 458 458 q12 713 793 637 637 q13 3581405433433343 q14 289 319 375 319 q15 567 514 513 513 q16 662 684 625 625 q17 1163128614041286 q18 8013779877367736 q19 878 857 831 831 q20 1975201319151915 q21 4871431942024202 q22 10641011992 992 Total cold run time: 51155 ms Total hot run time: 48354 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3724514268 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
zclllyybb commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3720129488 wait https://github.com/apache/doris/pull/59616 merge first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
zclllyybb commented on code in PR #58554: URL: https://github.com/apache/doris/pull/58554#discussion_r2665658144 ## be/src/vec/functions/function_date_or_datetime_computation.cpp: ## @@ -119,10 +120,16 @@ using FunctionDatetimeSubQuarters = using FunctionDatetimeSubYears = FunctionDateOrDateTimeComputation>; -using FunctionAddTimeDatetime = FunctionAddTime; -using FunctionAddTimeTime = FunctionAddTime; -using FunctionSubTimeDatetime = FunctionAddTime; -using FunctionSubTimeTime = FunctionAddTime; +using FunctionAddTimeDatetime = +FunctionNeedsToHandleNull, Review Comment: comparing to our default framework, I didn't see advantages using `FunctionNeedsToHandleNull` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3710244852 # FE Regression Coverage Report Increment line coverage ` 92.86% (13/14)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_487049c9a004eb0f958ad04e5cb366e05a2f36b6_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_487049c9a004eb0f958ad04e5cb366e05a2f36b6_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3710213765 # BE Regression && UT Coverage Report Increment line coverage `100.00% (28/28)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_487049c9a004eb0f958ad04e5cb366e05a2f36b6_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_487049c9a004eb0f958ad04e5cb366e05a2f36b6_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.90% (25736/34826) | | Line Coverage | 61.27% (274204/447545) | | Region Coverage | 56.08% (228546/407560) | | Branch Coverage | 58.03% (98607/169924) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709758807 run nonConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709756923 run vault_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709565291 # BE UT Coverage Report Increment line coverage `25.00% (7/28)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/487049c9a004eb0f958ad04e5cb366e05a2f36b6_487049c9a004eb0f958ad04e5cb366e05a2f36b6/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/487049c9a004eb0f958ad04e5cb366e05a2f36b6_487049c9a004eb0f958ad04e5cb366e05a2f36b6/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.25% (18970/35622) | | Line Coverage | 39.21% (175957/448731) | | Region Coverage | 33.76% (136167/403374) | | Branch Coverage | 34.71% (58786/169358) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709561575 # FE UT Coverage Report Increment line coverage ` 92.86% (13/14)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_487049c9a004eb0f958ad04e5cb366e05a2f36b6/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_487049c9a004eb0f958ad04e5cb366e05a2f36b6/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709428672 ClickBench: Total hot run time: 27.14 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 487049c9a004eb0f958ad04e5cb366e05a2f36b6, data reload: false query1 0.050.040.04 query2 0.100.050.05 query3 0.260.090.08 query4 1.600.110.12 query5 0.270.260.25 query6 1.140.670.64 query7 0.040.030.02 query8 0.050.040.04 query9 0.580.500.50 query10 0.540.540.55 query11 0.140.090.10 query12 0.140.110.11 query13 0.600.580.59 query14 0.940.950.94 query15 0.780.770.77 query16 0.410.400.39 query17 1.011.071.04 query18 0.230.210.22 query19 1.951.861.91 query20 0.020.010.01 query21 15.44 0.290.13 query22 5.290.050.05 query23 15.95 0.290.10 query24 1.060.571.11 query25 0.090.160.07 query26 0.130.130.13 query27 0.060.060.05 query28 5.381.070.88 query29 12.61 3.893.15 query30 0.280.140.11 query31 2.820.650.40 query32 3.230.570.45 query33 2.983.153.09 query34 16.85 5.124.41 query35 4.464.464.48 query36 0.670.500.48 query37 0.110.070.06 query38 0.070.050.03 query39 0.040.020.03 query40 0.170.150.14 query41 0.080.040.03 query42 0.040.030.03 query43 0.040.030.04 Total cold run time: 98.7 s Total hot run time: 27.14 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709412867 TPC-DS: Total hot run time: 172527 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 487049c9a004eb0f958ad04e5cb366e05a2f36b6, data reload: false query5 4407581 427 427 query6 344 228 215 215 query7 4222461 258 258 query8 329 246 225 225 query9 8773261225992599 query10 538 371 316 316 query11 15069 14981 14851 14851 query12 180 116 113 113 query13 1264508 373 373 query14 6032299027102710 query14_12659259225782578 query15 201 190 175 175 query16 983 477 364 364 query17 1071650 559 559 query18 2490419 329 329 query19 223 217 195 195 query20 130 117 113 113 query21 214 138 126 126 query22 3943421438823882 query23 16002 15600 15502 15502 query23_115596 15401 15548 15401 query24 7668155211611161 query24_11188115211751152 query25 530 448 392 392 query26 1242271 157 157 query27 2758453 294 294 query28 4570213821372137 query29 831 550 443 443 query30 313 243 213 213 query31 794 636 556 556 query32 78 69 67 67 query33 550 344 287 287 query34 921 876 513 513 query35 741 807 736 736 query36 837 868 813 813 query37 140 96 79 79 query38 2736270327402703 query39 764 760 737 737 query39_1714 700 702 700 query40 217 136 122 122 query41 68 62 63 62 query42 103 106 104 104 query43 480 438 425 425 query44 1316725 740 725 query45 187 185 173 173 query46 857 956 590 590 query47 1482140413471347 query48 308 338 234 234 query49 608 429 331 331 query50 641 274 202 202 query51 3723381838013801 query52 104 104 98 98 query53 291 333 278 278 query54 293 257 243 243 query55 77 73 71 71 query56 279 288 290 288 query57 10021018916 916 query58 268 254 249 249 query59 2161218921822182 query60 315 329 291 291 query61 163 182 151 151 query62 398 345 305 305 query63 299 262 267 262 query64 50641275976 976 query65 3789370136483648 query66 1419408 295 295 query67 15036 14862 14639 14639 query68 27181009739 739 query69 448 353 312 312 query70 1031998 850 850 query71 321 300 270 270 query72 6215357337513573 query73 589 726 298 298 query74 8753874486108610 query75 2774286024652465 query76 28631060627 627 query77 362 370 288 288 query78 977610165 91069106 query79 981 904 597 597 query80 1275595 518 518 query81 547 264 233 233 query82 267 143 112 112 query83 429 265 244 244 query84 254 124 102 102 query85 1073524 473 473 query86 353 298 289 289 query87 2952288028302830 query88 3136224422032203 query89 397 346 344 344 query90 1828167 150 150 query91 178 175 140 140 query92 73 68 61 61 query93 943 888 541 541 query94 554 332 302 302 query95 582 332 367 332 query96 587 465 208 208 query97 2305238323172317 query98 228 197 200 197 query99 620 588 506 506 Total cold run time: 247425 ms Total hot run time: 172527 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709382708 TPC-H: Total hot run time: 31573 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 487049c9a004eb0f958ad04e5cb366e05a2f36b6, data reload: false -- Round 1 -- q1 17654 420840304030 q2 2058360 241 241 q3 10128 1331723 723 q4 10218 915 331 331 q5 7527203919241924 q6 189 169 138 138 q7 912 774 658 658 q8 9262137011351135 q9 4814459545414541 q10 6737182214281428 q11 481 297 280 280 q12 688 735 600 600 q13 17767 377630513051 q14 295 305 274 274 q15 559 503 505 503 q16 700 670 618 618 q17 679 791 552 552 q18 6702647963886388 q19 1086972 620 620 q20 398 361 262 262 q21 3072246923172317 q22 10411034959 959 Total cold run time: 102967 ms Total hot run time: 31573 ms - Round 2, with runtime_filter_mode=off - q1 4099407540424042 q2 333 397 324 324 q3 2078260322312231 q4 1306174913231323 q5 4143401841284018 q6 215 178 131 131 q7 1851179916901690 q8 2848247124852471 q9 7240721072337210 q10 2683273523462346 q11 543 460 465 460 q12 710 773 630 630 q13 3702401834933493 q14 318 328 280 280 q15 558 508 508 508 q16 626 720 625 625 q17 1140129013531290 q18 8019797877717771 q19 883 848 900 848 q20 1964206619171917 q21 4819453344724472 q22 1162107810481048 Total cold run time: 51240 ms Total hot run time: 49128 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3709328167 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
zclllyybb commented on code in PR #58554: URL: https://github.com/apache/doris/pull/58554#discussion_r2611573115 ## be/src/vec/functions/function_date_or_datetime_computation.cpp: ## @@ -119,10 +120,19 @@ using FunctionDatetimeSubQuarters = using FunctionDatetimeSubYears = FunctionDateOrDateTimeComputation>; -using FunctionAddTimeDatetime = FunctionAddTime; -using FunctionAddTimeTime = FunctionAddTime; -using FunctionSubTimeDatetime = FunctionAddTime; -using FunctionSubTimeTime = FunctionAddTime; +using FunctionAddTimeDatetime = +FunctionNeedsToHandleNull, + TYPE_DATETIMEV2>; +using FunctionAddTimeTime = +FunctionNeedsToHandleNull, TYPE_TIMEV2>; +using FunctionSubTimeDatetime = +FunctionNeedsToHandleNull, + TYPE_DATETIMEV2>; +using FunctionSubTimeTime = +FunctionNeedsToHandleNull, TYPE_TIMEV2>; +using FunctionTimestampTwoArgs = Review Comment: 这种为啥不直接在FE改写了呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3637178148 # FE Regression Coverage Report Increment line coverage ` 83.33% (5/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_4056a613c4ed2677823c4f9d17e54f9c351e658b_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_4056a613c4ed2677823c4f9d17e54f9c351e658b_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3637100519 # BE Regression && UT Coverage Report Increment line coverage `100.00% (22/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_4056a613c4ed2677823c4f9d17e54f9c351e658b_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_4056a613c4ed2677823c4f9d17e54f9c351e658b_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.13% (25139/34375) | | Line Coverage | 60.27% (266725/442570) | | Region Coverage | 55.83% (224760/402561) | | Branch Coverage | 57.09% (95534/167349) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3636791408 # BE UT Coverage Report Increment line coverage `4.55% (1/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/4056a613c4ed2677823c4f9d17e54f9c351e658b_4056a613c4ed2677823c4f9d17e54f9c351e658b/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/4056a613c4ed2677823c4f9d17e54f9c351e658b_4056a613c4ed2677823c4f9d17e54f9c351e658b/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.39% (18727/35073) | | Line Coverage | 39.09% (173171/443046) | | Region Coverage | 33.74% (134221/397838) | | Branch Coverage | 34.69% (57745/166474) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3636749036 ClickBench: Total hot run time: 27.08 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 4056a613c4ed2677823c4f9d17e54f9c351e658b, data reload: false query1 0.050.050.05 query2 0.100.050.05 query3 0.250.090.08 query4 1.610.110.11 query5 0.290.250.27 query6 1.160.640.65 query7 0.030.020.03 query8 0.050.050.04 query9 0.570.510.49 query10 0.540.560.57 query11 0.160.100.12 query12 0.140.110.13 query13 0.610.600.62 query14 1.000.990.98 query15 0.820.790.81 query16 0.420.400.40 query17 0.961.081.03 query18 0.230.210.22 query19 1.941.871.79 query20 0.020.020.01 query21 15.43 0.300.13 query22 5.050.060.05 query23 16.07 0.290.10 query24 1.770.220.26 query25 0.090.050.07 query26 0.150.130.13 query27 0.060.050.06 query28 3.391.211.03 query29 12.63 4.013.21 query30 0.270.150.12 query31 2.820.620.41 query32 3.240.550.45 query33 2.963.042.95 query34 16.67 5.174.48 query35 4.594.564.55 query36 0.650.490.49 query37 0.110.070.06 query38 0.080.040.04 query39 0.040.030.04 query40 0.180.140.14 query41 0.090.030.02 query42 0.050.030.03 query43 0.040.040.03 Total cold run time: 97.38 s Total hot run time: 27.08 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3636731543 TPC-DS: Total hot run time: 180353 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 4056a613c4ed2677823c4f9d17e54f9c351e658b, data reload: false query5 4687629 481 481 query6 349 251 223 223 query7 4218469 280 280 query8 304 258 241 241 query9 8763262225822582 query10 495 383 331 331 query11 15232 15201 14486 14486 query12 184 116 113 113 query13 1267511 396 396 query14 6320325829892989 query14_12916288528992885 query15 208 199 179 179 query16 886 483 461 461 query17 1163729 608 608 query18 2615441 356 356 query19 230 231 208 208 query20 127 112 118 112 query21 225 140 118 118 query22 3854392638193819 query23 16598 16147 15817 15817 query23_116007 16016 15892 15892 query24 7340169612641264 query24_11241125012321232 query25 590 489 443 443 query26 1258273 167 167 query27 2736467 312 312 query28 4473219421722172 query29 806 565 462 462 query30 320 248 220 220 query31 813 692 635 635 query32 80 68 71 68 query33 530 344 293 293 query34 903 897 551 551 query35 832 826 713 713 query36 882 930 834 834 query37 125 91 77 77 query38 3852388437423742 query39 755 730 727 727 query39_1700 706 713 706 query40 227 137 121 121 query41 69 67 61 61 query42 110 105 104 104 query43 430 421 399 399 query44 1348743 746 743 query45 197 190 182 182 query46 892 999 631 631 query47 1636170616051605 query48 318 326 243 243 query49 620 434 362 362 query50 666 313 230 230 query51 3795385137703770 query52 108 109 96 96 query53 322 358 297 297 query54 308 262 258 258 query55 81 77 75 75 query56 297 298 329 298 query57 1139113210721072 query58 268 247 252 247 query59 2326242023562356 query60 308 309 289 289 query61 164 158 160 158 query62 717 666 615 615 query63 333 300 308 300 query64 4921128710141014 query65 4008391739703917 query66 1416445 312 312 query67 15032 14904 14917 14904 query68 83641020740 740 query69 501 342 317 317 query70 1115966 952 952 query71 383 316 293 293 query72 5879479248294792 query73 646 568 317 317 query74 8502885685388538 query75 3608350831413141 query76 38181138766 766 query77 609 403 289 289 query78 93809601 query79 1415896 635 635 query80 720 657 559 559 query81 510 264 232 232 query82 204 134 105 105 query83 256 256 238 238 query84 261 119 96 96 query85 891 510 462 462 query86 338 307 307 307 query87 4132412638593859 query88 3643229022802280 query89 468 417 394 394 query90 2214161 159 159 query91 171 169 143 143 query92 82 65 65 65 query93 1450946 561 561 query94 455 299 271 271 query95 571 384 301 301 query96 602 474 207 207 query97 2612261925772577 query98 215 197 195 195 query99 1277132612331233 Total cold run time: 262541 ms Total hot run time: 180353 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3636692203 TPC-H: Total hot run time: 35021 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4056a613c4ed2677823c4f9d17e54f9c351e658b, data reload: false -- Round 1 -- q1 17604 420940524052 q2 2040337 226 226 q3 10207 1316756 756 q4 10232 883 311 311 q5 7535215918961896 q6 195 165 136 136 q7 1003852 714 714 q8 9343148011601160 q9 7044530953785309 q10 7004241519871987 q11 524 309 285 285 q12 652 753 603 603 q13 17801 367830003000 q14 296 287 274 274 q15 590 508 508 508 q16 934 926 870 870 q17 688 883 463 463 q18 7348714169996999 q19 1164960 615 615 q20 405 367 250 250 q21 4236395136473647 q22 1068978 960 960 Total cold run time: 107913 ms Total hot run time: 35021 ms - Round 2, with runtime_filter_mode=off - q1 4133402340854023 q2 324 415 311 311 q3 2172268623082308 q4 1331179713021302 q5 4234464846864648 q6 227 186 141 141 q7 2004197317851785 q8 2689262025442544 q9 7436745575677455 q10 3024332528382838 q11 585 499 489 489 q12 675 798 895 798 q13 3564392633253325 q14 312 328 293 293 q15 552 528 529 528 q16 917 958 888 888 q17 1195141114241411 q18 7914760775947594 q19 906 895 915 895 q20 2063208718381838 q21 4767443442214221 q22 10511052963 963 Total cold run time: 52075 ms Total hot run time: 50598 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3636547571 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3635391212 # FE Regression Coverage Report Increment line coverage ` 66.67% (4/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_8e47b42828f742e6e5d9b550f51e048fed2199de_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_8e47b42828f742e6e5d9b550f51e048fed2199de_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3635115207 ClickBench: Total hot run time: 27.7 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8e47b42828f742e6e5d9b550f51e048fed2199de, data reload: false query1 0.050.050.04 query2 0.100.050.05 query3 0.250.090.09 query4 1.610.110.10 query5 0.280.260.24 query6 1.180.630.64 query7 0.030.020.02 query8 0.060.040.04 query9 0.580.510.49 query10 0.560.550.54 query11 0.160.110.11 query12 0.150.120.11 query13 0.630.620.60 query14 1.000.980.98 query15 0.800.800.80 query16 0.410.410.40 query17 1.051.091.04 query18 0.230.220.22 query19 1.921.881.87 query20 0.020.020.01 query21 15.43 0.310.14 query22 4.810.060.05 query23 16.15 0.290.11 query24 1.260.530.42 query25 0.060.080.06 query26 0.140.140.13 query27 0.050.050.06 query28 4.041.221.03 query29 12.61 4.113.23 query30 0.280.140.11 query31 2.850.630.39 query32 3.230.580.49 query33 3.013.173.14 query34 16.82 5.224.55 query35 4.534.594.56 query36 0.660.500.50 query37 0.110.070.07 query38 0.080.050.04 query39 0.040.030.04 query40 0.170.150.13 query41 0.100.030.03 query42 0.040.040.03 query43 0.040.030.04 Total cold run time: 97.58 s Total hot run time: 27.7 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3635104279 TPC-DS: Total hot run time: 181387 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8e47b42828f742e6e5d9b550f51e048fed2199de, data reload: false query5 4800593 489 489 query6 356 257 232 232 query7 4221487 279 279 query8 306 273 266 266 query9 8800262926312629 query10 497 396 325 325 query11 15208 14962 14672 14672 query12 183 120 119 119 query13 1267528 398 398 query14 6216331831443144 query14_12922297530402975 query15 214 200 185 185 query16 840 468 449 449 query17 1120679 597 597 query18 2592435 331 331 query19 225 224 196 196 query20 122 116 112 112 query21 219 137 117 117 query22 3904386238453845 query23 16489 16022 15858 15858 query23_115958 16205 15948 15948 query24 7354166812221222 query24_11227123812551238 query25 553 460 411 411 query26 1251270 159 159 query27 2763469 313 313 query28 4453217321412141 query29 834 553 439 439 query30 313 245 219 219 query31 835 697 622 622 query32 82 67 68 67 query33 536 339 309 309 query34 919 926 554 554 query35 795 809 730 730 query36 877 900 837 837 query37 127 96 89 89 query38 3864381938493819 query39 758 727 704 704 query39_1695 708 874 708 query40 228 141 122 122 query41 67 63 62 62 query42 107 104 107 104 query43 427 429 397 397 query44 1322761 756 756 query45 192 193 184 184 query46 888 987 621 621 query47 1673173116121612 query48 322 332 251 251 query49 663 451 351 351 query50 680 315 227 227 query51 3840385538323832 query52 114 107 97 97 query53 310 349 307 307 query54 288 262 254 254 query55 85 77 78 77 query56 343 313 290 290 query57 1143113810681068 query58 269 272 248 248 query59 2264235723152315 query60 328 304 289 289 query61 172 156 171 156 query62 704 660 627 627 query63 335 291 295 291 query64 49211273979 979 query65 4042391939563919 query66 1426452 352 352 query67 15233 14877 14687 14687 query68 27391053791 791 query69 435 353 311 311 query70 1064998 971 971 query71 325 308 290 290 query72 6325515652755156 query73 534 618 319 319 query74 8933884487008700 query75 3563353331703170 query76 29351155760 760 query77 376 400 312 312 query78 9552966190059005 query79 1208847 644 644 query80 1291676 545 545 query81 557 272 241 241 query82 1004135 104 104 query83 373 272 240 240 query84 253 121 106 106 query85 944 509 467 467 query86 409 292 271 271 query87 4026412539783978 query88 3294229222992292 query89 476 429 395 395 query90 1997158 153 153 query91 184 165 142 142 query92 66 68 64 64 query93 1150932 583 583 query94 529 312 276 276 query95 575 384 309 309 query96 600 470 215 215 query97 2609263425492549 query98 209 194 184 184 query99 1267129712361236 Total cold run time: 256927 ms Total hot run time: 181387 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3635080821 TPC-H: Total hot run time: 36195 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8e47b42828f742e6e5d9b550f51e048fed2199de, data reload: false -- Round 1 -- q1 17585 509549454945 q2 1996350 238 238 q3 10208 1320729 729 q4 10217 840 316 316 q5 7523209519231923 q6 191 174 144 144 q7 1003854 720 720 q8 9380140311061106 q9 7041531152715271 q10 6857239119861986 q11 517 310 302 302 q12 639 725 551 551 q13 17773 367530663066 q14 298 294 270 270 q15 601 532 512 512 q16 943 932 868 868 q17 718 867 489 489 q18 7457706871797068 q19 1107988 629 629 q20 410 394 254 254 q21 4277402438113811 q22 10911022997 997 Total cold run time: 107832 ms Total hot run time: 36195 ms - Round 2, with runtime_filter_mode=off - q1 5088504549854985 q2 349 422 327 327 q3 2140269722822282 q4 1338178113101310 q5 4784469445824582 q6 224 168 129 129 q7 2013196118021802 q8 2668269725712571 q9 7564755874777477 q10 3072328432693269 q11 607 509 504 504 q12 683 760 594 594 q13 3617404033993399 q14 295 288 269 269 q15 550 501 521 501 q16 906 927 872 872 q17 1192137514661375 q18 7987762675657565 q19 931 857 886 857 q20 1910194618111811 q21 4643427540214021 q22 10741025962 962 Total cold run time: 53635 ms Total hot run time: 51464 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3634982147 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3633615969 # BE UT Coverage Report Increment line coverage `5.00% (1/20)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e998963a5fd639c84aa13dd07c5fad5a3920de3d_e998963a5fd639c84aa13dd07c5fad5a3920de3d/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e998963a5fd639c84aa13dd07c5fad5a3920de3d_e998963a5fd639c84aa13dd07c5fad5a3920de3d/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.36% (18715/35071) | | Line Coverage | 39.07% (173043/442919) | | Region Coverage | 33.73% (134148/397749) | | Branch Coverage | 34.65% (57673/166428) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-365650 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris-website]
linrrzqqq commented on code in PR #3130: URL: https://github.com/apache/doris-website/pull/3130#discussion_r2597250163 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/date-time-functions/timestamp.md: ## @@ -59,4 +64,27 @@ SELECT TIMESTAMP(NULL); | NULL| +-+ +-- 两个参数，返回两个参数相加的结果(Date/DateTime + Time) Review Comment: 都是返回 NULL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris-website]
HappenLee commented on code in PR #3130: URL: https://github.com/apache/doris-website/pull/3130#discussion_r2597109226 ## i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/date-time-functions/timestamp.md: ## @@ -59,4 +64,27 @@ SELECT TIMESTAMP(NULL); | NULL| +-+ +-- 两个参数，返回两个参数相加的结果(Date/DateTime + Time) Review Comment: 第二个参数是个非法的time类型，比如秒是65秒会怎么样呢？check一下我们和mysql的行为 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3596365115 # BE Regression && UT Coverage Report Increment line coverage `100.00% (26/26)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_9930cf6479adda6cdd26a2a9b41603730bee7a62_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_9930cf6479adda6cdd26a2a9b41603730bee7a62_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.64% (24592/34325) | | Line Coverage | 58.17% (256616/441153) | | Region Coverage | 53.34% (214085/401394) | | Branch Coverage | 54.79% (91449/166906) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3596341267 # BE UT Coverage Report Increment line coverage `11.54% (3/26)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/9930cf6479adda6cdd26a2a9b41603730bee7a62_9930cf6479adda6cdd26a2a9b41603730bee7a62/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/9930cf6479adda6cdd26a2a9b41603730bee7a62_9930cf6479adda6cdd26a2a9b41603730bee7a62/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.82% (18492/35010) | | Line Coverage | 38.36% (169370/441561) | | Region Coverage | 33.15% (131471/396608) | | Branch Coverage | 34.10% (56616/166019) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3595825926 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3595672252 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
hello-stephen commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3594825767 # FE Regression Coverage Report Increment line coverage ` 66.67% (6/9)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58554_9930cf6479adda6cdd26a2a9b41603730bee7a62_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58554_9930cf6479adda6cdd26a2a9b41603730bee7a62_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3594499454 ClickBench: Total hot run time: 27.12 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 9930cf6479adda6cdd26a2a9b41603730bee7a62, data reload: false query1 0.050.050.05 query2 0.100.050.05 query3 0.260.080.08 query4 1.610.110.11 query5 0.260.250.24 query6 1.150.650.64 query7 0.020.020.02 query8 0.050.040.04 query9 0.560.500.49 query10 0.560.550.55 query11 0.150.100.10 query12 0.140.110.11 query13 0.640.600.60 query14 0.980.990.98 query15 0.800.820.82 query16 0.380.410.40 query17 1.041.001.07 query18 0.240.210.22 query19 1.941.761.84 query20 0.020.020.02 query21 15.45 0.270.14 query22 4.890.050.04 query23 15.86 0.260.10 query24 1.440.540.25 query25 0.090.040.07 query26 0.150.140.14 query27 0.080.050.05 query28 3.521.221.03 query29 12.61 3.853.23 query30 0.270.140.11 query31 2.820.610.38 query32 3.220.540.45 query33 3.113.073.05 query34 16.81 5.224.56 query35 4.564.524.49 query36 0.650.500.48 query37 0.110.070.06 query38 0.070.040.04 query39 0.040.030.02 query40 0.180.130.12 query41 0.080.030.02 query42 0.040.020.02 query43 0.050.030.03 Total cold run time: 97.05 s Total hot run time: 27.12 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3594489525 TPC-DS: Total hot run time: 181561 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9930cf6479adda6cdd26a2a9b41603730bee7a62, data reload: false query1 1046412 388 388 query2 6575117712101177 query3 6759227 219 219 query4 25653 23282 23038 23038 query5 5847651 497 497 query6 402 249 225 225 query7 4966501 301 301 query8 340 250 246 246 query9 8728262426132613 query10 583 350 309 309 query11 15347 14946 14827 14827 query12 191 119 116 116 query13 1687579 453 453 query14 10939 584558895845 query15 272 203 184 184 query16 7827703 528 528 query17 1434805 663 663 query18 2070433 342 342 query19 306 213 180 180 query20 133 132 121 121 query21 219 137 121 121 query22 3981403638873887 query23 32995 32028 31966 31966 query24 8000243224042404 query25 598 551 486 486 query26 1213282 170 170 query27 2680514 345 345 query28 4392219021512151 query29 815 676 523 523 query30 309 236 216 216 query31 828 717 613 613 query32 83 73 81 73 query33 608 401 341 341 query34 798 905 545 545 query35 794 835 742 742 query36 876 916 825 825 query37 116 113 90 90 query38 3772380937713771 query39 1465141714081408 query40 219 130 117 117 query41 62 62 62 62 query42 127 115 111 111 query43 428 440 395 395 query44 1282750 746 746 query45 202 195 180 180 query46 869 992 640 640 query47 1707174016661666 query48 406 421 353 353 query49 766 512 420 420 query50 642 692 404 404 query51 3860388938473847 query52 114 111 110 110 query53 237 259 193 193 query54 315 302 278 278 query55 94 89 90 89 query56 346 330 340 330 query57 1127115810941094 query58 288 277 278 277 query59 2280242623862386 query60 349 340 338 338 query61 173 163 161 161 query62 773 715 656 656 query63 233 190 191 190 query64 45131217911 911 query65 4080396039923960 query66 1037441 338 338 query67 15283 15126 14867 14867 query68 8455944 612 612 query69 550 354 313 313 query70 1115104810341034 query71 519 343 316 316 query72 5757504248504850 query73 703 582 346 346 query74 8782876385958595 query75 3818309324502450 query76 37521145725 725 query77 805 408 301 301 query78 9525958687758775 query79 2031847 592 592 query80 627 609 497 497 query81 501 268 235 235 query82 467 147 113 113 query83 266 267 254 254 query84 254 114 92 92 query85 889 495 446 446 query86 338 297 279 279 query87 4048402939603960 query88 3999230122482248 query89 389 330 297 297 query90 1976212 223 212 query91 171 174 145 145 query92 82 72 70 70 query93 1735989 656 656 query94 726 453 337 337 query95 493 416 405 405 query96 513 546 288 288 query97 2647269325762576 query98 239 216 208 208 query99 1319140112661266 Total cold run time: 274950 ms Total hot run time: 181561 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
doris-robot commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3594467290 TPC-H: Total hot run time: 33929 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 9930cf6479adda6cdd26a2a9b41603730bee7a62, data reload: false -- Round 1 -- q1 6157489248934892 q2 887 308 214 214 q3 16661273712 712 q4 852 837 367 367 q5 2114197320091973 q6 213 181 139 139 q7 942 840 660 660 q8 1211110311531103 q9 5467538552925292 q10 2267225018361836 q11 426 313 297 297 q12 300 371 229 229 q13 3282371430273027 q14 235 243 237 237 q15 561 529 508 508 q16 900 856 803 803 q17 569 810 444 444 q18 7255720970437043 q19 559 940 578 578 q20 404 334 233 233 q21 4343312623642364 q22 1016995 978 978 Total cold run time: 41626 ms Total hot run time: 33929 ms - Round 2, with runtime_filter_mode=off - q1 4931492948814881 q2 316 411 312 312 q3 2118264722802280 q4 1308174712831283 q5 4223411741724117 q6 213 170 128 128 q7 1936189517041704 q8 2568247224462446 q9 6996695669826956 q10 2904310326542654 q11 577 514 490 490 q12 644 720 556 556 q13 3185362130193019 q14 288 280 273 273 q15 553 512 511 511 q16 894 898 859 859 q17 1093134013321332 q18 7307720770137013 q19 740 724 749 724 q20 1976197818081808 q21 4550428341874187 q22 1063104310111011 Total cold run time: 50383 ms Total hot run time: 48544 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on code in PR #58554: URL: https://github.com/apache/doris/pull/58554#discussion_r2575545249 ## be/src/vec/functions/function_date_or_datetime_computation.cpp: ## @@ -121,6 +121,9 @@ using FunctionAddTimeDatetime = FunctionAddTime; using FunctionAddTimeTime = FunctionAddTime; using FunctionSubTimeDatetime = FunctionAddTime; using FunctionSubTimeTime = FunctionAddTime; +using FunctionTimestampTwoArgsDatetime = FunctionAddTime; +using FunctionTimestampTwoArgsDate = Review Comment: 这个 date 是入参的类型，返回类型都是 datetime -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
zclllyybb commented on code in PR #58554: URL: https://github.com/apache/doris/pull/58554#discussion_r2575542191 ## be/src/vec/functions/function_date_or_datetime_computation.cpp: ## @@ -121,6 +121,9 @@ using FunctionAddTimeDatetime = FunctionAddTime; using FunctionAddTimeTime = FunctionAddTime; using FunctionSubTimeDatetime = FunctionAddTime; using FunctionSubTimeTime = FunctionAddTime; +using FunctionTimestampTwoArgsDatetime = FunctionAddTime; +using FunctionTimestampTwoArgsDate = Review Comment: 这个函数返回一定有time部分，所以不需要date的签名了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
linrrzqqq commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3594421609 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Enhancement](function) Support two args versions of TIMESTAMP [doris]
Thearas commented on PR #58554: URL: https://github.com/apache/doris/pull/58554#issuecomment-3594420221 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
