Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
liaoxin01 merged PR #60953: URL: https://github.com/apache/doris/pull/60953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
github-actions[bot] commented on code in PR #60953:
URL: https://github.com/apache/doris/pull/60953#discussion_r2928894814
##
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##
@@ -2527,6 +2527,28 @@ public int getPartitionTotalReplicasNum(long
partitionId) {
return
partitionInfo.getReplicaAllocation(partitionId).getTotalReplicaNum();
}
+public Map> getPartitionVersionGapBackends(long
partitionId) {
+Map> result = new HashMap<>();
+Partition partition = getPartition(partitionId);
+if (partition == null) {
Review Comment:
**[Concurrency] Missing read lock.** This method iterates deeply nested
structures (`partition -> index -> tablet -> replica`) without acquiring the
table's `readLock()`. The structurally similar method `getAllTabletIds()` (line
626) acquires `readLock()` for the exact same traversal pattern.
Without the lock, concurrent operations (schema changes adding/dropping
rollup indices, `TabletScheduler` deleting replicas, clone tasks adding
replicas) can modify the underlying `ArrayList`s returned by `getTablets()` and
`getReplicas()` mid-iteration, causing `ConcurrentModificationException`.
Not all callers hold the lock either -- at least 2 of 3 call paths
(`RewriteTableCommand` and `NereidsLoadPlanInfoCollector`) do not hold the
table read lock.
Suggested fix: either acquire `readLock()`/`readUnlock()` within this method
(matching `getAllTabletIds()`), or document that callers must hold it and
ensure they do.
##
fe/fe-core/src/main/java/org/apache/doris/planner/OlapTableSink.java:
##
@@ -226,6 +226,10 @@ public void init(TUniqueId loadId, long txnId, long dbId,
long loadChannelTimeou
for (TOlapTablePartition partition :
tOlapTablePartitionParam.getPartitions()) {
partition.setTotalReplicaNum(dstTable.getPartitionTotalReplicasNum(partition.getId()));
partition.setLoadRequiredReplicaNum(dstTable.getLoadRequiredReplicaNum(partition.getId()));
+Map> gapBackends =
dstTable.getPartitionVersionGapBackends(partition.getId());
Review Comment:
**[Parallel code paths] `FrontendServiceImpl` auto-partition and
replace-partition paths are missing this treatment.**
`FrontendServiceImpl.createPartition()` (~line 4398) and
`FrontendServiceImpl.replacePartition()` (~line 4715) build
`TOlapTablePartition` objects that are sent to BE and processed through the
same `generate_partition_from()` + `_build_tablet_replica_info()` path. Neither
sets `tabletVersionGapBackends` (or `totalReplicaNum`/`loadRequiredReplicaNum`,
though that's a pre-existing issue).
For newly auto-created partitions, replicas are fresh and unlikely to have
version gaps, so the impact is low. But for completeness and correctness, these
paths should populate the same fields. Consider adding the same block after
building `tPartition` in both locations.
##
be/src/exec/sink/writer/vtablet_writer_v2.cpp:
##
@@ -1015,13 +1026,15 @@ void VTabletWriterV2::_calc_tablets_to_commit() {
Status VTabletWriterV2::_create_commit_info(std::vector&
tablet_commit_infos,
std::shared_ptr
load_stream_map) {
-std::unordered_map failed_tablets;
+// Track per-tablet non-gap success count and failure reasons
+std::unordered_map success_tablets_replica;
+std::unordered_set failed_tablets;
std::unordered_map failed_reason;
load_stream_map->for_each([&](int64_t dst_id, LoadStreamStubs& streams) {
size_t num_success_tablets = 0;
size_t num_failed_tablets = 0;
for (auto [tablet_id, reason] : streams.failed_tablets()) {
-failed_tablets[tablet_id]++;
+failed_tablets.insert(tablet_id);
Review Comment:
**[Minor] `_create_commit_info` only checks tablets in `failed_tablets`.**
If a tablet has zero failures but all succeeding backends are gap-backends, the
quorum check here is skipped. The FE commit-time check will still catch this
(it's authoritative), so this is not a correctness issue, but it means BE won't
fail-fast in this edge case.
This matches the old code's behavior (which also only checked tablets with
failures), so it's not a regression. Just noting for awareness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
dataroaring commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4052398927 /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
github-actions[bot] commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4047350789 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
github-actions[bot] commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4047350396 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4037129841 # BE Regression && UT Coverage Report Increment line coverage `72.50% (29/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.16% (20926/36608) | | Line Coverage | 40.20% (203017/505033) | | Region Coverage | 36.71% (162352/442235) | | Branch Coverage | 37.53% (69469/185078) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4037110016 # BE Regression && UT Coverage Report Increment line coverage `72.50% (29/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.99% (20862/36608) | | Line Coverage | 40.05% (202290/505033) | | Region Coverage | 36.52% (161485/442235) | | Branch Coverage | 37.34% (69109/185078) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4037061800 # BE Regression && UT Coverage Report Increment line coverage `55.00% (22/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.11% (20541/36608) | | Line Coverage | 39.36% (198766/505033) | | Region Coverage | 35.57% (157302/442235) | | Branch Coverage | 36.50% (67562/185078) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4037020479 # BE Regression && UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 54.86% (20077/36594) | | Line Coverage | 38.17% (192590/504504) | | Region Coverage | 34.36% (151734/441654) | | Branch Coverage | 35.32% (65250/184738) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4036514740 TPC-DS: Total hot run time: 153036 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 926d5e73680818bd9387ca605e67521e4a325b72, data reload: false query5 4341632 524 524 query6 330 238 206 206 query7 4210483 269 269 query8 327 240 231 231 query9 8719274927452745 query10 540 393 345 345 query11 7313580655785578 query12 194 130 126 126 query13 1261459 335 335 query14 5780384535873587 query14_12843279728222797 query15 203 193 177 177 query16 1008477 498 477 query17 1088711 623 623 query18 2449457 352 352 query19 235 215 188 188 query20 141 130 131 130 query21 227 144 123 123 query22 4966495247904790 query23 16723 16193 15702 15702 query23_115908 15944 15698 15698 query24 7851169312371237 query24_11255123112661231 query25 578 524 443 443 query26 1240271 152 152 query27 2774479 302 302 query28 4518187418531853 query29 871 585 501 501 query30 315 250 210 210 query31 1366128112141214 query32 87 82 72 72 query33 518 333 288 288 query34 945 912 574 574 query35 655 686 622 622 query36 1094112510351035 query37 132 107 84 84 query38 2947290729312907 query39 888 861 869 861 query39_1852 828 846 828 query40 230 156 142 142 query41 63 60 62 60 query42 310 295 300 295 query43 234 257 220 220 query44 query45 199 190 183 183 query46 879 988 611 611 query47 2109215020402040 query48 309 313 228 228 query49 639 446 405 405 query50 687 275 210 210 query51 4121411540024002 query52 291 296 285 285 query53 292 335 279 279 query54 289 265 263 263 query55 97 85 87 85 query56 319 337 304 304 query57 1373133012661266 query58 310 280 280 280 query59 1389144213141314 query60 343 344 324 324 query61 146 185 151 151 query62 623 596 531 531 query63 311 291 280 280 query64 5041130910141014 query65 query66 1453460 355 355 query67 16498 16423 16381 16381 query68 query69 396 323 297 297 query70 988 970 987 970 query71 347 306 307 306 query72 2899269824292429 query73 538 549 329 329 query74 10067 993897959795 query75 2856276624542454 query76 23041034670 670 query77 368 386 307 307 query78 11232 11547 10701 10701 query79 1135774 594 594 query80 982 633 534 534 query81 542 273 242 242 query82 1301151 116 116 query83 347 265 244 244 query84 253 121 94 94 query85 903 488 530 488 query86 392 331 288 288 query87 3148312529812981 query88 3521269726532653 query89 421 377 346 346 query90 1900185 175 175 query91 172 168 141 141 query92 84 84 78 78 query93 913 838 504 504 query94 519 333 290 290 query95 588 411 325 325 query96 657 519 228 228 query97 2464252523872387 query98 229 211 219 211 query99 10361007901 901 Total cold run time: 234553 ms Total hot run time: 153036 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4036474043 TPC-H: Total hot run time: 27760 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 926d5e73680818bd9387ca605e67521e4a325b72, data reload: false -- Round 1 -- q1 17639 451342934293 q2 q3 10641 847 531 531 q4 4709376 267 267 q5 7903123210351035 q6 221 173 146 146 q7 830 843 674 674 q8 10717 149713181318 q9 6621483447314731 q10 6611193416511651 q11 470 261 249 249 q12 775 575 474 474 q13 18090 296421922192 q14 231 231 212 212 q15 941 823 812 812 q16 757 737 668 668 q17 738 855 447 447 q18 6057542352465246 q19 12071010623 623 q20 495 495 387 387 q21 4659206315381538 q22 374 323 266 266 Total cold run time: 100686 ms Total hot run time: 27760 ms - Round 2, with runtime_filter_mode=off - q1 4738455545914555 q2 q3 3868432438553855 q4 884 1213786 786 q5 4044438243244324 q6 190 181 143 143 q7 1741162215741574 q8 2645274426292629 q9 7558736476137364 q10 3738399336933693 q11 536 463 442 442 q12 505 593 452 452 q13 2684319223832383 q14 284 303 272 272 q15 844 790 790 790 q16 741 771 723 723 q17 1210142213351335 q18 7317678466686668 q19 891 943 901 901 q20 2056220620142014 q21 3986345533123312 q22 483 425 378 378 Total cold run time: 50943 ms Total hot run time: 48593 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4036300384 # BE Regression && UT Coverage Report Increment line coverage `70.00% (28/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 42.52% (15577/36636) | | Line Coverage | 28.51% (144130/505626) | | Region Coverage | 27.15% (120053/442263) | | Branch Coverage | 26.38% (48815/185078) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4036278207 # BE UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/926d5e73680818bd9387ca605e67521e4a325b72_926d5e73680818bd9387ca605e67521e4a325b72/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/926d5e73680818bd9387ca605e67521e4a325b72_926d5e73680818bd9387ca605e67521e4a325b72/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.57% (19652/37386) | | Line Coverage | 36.16% (183185/506572) | | Region Coverage | 32.30% (141512/438087) | | Branch Coverage | 33.45% (61721/184502) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4036249184 # FE UT Coverage Report Increment line coverage ` 59.09% (13/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_926d5e73680818bd9387ca605e67521e4a325b72/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4036021232 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/926d5e73680818bd9387ca605e67521e4a325b72_926d5e73680818bd9387ca605e67521e4a325b72_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/926d5e73680818bd9387ca605e67521e4a325b72_926d5e73680818bd9387ca605e67521e4a325b72_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.45% (1798/2263) | | Line Coverage | 64.69% (32269/49881) | | Region Coverage | 65.67% (16161/24611) | | Branch Coverage | 56.04% (8608/15360) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
sollhui commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4035896056 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
liaoxin01 commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4035830709 /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4021260691 TPC-DS: Total hot run time: 153793 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 926d5e73680818bd9387ca605e67521e4a325b72, data reload: false query5 4330665 533 533 query6 323 243 206 206 query7 4227480 269 269 query8 350 258 244 244 query9 8683279027772777 query10 529 390 367 367 query11 7325593856775677 query12 185 126 128 126 query13 1275482 357 357 query14 6047395737043704 query14_12853289528392839 query15 201 198 179 179 query16 1010501 475 475 query17 1121729 617 617 query18 2536438 344 344 query19 216 215 184 184 query20 144 130 126 126 query21 225 145 124 124 query22 4768492347934793 query23 16696 15972 15682 15682 query23_115708 15883 15789 15789 query24 8200178712971297 query24_11272125012721250 query25 546 476 428 428 query26 1223265 154 154 query27 2771477 285 285 query28 4553188618631863 query29 798 658 473 473 query30 316 242 213 213 query31 1365128912441244 query32 82 76 73 73 query33 505 346 279 279 query34 940 938 576 576 query35 627 671 602 602 query36 10761125957 957 query37 136 97 85 85 query38 2963295428922892 query39 905 858 842 842 query39_1825 833 842 833 query40 235 158 141 141 query41 65 59 59 59 query42 318 289 302 289 query43 250 277 226 226 query44 query45 204 196 189 189 query46 875 1002611 611 query47 2109211820652065 query48 323 320 238 238 query49 634 464 390 390 query50 721 290 231 231 query51 4033408040694069 query52 289 297 281 281 query53 301 342 289 289 query54 300 280 276 276 query55 94 87 83 83 query56 339 322 314 314 query57 1366136912981298 query58 289 286 276 276 query59 1409146513141314 query60 348 356 328 328 query61 157 151 152 151 query62 619 597 535 535 query63 317 283 283 283 query64 49811300979 979 query65 query66 1450474 379 379 query67 16574 16651 16289 16289 query68 query69 395 317 325 317 query70 994 977 939 939 query71 350 318 310 310 query72 2730236026392360 query73 556 565 345 345 query74 9990993697629762 query75 2896279024862486 query76 22801062705 705 query77 390 399 340 340 query78 11269 11520 10751 10751 query79 1142767 609 609 query80 739 676 595 595 query81 503 282 245 245 query82 1359154 123 123 query83 382 279 267 267 query84 261 123 101 101 query85 954 507 451 451 query86 379 300 302 300 query87 3195314229932993 query88 3527268826692669 query89 432 384 354 354 query90 1974178 175 175 query91 168 162 139 139 query92 86 79 74 74 query93 952 836 511 511 query94 460 316 301 301 query95 599 350 315 315 query96 649 521 237 237 query97 2456253024052405 query98 233 222 228 222 query99 994 986 902 902 Total cold run time: 234248 ms Total hot run time: 153793 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected].
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4021231702 TPC-H: Total hot run time: 27992 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 926d5e73680818bd9387ca605e67521e4a325b72, data reload: false -- Round 1 -- q1 17624 455043124312 q2 q3 10643 803 535 535 q4 4685377 255 255 q5 7557119910131013 q6 176 186 148 148 q7 799 857 673 673 q8 9308148713731373 q9 4781495147504750 q10 6237190916561656 q11 485 279 247 247 q12 697 580 481 481 q13 18037 292622012201 q14 240 238 226 226 q15 924 809 833 809 q16 764 738 684 684 q17 732 884 431 431 q18 6017541352505250 q19 11411002651 651 q20 505 505 401 401 q21 4554226216171617 q22 400 337 279 279 Total cold run time: 96306 ms Total hot run time: 27992 ms - Round 2, with runtime_filter_mode=off - q1 4649454045254525 q2 q3 3883434138343834 q4 894 1218786 786 q5 4084440644124406 q6 184 183 142 142 q7 1783170015281528 q8 2462275227742752 q9 7539741973577357 q10 3724426136613661 q11 510 438 412 412 q12 512 602 457 457 q13 2798313623472347 q14 283 293 279 279 q15 841 783 785 783 q16 722 748 702 702 q17 1156143313971397 q18 7238679966036603 q19 926 976 953 953 q20 2065219020332033 q21 4009351734983498 q22 440 437 392 392 Total cold run time: 50702 ms Total hot run time: 48847 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4020986881 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/926d5e73680818bd9387ca605e67521e4a325b72_926d5e73680818bd9387ca605e67521e4a325b72_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/926d5e73680818bd9387ca605e67521e4a325b72_926d5e73680818bd9387ca605e67521e4a325b72_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.35% (1798/2266) | | Line Coverage | 64.55% (32217/49910) | | Region Coverage | 65.41% (16126/24653) | | Branch Coverage | 55.93% (8591/15360) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
sollhui commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-4020871296 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3989439421 # BE Regression && UT Coverage Report Increment line coverage `72.50% (29/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.15% (20900/36573) | | Line Coverage | 40.26% (203308/505019) | | Region Coverage | 36.91% (163110/441903) | | Branch Coverage | 37.56% (69489/185026) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3989244559 # BE Regression && UT Coverage Report Increment line coverage `72.50% (29/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.23% (20930/36573) | | Line Coverage | 40.31% (203560/505019) | | Region Coverage | 36.94% (163232/441903) | | Branch Coverage | 37.62% (69605/185026) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988987239 # BE Regression && UT Coverage Report Increment line coverage `72.50% (29/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.97% (20834/36573) | | Line Coverage | 40.09% (202437/505019) | | Region Coverage | 36.69% (162132/441903) | | Branch Coverage | 37.32% (69058/185026) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988971500 # BE Regression && UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 54.86% (20064/36573) | | Line Coverage | 38.32% (193502/505019) | | Region Coverage | 34.63% (153052/441903) | | Branch Coverage | 35.41% (65511/185026) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988911474 # BE Regression && UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 51.14% (18702/36573) | | Line Coverage | 35.07% (177130/505019) | | Region Coverage | 31.00% (137004/441903) | | Branch Coverage | 32.25% (59674/185026) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988791767 # BE Regression && UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 51.14% (18702/36573) | | Line Coverage | 35.07% (177130/505019) | | Region Coverage | 31.00% (137004/441903) | | Branch Coverage | 32.25% (59674/185026) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988775638 # BE UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.59% (19642/37351) | | Line Coverage | 36.22% (183504/506572) | | Region Coverage | 32.52% (142352/437766) | | Branch Coverage | 33.46% (61722/184462) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988517351 TPC-DS: Total hot run time: 183500 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 481f7e66984b8d3eaccc764717b3d41da85abbac, data reload: false query5 4350651 536 536 query6 336 215 207 207 query7 4206482 277 277 query8 327 244 233 233 query9 8716280727832783 query10 487 394 346 346 query11 17001 17733 17233 17233 query12 213 142 132 132 query13 1277530 361 361 query14 6726332029962996 query14_13007288928852885 query15 237 205 187 187 query16 1156499 452 452 query17 1476733 640 640 query18 3286476 358 358 query19 213 211 181 181 query20 160 141 139 139 query21 247 146 134 134 query22 5356505346034603 query23 17215 16849 16553 16553 query23_116589 16685 16566 16566 query24 7248164312201220 query24_11258125512221222 query25 574 486 437 437 query26 1251272 161 161 query27 2768477 321 321 query28 4483192719211921 query29 818 592 505 505 query30 316 247 213 213 query31 906 733 701 701 query32 79 71 72 71 query33 519 331 282 282 query34 900 915 571 571 query35 653 678 584 584 query36 11161115988 988 query37 136 96 83 83 query38 3048291128172817 query39 896 851 849 849 query39_1841 832 854 832 query40 233 159 134 134 query41 64 60 58 58 query42 104 101 102 101 query43 371 382 349 349 query44 query45 199 186 179 179 query46 873 984 601 601 query47 2119215320672067 query48 311 307 232 232 query49 630 462 381 381 query50 695 283 214 214 query51 4144408240774077 query52 106 112 99 99 query53 293 336 292 292 query54 301 282 256 256 query55 91 83 89 83 query56 310 310 317 310 query57 1377137412701270 query58 283 290 275 275 query59 2601266624852485 query60 371 336 330 330 query61 155 145 150 145 query62 636 594 572 572 query63 318 302 280 280 query64 48421254989 989 query65 query66 1376453 351 351 query67 16469 16351 16254 16254 query68 query69 387 321 294 294 query70 930 981 830 830 query71 339 316 319 316 query72 2861274024352435 query73 547 555 330 330 query74 9978992797599759 query75 2847274924822482 query76 22851044686 686 query77 362 415 315 315 query78 11176 11377 10629 10629 query79 1130815 596 596 query80 1326657 571 571 query81 561 285 264 264 query82 1000157 118 118 query83 333 269 257 257 query84 269 126 105 105 query85 1003571 440 440 query86 421 327 301 301 query87 3131311130173017 query88 3611269226772677 query89 425 376 343 343 query90 1955179 177 177 query91 173 154 133 133 query92 78 77 74 74 query93 1078853 511 511 query94 642 325 306 306 query95 577 404 313 313 query96 633 525 231 231 query97 2479248224022402 query98 227 214 221 214 query99 997 996 902 902 Total cold run time: 254867 ms Total hot run time: 183500 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988483071 TPC-H: Total hot run time: 29183 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 481f7e66984b8d3eaccc764717b3d41da85abbac, data reload: false -- Round 1 -- q1 17674 470444704470 q2 q3 10747 841 530 530 q4 4740364 266 266 q5 8043121910351035 q6 192 180 147 147 q7 800 870 673 673 q8 10523 166613491349 q9 6793510045144514 q10 6876188016571657 q11 479 256 238 238 q12 748 567 477 477 q13 17789 427434343434 q14 229 233 211 211 q15 949 802 788 788 q16 759 723 684 684 q17 709 873 433 433 q18 6007541652795279 q19 1125980 852 852 q20 635 589 424 424 q21 4603197214571457 q22 365 312 265 265 Total cold run time: 100785 ms Total hot run time: 29183 ms - Round 2, with runtime_filter_mode=off - q1 4622461246244612 q2 q3 1785220817651765 q4 871 1212793 793 q5 4074452744214421 q6 191 186 144 144 q7 1762166315861586 q8 2469275725902590 q9 7514727373287273 q10 2711289026252625 q11 528 449 430 430 q12 510 581 451 451 q13 4022445536283628 q14 293 313 289 289 q15 850 811 812 811 q16 737 804 737 737 q17 1237158113291329 q18 7128700867006700 q19 883 890 884 884 q20 2094217920012001 q21 3980356333783378 q22 478 422 388 388 Total cold run time: 48739 ms Total hot run time: 46835 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988183030 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.34% (1797/2265) | | Line Coverage | 64.76% (32185/49698) | | Region Coverage | 65.60% (16104/24550) | | Branch Coverage | 56.09% (8579/15294) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
sollhui commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3988059123 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3984458443 # BE Regression && UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 51.12% (18695/36571) | | Line Coverage | 35.03% (176903/505002) | | Region Coverage | 30.98% (136899/441898) | | Branch Coverage | 32.23% (59625/185024) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3984274543 # BE UT Coverage Report Increment line coverage `37.50% (15/40)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.57% (19635/37349) | | Line Coverage | 36.18% (183278/506555) | | Region Coverage | 32.49% (142239/437761) | | Branch Coverage | 33.43% (61673/184460) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3984175462 # FE UT Coverage Report Increment line coverage ` 59.09% (13/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_481f7e66984b8d3eaccc764717b3d41da85abbac/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3984075156 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/481f7e66984b8d3eaccc764717b3d41da85abbac_481f7e66984b8d3eaccc764717b3d41da85abbac_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.34% (1797/2265) | | Line Coverage | 64.76% (32185/49698) | | Region Coverage | 65.64% (16115/24550) | | Branch Coverage | 56.11% (8582/15294) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3983951404 TPC-DS: Total hot run time: 184100 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 481f7e66984b8d3eaccc764717b3d41da85abbac, data reload: false query5 4779643 504 504 query6 330 227 214 214 query7 4221482 291 291 query8 353 257 242 242 query9 8715278727522752 query10 516 391 336 336 query11 16957 17447 17101 17101 query12 202 127 128 127 query13 1290485 371 371 query14 6731336434463364 query14_12952303329032903 query15 212 197 179 179 query16 1042545 472 472 query17 2048737 653 653 query18 2832476 376 376 query19 217 221 194 194 query20 153 139 134 134 query21 232 143 126 126 query22 5615586049074907 query23 17179 16730 16570 16570 query23_116809 16779 16631 16631 query24 7124160112391239 query24_11234124212371237 query25 568 477 430 430 query26 1234269 201 201 query27 2657476 285 285 query28 4464189219241892 query29 823 570 470 470 query30 310 244 211 211 query31 874 730 649 649 query32 80 79 84 79 query33 503 330 277 277 query34 913 919 562 562 query35 625 676 598 598 query36 10741136993 993 query37 136 102 88 88 query38 2978291228792879 query39 900 894 840 840 query39_1835 825 837 825 query40 233 150 137 137 query41 67 61 58 58 query42 106 102 103 102 query43 361 386 345 345 query44 query45 201 191 183 183 query46 875 976 626 626 query47 2099210220372037 query48 310 317 223 223 query49 636 473 378 378 query50 695 280 217 217 query51 4098407840764076 query52 108 108 99 99 query53 291 341 281 281 query54 290 280 272 272 query55 92 91 87 87 query56 322 340 303 303 query57 1335132512741274 query58 291 279 276 276 query59 2635266525932593 query60 343 345 333 333 query61 154 153 151 151 query62 609 577 552 552 query63 319 278 280 278 query64 4864128010101010 query65 query66 1378459 349 349 query67 16443 16359 16331 16331 query68 query69 395 306 279 279 query70 1014990 960 960 query71 336 311 298 298 query72 2786263923772377 query73 544 556 316 316 query74 10020 995097819781 query75 2825273624822482 query76 23041025673 673 query77 371 380 307 307 query78 11127 11387 10620 10620 query79 1125809 608 608 query80 1342648 534 534 query81 559 285 250 250 query82 992 158 114 114 query83 340 259 245 245 query84 252 111 103 103 query85 899 481 440 440 query86 439 327 306 306 query87 3084310529712971 query88 3579266326442644 query89 421 371 346 346 query90 2011176 170 170 query91 167 162 136 136 query92 79 76 74 74 query93 967 828 509 509 query94 632 316 301 301 query95 590 343 377 343 query96 636 515 233 233 query97 2473250023942394 query98 231 221 216 216 query99 1029991 883 883 Total cold run time: 254992 ms Total hot run time: 184100 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected].
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3983893611 TPC-H: Total hot run time: 28849 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 481f7e66984b8d3eaccc764717b3d41da85abbac, data reload: false -- Round 1 -- q1 17730 448043694369 q2 q3 10732 786 527 527 q4 4713361 255 255 q5 8092121810381038 q6 236 177 146 146 q7 828 854 678 678 q8 10518 146813151315 q9 6147478047594759 q10 6864189016341634 q11 476 270 259 259 q12 747 576 474 474 q13 17795 423034203420 q14 230 227 223 223 q15 987 797 784 784 q16 761 708 670 670 q17 754 905 436 436 q18 5981539752305230 q19 1275971 596 596 q20 508 489 396 396 q21 4588184314031403 q22 339 275 237 237 Total cold run time: 100301 ms Total hot run time: 28849 ms - Round 2, with runtime_filter_mode=off - q1 4452436043724360 q2 q3 1757217417061706 q4 846 1202773 773 q5 4001431443434314 q6 180 171 138 138 q7 1714158614831483 q8 2409261325262526 q9 7907741774017401 q10 2613288624272427 q11 524 436 417 417 q12 501 605 487 487 q13 4080452036273627 q14 289 303 284 284 q15 823 799 806 799 q16 730 755 734 734 q17 1217155613861386 q18 7064682667006700 q19 899 912 861 861 q20 2098218120742074 q21 3999344134253425 q22 465 427 370 370 Total cold run time: 48568 ms Total hot run time: 46292 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
sollhui commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3983634026 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
hello-stephen commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3983457437 # FE UT Coverage Report Increment line coverage ` 59.09% (13/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60953_89f57c7cd6c35f3a2831c4ed6a963b943be71eba/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60953_89f57c7cd6c35f3a2831c4ed6a963b943be71eba/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
doris-robot commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3983355064 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/89f57c7cd6c35f3a2831c4ed6a963b943be71eba_89f57c7cd6c35f3a2831c4ed6a963b943be71eba_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/89f57c7cd6c35f3a2831c4ed6a963b943be71eba_89f57c7cd6c35f3a2831c4ed6a963b943be71eba_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.34% (1797/2265) | | Line Coverage | 64.75% (32181/49698) | | Region Coverage | 65.63% (16113/24550) | | Branch Coverage | 56.13% (8584/15294) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
sollhui commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3983081781 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [enhance](load) exclude version-gap replicas from success counting in quorum success [doris]
Thearas commented on PR #60953: URL: https://github.com/apache/doris/pull/60953#issuecomment-3983080040 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
