Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-20 Thread via GitHub


github-actions[bot] commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2485067044

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-19 Thread via GitHub


doris-robot commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2485025092

   
   
   TPC-H: Total hot run time: 44877 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a203ae133ff46dceb6baf6660269ed008a8ddeb0, 
data reload: false
   
   -- Round 1 --
   q1   17626   754273007300
   q2   2232116711591159
   q3   9966114611501146
   q4   10219   758 772 758
   q5   7599270826752675
   q6   241 145 143 143
   q7   986 630 617 617
   q8   9391238723672367
   q9   6611639863786378
   q10  7044227423442274
   q11  479 279 255 255
   q12  464 216 224 216
   q13  17815   301829992999
   q14  251 213 220 213
   q15  583 529 516 516
   q16  667 581 588 581
   q17  977 597 483 483
   q18  7288663567366635
   q19  1335937 956 937
   q20  2918269426792679
   q21  3915322032293220
   q22  1386134113261326
   Total cold run time: 109993 ms
   Total hot run time: 44877 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   7294721273577212
   q2   329 247 250 247
   q3   3124300929872987
   q4   2062181317981798
   q5   5631568657455686
   q6   222 141 139 139
   q7   2204186118061806
   q8   3296349335263493
   q9   8920891888498849
   q10  3625365135293529
   q11  616 517 512 512
   q12  854 624 662 624
   q13  12251   327433143274
   q14  305 272 277 272
   q15  581 509 523 509
   q16  675 639 645 639
   q17  1849163216261626
   q18  8217737377527373
   q19  1669168715091509
   q20  2143187318991873
   q21  5675545554285428
   q22  644 547 557 547
   Total cold run time: 72186 ms
   Total hot run time: 59932 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-19 Thread via GitHub


doris-robot commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2485036520

   
   
   ClickBench: Total hot run time: 32.65 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit a203ae133ff46dceb6baf6660269ed008a8ddeb0, 
data reload: false
   
   query1   0.050.030.03
   query2   0.070.030.04
   query3   0.230.070.06
   query4   1.620.100.10
   query5   0.420.420.40
   query6   1.180.650.66
   query7   0.020.020.01
   query8   0.040.030.04
   query9   0.600.500.49
   query10  0.570.550.55
   query11  0.140.100.10
   query12  0.140.110.11
   query13  0.610.600.60
   query14  2.742.722.76
   query15  0.910.820.83
   query16  0.380.390.38
   query17  1.041.001.06
   query18  0.200.210.20
   query19  1.911.831.98
   query20  0.020.010.01
   query21  15.37   0.620.58
   query22  2.361.761.99
   query23  17.01   0.980.72
   query24  2.931.362.02
   query25  0.320.060.05
   query26  0.480.140.13
   query27  0.050.050.04
   query28  9.641.111.10
   query29  12.56   3.243.22
   query30  0.240.060.07
   query31  2.850.390.38
   query32  3.250.470.48
   query33  3.053.023.03
   query34  17.21   4.414.48
   query35  4.474.454.46
   query36  0.650.500.47
   query37  0.090.060.06
   query38  0.050.030.04
   query39  0.030.020.02
   query40  0.160.130.13
   query41  0.090.030.03
   query42  0.030.020.02
   query43  0.030.020.03
   Total cold run time: 105.81 s
   Total hot run time: 32.65 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-19 Thread via GitHub


starocean999 merged PR #43449:
URL: https://github.com/apache/doris/pull/43449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-19 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484972393

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


doris-robot commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484887295

   
   
   TPC-H: Total hot run time: 45183 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a203ae133ff46dceb6baf6660269ed008a8ddeb0, 
data reload: false
   
   -- Round 1 --
   q1   17596   758272907290
   q2   2241116811711168
   q3   9962119911351135
   q4   10229   768 732 732
   q5   7620274127312731
   q6   244 146 150 146
   q7   982 632 622 622
   q8   9369236323632363
   q9   6831645664586456
   q10  7074235123072307
   q11  482 248 274 248
   q12  538 216 211 211
   q13  17766   304630563046
   q14  247 218 228 218
   q15  574 521 513 513
   q16  675 587 599 587
   q17  1022499 532 499
   q18  7513687967066706
   q19  1346975 970 970
   q20  2936270126922692
   q21  4049330432053205
   q22  1390135513381338
   Total cold run time: 110686 ms
   Total hot run time: 45183 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   7310724872467246
   q2   334 243 241 241
   q3   2953283328272827
   q4   1994167816711671
   q5   5377547054495449
   q6   220 140 135 135
   q7   2151173817531738
   q8   3306342534503425
   q9   8575853886388538
   q10  3541344834833448
   q11  592 494 501 494
   q12  775 556 647 556
   q13  14364   299530692995
   q14  290 268 268 268
   q15  562 521 523 521
   q16  667 641 638 638
   q17  1812158015691569
   q18  7953749575437495
   q19  1687152314751475
   q20  2074183518461835
   q21  5451524451915191
   q22  618 542 557 542
   Total cold run time: 72606 ms
   Total hot run time: 58297 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484858713

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484848149

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


doris-robot commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484837462

   
   
   TPC-H: Total hot run time: 45129 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a203ae133ff46dceb6baf6660269ed008a8ddeb0, 
data reload: false
   
   -- Round 1 --
   q1   17581   736672737273
   q2   2251116211631162
   q3   9976115211681152
   q4   10216   730 752 730
   q5   7594267427492674
   q6   236 148 144 144
   q7   989 605 607 605
   q8   9385235623572356
   q9   6554640464746404
   q10  7045226823042268
   q11  469 272 259 259
   q12  418 217 217 217
   q13  17792   308830763076
   q14  243 213 230 213
   q15  586 531 524 524
   q16  664 578 587 578
   q17  950 541 555 541
   q18  7307672567966725
   q19  1339106211101062
   q20  2913274426752675
   q21  3985321631483148
   q22  1398134313671343
   Total cold run time: 109891 ms
   Total hot run time: 45129 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   7270719174047191
   q2   339 237 247 237
   q3   3129307230153015
   q4   2060179217901790
   q5   5639568357825683
   q6   223 141 135 135
   q7   2254186317391739
   q8   3410353135313531
   q9   8912888688658865
   q10  3630355735773557
   q11  599 501 489 489
   q12  849 636 633 633
   q13  11224   324433053244
   q14  334 272 274 272
   q15  573 521 512 512
   q16  683 680 643 643
   q17  1845163716261626
   q18  8152781678597816
   q19  1681161814471447
   q20  2118188718461846
   q21  5608560555355535
   q22  624 540 543 540
   Total cold run time: 71156 ms
   Total hot run time: 60346 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484790011

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484753002

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484746491

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484721130

   run buildall
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484655046

   run buildall
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484645753

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484616771

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-18 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2484569047

   > pls resolved conflicts
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-17 Thread via GitHub


LiBinfeng-01 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2481790778

   pls resolved conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-14 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2477958904

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-14 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2477962734

   @morningman PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-14 Thread via GitHub


starocean999 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2477822486

   please resolve the conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-14 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2476149273

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-08 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2465928636

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-08 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2464675490

   run buildall
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-08 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2464062838

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2463912265

   run buildall
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


starocean999 commented on code in PR #43449:
URL: https://github.com/apache/doris/pull/43449#discussion_r1833791286


##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -4006,6 +4008,16 @@ public SetDefaultStorageVaultCommand 
visitSetDefaultStorageVault(SetDefaultStora
 return new 
SetDefaultStorageVaultCommand(stripQuotes(ctx.identifier().getText()));
 }
 
+@Override
+public Object visitRefreshCatalog(RefreshCatalogContext ctx) {
+if (ctx.name != null) {
+String catalogName = ctx.name.getText();
+Map properties = 
visitPropertyClause(ctx.propertyClause());

Review Comment:
   ```suggestion
   Map properties = ctx.propertyClause() != null
   ? Maps.newHashMap(visitPropertyClause(ctx.propertyClause())) 
: Maps.newHashMap();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


starocean999 commented on code in PR #43449:
URL: https://github.com/apache/doris/pull/43449#discussion_r1833794472


##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands.refresh;
+
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.util.Util;
+import org.apache.doris.datasource.CatalogIf;
+import org.apache.doris.datasource.CatalogLog;
+import org.apache.doris.datasource.ExternalCatalog;
+import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.Command;
+import org.apache.doris.nereids.trees.plans.commands.ForwardWithSync;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.persist.OperationType;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.Map;
+
+/**
+ * Manually refresh the catalog metadata.
+ */
+public class RefreshCatalogCommand extends Command implements ForwardWithSync {
+private static final Logger LOG = 
LogManager.getLogger(RefreshCatalogCommand.class);
+private static final String INVALID_CACHE = "invalid_cache";
+private final String catalogName;
+private Map properties;
+private boolean invalidCache = true;
+
+public RefreshCatalogCommand(String catalogName, Map 
properties) {
+super(PlanType.REFRESH_CATALOG_COMMAND);
+this.catalogName = catalogName;
+this.properties = properties;
+}
+
+private void validate() throws AnalysisException {
+Util.checkCatalogAllRules(catalogName);
+if (catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+throw new AnalysisException("Internal catalog name can't be 
refresh.");
+}
+
+if (!Env.getCurrentEnv().getAccessManager().checkCtlPriv(
+ConnectContext.get(), catalogName, PrivPredicate.SHOW)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_CATALOG_ACCESS_DENIED_ERROR,
+PrivPredicate.SHOW.getPrivs().toString(), catalogName);
+}
+
+if (properties != null) {
+// Set to false only if user set the property 
"invalid_cache"="false"
+invalidCache = !(properties.get(INVALID_CACHE) != null && 
properties.get(INVALID_CACHE)
+.equalsIgnoreCase("false"));
+}
+
+}
+
+private void refreshCatalogInternal(CatalogIf catalog) {
+if (!catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+((ExternalCatalog) catalog).onRefreshCache(invalidCache);
+LOG.info("refresh catalog {} with invalidCache {}", catalogName, 
invalidCache);
+}
+}
+
+/**
+ * refresh catalog
+ */
+public void handleRefreshCatalog() throws AnalysisException {
+CatalogIf catalog = 
Env.getCurrentEnv().getCatalogMgr().getCatalogOrAnalysisException(catalogName);
+CatalogLog log = new CatalogLog();
+log.setCatalogId(catalog.getId());
+log.setInvalidCache(isInvalidCache());

Review Comment:
   ```suggestion
   log.setInvalidCache(invalidCache);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


starocean999 commented on code in PR #43449:
URL: https://github.com/apache/doris/pull/43449#discussion_r1833794646


##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands.refresh;
+
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.util.Util;
+import org.apache.doris.datasource.CatalogIf;
+import org.apache.doris.datasource.CatalogLog;
+import org.apache.doris.datasource.ExternalCatalog;
+import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.Command;
+import org.apache.doris.nereids.trees.plans.commands.ForwardWithSync;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.persist.OperationType;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.Map;
+
+/**
+ * Manually refresh the catalog metadata.
+ */
+public class RefreshCatalogCommand extends Command implements ForwardWithSync {
+private static final Logger LOG = 
LogManager.getLogger(RefreshCatalogCommand.class);
+private static final String INVALID_CACHE = "invalid_cache";
+private final String catalogName;
+private Map properties;
+private boolean invalidCache = true;
+
+public RefreshCatalogCommand(String catalogName, Map 
properties) {
+super(PlanType.REFRESH_CATALOG_COMMAND);
+this.catalogName = catalogName;
+this.properties = properties;
+}
+
+private void validate() throws AnalysisException {
+Util.checkCatalogAllRules(catalogName);
+if (catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+throw new AnalysisException("Internal catalog name can't be 
refresh.");
+}
+
+if (!Env.getCurrentEnv().getAccessManager().checkCtlPriv(
+ConnectContext.get(), catalogName, PrivPredicate.SHOW)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_CATALOG_ACCESS_DENIED_ERROR,
+PrivPredicate.SHOW.getPrivs().toString(), catalogName);
+}
+
+if (properties != null) {
+// Set to false only if user set the property 
"invalid_cache"="false"
+invalidCache = !(properties.get(INVALID_CACHE) != null && 
properties.get(INVALID_CACHE)
+.equalsIgnoreCase("false"));
+}
+
+}
+
+private void refreshCatalogInternal(CatalogIf catalog) {
+if (!catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+((ExternalCatalog) catalog).onRefreshCache(invalidCache);
+LOG.info("refresh catalog {} with invalidCache {}", catalogName, 
invalidCache);
+}
+}
+
+/**
+ * refresh catalog
+ */
+public void handleRefreshCatalog() throws AnalysisException {
+CatalogIf catalog = 
Env.getCurrentEnv().getCatalogMgr().getCatalogOrAnalysisException(catalogName);
+CatalogLog log = new CatalogLog();
+log.setCatalogId(catalog.getId());
+log.setInvalidCache(isInvalidCache());
+refreshCatalogInternal(catalog);
+
Env.getCurrentEnv().getEditLog().logCatalogLog(OperationType.OP_REFRESH_CATALOG,
 log);
+}
+
+@Override
+public void run(ConnectContext ctx, StmtExecutor executor) throws 
Exception {
+validate();
+handleRefreshCatalog();
+}
+
+@Override
+public  R accept(PlanVisitor visitor, C context) {
+return visitor.visitRefreshCatalogCommand(this, context);
+}
+
+@Override
+public StmtType stmtType() {
+return StmtType.REFRESH;
+}
+
+/**
+ * return sql expression of this command
+ *
+ * @return sql c

Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


starocean999 commented on code in PR #43449:
URL: https://github.com/apache/doris/pull/43449#discussion_r1833793451


##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands.refresh;
+
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.util.Util;
+import org.apache.doris.datasource.CatalogIf;
+import org.apache.doris.datasource.CatalogLog;
+import org.apache.doris.datasource.ExternalCatalog;
+import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.Command;
+import org.apache.doris.nereids.trees.plans.commands.ForwardWithSync;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.persist.OperationType;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.Map;
+
+/**
+ * Manually refresh the catalog metadata.
+ */
+public class RefreshCatalogCommand extends Command implements ForwardWithSync {
+private static final Logger LOG = 
LogManager.getLogger(RefreshCatalogCommand.class);
+private static final String INVALID_CACHE = "invalid_cache";
+private final String catalogName;
+private Map properties;
+private boolean invalidCache = true;
+
+public RefreshCatalogCommand(String catalogName, Map 
properties) {
+super(PlanType.REFRESH_CATALOG_COMMAND);
+this.catalogName = catalogName;
+this.properties = properties;
+}
+
+private void validate() throws AnalysisException {
+Util.checkCatalogAllRules(catalogName);
+if (catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+throw new AnalysisException("Internal catalog name can't be 
refresh.");
+}
+
+if (!Env.getCurrentEnv().getAccessManager().checkCtlPriv(
+ConnectContext.get(), catalogName, PrivPredicate.SHOW)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_CATALOG_ACCESS_DENIED_ERROR,
+PrivPredicate.SHOW.getPrivs().toString(), catalogName);
+}
+
+if (properties != null) {
+// Set to false only if user set the property 
"invalid_cache"="false"
+invalidCache = !(properties.get(INVALID_CACHE) != null && 
properties.get(INVALID_CACHE)
+.equalsIgnoreCase("false"));
+}
+
+}
+
+private void refreshCatalogInternal(CatalogIf catalog) {
+if (!catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+((ExternalCatalog) catalog).onRefreshCache(invalidCache);
+LOG.info("refresh catalog {} with invalidCache {}", catalogName, 
invalidCache);
+}
+}
+
+/**
+ * refresh catalog
+ */
+public void handleRefreshCatalog() throws AnalysisException {
+CatalogIf catalog = 
Env.getCurrentEnv().getCatalogMgr().getCatalogOrAnalysisException(catalogName);
+CatalogLog log = new CatalogLog();
+log.setCatalogId(catalog.getId());
+log.setInvalidCache(isInvalidCache());
+refreshCatalogInternal(catalog);
+
Env.getCurrentEnv().getEditLog().logCatalogLog(OperationType.OP_REFRESH_CATALOG,
 log);
+}
+
+@Override
+public void run(ConnectContext ctx, StmtExecutor executor) throws 
Exception {
+validate();
+handleRefreshCatalog();
+}
+
+@Override
+public  R accept(PlanVisitor visitor, C context) {
+return visitor.visitRefreshCatalogCommand(this, context);
+}
+
+@Override
+public StmtType stmtType() {
+return StmtType.REFRESH;
+}
+
+/**
+ * return sql expression of this command
+ *
+ * @return sql c

Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


starocean999 commented on code in PR #43449:
URL: https://github.com/apache/doris/pull/43449#discussion_r1833793261


##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/refresh/RefreshCatalogCommand.java:
##
@@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands.refresh;
+
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.util.Util;
+import org.apache.doris.datasource.CatalogIf;
+import org.apache.doris.datasource.CatalogLog;
+import org.apache.doris.datasource.ExternalCatalog;
+import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.Command;
+import org.apache.doris.nereids.trees.plans.commands.ForwardWithSync;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.persist.OperationType;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.Map;
+
+/**
+ * Manually refresh the catalog metadata.
+ */
+public class RefreshCatalogCommand extends Command implements ForwardWithSync {
+private static final Logger LOG = 
LogManager.getLogger(RefreshCatalogCommand.class);
+private static final String INVALID_CACHE = "invalid_cache";
+private final String catalogName;
+private Map properties;
+private boolean invalidCache = true;
+
+public RefreshCatalogCommand(String catalogName, Map 
properties) {
+super(PlanType.REFRESH_CATALOG_COMMAND);
+this.catalogName = catalogName;
+this.properties = properties;
+}
+
+private void validate() throws AnalysisException {
+Util.checkCatalogAllRules(catalogName);
+if (catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+throw new AnalysisException("Internal catalog name can't be 
refresh.");
+}
+
+if (!Env.getCurrentEnv().getAccessManager().checkCtlPriv(
+ConnectContext.get(), catalogName, PrivPredicate.SHOW)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_CATALOG_ACCESS_DENIED_ERROR,
+PrivPredicate.SHOW.getPrivs().toString(), catalogName);
+}
+
+if (properties != null) {
+// Set to false only if user set the property 
"invalid_cache"="false"
+invalidCache = !(properties.get(INVALID_CACHE) != null && 
properties.get(INVALID_CACHE)
+.equalsIgnoreCase("false"));
+}
+
+}
+
+private void refreshCatalogInternal(CatalogIf catalog) {
+if (!catalogName.equals(InternalCatalog.INTERNAL_CATALOG_NAME)) {
+((ExternalCatalog) catalog).onRefreshCache(invalidCache);
+LOG.info("refresh catalog {} with invalidCache {}", catalogName, 
invalidCache);
+}
+}
+
+/**
+ * refresh catalog
+ */
+public void handleRefreshCatalog() throws AnalysisException {
+CatalogIf catalog = 
Env.getCurrentEnv().getCatalogMgr().getCatalogOrAnalysisException(catalogName);
+CatalogLog log = new CatalogLog();
+log.setCatalogId(catalog.getId());
+log.setInvalidCache(isInvalidCache());
+refreshCatalogInternal(catalog);
+
Env.getCurrentEnv().getEditLog().logCatalogLog(OperationType.OP_REFRESH_CATALOG,
 log);
+}
+
+@Override
+public void run(ConnectContext ctx, StmtExecutor executor) throws 
Exception {
+validate();
+handleRefreshCatalog();
+}
+
+@Override
+public  R accept(PlanVisitor visitor, C context) {
+return visitor.visitRefreshCatalogCommand(this, context);
+}
+
+@Override
+public StmtType stmtType() {
+return StmtType.REFRESH;
+}
+
+/**
+ * return sql expression of this command
+ *
+ * @return sql c

Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


github-actions[bot] commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2463880057

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


LiBinfeng-01 commented on code in PR #43449:
URL: https://github.com/apache/doris/pull/43449#discussion_r1833639667


##
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##
@@ -4006,6 +4008,17 @@ public SetDefaultStorageVaultCommand 
visitSetDefaultStorageVault(SetDefaultStora
 return new 
SetDefaultStorageVaultCommand(stripQuotes(ctx.identifier().getText()));
 }
 
+@Override
+public Object visitRefreshCatalog(RefreshCatalogContext ctx) {
+

Review Comment:
   remove this empty line



##
regression-test/suites/external_table_p0/nereids_commands/test_nereids_refresh_catalog.groovy:
##
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_nereids_refresh_catalog", 
"p0,external,mysql,external_docker,external_docker_mysql") {
+String enabled = context.config.otherConfigs.get("enableJdbcTest")
+String externalEnvIp = context.config.otherConfigs.get("externalEnvIp")
+String s3_endpoint = getS3Endpoint()
+String bucket = getS3BucketName()
+String driver_url = 
"https://${bucket}.${s3_endpoint}/regression/jdbc_driver/mysql-connector-java-8.0.25.jar";
+if (enabled != null && enabled.equalsIgnoreCase("true")) {
+String catalog_name = "refresh_catalog_mysql_catalog_nereids";
+String internal_db_name = "regression_test_jdbc_catalog_p0";
+String ex_db_name = "doris_test";
+String mysql_port = context.config.otherConfigs.get("mysql_57_port");
+String inDorisTable = "doris_in_tb_nereids";
+String ex_tb0 = "ex_tb0";
+String new_mysql_db = "new_mysql_db";
+
+sql """create database if not exists ${internal_db_name}; """
+
+sql """drop catalog if exists ${catalog_name} """
+
+   sql """set enable_nereids_planner=true;"""
+   sql """set enable_fallback_to_original_planner=false;"""
+
+sql """create catalog if not exists ${catalog_name} properties(
+"type"="jdbc",
+"user"="root",
+"password"="123456",
+"jdbc_url" = 
"jdbc:mysql://${externalEnvIp}:${mysql_port}/doris_test?useSSL=false",
+"driver_url" = "${driver_url}",
+"driver_class" = "com.mysql.cj.jdbc.Driver"
+);"""
+
+
+
+sql """switch ${catalog_name}"""
+sql """CALL EXECUTE_STMT("${catalog_name}", "drop database if exists 
${new_mysql_db}");"""
+
+qt_sql """show databases;"""
+sql """ use ${ex_db_name}"""
+
+qt_ex_tb0_where """select id from ${ex_tb0} where id = 111;"""
+order_qt_ex_tb0  """ select id, name from ${ex_tb0} order by id; """
+// create database in mysql
+sql """CALL EXECUTE_STMT("${catalog_name}", "create database  
${new_mysql_db} ;");"""
+qt_sql """show databases;"""
+checkNereidsExecute("refresh catalog ${catalog_name}")
+sql "refresh catalog ${catalog_name} ;"

Review Comment:
   can not do it again



##
regression-test/suites/external_table_p0/nereids_commands/test_nereids_refresh_catalog.groovy:
##
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_nereids_refresh_catalog", 
"p0,external,mysql,external_docker,external_docker_mysql") {
+String enabled = context.config.otherConfigs.get("enableJdbcTest")
+String externalEnvIp = context.config.otherConfigs.get("externalEnvIp")
+String s3_endpoint

Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


LiBinfeng-01 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2463879151

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


vinlee19 commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-2463878110

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](Nereids) support refresh catalog command [doris]

2024-11-07 Thread via GitHub


doris-robot commented on PR #43449:
URL: https://github.com/apache/doris/pull/43449#issuecomment-246201

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   ### Check List (For Author)
   
   - Test 
   
   - [ ] Regression test
   - [ ] Unit Test
   - [ ] Manual test (add detailed scripts or steps below)
   - [ ] No need to test or manual test. Explain why:
   - [ ] This is a refactor/code format and no logic has been changed.
   - [ ] Previous test can cover this change.
   - [ ] No code files have been changed.
   - [ ] Other reason 
   
   - Behavior changed:
   
   - [ ] No.
   - [ ] Yes. 
   
   - Does this need documentation?
   
   - [ ] No.
   - [ ] Yes. 
   
   - Release note
   
   
   
   None
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org