Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3997827149 # FE Regression Coverage Report Increment line coverage ` 82.19% (120/146)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3997767845 # BE Regression && UT Coverage Report Increment line coverage `94.49% (240/254)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.62% (26204/36588) | | Line Coverage | 54.38% (274749/505217) | | Region Coverage | 51.59% (228054/442078) | | Branch Coverage | 53.00% (98104/185114) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3997329187 # BE UT Coverage Report Increment line coverage `92.52% (235/254)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.57% (19645/37366) | | Line Coverage | 36.19% (183404/506770) | | Region Coverage | 32.48% (142229/437941) | | Branch Coverage | 33.45% (61728/184550) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3996896653 TPC-DS: Total hot run time: 184380 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2e58cbb02bbef3875ade57e26faab53d4fb3ac3d, data reload: false query5 5036660 517 517 query6 325 223 208 208 query7 4219481 284 284 query8 357 259 244 244 query9 8754279127842784 query10 563 371 368 368 query11 16942 17788 17180 17180 query12 203 134 134 134 query13 1461481 358 358 query14 6751334530583058 query14_12875288829082888 query15 214 209 190 190 query16 1174479 492 479 query17 1502755 637 637 query18 3278526 379 379 query19 215 213 182 182 query20 137 131 128 128 query21 217 144 121 121 query22 5677574953365336 query23 17243 16752 16362 16362 query23_116729 16657 16624 16624 query24 7168163612421242 query24_11224123012281228 query25 574 490 422 422 query26 1240269 147 147 query27 2774489 292 292 query28 4474190918891889 query29 812 600 509 509 query30 319 252 211 211 query31 894 738 674 674 query32 85 76 75 75 query33 530 341 292 292 query34 932 903 578 578 query35 643 687 593 593 query36 1082111910231023 query37 146 108 91 91 query38 2932298728612861 query39 901 869 848 848 query39_1836 820 830 820 query40 243 151 144 144 query41 69 65 65 65 query42 113 104 104 104 query43 383 383 367 367 query44 query45 200 192 187 187 query46 888 1013638 638 query47 2111211820392039 query48 320 323 280 280 query49 626 464 375 375 query50 692 269 234 234 query51 4074433840894089 query52 107 106 99 99 query53 286 341 282 282 query54 305 265 260 260 query55 88 87 79 79 query56 318 304 318 304 query57 1376132412571257 query58 314 277 278 277 query59 2577262725192519 query60 336 334 324 324 query61 141 145 144 144 query62 628 588 543 543 query63 309 279 276 276 query64 48211240969 969 query65 query66 1426455 348 348 query67 16286 16469 16252 16252 query68 query69 394 307 294 294 query70 968 977 979 977 query71 342 308 297 297 query72 2762264524622462 query73 543 563 323 323 query74 9961992997609760 query75 2864273724632463 query76 23101026691 691 query77 371 387 318 318 query78 11177 11527 10706 10706 query79 3088817 616 616 query80 1774624 523 523 query81 575 288 247 247 query82 1004150 120 120 query83 344 253 240 240 query84 253 119 102 102 query85 911 465 424 424 query86 490 328 300 300 query87 3122308830373037 query88 3520267526642664 query89 433 381 340 340 query90 2005177 172 172 query91 161 150 129 129 query92 81 77 70 70 query93 1856864 503 503 query94 647 327 297 297 query95 590 328 370 328 query96 633 522 225 225 query97 2494251424132413 query98 241 213 220 213 query99 988 993 924 924 Total cold run time: 258805 ms Total hot run time: 184380 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected].
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3996840536 TPC-H: Total hot run time: 29393 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2e58cbb02bbef3875ade57e26faab53d4fb3ac3d, data reload: false -- Round 1 -- q1 17648 450343224322 q2 q3 10735 855 534 534 q4 4736359 250 250 q5 8167120410211021 q6 226 174 148 148 q7 842 859 707 707 q8 10827 147713461346 q9 6750477647804776 q10 6876188816451645 q11 450 271 266 266 q12 760 570 467 467 q13 17787 423534323432 q14 242 232 214 214 q15 950 797 794 794 q16 745 727 679 679 q17 733 859 444 444 q18 6608534852615261 q19 11811057863 863 q20 572 546 443 443 q21 4627208214971497 q22 371 322 284 284 Total cold run time: 101833 ms Total hot run time: 29393 ms - Round 2, with runtime_filter_mode=off - q1 4704454745294529 q2 q3 1800220617721772 q4 855 1186796 796 q5 4065440543664366 q6 183 173 138 138 q7 1772167715451545 q8 2501274426392639 q9 7610766674097409 q10 2642294626822682 q11 582 435 417 417 q12 495 586 453 453 q13 3976441335233523 q14 280 298 270 270 q15 864 817 812 812 q16 738 778 713 713 q17 1217151813211321 q18 7279671066676667 q19 910 895 870 870 q20 2109219219791979 q21 40403563 q22 458 438 367 367 Total cold run time: 49080 ms Total hot run time: 46601 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3996310717 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_2e58cbb02bbef3875ade57e26faab53d4fb3ac3d_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.35% (1798/2266) | | Line Coverage | 64.53% (32206/49910) | | Region Coverage | 65.44% (16132/24653) | | Branch Coverage | 55.97% (8597/15360) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3996115709 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
github-actions[bot] commented on code in PR #60727:
URL: https://github.com/apache/doris/pull/60727#discussion_r2881626712
##
be/src/olap/tablet_meta.cpp:
##
@@ -82,6 +82,14 @@ bvar::Window>
g_contains_agg_with_cache_if_eligible_full_h
"g_contains_agg_with_cache_if_eligible_full_hit_1m",
&g_contains_agg_with_cache_if_eligible_full_hit, 60);
+namespace {
+
+inline PatternTypePB to_pattern_type_pb(TPatternType::type pattern_type) {
+return static_cast(pattern_type);
Review Comment:
**[Moderate] Fragile enum conversion via static_cast**
This `static_cast` relies on `TPatternType` and `PatternTypePB` having
identical ordinal values, which is currently true but fragile. The previous
`switch` approach provided compiler warnings (`-Wswitch`) for missing cases.
Consider adding compile-time guards:
```cpp
static_assert(static_cast(TPatternType::MATCH_NAME) ==
static_cast(PatternTypePB::MATCH_NAME));
static_assert(static_cast(TPatternType::MATCH_NAME_GLOB) ==
static_cast(PatternTypePB::MATCH_NAME_GLOB));
static_assert(static_cast(TPatternType::SKIP_NAME) ==
static_cast(PatternTypePB::SKIP_NAME));
static_assert(static_cast(TPatternType::SKIP_NAME_GLOB) ==
static_cast(PatternTypePB::SKIP_NAME_GLOB));
```
Alternatively, restore a `switch` statement with a `default` case that
returns an error or logs a warning.
##
be/src/vec/common/variant_util.cpp:
##
@@ -103,162 +105,126 @@
namespace doris::vectorized::variant_util {
#include "common/compile_check_begin.h"
-inline void append_escaped_regex_char(std::string* regex_output, char ch) {
-switch (ch) {
-case '.':
-case '^':
-case '$':
-case '+':
-case '*':
-case '?':
-case '(':
-case ')':
-case '|':
-case '{':
-case '}':
-case '[':
-case ']':
-case '\\':
-regex_output->push_back('\\');
-regex_output->push_back(ch);
-break;
-default:
-regex_output->push_back(ch);
-break;
-}
-}
+// Enable RE2::Set when glob pattern count is large enough to amortize setup
cost.
+constexpr size_t kSkipRe2SetThreshold = 32;
-// Small LRU to cap compiled glob patterns
-constexpr size_t kGlobRegexCacheCapacity = 256;
+Status build_compiled_skip_patterns(
+const std::vector>&
skip_patterns,
+bool enable_re2_set, ParseConfig* parse_config) {
+if (parse_config == nullptr) {
+return Status::InvalidArgument("ParseConfig for compiled skip patterns
is null");
+}
-struct GlobRegexCacheEntry {
-std::shared_ptr re2;
-std::list::iterator lru_it;
-};
+parse_config->skip_exact_patterns.clear();
+parse_config->compiled_skip_glob_regexes.clear();
+parse_config->compiled_skip_glob_regex_set.reset();
+parse_config->compiled_skip_use_re2_set = false;
+parse_config->skip_exact_patterns.reserve(skip_patterns.size());
-static std::mutex g_glob_regex_cache_mutex;
-static std::list g_glob_regex_cache_lru;
-static std::unordered_map g_glob_regex_cache;
+std::vector glob_regex_patterns;
+glob_regex_patterns.reserve(skip_patterns.size());
+for (const auto& [pattern, pt] : skip_patterns) {
+if (is_skip_exact_path_pattern_type(pt)) {
+parse_config->skip_exact_patterns.insert(pattern);
+continue;
+}
+if (!is_skip_glob_path_pattern_type(pt)) {
+continue;
+}
-std::shared_ptr get_or_build_re2(const std::string& glob_pattern) {
-{
-std::lock_guard lock(g_glob_regex_cache_mutex);
-auto it = g_glob_regex_cache.find(glob_pattern);
-if (it != g_glob_regex_cache.end()) {
-g_glob_regex_cache_lru.splice(g_glob_regex_cache_lru.begin(),
g_glob_regex_cache_lru,
- it->second.lru_it);
-return it->second.re2;
+std::string regex_pattern;
+auto st = glob_to_regex(pattern, ®ex_pattern);
+if (!st.ok()) {
+continue;
}
+glob_regex_patterns.emplace_back(std::move(regex_pattern));
}
-std::string regex_pattern;
-Status st = glob_to_regex(glob_pattern, ®ex_pattern);
-if (!st.ok()) {
-return nullptr;
-}
-auto compiled = std::make_shared(regex_pattern);
-if (!compiled->ok()) {
-return nullptr;
+
+if (glob_regex_patterns.empty()) {
+return Status::OK();
}
-{
-std::lock_guard lock(g_glob_regex_cache_mutex);
-auto it = g_glob_regex_cache.find(glob_pattern);
-if (it != g_glob_regex_cache.end()) {
-g_glob_regex_cache_lru.splice(g_glob_regex_cache_lru.begin(),
g_glob_regex_cache_lru,
- it->second.lru_it);
-return it->second.re2;
+
+if (enable_re2_set && glob_regex_patterns.size() >= kSkipRe2SetThreshold) {
+RE2::Options options;
+auto set = std::make_unique(options, RE2::ANCH
Re: [PR] [featrue](Variant) SKIP pattern [doris]
eldenmoon commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3995034021 /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on code in PR #60727:
URL: https://github.com/apache/doris/pull/60727#discussion_r2870148877
##
be/src/vec/common/variant_util.cpp:
##
@@ -130,15 +132,36 @@ inline void append_escaped_regex_char(std::string*
regex_output, char ch) {
// Small LRU to cap compiled glob patterns
constexpr size_t kGlobRegexCacheCapacity = 256;
+constexpr size_t kSkipRe2SetThreshold = 32;
+
+struct TransparentStringHash {
+using is_transparent = void;
+size_t operator()(std::string_view s) const { return
std::hash {}(s); }
+size_t operator()(const std::string& s) const {
+return std::hash {}(std::string_view(s));
+}
+};
+
+struct TransparentStringEq {
+using is_transparent = void;
+bool operator()(std::string_view lhs, std::string_view rhs) const { return
lhs == rhs; }
+};
+
+struct CompiledSkipMatcher {
Review Comment:
内联这个结构到了 ParseConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on code in PR #60727:
URL: https://github.com/apache/doris/pull/60727#discussion_r2870146769
##
be/src/vec/common/variant_util.cpp:
##
@@ -130,15 +132,36 @@ inline void append_escaped_regex_char(std::string*
regex_output, char ch) {
// Small LRU to cap compiled glob patterns
constexpr size_t kGlobRegexCacheCapacity = 256;
+constexpr size_t kSkipRe2SetThreshold = 32;
+
+struct TransparentStringHash {
+using is_transparent = void;
+size_t operator()(std::string_view s) const { return
std::hash {}(s); }
+size_t operator()(const std::string& s) const {
+return std::hash {}(std::string_view(s));
+}
+};
+
+struct TransparentStringEq {
+using is_transparent = void;
+bool operator()(std::string_view lhs, std::string_view rhs) const { return
lhs == rhs; }
+};
+
+struct CompiledSkipMatcher {
+phmap::flat_hash_set exact_patterns;
+std::vector> glob_regexes;
+std::unique_ptr glob_regex_set;
+bool use_re2_set = false;
+};
struct GlobRegexCacheEntry {
Review Comment:
已新增新的util文件
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on code in PR #60727:
URL: https://github.com/apache/doris/pull/60727#discussion_r2870145168
##
be/src/vec/common/variant_util.cpp:
##
@@ -130,15 +132,36 @@ inline void append_escaped_regex_char(std::string*
regex_output, char ch) {
// Small LRU to cap compiled glob patterns
constexpr size_t kGlobRegexCacheCapacity = 256;
+constexpr size_t kSkipRe2SetThreshold = 32;
+
+struct TransparentStringHash {
+using is_transparent = void;
+size_t operator()(std::string_view s) const { return
std::hash {}(s); }
+size_t operator()(const std::string& s) const {
+return std::hash {}(std::string_view(s));
+}
+};
+
+struct TransparentStringEq {
+using is_transparent = void;
+bool operator()(std::string_view lhs, std::string_view rhs) const { return
lhs == rhs; }
+};
+
+struct CompiledSkipMatcher {
+phmap::flat_hash_set exact_patterns;
+std::vector> glob_regexes;
+std::unique_ptr glob_regex_set;
+bool use_re2_set = false;
+};
struct GlobRegexCacheEntry {
std::shared_ptr re2;
std::list::iterator lru_it;
};
-static std::mutex g_glob_regex_cache_mutex;
-static std::list g_glob_regex_cache_lru;
-static std::unordered_map g_glob_regex_cache;
+std::mutex g_glob_regex_cache_mutex;
+std::list g_glob_regex_cache_lru;
+std::unordered_map g_glob_regex_cache;
Review Comment:
已删除这些结构，新增新的util文件
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on code in PR #60727:
URL: https://github.com/apache/doris/pull/60727#discussion_r2870144546
##
regression-test/suites/variant_p0/predefine/test_schema_template_skip.groovy:
##
@@ -0,0 +1,180 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_schema_template_skip", "p0") {
+sql """ set describe_extend_variant_column = true """
+sql """ set default_variant_enable_typed_paths_to_sparse = false """
+sql """ set default_variant_enable_doc_mode = false """
Review Comment:
支持的，已添加 doc mode 的回归测试
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3976304851 # BE Regression && UT Coverage Report Increment line coverage `94.51% (241/255)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_07ee3f27fd6fb8c2421b5e6a998945deaced4844_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_07ee3f27fd6fb8c2421b5e6a998945deaced4844_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.63% (26157/36516) | | Line Coverage | 54.44% (274439/504101) | | Region Coverage | 51.79% (228414/441040) | | Branch Coverage | 53.17% (98135/184566) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3976129792 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3970327923 run vault_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3970296563 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3970293171 run check_coverage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3970292422 run cloud_p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3970291542 run cloudut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3970291188 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
Copilot commented on code in PR #60727:
URL: https://github.com/apache/doris/pull/60727#discussion_r2851970966
##
fe/fe-common/src/main/java/org/apache/doris/catalog/VariantField.java:
##
@@ -114,7 +136,9 @@ public boolean equals(Object other) {
return false;
}
VariantField otherFiled = (VariantField) other;
-return otherFiled.pattern.equals(pattern) &&
otherFiled.type.equals(type);
+return otherFiled.pattern.equals(pattern)
+&& otherFiled.type.equals(type)
+&& otherFiled.patternType == patternType;
}
Review Comment:
The equals method has been overridden to include patternType, but the
hashCode method is missing. This violates the equals-hashCode contract in Java.
When two objects are equal according to equals(), they must have the same hash
code. This can lead to incorrect behavior when VariantField objects are used in
hash-based collections like HashMap or HashSet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3956479649 # FE Regression Coverage Report Increment line coverage ` 80.56% (116/144)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3956445845 # BE Regression && UT Coverage Report Increment line coverage `89.07% (163/183)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.14% (20863/36509) | | Line Coverage | 40.19% (202477/503819) | | Region Coverage | 36.85% (162280/440421) | | Branch Coverage | 37.50% (69124/184311) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3956401950 # FE Regression Coverage Report Increment line coverage ` 80.56% (116/144)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3956373530 # BE Regression && UT Coverage Report Increment line coverage `89.07% (163/183)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.81% (20740/36509) | | Line Coverage | 39.90% (201018/503819) | | Region Coverage | 36.51% (160790/440421) | | Branch Coverage | 37.16% (68490/184311) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3955666803 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3955666166 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3955257710 # FE Regression Coverage Report Increment line coverage ` 51.39% (74/144)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3955216816 # BE Regression && UT Coverage Report Increment line coverage `89.07% (163/183)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 56.81% (20740/36509) | | Line Coverage | 39.90% (201018/503819) | | Region Coverage | 36.51% (160790/440421) | | Branch Coverage | 37.16% (68490/184311) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3954989568 # BE UT Coverage Report Increment line coverage `89.07% (163/183)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/83cad20ad01b933909e5fc21c7c16d0cf241347f_83cad20ad01b933909e5fc21c7c16d0cf241347f/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/83cad20ad01b933909e5fc21c7c16d0cf241347f_83cad20ad01b933909e5fc21c7c16d0cf241347f/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.54% (19586/37276) | | Line Coverage | 36.15% (182664/505319) | | Region Coverage | 32.50% (141769/436253) | | Branch Coverage | 33.45% (61457/183725) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3954505031 TPC-DS: Total hot run time: 184214 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 83cad20ad01b933909e5fc21c7c16d0cf241347f, data reload: false query5 4427627 512 512 query6 353 217 205 205 query7 4203465 269 269 query8 348 234 225 225 query9 8757271927152715 query10 496 372 363 363 query11 16977 17530 17230 17230 query12 182 133 127 127 query13 1398481 376 376 query14 6464334330833083 query14_12997307129522952 query15 240 198 188 188 query16 966 516 483 483 query17 1202752 673 673 query18 2694464 460 460 query19 282 247 201 201 query20 145 137 131 131 query21 214 146 125 125 query22 5621520750025002 query23 17148 16801 16659 16659 query23_116719 16726 16627 16627 query24 7170161112271227 query24_11231124212281228 query25 572 478 429 429 query26 843 268 154 154 query27 2754480 288 288 query28 4468187118801871 query29 806 582 493 493 query30 316 246 214 214 query31 874 735 649 649 query32 89 78 70 70 query33 523 354 304 304 query34 909 913 576 576 query35 635 663 597 597 query36 11171104968 968 query37 142 100 82 82 query38 2971295928912891 query39 895 874 845 845 query39_1819 831 827 827 query40 228 153 138 138 query41 68 66 63 63 query42 105 105 101 101 query43 372 382 357 357 query44 query45 196 190 187 187 query46 879 973 598 598 query47 2115216120352035 query48 304 306 228 228 query49 635 464 367 367 query50 674 273 228 228 query51 4077414840534053 query52 107 106 98 98 query53 285 331 280 280 query54 289 254 252 252 query55 89 87 80 80 query56 306 316 291 291 query57 1345135312751275 query58 301 293 280 280 query59 2560263324932493 query60 335 336 323 323 query61 141 143 144 143 query62 612 584 554 554 query63 322 274 270 270 query64 43181266988 988 query65 query66 1372452 364 364 query67 16409 16405 16330 16330 query68 query69 407 310 289 289 query70 995 949 895 895 query71 338 305 288 288 query72 2754268324482448 query73 530 538 323 323 query74 10040 992897699769 query75 2855274624702470 query76 23061015658 658 query77 361 369 310 310 query78 11266 11348 10691 10691 query79 3145767 588 588 query80 1703626 542 542 query81 575 297 244 244 query82 994 144 126 126 query83 327 259 260 259 query84 243 135 96 96 query85 884 503 459 459 query86 420 302 305 302 query87 3143312829592959 query88 3542266026452645 query89 420 369 341 341 query90 1963179 172 172 query91 166 156 132 132 query92 76 72 72 72 query93 1203826 514 514 query94 637 304 293 293 query95 582 350 328 328 query96 645 515 230 230 query97 2443253524572457 query98 239 219 210 210 query99 10201002931 931 Total cold run time: 255175 ms Total hot run time: 184214 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3954454312 TPC-H: Total hot run time: 29084 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 83cad20ad01b933909e5fc21c7c16d0cf241347f, data reload: false -- Round 1 -- q1 17647 450643034303 q2 q3 10635 795 538 538 q4 4700363 258 258 q5 120710371037 q6 208 174 148 148 q7 825 851 698 698 q8 10501 149613451345 q9 6088482047564756 q10 6865188716481648 q11 481 258 236 236 q12 744 570 469 469 q13 17803 424234483448 q14 237 232 216 216 q15 944 797 793 793 q16 762 735 683 683 q17 752 873 418 418 q18 5990542952035203 q19 1122973 624 624 q20 505 500 543 500 q21 4646199014841484 q22 380 305 279 279 Total cold run time: 99612 ms Total hot run time: 29084 ms - Round 2, with runtime_filter_mode=off - q1 4688454746644547 q2 q3 1879224717951795 q4 851 1188787 787 q5 4043441043594359 q6 189 178 141 141 q7 1768166715311531 q8 2530277825952595 q9 7573736374927363 q10 2669281824012401 q11 502 437 409 409 q12 523 681 479 479 q13 3954460436003600 q14 294 289 267 267 q15 848 832 829 829 q16 774 761 737 737 q17 1269160413061306 q18 7233701465946594 q19 876 864 868 864 q20 2127217120342034 q21 3935350332773277 q22 483 477 412 412 Total cold run time: 49008 ms Total hot run time: 46327 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3954336716 # FE UT Coverage Report Increment line coverage ` 72.92% (105/144)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_83cad20ad01b933909e5fc21c7c16d0cf241347f/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3954160338 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/83cad20ad01b933909e5fc21c7c16d0cf241347f_83cad20ad01b933909e5fc21c7c16d0cf241347f_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/83cad20ad01b933909e5fc21c7c16d0cf241347f_83cad20ad01b933909e5fc21c7c16d0cf241347f_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.33% (1796/2264) | | Line Coverage | 64.83% (32023/49393) | | Region Coverage | 65.51% (15974/24383) | | Branch Coverage | 56.01% (8496/15168) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3953936409 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3953848629 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3953769587 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.33% (1796/2264) | | Line Coverage | 64.79% (32003/49393) | | Region Coverage | 65.48% (15965/24383) | | Branch Coverage | 56.01% (8495/15168) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3953517094 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3952754684 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3952691377 # BE UT Coverage Report Increment line coverage `89.25% (166/186)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.55% (19586/37268) | | Line Coverage | 36.16% (182686/505179) | | Region Coverage | 32.50% (141759/436126) | | Branch Coverage | 33.47% (61468/183668) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3951406278 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_75b1d54e01ad43e9e0228d8dad39f2dd20ad0a79_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.33% (1796/2264) | | Line Coverage | 64.82% (32018/49393) | | Region Coverage | 65.55% (15984/24383) | | Branch Coverage | 55.99% (8493/15168) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3951176252 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3950910699 # FE Regression Coverage Report Increment line coverage ` 81.12% (116/143)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_6d3868f135510acf34681c54c30ac9b91b1ee7b2_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_6d3868f135510acf34681c54c30ac9b91b1ee7b2_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3950837842 # BE Regression && UT Coverage Report Increment line coverage `92.39% (170/184)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_6d3868f135510acf34681c54c30ac9b91b1ee7b2_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_6d3868f135510acf34681c54c30ac9b91b1ee7b2_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.27% (26746/36501) | | Line Coverage | 56.52% (284690/503677) | | Region Coverage | 53.95% (237541/440278) | | Branch Coverage | 55.64% (102514/184252) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3950477910 # BE UT Coverage Report Increment line coverage `89.13% (164/184)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6d3868f135510acf34681c54c30ac9b91b1ee7b2_6d3868f135510acf34681c54c30ac9b91b1ee7b2/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6d3868f135510acf34681c54c30ac9b91b1ee7b2_6d3868f135510acf34681c54c30ac9b91b1ee7b2/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.52% (19561/37243) | | Line Coverage | 36.13% (182429/504917) | | Region Coverage | 32.48% (141600/435894) | | Branch Coverage | 33.44% (61384/183548) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3950025884 TPC-DS: Total hot run time: 184106 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6d3868f135510acf34681c54c30ac9b91b1ee7b2, data reload: false query5 4350651 510 510 query6 325 216 196 196 query7 4198476 269 269 query8 320 249 230 230 query9 8695277527152715 query10 505 375 349 349 query11 17021 17596 17468 17468 query12 191 134 124 124 query13 2674465 337 337 query14 6465336130463046 query14_13015291929712919 query15 223 199 183 183 query16 1231528 512 512 query17 1169777 633 633 query18 2802483 363 363 query19 222 222 199 199 query20 147 136 134 134 query21 219 157 120 120 query22 5017480946864686 query23 17210 16846 16610 16610 query23_116628 16663 16794 16663 query24 7190165412211221 query24_11223124112441241 query25 554 478 431 431 query26 1236263 158 158 query27 2771485 300 300 query28 4498188518761876 query29 824 589 492 492 query30 311 252 213 213 query31 889 750 640 640 query32 85 73 73 73 query33 537 364 289 289 query34 948 929 576 576 query35 646 688 597 597 query36 10741096995 995 query37 140 99 86 86 query38 2951293628832883 query39 873 886 920 886 query39_1825 844 805 805 query40 238 160 138 138 query41 66 65 63 63 query42 107 102 103 102 query43 385 397 352 352 query44 query45 200 193 183 183 query46 916 1047605 605 query47 2102210220432043 query48 316 336 228 228 query49 626 467 380 380 query50 713 291 215 215 query51 4073404640284028 query52 109 109 105 105 query53 302 339 277 277 query54 304 267 253 253 query55 89 84 85 84 query56 313 304 323 304 query57 1339131712781278 query58 287 280 264 264 query59 2583273725912591 query60 325 336 309 309 query61 148 147 145 145 query62 629 589 542 542 query63 328 278 276 276 query64 4870129210391039 query65 query66 1464449 342 342 query67 16353 16409 16211 16211 query68 query69 410 306 281 281 query70 997 987 968 968 query71 351 300 287 287 query72 2727261324372437 query73 541 570 349 349 query74 9988992297269726 query75 2867274424742474 query76 22931054698 698 query77 363 399 304 304 query78 11186 11390 10689 10689 query79 3168805 616 616 query80 1718627 565 565 query81 573 280 248 248 query82 956 157 114 114 query83 329 259 240 240 query84 257 119 96 96 query85 915 470 426 426 query86 422 306 283 283 query87 3137310629762976 query88 3604267826542654 query89 425 374 345 345 query90 1959176 170 170 query91 160 160 132 132 query92 76 74 72 72 query93 1269848 512 512 query94 633 319 285 285 query95 585 334 375 334 query96 638 546 235 235 query97 2439247824372437 query98 237 211 208 208 query99 10001010933 933 Total cold run time: 257684 ms Total hot run time: 184106 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected].
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3949968171 TPC-H: Total hot run time: 29277 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6d3868f135510acf34681c54c30ac9b91b1ee7b2, data reload: false -- Round 1 -- q1 17596 452943794379 q2 q3 10702 782 523 523 q4 4731361 256 256 q5 8004120210141014 q6 209 175 146 146 q7 818 846 671 671 q8 10645 148513631363 q9 6816484547854785 q10 6894188916501650 q11 446 251 246 246 q12 756 572 465 465 q13 17776 433434183418 q14 239 234 224 224 q15 949 812 810 810 q16 741 719 676 676 q17 729 881 433 433 q18 6241543252785278 q19 1166994 807 807 q20 648 568 434 434 q21 4624189114421442 q22 373 307 257 257 Total cold run time: 101103 ms Total hot run time: 29277 ms - Round 2, with runtime_filter_mode=off - q1 4815467645604560 q2 q3 1826220718201820 q4 889 1202791 791 q5 4049448743734373 q6 182 177 141 141 q7 1877165215581558 q8 2507276126762676 q9 7537748873237323 q10 2608283725502550 q11 511 428 430 428 q12 500 591 436 436 q13 4096442336563656 q14 286 301 274 274 q15 845 813 807 807 q16 896 787 708 708 q17 1182153813381338 q18 7202677666416641 q19 906 871 934 871 q20 2074214820792079 q21 4032352833743374 q22 470 478 399 399 Total cold run time: 49290 ms Total hot run time: 46803 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3949579483 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6d3868f135510acf34681c54c30ac9b91b1ee7b2_6d3868f135510acf34681c54c30ac9b91b1ee7b2_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6d3868f135510acf34681c54c30ac9b91b1ee7b2_6d3868f135510acf34681c54c30ac9b91b1ee7b2_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.33% (1796/2264) | | Line Coverage | 64.80% (32006/49393) | | Region Coverage | 65.52% (15975/24383) | | Branch Coverage | 56.01% (8495/15168) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3949318806 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3901294678 # FE Regression Coverage Report Increment line coverage ` 69.23% (99/143)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3901277705 # BE Regression && UT Coverage Report Increment line coverage `89.75% (254/283)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.78% (26069/36318) | | Line Coverage | 54.46% (273009/501261) | | Region Coverage | 51.93% (227276/437663) | | Branch Coverage | 53.37% (97569/182802) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3900887702 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3899295624 # FE Regression Coverage Report Increment line coverage ` 81.12% (116/143)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3899253807 # BE Regression && UT Coverage Report Increment line coverage `89.75% (254/283)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.68% (26034/36318) | | Line Coverage | 54.37% (272524/501261) | | Region Coverage | 51.83% (226837/437663) | | Branch Coverage | 53.26% (97369/182802) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3898876987 # BE UT Coverage Report Increment line coverage `91.40% (287/314)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/288b22da667f3b2ad306f9989af458f6cde0a63c_288b22da667f3b2ad306f9989af458f6cde0a63c/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/288b22da667f3b2ad306f9989af458f6cde0a63c_288b22da667f3b2ad306f9989af458f6cde0a63c/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.71% (19538/37065) | | Line Coverage | 36.28% (182309/502541) | | Region Coverage | 32.64% (141433/433296) | | Branch Coverage | 33.69% (61346/182108) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3898466121 TPC-DS: Total hot run time: 183976 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 288b22da667f3b2ad306f9989af458f6cde0a63c, data reload: false query5 4783657 550 550 query6 353 229 214 214 query7 4224484 276 276 query8 343 247 239 239 query9 8755276927462746 query10 490 379 346 346 query11 17027 17426 17247 17247 query12 183 139 126 126 query13 1274489 374 374 query14 6639339830653065 query14_12929296228662866 query15 213 256 243 243 query16 4279525 447 447 query17 1194779 626 626 query18 2700510 355 355 query19 214 216 191 191 query20 143 142 142 142 query21 262 154 121 121 query22 5400482748454827 query23 17244 16902 16533 16533 query23_116704 17155 16702 16702 query24 7195164412271227 query24_11228124612501246 query25 578 474 430 430 query26 1205267 154 154 query27 2771476 293 293 query28 4431186318701863 query29 735 551 460 460 query30 315 247 209 209 query31 852 739 656 656 query32 80 76 68 68 query33 505 338 283 283 query34 919 910 554 554 query35 654 677 592 592 query36 1083110710261026 query37 144 101 81 81 query38 2952294728922892 query39 876 878 850 850 query39_1821 824 827 824 query40 225 146 131 131 query41 64 58 58 58 query42 102 99 100 99 query43 371 374 350 350 query44 query45 208 196 178 178 query46 867 986 613 613 query47 2111210520642064 query48 313 312 237 237 query49 641 473 372 372 query50 682 281 222 222 query51 4111415041284128 query52 107 103 95 95 query53 289 331 274 274 query54 289 271 259 259 query55 90 81 87 81 query56 316 301 300 300 query57 1359132812591259 query58 286 271 291 271 query59 2611266425882588 query60 358 331 321 321 query61 173 147 147 147 query62 614 602 551 551 query63 306 272 287 272 query64 45241246985 985 query65 query66 1330430 339 339 query67 16503 16429 16471 16429 query68 query69 400 291 281 281 query70 1019989 953 953 query71 341 310 306 306 query72 2756265523752375 query73 538 544 317 317 query74 9990993197449744 query75 2833273624492449 query76 18541027693 693 query77 361 387 300 300 query78 11258 11430 10677 10677 query79 1378806 602 602 query80 1289614 521 521 query81 562 275 253 253 query82 979 148 120 120 query83 371 261 240 240 query84 250 123 97 97 query85 880 471 435 435 query86 421 330 299 299 query87 3129312430013001 query88 3580266126572657 query89 423 368 352 352 query90 2018171 172 171 query91 158 157 130 130 query92 78 75 69 69 query93 1006833 503 503 query94 625 330 284 284 query95 600 340 318 318 query96 658 510 223 223 query97 2483249224052405 query98 230 213 216 213 query99 1005969 908 908 Total cold run time: 256212 ms Total hot run time: 183976 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3898410647 TPC-H: Total hot run time: 28897 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 288b22da667f3b2ad306f9989af458f6cde0a63c, data reload: false -- Round 1 -- q1 17613 458244124412 q2 q3 10731 793 523 523 q4 4731365 253 253 q5 8124121610131013 q6 220 173 150 150 q7 809 853 673 673 q8 10648 148113351335 q9 6835473547934735 q10 6896188916441644 q11 467 264 234 234 q12 752 570 468 468 q13 17786 421734183418 q14 246 230 217 217 q15 998 785 790 785 q16 742 708 666 666 q17 794 872 406 406 q18 6148547052925292 q19 1155974 652 652 q20 509 485 390 390 q21 4400185613821382 q22 353 283 249 249 Total cold run time: 100957 ms Total hot run time: 28897 ms - Round 2, with runtime_filter_mode=off - q1 4509437443794374 q2 q3 1804219117241724 q4 849 1151768 768 q5 4066440143614361 q6 178 172 140 140 q7 1693160614831483 q8 2852266825192519 q9 7901747575637475 q10 2688287123792379 q11 512 453 432 432 q12 502 600 455 455 q13 4006449935883588 q14 278 326 288 288 q15 888 820 804 804 q16 738 779 706 706 q17 1176152013251325 q18 7244679466176617 q19 902 854 874 854 q20 2093226620812081 q21 3963353633373337 q22 479 508 423 423 Total cold run time: 49321 ms Total hot run time: 46133 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3898078780 # FE UT Coverage Report Increment line coverage ` 72.73% (104/143)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_288b22da667f3b2ad306f9989af458f6cde0a63c/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3897916376 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/288b22da667f3b2ad306f9989af458f6cde0a63c_288b22da667f3b2ad306f9989af458f6cde0a63c_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/288b22da667f3b2ad306f9989af458f6cde0a63c_288b22da667f3b2ad306f9989af458f6cde0a63c_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.33% (1796/2264) | | Line Coverage | 64.79% (31989/49372) | | Region Coverage | 65.48% (15962/24378) | | Branch Coverage | 56.01% (8494/15164) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3897716764 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3897695151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3895169195 # FE Regression Coverage Report Increment line coverage ` 67.83% (97/143)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3895128609 # BE Regression && UT Coverage Report Increment line coverage `88.18% (194/220)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.45% (26628/36253) | | Line Coverage | 56.63% (283275/500226) | | Region Coverage | 54.30% (237077/436639) | | Branch Coverage | 56.01% (102176/182413) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894951495 TPC-DS: Total hot run time: 185035 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1c44ebafc1ae24f5ad517947035f204d24699cb8, data reload: false query5 4350624 511 511 query6 349 219 195 195 query7 4208467 261 261 query8 338 252 238 238 query9 8713277927502750 query10 486 364 331 331 query11 17138 17709 17440 17440 query12 180 129 117 117 query13 1461503 392 392 query14 6234341830763076 query14_13158292129332921 query15 224 219 187 187 query16 1079470 509 470 query17 1153749 649 649 query18 2675443 353 353 query19 218 202 208 202 query20 137 125 130 125 query21 222 145 136 136 query22 5229506246804680 query23 17401 17041 16733 16733 query23_116781 16768 16820 16768 query24 7206163412291229 query24_11227122612381226 query25 535 467 409 409 query26 1246273 163 163 query27 2774486 290 290 query28 4478191018951895 query29 825 581 500 500 query30 310 247 215 215 query31 862 745 655 655 query32 86 77 78 77 query33 537 357 289 289 query34 921 905 548 548 query35 634 658 599 599 query36 10581133954 954 query37 130 93 91 91 query38 2975289828882888 query39 865 851 885 851 query39_1829 871 796 796 query40 234 154 137 137 query41 68 65 63 63 query42 105 103 102 102 query43 378 384 363 363 query44 query45 204 186 190 186 query46 901 986 613 613 query47 2115215920802080 query48 312 329 237 237 query49 649 477 401 401 query50 679 285 224 224 query51 4188418241274127 query52 109 112 100 100 query53 294 346 280 280 query54 310 283 273 273 query55 90 91 83 83 query56 320 311 323 311 query57 1401134412861286 query58 295 290 284 284 query59 2574273425392539 query60 346 346 342 342 query61 171 173 176 173 query62 633 581 554 554 query63 323 283 288 283 query64 5041136310081008 query65 query66 1458471 348 348 query67 16510 16565 16303 16303 query68 query69 406 330 277 277 query70 927 984 921 921 query71 337 296 304 296 query72 2828267924772477 query73 542 540 334 334 query74 9609956094109410 query75 2837273624482448 query76 22831042656 656 query77 372 368 305 305 query78 11666 11780 11133 11133 query79 2666771 604 604 query80 1759610 530 530 query81 569 300 247 247 query82 984 154 112 112 query83 324 256 244 244 query84 252 116 99 99 query85 889 478 432 432 query86 406 335 265 265 query87 3088317030783078 query88 3560269926882688 query89 423 362 349 349 query90 2000169 168 168 query91 163 163 137 137 query92 79 77 72 72 query93 1125841 506 506 query94 630 312 304 304 query95 589 390 314 314 query96 662 516 231 231 query97 2501252824742474 query98 239 214 213 213 query99 997 1000913 913 Total cold run time: 256480 ms Total hot run time: 185035 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected].
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894900835 TPC-H: Total hot run time: 29990 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1c44ebafc1ae24f5ad517947035f204d24699cb8, data reload: false -- Round 1 -- q1 17615 451344024402 q2 q3 10744 845 546 546 q4 4718376 253 253 q5 8204126110361036 q6 248 187 144 144 q7 917 895 681 681 q8 11020 166114921492 q9 6948515350645064 q10 6950189516451645 q11 479 278 261 261 q12 760 603 483 483 q13 17841 425934233423 q14 239 232 208 208 q15 955 801 814 801 q16 773 740 682 682 q17 760 943 456 456 q18 6187549755245497 q19 13401222709 709 q20 617 593 423 423 q21 4506208714971497 q22 365 303 287 287 Total cold run time: 102186 ms Total hot run time: 29990 ms - Round 2, with runtime_filter_mode=off - q1 5089487748124812 q2 q3 1935229018041804 q4 977 1273776 776 q5 4203442844494428 q6 214 197 142 142 q7 1860169215281528 q8 2789305329152915 q9 7751762674807480 q10 2883288724092409 q11 542 427 411 411 q12 556 628 455 455 q13 4109452735953595 q14 302 309 287 287 q15 885 820 823 820 q16 731 789 720 720 q17 1433176713901390 q18 7237685967396739 q19 970 1001966 966 q20 2168224322142214 q21 4307371734813481 q22 517 463 412 412 Total cold run time: 51458 ms Total hot run time: 47784 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894769475 run nonConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894748373 run nonConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894747698 # FE Regression Coverage Report Increment line coverage ` 81.12% (116/143)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894727379 run noConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894723809 # BE Regression && UT Coverage Report Increment line coverage `88.18% (194/220)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.48% (26638/36253) | | Line Coverage | 56.66% (283438/500226) | | Region Coverage | 54.34% (237249/436639) | | Branch Coverage | 56.05% (102234/182413) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894499714 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894356537 run nonConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894344337 run nonConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894341888 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894279001 # FE Regression Coverage Report Increment line coverage ` 81.12% (116/143)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
hello-stephen commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3894240468 # BE Regression && UT Coverage Report Increment line coverage `88.18% (194/220)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60727_1c44ebafc1ae24f5ad517947035f204d24699cb8_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.47% (26636/36253) | | Line Coverage | 56.66% (283420/500226) | | Region Coverage | 54.33% (237235/436639) | | Branch Coverage | 56.04% (102224/182413) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3893411379 # BE UT Coverage Report Increment line coverage `85.45% (188/220)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1c44ebafc1ae24f5ad517947035f204d24699cb8_1c44ebafc1ae24f5ad517947035f204d24699cb8/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1c44ebafc1ae24f5ad517947035f204d24699cb8_1c44ebafc1ae24f5ad517947035f204d24699cb8/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.71% (19500/36997) | | Line Coverage | 36.25% (181765/501463) | | Region Coverage | 32.61% (140973/432259) | | Branch Coverage | 33.65% (61145/181709) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
doris-robot commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3892417741 # Cloud UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1c44ebafc1ae24f5ad517947035f204d24699cb8_1c44ebafc1ae24f5ad517947035f204d24699cb8_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1c44ebafc1ae24f5ad517947035f204d24699cb8_1c44ebafc1ae24f5ad517947035f204d24699cb8_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 79.32% (1795/2263) | | Line Coverage | 64.81% (31958/49311) | | Region Coverage | 65.53% (15949/24339) | | Branch Coverage | 56.02% (8477/15132) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
gary-cloud commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3892174153 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [featrue](Variant) SKIP pattern [doris]
Thearas commented on PR #60727: URL: https://github.com/apache/doris/pull/60727#issuecomment-3892173261 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
