subject:"Re\: \[PR\] \[feature\]\(be\) Support flexible variant partial update \[doris\]"

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-09-30 Thread via GitHub



eNathan commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-5912530428

   Hi @eldenmoon, our team is interested in updating selected fields inside a 
VARIANT column while preserving omitted fields. Our JSON objects are flat, with 
no nesting.
   
   This PR looks like a match, but I noticed it was closed without merging. Is 
there a replacement PR or a target release for this feature?
   
   We’re deciding whether to wait for native support or implement a workaround, 
so even a rough indication of the plans would help.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-09-21 Thread via GitHub



eldenmoon closed pull request #63182: [feature](be) Support flexible variant 
partial update
URL: https://github.com/apache/doris/pull/63182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4468326247

   # FE Regression Coverage Report
   Increment line coverage `  67.18% (176/262)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_c59e3952a50c2f0fd505d4606c20213ff17c7021_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_c59e3952a50c2f0fd505d4606c20213ff17c7021_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4468288118

   # BE Regression && UT Coverage Report
   Increment line coverage `92.76% (846/912)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_c59e3952a50c2f0fd505d4606c20213ff17c7021_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_c59e3952a50c2f0fd505d4606c20213ff17c7021_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.97% (27230/37837) |
   | Line Coverage | 55.34% (290285/524566) |
   | Region Coverage   | 52.22% (240587/460701) |
   | Branch Coverage   | 53.71% (104124/193852) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467984940

   # BE UT Coverage Report
   Increment line coverage `64.11% (584/911)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/c59e3952a50c2f0fd505d4606c20213ff17c7021_c59e3952a50c2f0fd505d4606c20213ff17c7021/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/c59e3952a50c2f0fd505d4606c20213ff17c7021_c59e3952a50c2f0fd505d4606c20213ff17c7021/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.55% (20692/38637) |
   | Line Coverage | 37.21% (195701/525942) |
   | Region Coverage   | 33.56% (153117/456286) |
   | Branch Coverage   | 34.60% (66827/193122) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467967217

   
   
   TPC-DS: Total hot run time: 169020 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c59e3952a50c2f0fd505d4606c20213ff17c7021, 
data reload: false
   
   query5   4320647 548 548
   query6   332 228 201 201
   query7   4223580 296 296
   query8   327 228 219 219
   query9   8824396739783967
   query10  449 335 298 298
   query11  5805235322052205
   query12  182 127 122 122
   query13  1301613 406 406
   query14  5981534650515051
   query14_14361437443014301
   query15  208 204 180 180
   query16  1000445 423 423
   query17  1113705 589 589
   query18  2460485 345 345
   query19  217 201 160 160
   query20  135 128 125 125
   query21  213 144 116 116
   query22  13627   13448   13393   13393
   query23  17162   16362   15964   15964
   query23_116028   16057   16126   16057
   query24  7428173312711271
   query24_11288127413041274
   query25  560 475 407 407
   query26  1332326 169 169
   query27  2710537 336 336
   query28  4392196019341934
   query29  1004630 482 482
   query30  316 246 201 201
   query31  11131056935 935
   query32  91  79  70  70
   query33  541 372 284 284
   query34  11751125645 645
   query35  755 777 654 654
   query36  1353131211561156
   query37  151 98  85  85
   query38  3196313830693069
   query39  927 916 905 905
   query39_1892 874 877 874
   query40  241 143 126 126
   query41  65  62  63  62
   query42  114 110 106 106
   query43  316 321 284 284
   query44  
   query45  203 193 190 190
   query46  10551171734 734
   query47  2354232822282228
   query48  397 399 285 285
   query49  622 480 385 385
   query50  980 342 247 247
   query51  4284425341744174
   query52  105 104 95  95
   query53  256 280 202 202
   query54  305 275 253 253
   query55  90  88  86  86
   query56  286 317 302 302
   query57  1393139112871287
   query58  291 265 256 256
   query59  1531161414411441
   query60  334 337 323 323
   query61  178 177 175 175
   query62  679 637 571 571
   query63  245 203 207 203
   query64  2478871 679 679
   query65  
   query66  1741483 384 384
   query67  30022   29847   29811   29811
   query68  
   query69  465 338 304 304
   query70  10621019966 966
   query71  315 283 270 270
   query72  3003271523492349
   query73  820 784 439 439
   query74  5082486347144714
   query75  2662257422722272
   query76  21851114781 781
   query77  395 406 332 332
   query78  12107   12083   11621   11621
   query79  14101014747 747
   query80  660 547 465 465
   query81  458 280 240 240
   query82  1300154 120 120
   query83  355 271 247 247
   query84  288 137 111 111
   query85  881 529 442 442
   query86  411 361 358 358
   query87  3376333032573257
   query88  3494262026152615
   query89  440 380 337 337
   query90  1890182 178 178
   query91  178 168 140 140
   query92  78  79  76  76
   query93  14571369829 829
   query94  549 350 315 315
   query95  684 378 361 361
   query96  1078721 336 336
   query97  2662268325722572
   query98  237 230 226 226
   query99  11071102971 971
   Total cold run time: 252147 ms
   Total hot run time: 169020 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467944543

   
   
   TPC-H: Total hot run time: 30779 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c59e3952a50c2f0fd505d4606c20213ff17c7021, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17235   382937923792
   q2   q3  10581   1365795 795
   q4   4676468 350 350
   q5   7835223720852085
   q6   243 174 137 137
   q7   944 777 629 629
   q8   9414168915901590
   q9   5337490648704870
   q10  6402207217991799
   q11  449 275 247 247
   q12  638 424 287 287
   q13  18148   339127472747
   q14  262 259 232 232
   q15  q16 810 782 706 706
   q17  992 965 939 939
   q18  6973566755585558
   q19  1149130810631063
   q20  513 401 264 264
   q21  5725255523842384
   q22  440 363 305 305
   Total cold run time: 98766 ms
   Total hot run time: 30779 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4175408440894084
   q2   q3  4471490842774277
   q4   2099216913971397
   q5   4384426542584258
   q6   226 172 129 129
   q7   1725184016801680
   q8   2544218820812081
   q9   7646774777187718
   q10  4542444640434043
   q11  562 409 378 378
   q12  733 729 543 543
   q13  3230368729922992
   q14  295 311 275 275
   q15  q16 693 746 712 712
   q17  1315130913081308
   q18  8102729971847184
   q19  1112106510771065
   q20  2198220819301930
   q21  5264457844044404
   q22  523 486 417 417
   Total cold run time: 55839 ms
   Total hot run time: 50875 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467918158

   # BE UT Coverage Report
   Increment line coverage `64.11% (584/911)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/d73b6ab638261b168585a3a46b5fb0daa20ee788_d73b6ab638261b168585a3a46b5fb0daa20ee788/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/d73b6ab638261b168585a3a46b5fb0daa20ee788_d73b6ab638261b168585a3a46b5fb0daa20ee788/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.55% (20692/38637) |
   | Line Coverage | 37.21% (195721/525942) |
   | Region Coverage   | 33.60% (15/456286) |
   | Branch Coverage   | 34.61% (66847/193122) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467919776

   # FE UT Coverage Report
   Increment line coverage `  78.82% (201/255)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_d73b6ab638261b168585a3a46b5fb0daa20ee788/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_d73b6ab638261b168585a3a46b5fb0daa20ee788/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467893476

   
   
   TPC-DS: Total hot run time: 169231 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit aaef4cc98f53001e7814561f7604a225a7e8b0f5, 
data reload: false
   
   query5   4323649 504 504
   query6   340 223 201 201
   query7   4234584 318 318
   query8   316 231 227 227
   query9   8821405940384038
   query10  449 346 301 301
   query11  5790250822332233
   query12  189 134 126 126
   query13  1293631 452 452
   query14  6170540950815081
   query14_14388437543434343
   query15  220 204 186 186
   query16  1058478 445 445
   query17  1160729 604 604
   query18  2739491 355 355
   query19  224 209 170 170
   query20  140 137 131 131
   query21  224 148 125 125
   query22  13601   13606   13371   13371
   query23  17188   16356   16016   16016
   query23_116229   16122   16342   16122
   query24  7346177113071307
   query24_11311132412891289
   query25  556 469 419 419
   query26  1322317 171 171
   query27  2661529 348 348
   query28  4305195319831953
   query29  981 627 498 498
   query30  310 235 190 190
   query31  11371067942 942
   query32  89  74  75  74
   query33  535 351 298 298
   query34  11611163625 625
   query35  758 783 665 665
   query36  1295129211081108
   query37  154 112 94  94
   query38  3223314930333033
   query39  935 933 900 900
   query39_1874 876 877 876
   query40  226 153 129 129
   query41  66  76  64  64
   query42  110 109 109 109
   query43  326 329 300 300
   query44  
   query45  206 205 199 199
   query46  11171169701 701
   query47  2280230221642164
   query48  415 411 297 297
   query49  640 521 388 388
   query50  984 357 244 244
   query51  4285431642554255
   query52  105 104 96  96
   query53  253 287 208 208
   query54  322 274 249 249
   query55  91  88  92  88
   query56  308 317 315 315
   query57  1389137413101310
   query58  290 274 273 273
   query59  1598164814291429
   query60  316 327 330 327
   query61  158 152 155 152
   query62  661 623 563 563
   query63  240 195 202 195
   query64  2346802 644 644
   query65  
   query66  1674478 350 350
   query67  29332   29975   29816   29816
   query68  
   query69  470 341 308 308
   query70  998 1016952 952
   query71  312 280 283 280
   query72  2946265726602657
   query73  796 785 421 421
   query74  5118486847594759
   query75  2668256722662266
   query76  22421152787 787
   query77  409 410 334 334
   query78  12080   12097   11490   11490
   query79  13501005739 739
   query80  649 550 482 482
   query81  451 275 231 231
   query82  1372160 119 119
   query83  373 291 252 252
   query84  278 142 110 110
   query85  890 554 444 444
   query86  386 340 329 329
   query87  3414336032183218
   query88  3583269226572657
   query89  439 389 360 360
   query90  1855181 186 181
   query91  175 165 141 141
   query92  83  78  73  73
   query93  15051421897 897
   query94  529 364 320 320
   query95  685 471 345 345
   query96  1088821 325 325
   query97  2682272925512551
   query98  242 228 228 228
   query99  11141081973 973
   Total cold run time: 251934 ms
   Total hot run time: 169231 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467877281

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467874867

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/aaef4cc98f53001e7814561f7604a225a7e8b0f5_aaef4cc98f53001e7814561f7604a225a7e8b0f5_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/aaef4cc98f53001e7814561f7604a225a7e8b0f5_aaef4cc98f53001e7814561f7604a225a7e8b0f5_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.52% (33329/51653) |
   | Region Coverage   | 65.22% (16524/25335) |
   | Branch Coverage   | 55.74% (8834/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467866282

   
   
   TPC-DS: Total hot run time: 169226 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit d73b6ab638261b168585a3a46b5fb0daa20ee788, 
data reload: false
   
   query5   4326651 511 511
   query6   339 232 214 214
   query7   4258531 304 304
   query8   325 229 229 229
   query9   8854399939483948
   query10  445 344 299 299
   query11  5829242422212221
   query12  184 127 125 125
   query13  1282618 445 445
   query14  5953534650605060
   query14_14332435143304330
   query15  216 204 180 180
   query16  1004470 446 446
   query17  1161755 601 601
   query18  2601492 364 364
   query19  220 203 173 173
   query20  138 136 132 132
   query21  216 137 120 120
   query22  13707   13668   13334   13334
   query23  17132   16388   16063   16063
   query23_116227   16283   16230   16230
   query24  7658175012961296
   query24_11309134412991299
   query25  579 497 434 434
   query26  1342326 183 183
   query27  2668546 339 339
   query28  4427194219151915
   query29  1040643 512 512
   query30  304 238 201 201
   query31  11341062947 947
   query32  94  78  80  78
   query33  534 364 300 300
   query34  11631137655 655
   query35  766 779 712 712
   query36  1341137612221222
   query37  152 100 90  90
   query38  3233314930203020
   query39  923 926 900 900
   query39_1869 866 883 866
   query40  224 143 123 123
   query41  63  63  61  61
   query42  112 107 114 107
   query43  324 324 284 284
   query44  
   query45  211 197 194 194
   query46  10521157733 733
   query47  2294228722062206
   query48  375 396 291 291
   query49  633 483 387 387
   query50  967 357 256 256
   query51  4426428243014282
   query52  105 106 93  93
   query53  254 286 204 204
   query54  302 268 252 252
   query55  97  88  83  83
   query56  295 294 309 294
   query57  1421142313361336
   query58  306 271 269 269
   query59  1547163814291429
   query60  320 322 309 309
   query61  168 150 156 150
   query62  677 628 564 564
   query63  233 202 212 202
   query64  2399815 629 629
   query65  
   query66  1696476 389 389
   query67  29980   29941   29839   29839
   query68  
   query69  464 347 306 306
   query70  10001015987 987
   query71  308 273 261 261
   query72  3059273224152415
   query73  888 814 419 419
   query74  5091491547184718
   query75  2655259622412241
   query76  22031118761 761
   query77  396 405 332 332
   query78  12237   12090   11635   11635
   query79  15011013713 713
   query80  640 547 458 458
   query81  456 275 243 243
   query82  1353159 124 124
   query83  366 279 248 248
   query84  268 142 110 110
   query85  888 549 445 445
   query86  400 315 301 301
   query87  3396338932133213
   query88  3520263826192619
   query89  439 392 336 336
   query90  1998178 175 175
   query91  177 171 142 142
   query92  81  74  76  74
   query93  14311497849 849
   query94  531 353 309 309
   query95  675 385 347 347
   query96  1103762 324 324
   query97  2709268825442544
   query98  237 226 223 223
   query99  111910011001
   Total cold run time: 253381 ms
   Total hot run time: 169226 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467868526

   # FE UT Coverage Report
   Increment line coverage `  78.66% (199/253)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_8978736b9578aae8b3b7a29b0863660340387994/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_8978736b9578aae8b3b7a29b0863660340387994/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467868486

   
   
   TPC-H: Total hot run time: 31121 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit aaef4cc98f53001e7814561f7604a225a7e8b0f5, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17229   414640884088
   q2   q3  10542   1418804 804
   q4   4669471 347 347
   q5   7693229221122112
   q6   243 177 142 142
   q7   951 752 634 634
   q8   9423169415541554
   q9   5089490648914891
   q10  6382205917761776
   q11  449 285 248 248
   q12  635 437 317 317
   q13  18125   345927492749
   q14  266 259 229 229
   q15  q16 820 766 703 703
   q17  1006960 966 960
   q18  6833583454705470
   q19  12311299
   q20  520 412 264 264
   q21  5559259024172417
   q22  436 365 305 305
   Total cold run time: 98101 ms
   Total hot run time: 31121 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4392426742424242
   q2   q3  4541495943544354
   q4   2183224113911391
   q5   4448431243404312
   q6   233 175 134 134
   q7   1729222018011801
   q8   2758211823132118
   q9   8041802177507750
   q10  4612448740514051
   q11  602 436 400 400
   q12  757 732 536 536
   q13  3404373929472947
   q14  279 315 277 277
   q15  q16 730 736 645 645
   q17  1375135113711351
   q18  8202742373727372
   q19  1185114911381138
   q20  2229221119411941
   q21  5386476145994599
   q22  549 479 433 433
   Total cold run time: 57635 ms
   Total hot run time: 51792 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467842975

   
   
   TPC-H: Total hot run time: 31388 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit d73b6ab638261b168585a3a46b5fb0daa20ee788, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17312   390239353902
   q2   q3  10567   1383826 826
   q4   4672483 351 351
   q5   7821230321312131
   q6   239 178 144 144
   q7   927 780 641 641
   q8   9436174916211621
   q9   5131500149304930
   q10  6439208718241824
   q11  434 271 252 252
   q12  634 434 296 296
   q13  18106   340027352735
   q14  266 258 237 237
   q15  q16 819 768 712 712
   q17  1003959 985 959
   q18  7292575756375637
   q19  11541257983 983
   q20  523 450 345 345
   q21  6015289825322532
   q22  474 484 330 330
   Total cold run time: 99264 ms
   Total hot run time: 31388 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4614462144904490
   q2   q3  4837524646924692
   q4   2134222714491449
   q5   4944457745874577
   q6   231 179 139 139
   q7   1887173815041504
   q8   2365206121272061
   q9   7604716771817167
   q10  4466438639833983
   q11  528 373 348 348
   q12  711 728 508 508
   q13  3094337927802780
   q14  265 291 245 245
   q15  q16 675 692 626 626
   q17  1256124612251225
   q18  7259674568346745
   q19  1109114010861086
   q20  2198225019291929
   q21  5310457944274427
   q22  524 490 404 404
   Total cold run time: 56011 ms
   Total hot run time: 50385 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467843314

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467843380

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467838058

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/d73b6ab638261b168585a3a46b5fb0daa20ee788_d73b6ab638261b168585a3a46b5fb0daa20ee788_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/d73b6ab638261b168585a3a46b5fb0daa20ee788_d73b6ab638261b168585a3a46b5fb0daa20ee788_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.52% (33329/51653) |
   | Region Coverage   | 65.23% (16525/25335) |
   | Branch Coverage   | 55.73% (8832/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3253311000


##
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##
@@ -3197,10 +3197,16 @@ public boolean getEnableUniqueKeySkipBitmap() {
  * 1. Must be MoW unique key table
  * 2. Must have skip_bitmap column
  * 3. Must have light_schema_change enabled
- * 4. Cannot have variant columns
  * @throws UserException if any constraint is not satisfied
  */
 public void validateForFlexiblePartialUpdate() throws UserException {
+validateForFlexiblePartialUpdate(true);
+}
+
+/**
+ * Validate that the table supports flexible partial update.
+ */
+public void validateForFlexiblePartialUpdate(boolean 
validateBackendCapability) throws UserException {
 if (!getEnableUniqueKeyMergeOnWrite()) {

Review Comment:
   This table-level validator still omits the cluster-key restriction that 
every partial-update planner enforces later. A concrete path is a UNIQUE MoW 
table with cluster keys: `ALTER TABLE ... ENABLE FEATURE 
"UPDATE_FLEXIBLE_COLUMNS"` reaches this validator and can add the hidden 
skip-bitmap column, but any later flexible partial update load is rejected by 
`NereidsStreamLoadPlanner` / `NereidsLoadingTaskPlanner` with the cluster-key 
partial-update check. Please reject `isUniqKeyMergeOnWriteWithClusterKeys()` 
here (or in the enable-feature path before adding the hidden column) and add a 
negative enable-feature test for cluster-key tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467812422

   
   
   TPC-DS: Total hot run time: 169833 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 752be339e61ccfbf2cc5ad4a5c6aa5d093054aaa, 
data reload: false
   
   query5   4320663 515 515
   query6   337 222 208 208
   query7   4237551 305 305
   query8   329 227 230 227
   query9   8803394539673945
   query10  470 342 300 300
   query11  5782239721842184
   query12  186 130 125 125
   query13  1282613 440 440
   query14  5934535451315131
   query14_14390434543634345
   query15  207 202 187 187
   query16  1006493 428 428
   query17  1152764 620 620
   query18  2556485 359 359
   query19  210 206 159 159
   query20  147 131 128 128
   query21  226 140 115 115
   query22  13605   13492   13386   13386
   query23  17325   16372   16007   16007
   query23_116145   16161   16193   16161
   query24  7538178612941294
   query24_11301130913071307
   query25  549 472 409 409
   query26  1304331 169 169
   query27  2695559 341 341
   query28  4446193919111911
   query29  984 626 497 497
   query30  301 247 194 194
   query31  11081052939 939
   query32  91  79  74  74
   query33  539 347 303 303
   query34  11661125647 647
   query35  757 779 687 687
   query36  1332131111871187
   query37  155 103 102 102
   query38  3225314430453045
   query39  921 916 906 906
   query39_1865 877 910 877
   query40  230 146 124 124
   query41  97  63  62  62
   query42  110 110 110 110
   query43  323 318 291 291
   query44  
   query45  207 203 197 197
   query46  10621198707 707
   query47  2219230721272127
   query48  403 403 300 300
   query49  628 510 385 385
   query50  981 347 260 260
   query51  4327420441754175
   query52  104 105 94  94
   query53  250 279 203 203
   query54  305 276 267 267
   query55  92  89  84  84
   query56  311 310 320 310
   query57  1405139612961296
   query58  298 284 266 266
   query59  1525163813971397
   query60  326 325 311 311
   query61  161 156 151 151
   query62  669 619 569 569
   query63  242 204 224 204
   query64  2386809 653 653
   query65  
   query66  1685479 390 390
   query67  30139   29951   29799   29799
   query68  
   query69  480 341 305 305
   query70  1025940 927 927
   query71  312 278 267 267
   query72  2985271923982398
   query73  851 770 405 405
   query74  5033490347284728
   query75  2667260722532253
   query76  23171135788 788
   query77  394 432 338 338
   query78  12104   12121   11697   11697
   query79  12521021715 715
   query80  625 564 483 483
   query81  453 293 246 246
   query82  331 163 125 125
   query83  365 291 262 262
   query84  267 145 136 136
   query85  972 618 533 533
   query86  397 323 329 323
   query87  3416344832363236
   query88  3550269726892689
   query89  433 389 335 335
   query90  1874187 195 187
   query91  193 181 154 154
   query92  77  79  79  79
   query93  14811551806 806
   query94  543 364 336 336
   query95  715 484 369 369
   query96  1078811 338 338
   query97  2668267025432543
   query98  242 233 267 233
   query99  11401100991 991
   Total cold run time: 251639 ms
   Total hot run time: 169833 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467793228

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467808823

   
   
   TPC-DS: Total hot run time: 170497 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8978736b9578aae8b3b7a29b0863660340387994, 
data reload: false
   
   query5   4303661 523 523
   query6   324 219 200 200
   query7   4244565 293 293
   query8   326 231 222 222
   query9   8815405240404040
   query10  457 345 306 306
   query11  5795242221872187
   query12  187 129 126 126
   query13  1286626 420 420
   query14  6083541350415041
   query14_14383441043874387
   query15  214 205 184 184
   query16  1042489 457 457
   query17  1170754 621 621
   query18  2728498 371 371
   query19  221 206 167 167
   query20  142 135 130 130
   query21  223 151 123 123
   query22  13708   13780   13439   13439
   query23  17128   16423   15919   15919
   query23_116202   16165   16137   16137
   query24  7378175513021302
   query24_11304131913071307
   query25  595 503 445 445
   query26  1370324 175 175
   query27  2641587 348 348
   query28  4412196819291929
   query29  1028649 537 537
   query30  310 237 202 202
   query31  11371072952 952
   query32  86  82  75  75
   query33  558 359 309 309
   query34  11711117646 646
   query35  795 779 674 674
   query36  1314131211771177
   query37  154 103 89  89
   query38  3217312830653065
   query39  924 920 889 889
   query39_1868 892 863 863
   query40  235 151 124 124
   query41  66  68  64  64
   query42  110 110 113 110
   query43  333 326 293 293
   query44  
   query45  209 200 199 199
   query46  10861162695 695
   query47  2318231221532153
   query48  409 399 306 306
   query49  629 483 390 390
   query50  960 353 259 259
   query51  4308429742504250
   query52  106 110 94  94
   query53  256 280 211 211
   query54  321 279 272 272
   query55  97  91  87  87
   query56  302 311 309 309
   query57  1418136012911291
   query58  295 276 261 261
   query59  1587161614231423
   query60  332 351 311 311
   query61  163 159 159 159
   query62  659 622 561 561
   query63  254 202 204 202
   query64  2365815 686 686
   query65  
   query66  1658485 351 351
   query67  29897   30016   29809   29809
   query68  
   query69  466 346 306 306
   query70  997 102210001000
   query71  310 282 269 269
   query72  2936288224512451
   query73  836 821 435 435
   query74  5070488847054705
   query75  2668260022362236
   query76  22681128791 791
   query77  411 413 339 339
   query78  12084   12038   11563   11563
   query79  14681026731 731
   query80  676 548 475 475
   query81  456 280 240 240
   query82  1340159 124 124
   query83  361 282 251 251
   query84  257 145 107 107
   query85  888 565 463 463
   query86  396 364 337 337
   query87  3488333531953195
   query88  3569265726532653
   query89  437 390 337 337
   query90  1998185 190 185
   query91  184 171 142 142
   query92  80  80  75  75
   query93  14801413861 861
   query94  530 337 318 318
   query95  698 481 353 353
   query96  1051803 332 332
   query97  2685267725322532
   query98  239 226 228 226
   query99  1125113010391039
   Total cold run time: 253140 ms
   Total hot run time: 170497 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467808303

   
   
   TPC-DS: Total hot run time: 169372 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0b825c284d78844f5e8343eaf061710bd2d9fa03, 
data reload: false
   
   query5   4339661 525 525
   query6   332 225 195 195
   query7   4260576 319 319
   query8   327 238 230 230
   query9   8832400940054005
   query10  446 391 315 315
   query11  5818241722282228
   query12  183 130 126 126
   query13  1365645 431 431
   query14  5954536450455045
   query14_14354434043434340
   query15  214 202 184 184
   query16  1078470 448 448
   query17  1173742 614 614
   query18  2739498 370 370
   query19  232 211 185 185
   query20  142 131 131 131
   query21  217 139 119 119
   query22  13616   13559   13416   13416
   query23  17260   16376   16141   16141
   query23_116198   16242   16324   16242
   query24  7523176313051305
   query24_11325126713241267
   query25  570 514 446 446
   query26  1325320 171 171
   query27  2681560 352 352
   query28  4381194419271927
   query29  980 651 523 523
   query30  309 243 207 207
   query31  1066947 947
   query32  89  82  79  79
   query33  548 359 309 309
   query34  11791147633 633
   query35  817 786 656 656
   query36  1353130311481148
   query37  156 104 96  96
   query38  3217316830743074
   query39  929 944 896 896
   query39_1872 888 886 886
   query40  226 144 127 127
   query41  66  62  66  62
   query42  111 110 107 107
   query43  323 327 298 298
   query44  
   query45  212 202 191 191
   query46  11191203727 727
   query47  2300232321562156
   query48  395 404 309 309
   query49  629 492 380 380
   query50  970 339 250 250
   query51  4373431042444244
   query52  106 105 94  94
   query53  253 277 202 202
   query54  307 266 249 249
   query55  98  89  87  87
   query56  303 314 299 299
   query57  1424139613361336
   query58  311 271 281 271
   query59  1607162113821382
   query60  320 330 304 304
   query61  160 159 157 157
   query62  669 622 553 553
   query63  254 199 204 199
   query64  2371814 621 621
   query65  
   query66  1687468 342 342
   query67  30121   29318   29824   29318
   query68  
   query69  473 338 335 335
   query70  10201004976 976
   query71  312 284 266 266
   query72  3068274824482448
   query73  830 783 409 409
   query74  5060488347214721
   query75  2677259722472247
   query76  23451136752 752
   query77  390 403 343 343
   query78  12150   12318   11548   11548
   query79  13771058736 736
   query80  642 549 462 462
   query81  453 281 250 250
   query82  1089161 126 126
   query83  356 276 246 246
   query84  270 145 111 111
   query85  886 537 458 458
   query86  390 338 316 316
   query87  3393336332483248
   query88  3501263425962596
   query89  430 386 336 336
   query90  1958184 175 175
   query91  181 173 146 146
   query92  82  75  74  74
   query93  15011460913 913
   query94  542 360 330 330
   query95  658 394 442 394
   query96  1040816 322 322
   query97  2728270925632563
   query98  249 249 252 249
   query99  11061077976 976
   Total cold run time: 253336 ms
   Total hot run time: 169372 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467808527

   
   
   TPC-DS: Total hot run time: 170246 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit d6104f1efa160b15e62f87d56f45c0ef93e58ac0, 
data reload: false
   
   query5   4325650 525 525
   query6   345 217 200 200
   query7   4502548 309 309
   query8   332 226 207 207
   query9   8822397339733973
   query10  447 342 297 297
   query11  5824240421402140
   query12  185 126 126 126
   query13  1295609 427 427
   query14  5952535350675067
   query14_14346435643084308
   query15  223 207 185 185
   query16  1012481 445 445
   query17  987 727 575 575
   query18  2440490 354 354
   query19  206 202 161 161
   query20  136 132 140 132
   query21  210 140 117 117
   query22  13661   13611   13476   13476
   query23  17262   16510   16108   16108
   query23_116271   16313   16245   16245
   query24  7553175312881288
   query24_11293129713061297
   query25  543 461 396 396
   query26  1337315 170 170
   query27  2712539 334 334
   query28  4470193719461937
   query29  954 627 494 494
   query30  308 242 202 202
   query31  11001065932 932
   query32  81  83  71  71
   query33  531 350 286 286
   query34  11561114624 624
   query35  749 777 672 672
   query36  1344135512061206
   query37  152 107 94  94
   query38  3209313730483048
   query39  932 932 906 906
   query39_1879 884 879 879
   query40  228 145 126 126
   query41  68  64  62  62
   query42  113 110 111 110
   query43  326 326 289 289
   query44  
   query45  217 208 198 198
   query46  10721248753 753
   query47  23252314
   query48  403 440 288 288
   query49  650 504 435 435
   query50  962 362 261 261
   query51  4331427942364236
   query52  108 115 96  96
   query53  254 280 211 211
   query54  324 317 252 252
   query55  93  88  83  83
   query56  297 319 310 310
   query57  1399140113261326
   query58  289 269 267 267
   query59  1557158313881388
   query60  319 323 300 300
   query61  155 156 147 147
   query62  644 614 556 556
   query63  237 196 210 196
   query64  2376797 625 625
   query65  
   query66  1721467 352 352
   query67  29847   29923   29698   29698
   query68  
   query69  473 341 308 308
   query70  1011101410001000
   query71  301 272 269 269
   query72  3056278124302430
   query73  850 791 430 430
   query74  5051491547294729
   query75  2649260222352235
   query76  23301129732 732
   query77  399 402 332 332
   query78  12126   12209   11608   11608
   query79  12481049743 743
   query80  595 550 451 451
   query81  448 282 241 241
   query82  245 160 121 121
   query83  276 279 248 248
   query84  293 138 105 105
   query85  893 538 452 452
   query86  369 306 301 301
   query87  3362340532123212
   query88  3481265226602652
   query89  431 389 342 342
   query90  2156184 175 175
   query91  175 170 138 138
   query92  76  86  82  82
   query93  15121383856 856
   query94  536 321 327 321
   query95  659 376 349 349
   query96  1076841 329 329
   query97  2706272825672567
   query98  237 230 229 229
   query99  11301122998 998
   Total cold run time: 251396 ms
   Total hot run time: 170246 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467793231

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467789269

   
   
   TPC-H: Total hot run time: 30855 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 752be339e61ccfbf2cc5ad4a5c6aa5d093054aaa, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17625   393138863886
   q2   q3  10939   1409792 792
   q4   4745470 347 347
   q5   9900227720732073
   q6   386 177 136 136
   q7   969 783 638 638
   q8   9583162814671467
   q9   7061490649214906
   q10  6441214217581758
   q11  436 274 245 245
   q12  690 426 296 296
   q13  18244   344427832783
   q14  262 255 232 232
   q15  q16 821 771 701 701
   q17  957 924 949 924
   q18  6796568255125512
   q19  1330136611171117
   q20  515 414 259 259
   q21  5672267824882488
   q22  444 355 295 295
   Total cold run time: 103816 ms
   Total hot run time: 30855 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4194406441074064
   q2   q3  4490487843034303
   q4   2077220513991399
   q5   4358426048124260
   q6   254 204 151 151
   q7   2006188815481548
   q8   2433206521152065
   q9   7725770875647564
   q10  4603451741074107
   q11  575 424 372 372
   q12  729 752 520 520
   q13  3375364930113011
   q14  297 302 290 290
   q15  q16 699 749 630 630
   q17  1348133613081308
   q18  7842732766006600
   q19  1088112710931093
   q20  2232222519371937
   q21  5279462144274427
   q22  525 458 400 400
   Total cold run time: 56129 ms
   Total hot run time: 50049 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467785830

   
   
   TPC-H: Total hot run time: 31114 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8978736b9578aae8b3b7a29b0863660340387994, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17237   397241143972
   q2   q3  10591   1482781 781
   q4   4703464 347 347
   q5   7732221920782078
   q6   244 180 143 143
   q7   1007776 618 618
   q8   9352161716581617
   q9   5272490048854885
   q10  6400206718211821
   q11  442 276 244 244
   q12  638 428 298 298
   q13  18120   343328342834
   q14  273 251 233 233
   q15  q16 814 764 709 709
   q17  981 935 1021935
   q18  6966564955025502
   q19  1211129010651065
   q20  500 400 259 259
   q21  5627265524682468
   q22  455 366 305 305
   Total cold run time: 98565 ms
   Total hot run time: 31114 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4374425041744174
   q2   q3  4623494343094309
   q4   2126219213801380
   q5   4406429243114292
   q6   234 179 134 134
   q7   1821210017101710
   q8   2603213021602130
   q9   7879800176737673
   q10  4533446440754075
   q11  604 453 389 389
   q12  723 768 546 546
   q13  3289370029882988
   q14  292 300 283 283
   q15  q16 719 733 638 638
   q17  1347134313071307
   q18  8141732772207220
   q19  1183118211231123
   q20  2279224219161916
   q21  5362463145754575
   q22  554 461 407 407
   Total cold run time: 57092 ms
   Total hot run time: 51269 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467785605

   
   
   TPC-H: Total hot run time: 30909 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit d6104f1efa160b15e62f87d56f45c0ef93e58ac0, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17660   391739473917
   q2   q3  10775   1441833 833
   q4   4698472 349 349
   q5   7579231221192119
   q6   236 178 139 139
   q7   953 775 632 632
   q8   9359165315601560
   q9   5095486148444844
   q10  6421209817921792
   q11  431 280 247 247
   q12  630 424 294 294
   q13  18115   330427562756
   q14  262 249 241 241
   q15  q16 799 771 705 705
   q17  971 820 906 820
   q18  6936580755745574
   q19  1161132510951095
   q20  483 400 264 264
   q21  5143261424202420
   q22  436 360 308 308
   Total cold run time: 98143 ms
   Total hot run time: 30909 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4166410340744074
   q2   q3  4461490043184318
   q4   2069220513821382
   q5   4373425242544252
   q6   227 174 130 130
   q7   1696168419331684
   q8   2647217821332133
   q9   7817793675647564
   q10  4547447340524052
   q11  555 425 370 370
   q12  723 736 565 565
   q13  3250366529862986
   q14  294 314 286 286
   q15  q16 737 728 669 669
   q17  1345131013571310
   q18  7937721472207214
   q19  1169112411521124
   q20  2218219519161916
   q21  5294462844284428
   q22  518 446 409 409
   Total cold run time: 56043 ms
   Total hot run time: 50866 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467785303

   
   
   TPC-H: Total hot run time: 31336 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0b825c284d78844f5e8343eaf061710bd2d9fa03, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17741   385938363836
   q2   q3  10868   1393816 816
   q4   4747484 348 348
   q5   10035   231720932093
   q6   367 176 140 140
   q7   961 775 634 634
   q8   9570178416371637
   q9   6983494449024902
   q10  6490226018331833
   q11  436 275 247 247
   q12  688 422 295 295
   q13  18221   340127622762
   q14  266 257 236 236
   q15  q16 822 774 710 710
   q17  982 906 985 906
   q18  6910573959675739
   q19  1193131211331133
   q20  512 417 262 262
   q21  5927284324912491
   q22  462 374 316 316
   Total cold run time: 104181 ms
   Total hot run time: 31336 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4606453245454532
   q2   q3  4875540145744574
   q4   2150220314281428
   q5   4740465246424642
   q6   230 180 124 124
   q7   1894172414901490
   q8   2414193818971897
   q9   7290721572657215
   q10  4469438139903990
   q11  535 381 353 353
   q12  703 725 500 500
   q13  3008334928042804
   q14  264 279 249 249
   q15  q16 683 695 609 609
   q17  1279124612311231
   q18  7354694367886788
   q19  1146108210711071
   q20  2228225719391939
   q21  5337461145534553
   q22  545 452 437 437
   Total cold run time: 55750 ms
   Total hot run time: 50426 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467782195

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/8978736b9578aae8b3b7a29b0863660340387994_8978736b9578aae8b3b7a29b0863660340387994_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/8978736b9578aae8b3b7a29b0863660340387994_8978736b9578aae8b3b7a29b0863660340387994_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.52% (33327/51653) |
   | Region Coverage   | 65.22% (16523/25335) |
   | Branch Coverage   | 55.73% (8832/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3253288157


##
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##
@@ -2112,29 +2189,53 @@ private void validateFlexiblePartialUpdateForAlter() 
throws UserException {
 }
 OlapTable olapTable = (OlapTable) table;
 
-// Validate table-level constraints (MoW, skip_bitmap, 
light_schema_change, variant columns)
+// Validate table-level constraints (MoW, skip_bitmap, 
light_schema_change)
 olapTable.validateForFlexiblePartialUpdate();
 
+Map mergedJobProperties = 
Maps.newHashMap(this.jobProperties);
+mergedJobProperties.putAll(newJobProperties);
+
 // Routine load specific validations
 // Must use JSON format
-String format = 
this.jobProperties.getOrDefault(FileFormatProperties.PROP_FORMAT, "csv");
+String format = 
mergedJobProperties.getOrDefault(FileFormatProperties.PROP_FORMAT, "csv");
 if (!"json".equalsIgnoreCase(format)) {
 throw new DdlException("Flexible partial update only supports JSON 
format, but current job uses: "
 + format);
 }
 // Cannot use fuzzy_parse
-if (Boolean.parseBoolean(this.jobProperties.getOrDefault(
+if (Boolean.parseBoolean(mergedJobProperties.getOrDefault(
 JsonFileFormatProperties.PROP_FUZZY_PARSE, "false"))) {
 throw new DdlException("Flexible partial update does not support 
fuzzy_parse");
 }
 // Cannot use jsonpaths
-String jsonPaths = getJsonPaths();
+String jsonPaths = 
mergedJobProperties.get(JsonFileFormatProperties.PROP_JSON_PATHS);
 if (jsonPaths != null && !jsonPaths.isEmpty()) {
 throw new DdlException("Flexible partial update does not support 
jsonpaths");
 }
 // Cannot specify COLUMNS mapping
-if (columnDescs != null && !columnDescs.descs.isEmpty()) {
+if ((columnDescs != null && !columnDescs.descs.isEmpty())
+|| (newRoutineLoadDesc != null && 
newRoutineLoadDesc.getColumnsInfo() != null
+&& !newRoutineLoadDesc.getColumnsInfo().isEmpty())) {
 throw new DdlException("Flexible partial update does not support 
COLUMNS specification");
 }
+validateRoutineLoadDescForFlexiblePartialUpdate(newRoutineLoadDesc);
+}
+
+private void 
validateRoutineLoadDescForFlexiblePartialUpdate(RoutineLoadDesc 
newRoutineLoadDesc)
+throws DdlException {
+boolean newDescHasExplicitMergeType = newRoutineLoadDesc != null
+&& (newRoutineLoadDesc.isMergeTypeSpecified()
+|| newRoutineLoadDesc.getMergeType() != 
LoadTask.MergeType.APPEND);
+if (mergeTypeSpecified || mergeType != LoadTask.MergeType.APPEND || 
newDescHasExplicitMergeType) {
+throw new DdlException("Don't support flexible partial update when 
'merge_type' is specified");
+}
+if (whereExpr != null || (newRoutineLoadDesc != null && 
newRoutineLoadDesc.getFilter() != null)) {
+throw new DdlException("Don't support flexible partial update when 
'where' is specified");

Review Comment:
   This descriptor validation still allows a flexible routine-load job to 
install a `DELETE ON` clause. A concrete path is: create a JSON routine load in 
`UPDATE_FLEXIBLE_COLUMNS`, pause it, then run `ALTER ROUTINE LOAD ... DELETE ON 
is_delete = 1`. `validateFlexiblePartialUpdateForAlter()` calls this helper, 
but the helper only rejects merge type, `WHERE`, and sequence column; 
`setRoutineLoadDesc()` then persists `deleteCondition`. Subsequent planning 
rejects the job in 
`NereidsStreamLoadPlanner.validateLoadTaskForFlexiblePartialUpdate()` because 
`taskInfo.getDeleteCondition() != null`, so the accepted ALTER leaves the job 
unable to schedule tasks. Please reject existing or incoming `deleteCondition` 
here, and add a negative ALTER test for adding `DELETE ON` to an 
already-flexible routine-load job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467749655

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467749661

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3253263277


##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AlterTableCommand.java:
##
@@ -161,6 +162,7 @@ private void rewriteAlterOpForOlapTable(ConnectContext ctx, 
OlapTable table) thr
 throw new AnalysisException("table " + table.getName()
 + " has enabled update flexible columns 
feature already.");
 }
+table.validateVariantColumnsForFlexiblePartialUpdate();
 }

Review Comment:
   This enable-feature path still omits the same `light_schema_change` 
requirement enforced later by `OlapTable.validateForFlexiblePartialUpdate()`. A 
concrete failure path is a UNIQUE MoW table created with 
`"light_schema_change"="false"`: `ALTER TABLE ... ENABLE FEATURE 
"UPDATE_FLEXIBLE_COLUMNS"` passes these checks and adds the hidden skip-bitmap 
column, but every later flexible partial update load is rejected at 
`validateForFlexiblePartialUpdate()` because `getEnableLightSchemaChange()` is 
false. Please reject the ALTER up front, or enable/require light schema change 
atomically with the feature, and add a negative test for this table property.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467710609

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/752be339e61ccfbf2cc5ad4a5c6aa5d093054aaa_752be339e61ccfbf2cc5ad4a5c6aa5d093054aaa_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/752be339e61ccfbf2cc5ad4a5c6aa5d093054aaa_752be339e61ccfbf2cc5ad4a5c6aa5d093054aaa_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.55% (33343/51653) |
   | Region Coverage   | 65.25% (16531/25335) |
   | Branch Coverage   | 55.75% (8836/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467701210

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467701226

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467689899

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/d6104f1efa160b15e62f87d56f45c0ef93e58ac0_d6104f1efa160b15e62f87d56f45c0ef93e58ac0_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/d6104f1efa160b15e62f87d56f45c0ef93e58ac0_d6104f1efa160b15e62f87d56f45c0ef93e58ac0_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.52% (33327/51653) |
   | Region Coverage   | 65.22% (16523/25335) |
   | Branch Coverage   | 55.74% (8834/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467650475

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467650409

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467594768

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467594111

   # FE UT Coverage Report
   Increment line coverage `  76.13% (169/222)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_31b870a633911bd0fba4f1c416d2b4aea80c0089/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_31b870a633911bd0fba4f1c416d2b4aea80c0089/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467594702

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467567804

   # FE UT Coverage Report
   Increment line coverage `  76.13% (169/222)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_cd1a15fc65fd954042dbf59c04794a5462972789/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_cd1a15fc65fd954042dbf59c04794a5462972789/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467554050

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/0b825c284d78844f5e8343eaf061710bd2d9fa03_0b825c284d78844f5e8343eaf061710bd2d9fa03_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/0b825c284d78844f5e8343eaf061710bd2d9fa03_0b825c284d78844f5e8343eaf061710bd2d9fa03_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.50% (33314/51653) |
   | Region Coverage   | 65.19% (16517/25335) |
   | Branch Coverage   | 55.74% (8834/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467551261

   
   
   TPC-DS: Total hot run time: 169557 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit b2c619c454e1a75485a962c7b3fc47053e196549, 
data reload: false
   
   query5   4322660 516 516
   query6   333 222 196 196
   query7   4274568 301 301
   query8   336 240 224 224
   query9   8837401639833983
   query10  452 352 301 301
   query11  5784239621822182
   query12  188 131 125 125
   query13  1292651 444 444
   query14  5995536250865086
   query14_14361436143164316
   query15  214 206 184 184
   query16  1033449 432 432
   query17  1162760 608 608
   query18  2699488 359 359
   query19  217 210 168 168
   query20  136 134 135 134
   query21  225 142 123 123
   query22  13679   13668   13587   13587
   query23  17034   16382   16089   16089
   query23_116207   16183   16182   16182
   query24  7425176213071307
   query24_11303131313151313
   query25  586 495 436 436
   query26  1317319 177 177
   query27  2692555 352 352
   query28  4348195819531953
   query29  1005653 518 518
   query30  308 240 204 204
   query31  11311056936 936
   query32  103 78  78  78
   query33  552 360 330 330
   query34  11591114644 644
   query35  764 788 716 716
   query36  1332136211451145
   query37  147 102 90  90
   query38  3216314330663066
   query39  940 931 884 884
   query39_1867 874 861 861
   query40  225 146 123 123
   query41  71  65  61  61
   query42  113 108 110 108
   query43  316 325 288 288
   query44  
   query45  208 199 198 198
   query46  10871222744 744
   query47  2326229422192219
   query48  393 409 303 303
   query49  656 491 390 390
   query50  948 350 248 248
   query51  4327433742524252
   query52  105 103 100 100
   query53  254 282 202 202
   query54  308 270 262 262
   query55  94  89  92  89
   query56  299 344 314 314
   query57  1409141013291329
   query58  297 270 260 260
   query59  1510161013911391
   query60  324 331 312 312
   query61  160 156 155 155
   query62  665 624 575 575
   query63  242 201 203 201
   query64  2371810 627 627
   query65  
   query66  1742472 355 355
   query67  30063   29955   29850   29850
   query68  
   query69  471 336 298 298
   query70  10111000958 958
   query71  308 272 294 272
   query72  3020270624272427
   query73  848 723 419 419
   query74  5069486747534753
   query75  2664258522472247
   query76  21451147772 772
   query77  395 403 336 336
   query78  12163   12128   11503   11503
   query79  14421064728 728
   query80  786 548 457 457
   query81  489 280 239 239
   query82  1305164 123 123
   query83  359 284 248 248
   query84  263 138 107 107
   query85  920 534 464 464
   query86  434 334 304 304
   query87  3447339532213221
   query88  3496263025922592
   query89  445 389 336 336
   query90  1802177 179 177
   query91  176 167 141 141
   query92  90  76  74  74
   query93  14951379888 888
   query94  629 359 301 301
   query95  669 378 345 345
   query96  1007776 324 324
   query97  2708270925982598
   query98  240 229 226 226
   query99  11091098989 989
   Total cold run time: 252983 ms
   Total hot run time: 169557 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467535189

   
   
   TPC-DS: Total hot run time: 169162 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 31b870a633911bd0fba4f1c416d2b4aea80c0089, 
data reload: false
   
   query5   4324664 512 512
   query6   343 210 198 198
   query7   4252556 286 286
   query8   334 237 214 214
   query9   8816400740264007
   query10  465 337 297 297
   query11  5808236421892189
   query12  178 129 126 126
   query13  1296620 439 439
   query14  6016538450605060
   query14_14382437343644364
   query15  217 208 186 186
   query16  1050477 458 458
   query17  1174748 604 604
   query18  2627492 362 362
   query19  233 204 165 165
   query20  138 130 131 130
   query21  216 139 121 121
   query22  13609   13653   13436   13436
   query23  17178   16379   15940   15940
   query23_116086   16155   16133   16133
   query24  7270177112831283
   query24_11336128313271283
   query25  582 501 453 453
   query26  1324324 182 182
   query27  2683585 349 349
   query28  4355195719301930
   query29  1013646 516 516
   query30  308 237 210 210
   query31  11341076949 949
   query32  99  78  73  73
   query33  547 362 308 308
   query34  11721145641 641
   query35  774 801 676 676
   query36  1332132311941194
   query37  153 108 114 108
   query38  3198317630743074
   query39  923 953 917 917
   query39_1888 905 864 864
   query40  229 145 125 125
   query41  69  62  63  62
   query42  111 106 122 106
   query43  324 332 286 286
   query44  
   query45  210 198 195 195
   query46  10331177726 726
   query47  2266231922052205
   query48  396 420 294 294
   query49  638 493 379 379
   query50  982 355 258 258
   query51  4412432742454245
   query52  106 105 103 103
   query53  262 282 207 207
   query54  309 286 262 262
   query55  92  87  82  82
   query56  301 319 315 315
   query57  1386138412961296
   query58  300 281 263 263
   query59  1548163214521452
   query60  320 325 303 303
   query61  160 158 188 158
   query62  648 622 580 580
   query63  242 196 213 196
   query64  2369792 632 632
   query65  
   query66  1679486 364 364
   query67  30056   30014   29900   29900
   query68  
   query69  463 326 312 312
   query70  1021994 983 983
   query71  307 277 270 270
   query72  3037267624182418
   query73  867 780 452 452
   query74  5091491847534753
   query75  2684258822742274
   query76  21541171765 765
   query77  398 417 338 338
   query78  12090   12061   11667   11667
   query79  14591046737 737
   query80  731 538 457 457
   query81  464 281 246 246
   query82  1310162 121 121
   query83  333 272 244 244
   query84  261 142 115 115
   query85  903 553 487 487
   query86  405 365 312 312
   query87  3392343631853185
   query88  3550267826452645
   query89  454 387 335 335
   query90  1966182 187 182
   query91  179 162 149 149
   query92  85  79  74  74
   query93  14561454855 855
   query94  547 344 307 307
   query95  692 493 350 350
   query96  1029761 328 328
   query97  2676268125672567
   query98  245 237 239 237
   query99  11011080980 980
   Total cold run time: 252657 ms
   Total hot run time: 169162 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467526906

   
   
   TPC-H: Total hot run time: 30798 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit b2c619c454e1a75485a962c7b3fc47053e196549, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17031   390437883788
   q2   q3  10551   1373811 811
   q4   4668473 348 348
   q5   7819225020812081
   q6   241 174 139 139
   q7   965 777 621 621
   q8   9409161116241611
   q9   5138493548974897
   q10  6416210117791779
   q11  442 273 245 245
   q12  634 422 293 293
   q13  18128   345428122812
   q14  260 255 237 237
   q15  q16 808 770 708 708
   q17  909 890 946 890
   q18  7018569054975497
   q19  1162122211191119
   q20  534 398 265 265
   q21  5449263423492349
   q22  419 357 308 308
   Total cold run time: 98001 ms
   Total hot run time: 30798 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4187407240814072
   q2   q3  4491496543234323
   q4   2079221013851385
   q5   4404426942924269
   q6   227 177 131 131
   q7   1756157118441571
   q8   2594222520812081
   q9   7742777976947694
   q10  4510447640694069
   q11  564 418 378 378
   q12  721 737 527 527
   q13  3309363330163016
   q14  296 302 287 287
   q15  q16 718 792 633 633
   q17  1332129913231299
   q18  7978734670117011
   q19  1079109710721072
   q20  2219221619191919
   q21  5281463644514451
   q22  517 487 424 424
   Total cold run time: 56004 ms
   Total hot run time: 50612 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467505791

   
   
   TPC-H: Total hot run time: 30842 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 31b870a633911bd0fba4f1c416d2b4aea80c0089, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17058   388838873887
   q2   q3  10508   1347803 803
   q4   4667474 353 353
   q5   7814223020672067
   q6   243 181 136 136
   q7   963 787 623 623
   q8   9478172915741574
   q9   5064493448234823
   q10  6411207517831783
   q11  448 273 245 245
   q12  636 429 293 293
   q13  18129   334527932793
   q14  261 252 232 232
   q15  q16 822 780 709 709
   q17  1002995 991 991
   q18  7523554154615461
   q19  1151136711051105
   q20  516 399 265 265
   q21  5578255523892389
   q22  444 367 310 310
   Total cold run time: 98716 ms
   Total hot run time: 30842 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4194412041104110
   q2   q3  4472488844304430
   q4   2119218713981398
   q5   4361435942784278
   q6   233 176 132 132
   q7   1724189116341634
   q8   2585216620362036
   q9   7682772577197719
   q10  4537443740274027
   q11  594 391 378 378
   q12  739 724 521 521
   q13  3326361229792979
   q14  292 316 282 282
   q15  q16 718 751 667 667
   q17  1361128313011283
   q18  8027735670777077
   q19  1103109010911090
   q20  220519361936
   q21  5269462145184518
   q22  519 466 413 413
   Total cold run time: 56060 ms
   Total hot run time: 50908 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467483677

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467483336

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467473355

   # FE UT Coverage Report
   Increment line coverage `  76.12% (153/201)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_e9391dc33ababec0ebfaa1c88519de57f21195da/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_e9391dc33ababec0ebfaa1c88519de57f21195da/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467465227

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/31b870a633911bd0fba4f1c416d2b4aea80c0089_31b870a633911bd0fba4f1c416d2b4aea80c0089_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/31b870a633911bd0fba4f1c416d2b4aea80c0089_31b870a633911bd0fba4f1c416d2b4aea80c0089_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.55% (33343/51653) |
   | Region Coverage   | 65.25% (16532/25335) |
   | Branch Coverage   | 55.77% (8839/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467428240

   # BE UT Coverage Report
   Increment line coverage `64.96% (571/879)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/e9391dc33ababec0ebfaa1c88519de57f21195da_e9391dc33ababec0ebfaa1c88519de57f21195da/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/e9391dc33ababec0ebfaa1c88519de57f21195da_e9391dc33ababec0ebfaa1c88519de57f21195da/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.56% (20692/38636) |
   | Line Coverage | 37.22% (195722/525917) |
   | Region Coverage   | 33.56% (153130/456271) |
   | Branch Coverage   | 34.60% (66820/193113) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467414037

   
   
   TPC-DS: Total hot run time: 168098 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit e9391dc33ababec0ebfaa1c88519de57f21195da, 
data reload: false
   
   query5   4322656 515 515
   query6   332 211 197 197
   query7   4237565 308 308
   query8   342 235 242 235
   query9   8831395339543953
   query10  448 342 308 308
   query11  5790240321812181
   query12  189 125 124 124
   query13  1295579 414 414
   query14  5914532950115011
   query14_14350429843074298
   query15  211 202 181 181
   query16  991 450 421 421
   query17  1120712 581 581
   query18  2505492 373 373
   query19  221 211 169 169
   query20  148 135 135 135
   query21  220 140 122 122
   query22  13557   13521   13731   13521
   query23  17096   16357   15915   15915
   query23_116160   16233   16189   16189
   query24  7211177012771277
   query24_11302131413051305
   query25  614 510 440 440
   query26  1316326 173 173
   query27  2686591 345 345
   query28  4333197719511951
   query29  1003649 540 540
   query30  308 233 204 204
   query31  11051060966 966
   query32  86  76  78  76
   query33  553 364 298 298
   query34  11891192664 664
   query35  751 806 667 667
   query36  1341138511451145
   query37  153 107 95  95
   query38  3201315930493049
   query39  931 925 920 920
   query39_1875 886 868 868
   query40  231 145 130 130
   query41  71  70  66  66
   query42  109 114 114 114
   query43  326 341 289 289
   query44  
   query45  213 203 194 194
   query46  10541144723 723
   query47  2300233821842184
   query48  398 415 303 303
   query49  648 506 406 406
   query50  1006353 262 262
   query51  4313425941904190
   query52  108 107 98  98
   query53  260 283 208 208
   query54  328 284 271 271
   query55  110 92  89  89
   query56  333 323 315 315
   query57  1409138913061306
   query58  315 279 282 279
   query59  1607159914481448
   query60  314 323 301 301
   query61  153 155 154 154
   query62  661 621 567 567
   query63  233 204 209 204
   query64  2357806 632 632
   query65  
   query66  1690478 351 351
   query67  29410   29804   29183   29183
   query68  
   query69  469 337 296 296
   query70  1041982 990 982
   query71  298 267 265 265
   query72  3065266623372337
   query73  805 750 424 424
   query74  5030498146964696
   query75  2693257422462246
   query76  21201132760 760
   query77  386 407 339 339
   query78  12195   12148   11568   11568
   query79  14751036745 745
   query80  1211547 454 454
   query81  504 281 242 242
   query82  1299159 124 124
   query83  349 283 244 244
   query84  257 141 109 109
   query85  957 552 445 445
   query86  431 318 313 313
   query87  3407342231873187
   query88  3504266026522652
   query89  455 376 333 333
   query90  1846180 175 175
   query91  179 163 140 140
   query92  95  74  66  66
   query93  15381428933 933
   query94  636 353 294 294
   query95  663 393 340 340
   query96  1007798 341 341
   query97  2720268125582558
   query98  234 227 223 223
   query99  11571097971 971
   Total cold run time: 252301 ms
   Total hot run time: 168098 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467411827

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467411648

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3253088584


##
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##
@@ -3213,9 +3214,93 @@ public void validateForFlexiblePartialUpdate() throws 
UserException {
 throw new UserException("Flexible partial update can only support 
table with light_schema_change enabled."
 + " But table " + getName() + "'s property 
light_schema_change is false");
 }
-if (hasVariantColumns()) {
-throw new UserException("Flexible partial update can only support 
table without variant columns.");
+validateVariantColumnsForFlexiblePartialUpdate();
+}
+
+public void validateVariantColumnsForFlexiblePartialUpdate() throws 
UserException {
+validateVariantColumnsForFlexiblePartialUpdate(getBaseSchema(), 
variantEnableFlattenNested());
+}
+
+public static void 
validateVariantColumnsForFlexiblePartialUpdate(List columns) throws 
UserException {
+validateVariantColumnsForFlexiblePartialUpdate(columns, false);
+}
+
+public static void validateVariantColumnsForFlexiblePartialUpdate(
+List columns, boolean deprecatedVariantFlattenNested) 
throws UserException {
+boolean hasVariantColumn = false;
+for (Column column : columns) {
+validateVariantColumnForFlexiblePartialUpdate(column);
+if (column.getType().isVariantType() && 
deprecatedVariantFlattenNested) {
+throw new UserException(
+"VARIANT flexible partial update does not support "
++ "deprecated_variant_enable_flatten_nested in 
this version");
+}
+hasVariantColumn |= column.getType().isVariantType();
+}
+if (hasVariantColumn) {
+try {
+validateBackendsSupportVariantFlexiblePartialUpdate(
+
Env.getCurrentSystemInfo().getAllBackendsByAllCluster().values());
+} catch (AnalysisException e) {
+throw new UserException(e.getMessage(), e);
+}
+}
+}
+
+public static void validateVariantColumnForFlexiblePartialUpdate(Column 
column) throws UserException {
+if (column.getType().isVariantType() && 
column.getVariantEnableDocMode()) {
+throw new UserException(
+"VARIANT flexible partial update does not support doc mode 
in this version");
+}
+}
+
+@VisibleForTesting
+static void 
validateBackendsSupportVariantFlexiblePartialUpdate(Collection 
backends)
+throws UserException {
+for (Backend backend : backends) {
+if (!backend.isAlive()) {
+continue;
+}
+if 
(backendVersionSupportsVariantFlexiblePartialUpdate(backend.getVersion())) {
+continue;
+}
+throw new UserException("VARIANT flexible partial update requires 
all alive backends to "
++ "support variant patch skip-bitmap markers. Backend " + 
backend.getId() + " ("
++ backend.getHost() + ") is running version " + 
backend.getVersion()
++ ", expected at least " + Version.DORIS_BUILD_VERSION);
+}
+}
+
+@VisibleForTesting
+static boolean backendVersionSupportsVariantFlexiblePartialUpdate(String 
backendVersion) {
+if (Strings.isNullOrEmpty(backendVersion)) {
+return false;
+}
+if (backendVersion.equals(Version.DORIS_BUILD_VERSION)
+|| backendVersion.startsWith(Version.DORIS_BUILD_VERSION + 
"-")) {

Review Comment:
   This does not actually prove that every backend understands the new VARIANT 
skip-bitmap marker format. It compares only the semantic build version, so an 
old BE binary from the same release branch/build version as the FE still passes 
this check during rolling upgrade even though its 
`FlexibleReadPlan::prepare_to_read()` will treat the high-bit marker values as 
ordinary column unique ids. The `!backend.isAlive()` skip above has a similar 
failure path: a BE that is down during validation can later restart with old 
code and publish/compact/read rowsets containing these markers. This is a 
follow-up to the existing marker-compatibility thread, but distinct because 
this newly added gate is the concrete implementation that still lets 
incompatible BEs through. Please gate on an explicit BE capability/build 
hash/protocol feature advertised by every backend that can participate in the 
table, or otherwise keep VARIANT flexible partial update disabled until old BEs 
cannot process the rowsets.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467378932

   
   
   TPC-H: Total hot run time: 30778 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit e9391dc33ababec0ebfaa1c88519de57f21195da, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   16772   379037683768
   q2   q3  10450   1305792 792
   q4   4667466 357 357
   q5   7968223520862086
   q6   233 171 138 138
   q7   962 750 643 643
   q8   9381163415771577
   q9   5052496748574857
   q10  6375209917991799
   q11  474 270 244 244
   q12  624 417 294 294
   q13  18121   333727342734
   q14  256 258 239 239
   q15  q16 794 778 701 701
   q17  929 885 906 885
   q18  6787579255175517
   q19  1183131610911091
   q20  490 390 255 255
   q21  5559260724912491
   q22  429 357 310 310
   Total cold run time: 97506 ms
   Total hot run time: 30778 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4162409940844084
   q2   q3  4494490443084308
   q4   2084221213741374
   q5   4407422742204220
   q6   222 176 126 126
   q7   1747165017021650
   q8   2694217420122012
   q9   7701760876937608
   q10  4547445940624062
   q11  569 420 383 383
   q12  730 743 522 522
   q13  3313375728572857
   q14  293 309 289 289
   q15  q16 717 763 670 670
   q17  1369128212981282
   q18  8035736971737173
   q19  1091109511051095
   q20  2208219919211921
   q21  5258458844384438
   q22  512 477 409 409
   Total cold run time: 56153 ms
   Total hot run time: 50483 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467370878

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467370898

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467349905

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467350285

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467334116

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/e9391dc33ababec0ebfaa1c88519de57f21195da_e9391dc33ababec0ebfaa1c88519de57f21195da_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/e9391dc33ababec0ebfaa1c88519de57f21195da_e9391dc33ababec0ebfaa1c88519de57f21195da_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.49% (33313/51653) |
   | Region Coverage   | 65.19% (16517/25335) |
   | Branch Coverage   | 55.70% (8828/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467294885

   
   
   TPC-DS: Total hot run time: 169431 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 1dc8d60171456e4031c5f8012198ca0699188f3e, 
data reload: false
   
   query5   4340654 519 519
   query6   328 229 197 197
   query7   4283576 318 318
   query8   341 240 220 220
   query9   8813401339783978
   query10  452 339 310 310
   query11  5797246522452245
   query12  186 131 126 126
   query13  1272615 424 424
   query14  5941536750615061
   query14_14364435843204320
   query15  209 203 187 187
   query16  1045465 445 445
   query17  1154745 607 607
   query18  2773499 361 361
   query19  230 206 164 164
   query20  138 135 127 127
   query21  220 146 126 126
   query22  13590   13513   13303   13303
   query23  17232   16339   16097   16097
   query23_116176   16203   16308   16203
   query24  7279177412931293
   query24_11312127613271276
   query25  583 493 431 431
   query26  1319322 171 171
   query27  2685577 343 343
   query28  4331196719381938
   query29  1014661 513 513
   query30  307 243 206 206
   query31  10991066945 945
   query32  94  77  75  75
   query33  545 375 334 334
   query34  11641121642 642
   query35  776 782 659 659
   query36  1360136111371137
   query37  147 105 91  91
   query38  3183311130493049
   query39  917 917 895 895
   query39_1877 890 883 883
   query40  230 142 127 127
   query41  69  62  61  61
   query42  109 111 108 108
   query43  323 336 292 292
   query44  
   query45  207 202 190 190
   query46  10411185722 722
   query47  2307239022192219
   query48  380 405 296 296
   query49  627 497 378 378
   query50  968 340 257 257
   query51  4420437642174217
   query52  104 106 98  98
   query53  245 299 198 198
   query54  324 269 263 263
   query55  96  91  86  86
   query56  303 306 295 295
   query57  1429142713341334
   query58  300 267 271 267
   query59  1552161114161416
   query60  320 344 310 310
   query61  164 162 164 162
   query62  665 611 566 566
   query63  243 201 203 201
   query64  2379809 644 644
   query65  
   query66  1652484 362 362
   query67  29990   29965   29855   29855
   query68  
   query69  468 336 302 302
   query70  1104100010111000
   query71  306 274 265 265
   query72  3030274724262426
   query73  856 786 418 418
   query74  5050488947314731
   query75  2659263022292229
   query76  22001139724 724
   query77  414 408 313 313
   query78  12265   12204   11611   11611
   query79  14421032733 733
   query80  648 544 469 469
   query81  454 284 239 239
   query82  1311163 125 125
   query83  354 280 249 249
   query84  264 138 112 112
   query85  884 539 453 453
   query86  387 341 314 314
   query87  3423337831953195
   query88  3516263426152615
   query89  456 382 335 335
   query90  1937173 185 173
   query91  186 169 139 139
   query92  81  79  75  75
   query93  15061498900 900
   query94  545 356 313 313
   query95  684 381 443 381
   query96  1027766 337 337
   query97  2692272725552555
   query98  234 232 226 226
   query99  1108982 982
   Total cold run time: 252779 ms
   Total hot run time: 169431 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467267330

   
   
   TPC-H: Total hot run time: 31023 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 1dc8d60171456e4031c5f8012198ca0699188f3e, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17194   387739253877
   q2   q3  10509   1394797 797
   q4   4672469 364 364
   q5   792720792079
   q6   238 177 141 141
   q7   960 790 642 642
   q8   9403179915951595
   q9   5183489849074898
   q10  6400210317591759
   q11  426 274 248 248
   q12  638 436 296 296
   q13  18106   344227972797
   q14  261 254 238 238
   q15  q16 820 773 710 710
   q17  1010960 931 931
   q18  6818576756555655
   q19  1189131310191019
   q20  499 400 259 259
   q21  5543260324192419
   q22  432 363 299 299
   Total cold run time: 98228 ms
   Total hot run time: 31023 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4234410441184104
   q2   q3  4483492143074307
   q4   2110222114111411
   q5   4406429343174293
   q6   224 172 129 129
   q7   1747196618301830
   q8   2638223822312231
   q9   7918816578397839
   q10  4542455840024002
   q11  574 445 384 384
   q12  729 754 525 525
   q13  3364362429682968
   q14  306 300 274 274
   q15  q16 741 739 647 647
   q17  1329133614181336
   q18  8003734172687268
   q19  1190114410871087
   q20  2206222319391939
   q21  5408476446434643
   q22  509 474 402 402
   Total cold run time: 56661 ms
   Total hot run time: 51619 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467261869

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467261640

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467236728

   # BE UT Coverage Report
   Increment line coverage `64.96% (571/879)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/1dc8d60171456e4031c5f8012198ca0699188f3e_1dc8d60171456e4031c5f8012198ca0699188f3e/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/1dc8d60171456e4031c5f8012198ca0699188f3e_1dc8d60171456e4031c5f8012198ca0699188f3e/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.59% (20705/38636) |
   | Line Coverage | 37.24% (195848/525917) |
   | Region Coverage   | 33.60% (153324/456271) |
   | Branch Coverage   | 34.63% (66881/193113) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467176436

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467071763

   
   
   TPC-DS: Total hot run time: 169679 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 1c0312b24ec19ef2ef7e67f6d6e7ca260b89d9a7, 
data reload: false
   
   query5   4315650 504 504
   query6   338 215 209 209
   query7   4271569 303 303
   query8   322 237 237 237
   query9   8826400340104003
   query10  458 356 297 297
   query11  5738242522062206
   query12  173 131 128 128
   query13  1300601 424 424
   query14  5949539750705070
   query14_14367437343534353
   query15  213 211 186 186
   query16  1018477 471 471
   query17  1179774 579 579
   query18  2465478 350 350
   query19  212 207 188 188
   query20  135 137 135 135
   query21  213 136 120 120
   query22  13641   13621   13338   13338
   query23  17346   16484   16144   16144
   query23_116173   16234   16214   16214
   query24  7542179113011301
   query24_11290130913121309
   query25  539 490 405 405
   query26  1305321 168 168
   query27  2710558 340 340
   query28  4419193119371931
   query29  934 619 487 487
   query30  303 237 199 199
   query31  11091070942 942
   query32  94  76  78  76
   query33  538 351 295 295
   query34  11621159654 654
   query35  756 772 667 667
   query36  1358133611631163
   query37  148 108 96  96
   query38  3245314330403040
   query39  915 925 901 901
   query39_1881 875 882 875
   query40  226 152 125 125
   query41  68  64  63  63
   query42  112 109 106 106
   query43  324 327 281 281
   query44  
   query45  209 201 193 193
   query46  10951174706 706
   query47  2301232122282228
   query48  401 423 290 290
   query49  636 491 388 388
   query50  1000345 244 244
   query51  4327436641874187
   query52  104 114 95  95
   query53  255 275 207 207
   query54  320 272 252 252
   query55  95  90  87  87
   query56  293 314 310 310
   query57  1404139613181318
   query58  305 275 275 275
   query59  1522156914041404
   query60  324 330 314 314
   query61  164 167 161 161
   query62  663 620 563 563
   query63  242 199 209 199
   query64  2415800 627 627
   query65  
   query66  1725506 355 355
   query67  30040   29985   29881   29881
   query68  
   query69  474 334 303 303
   query70  10701011989 989
   query71  299 272 269 269
   query72  2985293423982398
   query73  840 727 428 428
   query74  5155491047324732
   query75  2700262222982298
   query76  22801148774 774
   query77  416 411 344 344
   query78  12276   12078   11698   11698
   query79  12491067738 738
   query80  637 572 486 486
   query81  453 284 241 241
   query82  247 168 128 128
   query83  280 295 252 252
   query84  268 151 114 114
   query85  946 612 550 550
   query86  376 348 324 324
   query87  3375337332273227
   query88  3506267026692669
   query89  417 392 341 341
   query90  2171188 192 188
   query91  236 168 137 137
   query92  81  89  75  75
   query93  13701406885 885
   query94  544 372 316 316
   query95  664 469 345 345
   query96  1020815 360 360
   query97  2686273325912591
   query98  243 227 234 227
   query99  11351100975 975
   Total cold run time: 251761 ms
   Total hot run time: 169679 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467047667

   
   
   TPC-H: Total hot run time: 31260 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 1c0312b24ec19ef2ef7e67f6d6e7ca260b89d9a7, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17759   386738533853
   q2   q3  10746   1406821 821
   q4   4690476 348 348
   q5   7599233121002100
   q6   241 180 137 137
   q7   928 790 648 648
   q8   9357168215331533
   q9   5063490349104903
   q10  6374210318341834
   q11  434 270 249 249
   q12  636 417 290 290
   q13  18131   342328262826
   q14  266 257 236 236
   q15  q16 792 783 714 714
   q17  963 945 949 945
   q18  6692586255275527
   q19  1184130610471047
   q20  464 384 259 259
   q21  5578283526752675
   q22  454 390 315 315
   Total cold run time: 98351 ms
   Total hot run time: 31260 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4744456245534553
   q2   q3  4943534445894589
   q4   2135220414271427
   q5   4897470746114611
   q6   233 172 133 133
   q7   1892172915211521
   q8   2368216121092109
   q9   7616733872297229
   q10  4492440339433943
   q11  526 380 352 352
   q12  709 719 509 509
   q13  3059337028032803
   q14  267 285 244 244
   q15  q16 681 693 610 610
   q17  1260123212241224
   q18  7338691667096709
   q19  1103111410941094
   q20  2241222719351935
   q21  5306457644624462
   q22  515 468 388 388
   Total cold run time: 56325 ms
   Total hot run time: 50445 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4467018737

   # FE UT Coverage Report
   Increment line coverage `  76.12% (153/201)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_1dc8d60171456e4031c5f8012198ca0699188f3e/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_1dc8d60171456e4031c5f8012198ca0699188f3e/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4466978790

   # FE UT Coverage Report
   Increment line coverage `  76.80% (149/194)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_1c0312b24ec19ef2ef7e67f6d6e7ca260b89d9a7/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_1c0312b24ec19ef2ef7e67f6d6e7ca260b89d9a7/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4466899548

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/1dc8d60171456e4031c5f8012198ca0699188f3e_1dc8d60171456e4031c5f8012198ca0699188f3e_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/1dc8d60171456e4031c5f8012198ca0699188f3e_1dc8d60171456e4031c5f8012198ca0699188f3e_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.06% (1854/2375) |
   | Line Coverage | 64.52% (33329/51653) |
   | Region Coverage   | 65.23% (16525/25335) |
   | Branch Coverage   | 55.76% (8837/15848) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4466835105

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4466834760

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4466801430

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-16 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4466801209

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4447501649

   # FE Regression Coverage Report
   Increment line coverage `  67.20% (125/186)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_ba85f4eb2f0c88f51a99f89dacee1072180a35ac_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_ba85f4eb2f0c88f51a99f89dacee1072180a35ac_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4447453610

   # BE Regression && UT Coverage Report
   Increment line coverage `92.69% (812/876)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_ba85f4eb2f0c88f51a99f89dacee1072180a35ac_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_ba85f4eb2f0c88f51a99f89dacee1072180a35ac_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.75% (27827/37733) |
   | Line Coverage | 57.66% (301784/523354) |
   | Region Coverage   | 54.84% (251741/459006) |
   | Branch Coverage   | 56.40% (109044/193351) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4447075967

   # FE UT Coverage Report
   Increment line coverage `  76.09% (140/184)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_ba85f4eb2f0c88f51a99f89dacee1072180a35ac/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_ba85f4eb2f0c88f51a99f89dacee1072180a35ac/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4447039081

   # BE UT Coverage Report
   Increment line coverage `65.18% (571/876)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/ba85f4eb2f0c88f51a99f89dacee1072180a35ac_ba85f4eb2f0c88f51a99f89dacee1072180a35ac/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/ba85f4eb2f0c88f51a99f89dacee1072180a35ac_ba85f4eb2f0c88f51a99f89dacee1072180a35ac/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.62% (20662/38533) |
   | Line Coverage | 37.25% (195447/524735) |
   | Region Coverage   | 33.65% (152985/454590) |
   | Branch Coverage   | 34.66% (66759/192623) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446832545

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/ba85f4eb2f0c88f51a99f89dacee1072180a35ac_ba85f4eb2f0c88f51a99f89dacee1072180a35ac_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/ba85f4eb2f0c88f51a99f89dacee1072180a35ac_ba85f4eb2f0c88f51a99f89dacee1072180a35ac_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.03% (1850/2371) |
   | Line Coverage | 64.69% (33224/51362) |
   | Region Coverage   | 65.23% (16447/25214) |
   | Branch Coverage   | 55.71% (8779/15758) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446802216

   
   
   TPC-DS: Total hot run time: 172873 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit ba85f4eb2f0c88f51a99f89dacee1072180a35ac, 
data reload: false
   
   query5   4314650 531 531
   query6   328 239 215 215
   query7   4238563 299 299
   query8   340 235 252 235
   query9   8855410940524052
   query10  502 342 304 304
   query11  6035244121952195
   query12  185 130 128 128
   query13  1273617 445 445
   query14  6208549050915091
   query14_14425443844424438
   query15  209 207 191 191
   query16  1001457 466 457
   query17  1133817 607 607
   query18  2614461 352 352
   query19  215 203 159 159
   query20  133 131 133 131
   query21  215 132 114 114
   query22  13545   14209   14506   14209
   query23  17408   16534   16205   16205
   query23_116308   16284   16207   16207
   query24  7450174213381338
   query24_11336136713591359
   query25  553 489 423 423
   query26  1317318 165 165
   query27  2727631 341 341
   query28  4406199219181918
   query29  980 631 517 517
   query30  303 230 199 199
   query31  11071065917 917
   query32  87  72  67  67
   query33  513 354 300 300
   query34  11631137670 670
   query35  788 790 674 674
   query36  1326133311401140
   query37  150 100 85  85
   query38  3162314030323032
   query39  949 923 871 871
   query39_1877 869 875 869
   query40  230 157 137 137
   query41  64  60  60  60
   query42  107 107 104 104
   query43  324 327 283 283
   query44  
   query45  205 201 188 188
   query46  10221203728 728
   query47  2251230021822182
   query48  397 413 305 305
   query49  630 525 425 425
   query50  718 284 208 208
   query51  4314430442944294
   query52  104 103 92  92
   query53  238 268 203 203
   query54  310 262 251 251
   query55  94  88  87  87
   query56  303 301 331 301
   query57  1393139513131313
   query58  287 261 273 261
   query59  1583163215141514
   query60  347 337 326 326
   query61  153 177 152 152
   query62  668 618 558 558
   query63  243 201 206 201
   query64  2388815 665 665
   query65  
   query66  1712517 389 389
   query67  30011   29884   30178   29884
   query68  
   query69  447 351 315 315
   query70  1066969 1042969
   query71  314 295 276 276
   query72  2926281826502650
   query73  812 748 418 418
   query74  5063500447474747
   query75  2778266423322332
   query76  23331150768 768
   query77  437 448 369 369
   query78  13018   13058   12403   12403
   query79  1521963 740 740
   query80  1236611 534 534
   query81  498 286 244 244
   query82  1414173 127 127
   query83  361 287 261 261
   query84  274 149 118 118
   query85  972 527 444 444
   query86  428 347 310 310
   query87  3405335432273227
   query88  3560270026512651
   query89  446 378 339 339
   query90  1804191 190 190
   query91  181 173 136 136
   query92  77  76  74  74
   query93  959 989 559 559
   query94  623 339 289 289
   query95  663 462 345 345
   query96  996 745 339 339
   query97  2725272525842584
   query98  243 230 223 223
   query99  10861086963 963
   Total cold run time: 254363 ms
   Total hot run time: 172873 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446723008

   
   
   TPC-H: Total hot run time: 29637 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit ba85f4eb2f0c88f51a99f89dacee1072180a35ac, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17646   394740003947
   q2   q3  10724   879 609 609
   q4   4658456 351 351
   q5   7450133811321132
   q6   186 170 142 142
   q7   928 952 748 748
   q8   9324140912701270
   q9   5600541553615361
   q10  6242207318041804
   q11  465 266 265 265
   q12  628 419 297 297
   q13  18152   320227642764
   q14  294 280 267 267
   q15  q16 854 869 792 792
   q17  10031150695 695
   q18  6487577156435643
   q19  1145126811041104
   q20  496 396 262 262
   q21  3975227918711871
   q22  437 358 313 313
   Total cold run time: 96694 ms
   Total hot run time: 29637 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4160410641214106
   q2   q3  4663477442244224
   q4   2167224014321432
   q5   5021492851824928
   q6   185 169 132 132
   q7   2034181917511751
   q8   3659325232303230
   q9   8601854085728540
   q10  4531455342544254
   q11  649 453 438 438
   q12  713 759 531 531
   q13  3577379928982898
   q14  327 317 286 286
   q15  q16 794 768 761 761
   q17  1367139413681368
   q18  8136732472757275
   q19  1147115911811159
   q20  2268222519671967
   q21  6270561651595159
   q22  592 564 432 432
   Total cold run time: 60861 ms
   Total hot run time: 54871 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446670920

   # BE UT Coverage Report
   Increment line coverage `65.18% (571/876)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/9130a404d6d81627039305cc248d9eb36f94257c_9130a404d6d81627039305cc248d9eb36f94257c/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/9130a404d6d81627039305cc248d9eb36f94257c_9130a404d6d81627039305cc248d9eb36f94257c/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.62% (20662/38533) |
   | Line Coverage | 37.24% (195418/524735) |
   | Region Coverage   | 33.63% (152883/454590) |
   | Branch Coverage   | 34.65% (66752/192623) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446637649

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446637603

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446565416

   # FE UT Coverage Report
   Increment line coverage `  78.29% (101/129)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_04c3d8f2abd1b06ced93665c536bb441436e3f11/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_04c3d8f2abd1b06ced93665c536bb441436e3f11/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446564463

   
   
   TPC-DS: Total hot run time: 169879 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 9130a404d6d81627039305cc248d9eb36f94257c, 
data reload: false
   
   query5   4323656 523 523
   query6   330 219 206 206
   query7   4229564 292 292
   query8   338 239 230 230
   query9   8877411140654065
   query10  455 332 324 324
   query11  5829240022212221
   query12  193 130 128 128
   query13  1299592 448 448
   query14  6729543151315131
   query14_14434439744224397
   query15  215 206 186 186
   query16  1019472 446 446
   query17  1401779 639 639
   query18  2728489 365 365
   query19  315 212 171 171
   query20  144 135 132 132
   query21  217 141 121 121
   query22  13669   13462   13398   13398
   query23  17179   16368   16002   16002
   query23_116208   16130   16177   16130
   query24  7388184713941394
   query24_11372136213741362
   query25  580 530 478 478
   query26  1329319 179 179
   query27  2619585 353 353
   query28  4343198919621962
   query29  1007652 560 560
   query30  310 245 205 205
   query31  11211079957 957
   query32  97  85  75  75
   query33  540 366 325 325
   query34  11421121630 630
   query35  767 792 723 723
   query36  1314134511821182
   query37  155 106 87  87
   query38  3180314430683068
   query39  925 926 885 885
   query39_1864 870 880 870
   query40  228 162 138 138
   query41  65  63  60  60
   query42  108 110 110 110
   query43  333 326 298 298
   query44  
   query45  213 201 200 200
   query46  10471243728 728
   query47  2259235122032203
   query48  398 429 289 289
   query49  638 532 436 436
   query50  701 284 213 213
   query51  4295431942374237
   query52  106 109 104 104
   query53  256 296 209 209
   query54  306 272 260 260
   query55  94  91  84  84
   query56  305 319 296 296
   query57  1411135112931293
   query58  296 283 270 270
   query59  1536162513771377
   query60  364 361 351 351
   query61  153 155 161 155
   query62  672 618 566 566
   query63  238 199 205 199
   query64  2347846 680 680
   query65  
   query66  1711526 397 397
   query67  30168   29923   29128   29128
   query68  
   query69  454 334 296 296
   query70  10171052966 966
   query71  300 271 272 271
   query72  2904270624572457
   query73  846 744 422 422
   query74  5076495447464746
   query75  2774268323442344
   query76  22681120754 754
   query77  406 427 349 349
   query78  12819   12942   12372   12372
   query79  1520979 732 732
   query80  1373580 481 481
   query81  520 280 243 243
   query82  998 161 120 120
   query83  308 285 243 243
   query84  249 144 108 108
   query85  925 523 446 446
   query86  451 326 332 326
   query87  3457333932023202
   query88  3515269126622662
   query89  439 381 335 335
   query90  1964179 185 179
   query91  181 167 144 144
   query92  82  76  75  75
   query93  1079947 559 559
   query94  729 337 295 295
   query95  663 385 431 385
   query96  1025765 360 360
   query97  2711270525682568
   query98  244 226 231 226
   query99  10991138964 964
   Total cold run time: 254686 ms
   Total hot run time: 169879 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446497457

   
   
   TPC-H: Total hot run time: 29913 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 9130a404d6d81627039305cc248d9eb36f94257c, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17611   410840414041
   q2   q3  10581   879 606 606
   q4   4673456 338 338
   q5   7445132511391139
   q6   195 183 144 144
   q7   904 952 765 765
   q8   9306137612811281
   q9   5616537353395339
   q10  6283209318311831
   q11  481 278 263 263
   q12  633 412 296 296
   q13  18124   326927562756
   q14  295 285 261 261
   q15  q16 897 862 791 791
   q17  10311018812 812
   q18  6470562555875587
   q19  1568126211251125
   q20  513 410 258 258
   q21  4987238819441944
   q22  450 405 336 336
   Total cold run time: 98063 ms
   Total hot run time: 29913 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4835471947224719
   q2   q3  4630484042024202
   q4   2179222914271427
   q5   5022505253155052
   q6   201 183 149 149
   q7   2108179816411641
   q8   3358309231253092
   q9   8483876684578457
   q10  4479449342594259
   q11  600 474 410 410
   q12  685 736 510 510
   q13  3354359029252925
   q14  314 308 276 276
   q15  q16 794 791 708 708
   q17  1433145013611361
   q18  8027723272137213
   q19  1168117211601160
   q20  2260222019581958
   q21  6388556851335133
   q22  545 502 400 400
   Total cold run time: 60863 ms
   Total hot run time: 55052 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3238307674


##
fe/fe-core/src/main/java/org/apache/doris/nereids/load/NereidsStreamLoadPlanner.java:
##
@@ -150,6 +151,9 @@ public TPipelineFragmentParams plan(TUniqueId loadId, int 
fragmentInstanceIdInde
 if (uniquekeyUpdateMode == 
TUniqueKeyUpdateMode.UPDATE_FLEXIBLE_COLUMNS) {
 // Validate table-level constraints for flexible partial update
 destTable.validateForFlexiblePartialUpdate();

Review Comment:
   This guard means the new flexible-update request-shape validation is skipped 
for `NereidsRoutineLoadTaskInfo`, even though routine load uses this same 
planner. `CreateRoutineLoadInfo.validateFlexiblePartialUpdate()` currently 
rejects only format/fuzzy/jsonpaths/COLUMNS, so a routine load can still be 
created or altered to `UPDATE_FLEXIBLE_COLUMNS` with `merge_type` DELETE/MERGE, 
a `WHERE` filter, or a load-level `function_column.sequence_col`; stream load 
rejects those same combinations in 
`validateStreamLoadForFlexiblePartialUpdate()`. A concrete path is `CREATE 
ROUTINE LOAD ... MERGE ... DELETE ON ... PROPERTIES("format"="json", 
"unique_key_update_mode"="UPDATE_FLEXIBLE_COLUMNS")`: it passes routine-load 
validation, plans as `NereidsRoutineLoadTaskInfo`, and never enters this 
helper. Please apply the unsupported-option checks to all flexible partial 
update load tasks, or add equivalent routine-load validation and regression 
coverage. This is distinct from the existing stream-loa
 d `merge_type=APPEND` thread because routine load bypasses the helper entirely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446290717

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



eldenmoon commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4446290726

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4445987600

   
   
   TPC-DS: Total hot run time: 170008 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 04c3d8f2abd1b06ced93665c536bb441436e3f11, 
data reload: false
   
   query5   4348641 497 497
   query6   335 222 196 196
   query7   4237585 306 306
   query8   337 238 228 228
   query9   8853401340114011
   query10  471 345 306 306
   query11  5804232121632163
   query12  189 139 129 129
   query13  1284612 409 409
   query14  6090537450375037
   query14_14357436043504350
   query15  211 204 178 178
   query16  1009441 429 429
   query17  1155771 641 641
   query18  2740503 366 366
   query19  226 213 171 171
   query20  137 133 131 131
   query21  215 134 121 121
   query22  13552   13507   13469   13469
   query23  17076   16344   15940   15940
   query23_116217   16212   16253   16212
   query24  7345177913261326
   query24_11360134413591344
   query25  598 523 464 464
   query26  1322333 169 169
   query27  2730624 358 358
   query28  4350196619611961
   query29  1025658 523 523
   query30  310 240 204 204
   query31  11331078953 953
   query32  89  79  72  72
   query33  543 363 300 300
   query34  11491092629 629
   query35  780 778 670 670
   query36  1364133511181118
   query37  145 99  86  86
   query38  3199311830523052
   query39  913 927 895 895
   query39_1860 882 863 863
   query40  233 150 136 136
   query41  66  63  61  61
   query42  109 105 106 105
   query43  317 324 284 284
   query44  
   query45  206 198 194 194
   query46  10521168727 727
   query47  2315225022112211
   query48  410 426 309 309
   query49  630 507 408 408
   query50  706 303 214 214
   query51  4273426742464246
   query52  102 104 93  93
   query53  237 279 205 205
   query54  312 262 251 251
   query55  92  88  83  83
   query56  310 297 304 297
   query57  1424140013151315
   query58  289 269 260 260
   query59  1531158713591359
   query60  350 325 321 321
   query61  163 149 157 149
   query62  664 632 560 560
   query63  241 199 193 193
   query64  2376810 673 673
   query65  
   query66  1720512 441 441
   query67  3   29958   29806   29806
   query68  
   query69  459 341 296 296
   query70  1024988 1013988
   query71  296 274 269 269
   query72  2925273324132413
   query73  864 763 423 423
   query74  5027495847234723
   query75  2739265023482348
   query76  22571132769 769
   query77  398 413 348 348
   query78  12933   12969   12399   12399
   query79  1452974 735 735
   query80  823 594 495 495
   query81  476 276 234 234
   query82  1312156 118 118
   query83  352 274 237 237
   query84  273 141 110 110
   query85  945 543 440 440
   query86  417 349 310 310
   query87  3428334331893189
   query88  3460264825912591
   query89  442 387 335 335
   query90  1791182 175 175
   query91  177 174 137 137
   query92  78  76  75  75
   query93  950 965 553 553
   query94  617 341 295 295
   query95  664 486 361 361
   query96  999 741 345 345
   query97  2697268125772577
   query98  238 230 244 230
   query99  1108111510021002
   Total cold run time: 252739 ms
   Total hot run time: 170008 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4445923284

   
   
   TPC-H: Total hot run time: 29522 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 04c3d8f2abd1b06ced93665c536bb441436e3f11, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17491   384238423842
   q2   q3  10545   865 607 607
   q4   4657454 341 341
   q5   7464132211301130
   q6   197 168 140 140
   q7   934 941 758 758
   q8   9340141812661266
   q9   5535543353275327
   q10  6318208618361836
   q11  472 262 251 251
   q12  639 410 282 282
   q13  18146   367727252725
   q14  291 280 266 266
   q15  q16 903 873 783 783
   q17  1001978 746 746
   q18  6425568756405640
   q19  1150128710481048
   q20  500 400 250 250
   q21  4658237919341934
   q22  456 380 350 350
   Total cold run time: 97122 ms
   Total hot run time: 29522 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4657452545504525
   q2   q3  4647477141654165
   q4   2137216513841384
   q5   4990502152795021
   q6   196 164 135 135
   q7   2063179416271627
   q8   3437309431213094
   q9   8392853485358534
   q10  4480450642404240
   q11  623 409 409 409
   q12  727 767 534 534
   q13  3183360529722972
   q14  298 308 296 296
   q15  q16 784 788 700 700
   q17  1378138612851285
   q18  7950710771327107
   q19  1152117911131113
   q20  227419661966
   q21  6226547548984898
   q22  571 521 401 401
   Total cold run time: 60113 ms
   Total hot run time: 54406 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4445881360

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/04c3d8f2abd1b06ced93665c536bb441436e3f11_04c3d8f2abd1b06ced93665c536bb441436e3f11_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/04c3d8f2abd1b06ced93665c536bb441436e3f11_04c3d8f2abd1b06ced93665c536bb441436e3f11_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 78.03% (1850/2371) |
   | Line Coverage | 64.70% (33231/51362) |
   | Region Coverage   | 65.23% (16448/25214) |
   | Branch Coverage   | 55.71% (8778/15758) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [feature](be) Support flexible variant partial update [doris]

2026-05-13 Thread via GitHub



hello-stephen commented on PR #63182:
URL: https://github.com/apache/doris/pull/63182#issuecomment-4445771442

   # FE Regression Coverage Report
   Increment line coverage `  62.79% (81/129)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_44f78b1c286e86e3aa43db190dc333747099e816_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63182_44f78b1c286e86e3aa43db190dc333747099e816_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

1 2 3 >

1 - 100 of 284 matches

Mail list logo