Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-21 Thread via GitHub


morningman merged PR #60540:
URL: https://github.com/apache/doris/pull/60540


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-15 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3905429384

   # BE Regression && UT Coverage Report
   Increment line coverage `0.43% (3/697)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.64% (26056/36369) |
   | Line Coverage | 54.36% (272834/501857) |
   | Region Coverage   | 51.70% (226749/438606) |
   | Branch Coverage   | 53.23% (97480/183147) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-15 Thread via GitHub


morningman commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3905357716

   run check_coverage


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-14 Thread via GitHub


github-actions[bot] commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3901996244

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-14 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3901525323

   # FE Regression Coverage Report
   Increment line coverage `  69.57% (32/46)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-14 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3901473007

   # BE Regression && UT Coverage Report
   Increment line coverage `0.43% (3/697)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.64% (26056/36369) |
   | Line Coverage | 54.36% (272834/501857) |
   | Region Coverage   | 51.70% (226749/438606) |
   | Branch Coverage   | 53.23% (97480/183147) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3901073026

   # BE UT Coverage Report
   Increment line coverage `0.29% (2/698)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/12447982643763792178c507ec0123b7e3195ab1_12447982643763792178c507ec0123b7e3195ab1/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/12447982643763792178c507ec0123b7e3195ab1_12447982643763792178c507ec0123b7e3195ab1/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.60% (19523/37117) |
   | Line Coverage | 36.18% (182023/503107) |
   | Region Coverage   | 32.51% (141169/434230) |
   | Branch Coverage   | 33.55% (61212/182443) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3900742522

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/12447982643763792178c507ec0123b7e3195ab1_12447982643763792178c507ec0123b7e3195ab1_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/12447982643763792178c507ec0123b7e3195ab1_12447982643763792178c507ec0123b7e3195ab1_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.33% (1796/2264) |
   | Line Coverage | 64.83% (32007/49372) |
   | Region Coverage   | 65.55% (15980/24378) |
   | Branch Coverage   | 56.00% (8492/15164) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


zhangstar333 commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3900648127

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3900643710

   
   
   TPC-H: Total hot run time: 28969 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 12447982643763792178c507ec0123b7e3195ab1, 
data reload: false
   
   -- Round 1 --
   
   q1   17641   450943044304
   q2   q3  10724   797 527 527
   q4   4722375 254 254
   q5   8146122410381038
   q6   244 172 145 145
   q7   819 854 678 678
   q8   10864   150913541354
   q9   6609478747504750
   q10  6881187216421642
   q11  465 259 236 236
   q12  744 570 476 476
   q13  17779   438334133413
   q14  229 225 213 213
   q15  944 799 790 790
   q16  756 737 665 665
   q17  700 876 421 421
   q18  5971556251665166
   q19  1218975 697 697
   q20  631 566 431 431
   q21  4461189515061506
   q22  392 306 263 263
   Total cold run time: 100940 ms
   Total hot run time: 28969 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   4731449144954491
   q2   q3  1803222517671767
   q4   849 1217789 789
   q5   4126455043714371
   q6   189 170 141 141
   q7   1782166115561556
   q8   2483273226262626
   q9   7564753172777277
   q10  2624282325762576
   q11  511 424 408 408
   q12  498 593 444 444
   q13  3965439935873587
   q14  293 306 288 288
   q15  840 818 801 801
   q16  719 790 784 784
   q17  1201157013051305
   q18  7047675065296529
   q19  908 847 859 847
   q20  2282215520082008
   q21  4020358733243324
   q22  488 449 420 420
   Total cold run time: 48923 ms
   Total hot run time: 46339 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3900487828

   # FE UT Coverage Report
   Increment line coverage `  32.61% (15/46)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_12447982643763792178c507ec0123b7e3195ab1/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


morningman commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3900368494

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


github-actions[bot] commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3900298958

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


github-actions[bot] commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3900299024

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3898686529

   # BE Regression && UT Coverage Report
   Increment line coverage `0.43% (3/697)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_0526fc72a21480270bcc835b7ae0f8f2d7089f73_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_0526fc72a21480270bcc835b7ae0f8f2d7089f73_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.77% (26054/36301) |
   | Line Coverage | 54.44% (272682/500881) |
   | Region Coverage   | 51.80% (226784/437792) |
   | Branch Coverage   | 53.29% (97403/182769) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3898655888

   # BE UT Coverage Report
   Increment line coverage `0.29% (2/698)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/0526fc72a21480270bcc835b7ae0f8f2d7089f73_0526fc72a21480270bcc835b7ae0f8f2d7089f73/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/0526fc72a21480270bcc835b7ae0f8f2d7089f73_0526fc72a21480270bcc835b7ae0f8f2d7089f73/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.62% (19523/37099) |
   | Line Coverage | 36.20% (182040/502913) |
   | Region Coverage   | 32.54% (141195/433878) |
   | Branch Coverage   | 33.57% (61216/182336) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3898623017

   
   
   TPC-DS: Total hot run time: 184893 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0526fc72a21480270bcc835b7ae0f8f2d7089f73, 
data reload: false
   
   query5   5005666 524 524
   query6   326 233 204 204
   query7   4214494 271 271
   query8   335 256 236 236
   query9   8728277627612761
   query10  560 363 337 337
   query11  17167   17652   17244   17244
   query12  220 131 129 129
   query13  1589502 363 363
   query14  7013417033853385
   query14_13292332333213321
   query15  215 202 184 184
   query16  1056491 479 479
   query17  1192834 723 723
   query18  2916498 355 355
   query19  228 234 203 203
   query20  154 143 135 135
   query21  221 159 134 134
   query22  5084498247444744
   query23  17415   16819   16457   16457
   query23_116643   16630   16630   16630
   query24  7081170412541254
   query24_11244126612571257
   query25  569 478 402 402
   query26  1238264 151 151
   query27  2778508 291 291
   query28  4460188218701870
   query29  811 607 474 474
   query30  321 258 222 222
   query31  908 730 659 659
   query32  78  75  74  74
   query33  531 351 283 283
   query34  956 960 562 562
   query35  665 722 611 611
   query36  1066941 941
   query37  135 96  82  82
   query38  2962288228852882
   query39  937 871 849 849
   query39_1845 828 825 825
   query40  234 159 136 136
   query41  65  62  58  58
   query42  106 106 102 102
   query43  372 387 355 355
   query44  
   query45  197 198 204 198
   query46  982 1051623 623
   query47  2103206620182018
   query48  309 319 225 225
   query49  626 482 387 387
   query50  695 284 220 220
   query51  4209415841074107
   query52  111 111 99  99
   query53  328 367 295 295
   query54  298 268 292 268
   query55  84  83  85  83
   query56  347 305 323 305
   query57  1395131612701270
   query58  294 284 278 278
   query59  2580265025022502
   query60  338 332 321 321
   query61  151 145 146 145
   query62  628 598 540 540
   query63  323 290 282 282
   query64  4902129710271027
   query65  
   query66  1389483 367 367
   query67  16315   16250   16268   16250
   query68  
   query69  406 318 289 289
   query70  1020997 950 950
   query71  342 333 305 305
   query72  2835276523872387
   query73  545 572 324 324
   query74  10031   995397179717
   query75  3054288025572557
   query76  22831117717 717
   query77  375 431 310 310
   query78  11270   11483   10711   10711
   query79  1161824 615 615
   query80  892 660 579 579
   query81  538 292 259 259
   query82  1316158 129 129
   query83  342 277 270 270
   query84  257 118 102 102
   query85  977 489 434 434
   query86  380 306 303 303
   query87  3135305630413041
   query88  3613269526552655
   query89  459 386 356 356
   query90  1797181 172 172
   query91  167 154 134 134
   query92  73  77  73  73
   query93  958 852 507 507
   query94  502 330 289 289
   query95  598 357 376 357
   query96  656 535 231 231
   query97  2498251423772377
   query98  234 220 224 220
   query99  1015970 884 884
   Total cold run time: 256138 ms
   Total hot run time: 184893 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected].

Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3898570593

   
   
   TPC-H: Total hot run time: 29118 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0526fc72a21480270bcc835b7ae0f8f2d7089f73, 
data reload: false
   
   -- Round 1 --
   
   q1   17665   459843544354
   q2   q3  10728   817 533 533
   q4   4746370 252 252
   q5   8115125210491049
   q6   212 175 145 145
   q7   837 882 675 675
   q8   10672   149813781378
   q9   6783478746174617
   q10  6881187616381638
   q11  479 267 231 231
   q12  780 575 459 459
   q13  17786   420334343434
   q14  236 233 220 220
   q15  948 793 814 793
   q16  738 718 682 682
   q17  714 836 469 469
   q18  6045544353245324
   q19  1158973 727 727
   q20  652 588 406 406
   q21  4576192514711471
   q22  401 299 261 261
   Total cold run time: 101152 ms
   Total hot run time: 29118 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   4764457546004575
   q2   q3  1858227417501750
   q4   881 1174784 784
   q5   4086436543854365
   q6   177 168 135 135
   q7   1755163115441544
   q8   2515269725772577
   q9   7539734874307348
   q10  2674300224132413
   q11  508 443 433 433
   q12  519 601 477 477
   q13  3954432436333633
   q14  280 296 295 295
   q15  892 818 806 806
   q16  718 808 707 707
   q17  1198160313211321
   q18  7093676265636563
   q19  920 924 914 914
   q20  2060211719911991
   q21  4016345733183318
   q22  449 453 393 393
   Total cold run time: 48856 ms
   Total hot run time: 46342 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


morningman commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3897899095

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3897728018

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/0526fc72a21480270bcc835b7ae0f8f2d7089f73_0526fc72a21480270bcc835b7ae0f8f2d7089f73_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/0526fc72a21480270bcc835b7ae0f8f2d7089f73_0526fc72a21480270bcc835b7ae0f8f2d7089f73_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.33% (1796/2264) |
   | Line Coverage | 64.79% (31986/49372) |
   | Region Coverage   | 65.49% (15965/24378) |
   | Branch Coverage   | 55.97% (8487/15164) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


morningman commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3897551212

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


morningman commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3897550868

   run cloudut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


morningman commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3897550263

   run beut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3897146065

   # FE Regression Coverage Report
   Increment line coverage `  69.57% (32/46)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_0526fc72a21480270bcc835b7ae0f8f2d7089f73_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_0526fc72a21480270bcc835b7ae0f8f2d7089f73_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3895686756

   
   
   TPC-DS: Total hot run time: 184917 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 06963e215d2ab1eac0a07b363e4dd2ea5aed417f, 
data reload: false
   
   query5   4712664 517 517
   query6   335 223 205 205
   query7   4228484 276 276
   query8   354 252 249 249
   query9   8757278327402740
   query10  531 388 338 338
   query11  17246   17707   17369   17369
   query12  202 140 148 140
   query13  1301486 396 396
   query14  7473345331633163
   query14_12975297229832972
   query15  208 198 196 196
   query16  1030506 493 493
   query17  1563824 664 664
   query18  3208487 360 360
   query19  215 234 197 197
   query20  146 125 145 125
   query21  229 162 123 123
   query22  5098481549224815
   query23  17395   16897   16657   16657
   query23_116722   16625   16798   16625
   query24  7201161912321232
   query24_11246123712351235
   query25  572 491 423 423
   query26  1247265 154 154
   query27  2740472 295 295
   query28  4456193618591859
   query29  793 560 471 471
   query30  315 247 208 208
   query31  858 719 648 648
   query32  80  72  68  68
   query33  513 332 282 282
   query34  924 910 568 568
   query35  642 669 598 598
   query36  10641159954 954
   query37  130 95  86  86
   query38  2946295628492849
   query39  868 846 803 803
   query39_1818 813 787 787
   query40  231 151 136 136
   query41  63  61  59  59
   query42  103 102 100 100
   query43  377 388 341 341
   query44  
   query45  196 187 177 177
   query46  889 1000632 632
   query47  2116211620982098
   query48  322 324 243 243
   query49  629 470 376 376
   query50  688 289 219 219
   query51  4078416140704070
   query52  109 111 99  99
   query53  287 344 297 297
   query54  302 269 300 269
   query55  92  86  81  81
   query56  299 304 290 290
   query57  1366133312891289
   query58  280 280 273 273
   query59  2620268825922592
   query60  342 331 319 319
   query61  152 160 176 160
   query62  629 593 553 553
   query63  317 271 266 266
   query64  4862128610171017
   query65  
   query66  1392459 354 354
   query67  16709   16600   16339   16339
   query68  
   query69  397 319 290 290
   query70  983 958 943 943
   query71  349 305 290 290
   query72  2824267424262426
   query73  531 554 331 331
   query74  9630952793479347
   query75  2837273124842484
   query76  22951045672 672
   query77  358 393 306 306
   query78  11632   11820   11080   11080
   query79  2424779 620 620
   query80  1795626 597 597
   query81  581 292 254 254
   query82  971 149 117 117
   query83  342 256 258 256
   query84  251 114 93  93
   query85  928 481 453 453
   query86  419 313 291 291
   query87  3095313830373037
   query88  3514266126782661
   query89  432 365 341 341
   query90  2033179 173 173
   query91  166 157 136 136
   query92  88  79  72  72
   query93  1023836 502 502
   query94  626 325 326 325
   query95  585 397 323 323
   query96  640 511 222 222
   query97  2445247824102410
   query98  240 226 221 221
   query99  1013977 907 907
   Total cold run time: 258042 ms
   Total hot run time: 184917 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-13 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3895625633

   
   
   TPC-H: Total hot run time: 28986 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 06963e215d2ab1eac0a07b363e4dd2ea5aed417f, 
data reload: false
   
   -- Round 1 --
   
   q1   17668   449043124312
   q2   q3  10657   780 534 534
   q4   4722380 250 250
   q5   7829124310061006
   q6   231 174 145 145
   q7   844 869 673 673
   q8   10553   149813741374
   q9   6057477746494649
   q10  6859189216481648
   q11  453 269 257 257
   q12  755 573 471 471
   q13  17792   423734203420
   q14  231 235 207 207
   q15  953 804 811 804
   q16  756 712 668 668
   q17  722 879 431 431
   q18  6079548152275227
   q19  1191992 635 635
   q20  512 642 504 504
   q21  4586200015091509
   q22  385 298 262 262
   Total cold run time: 99835 ms
   Total hot run time: 28986 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   4725462345994599
   q2   q3  1868227018461846
   q4   904 1207781 781
   q5   4156447844054405
   q6   181 182 146 146
   q7   1819168614881488
   q8   2500278425992599
   q9   7542736674647366
   q10  2772286725832583
   q11  508 440 424 424
   q12  510 578 454 454
   q13  4176438035983598
   q14  279 306 281 281
   q15  910 859 829 829
   q16  729 796 744 744
   q17  1225160713501350
   q18  7204672066426642
   q19  929 954 919 919
   q20  2080217420302030
   q21  4016355133663366
   q22  487 469 398 398
   Total cold run time: 49520 ms
   Total hot run time: 46848 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-12 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3895211336

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/06963e215d2ab1eac0a07b363e4dd2ea5aed417f_06963e215d2ab1eac0a07b363e4dd2ea5aed417f_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/06963e215d2ab1eac0a07b363e4dd2ea5aed417f_06963e215d2ab1eac0a07b363e4dd2ea5aed417f_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.32% (1795/2263) |
   | Line Coverage | 64.86% (31985/49311) |
   | Region Coverage   | 65.55% (15954/24339) |
   | Branch Coverage   | 56.05% (8482/15132) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-12 Thread via GitHub


zhangstar333 commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3895134740

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3881973353

   # FE Regression Coverage Report
   Increment line coverage `  26.75% (42/157)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3881931710

   # BE Regression && UT Coverage Report
   Increment line coverage `0.29% (2/697)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.38% (20774/36206) |
   | Line Coverage | 40.36% (201682/499766) |
   | Region Coverage   | 37.22% (162587/436835) |
   | Branch Coverage   | 37.88% (69065/182349) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3881912507

   # BE Regression && UT Coverage Report
   Increment line coverage `0.29% (2/697)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.38% (20774/36206) |
   | Line Coverage | 40.36% (201682/499766) |
   | Region Coverage   | 37.22% (162587/436835) |
   | Branch Coverage   | 37.88% (69065/182349) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3881899679

   # BE UT Coverage Report
   Increment line coverage `0.29% (2/698)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.63% (19450/36953) |
   | Line Coverage | 36.14% (181091/501031) |
   | Region Coverage   | 32.52% (140629/432468) |
   | Branch Coverage   | 33.55% (60950/181653) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3880354782

   # FE Regression Coverage Report
   Increment line coverage `  28.66% (45/157)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3879287235

   
   
   ClickBench: Total hot run time: 28.88 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit dfd8f489ad853fc6e835fc2d3e2efccf398e63c8, 
data reload: false
   
   query1   0.050.050.05
   query2   0.100.040.05
   query3   0.260.080.09
   query4   1.610.110.11
   query5   0.270.240.25
   query6   1.170.670.67
   query7   0.030.030.02
   query8   0.050.040.04
   query9   0.540.490.49
   query10  0.530.540.54
   query11  0.140.090.10
   query12  0.140.110.10
   query13  0.630.610.62
   query14  1.061.071.06
   query15  0.880.860.88
   query16  0.400.400.40
   query17  1.181.131.15
   query18  0.230.220.25
   query19  2.002.052.06
   query20  0.020.020.01
   query21  15.41   0.280.16
   query22  5.240.060.05
   query23  15.99   0.270.10
   query24  1.500.370.18
   query25  0.090.060.09
   query26  0.150.130.13
   query27  0.070.070.05
   query28  3.261.140.96
   query29  12.56   3.833.15
   query30  0.280.130.13
   query31  2.820.630.42
   query32  3.230.600.49
   query33  3.223.213.31
   query34  16.52   5.354.70
   query35  4.835.385.34
   query36  0.660.550.55
   query37  0.110.070.07
   query38  0.070.040.04
   query39  0.040.030.03
   query40  0.200.190.16
   query41  0.090.030.03
   query42  0.040.030.03
   query43  0.040.030.03
   Total cold run time: 97.71 s
   Total hot run time: 28.88 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3879116632

   
   
   TPC-H: Total hot run time: 30584 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit dfd8f489ad853fc6e835fc2d3e2efccf398e63c8, 
data reload: false
   
   -- Round 1 --
   q1   17614   444543064306
   q2   2015351 255 255
   q3   10163   1328789 789
   q4   10198   786 308 308
   q5   7536223919401940
   q6   243 179 145 145
   q7   930 712 612 612
   q8   9275141910731073
   q9   4992460546224605
   q10  6863197415771577
   q11  469 257 243 243
   q12  400 382 223 223
   q13  17834   408132943294
   q14  224 233 230 230
   q15  873 803 808 803
   q16  698 710 626 626
   q17  774 821 507 507
   q18  7177581863105818
   q19  15481019654 654
   q20  545 538 414 414
   q21  2716196319171917
   q22  339 308 245 245
   Total cold run time: 103426 ms
   Total hot run time: 30584 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4703461745104510
   q2   260 333 258 258
   q3   2381299023142314
   q4   1506182214561456
   q5   4569468046684668
   q6   218 177 136 136
   q7   2020191917121712
   q8   2612252624662466
   q9   7675768675287528
   q10  2864309325902590
   q11  502 430 417 417
   q12  655 759 604 604
   q13  3837443136043604
   q14  266 287 257 257
   q15  817 771 779 771
   q16  631 674 649 649
   q17  1095128912801280
   q18  7549735471287128
   q19  865 830 860 830
   q20  1954202318521852
   q21  4535423040984098
   q22  538 469 400 400
   Total cold run time: 52052 ms
   Total hot run time: 49528 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3878280404

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_dfd8f489ad853fc6e835fc2d3e2efccf398e63c8_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.35% (1795/2262) |
   | Line Coverage | 64.86% (31956/49269) |
   | Region Coverage   | 65.55% (15944/24323) |
   | Branch Coverage   | 56.05% (8472/15114) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


zhangstar333 commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3877964631

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-10 Thread via GitHub


morningman commented on code in PR #60540:
URL: https://github.com/apache/doris/pull/60540#discussion_r2783182137


##
be/src/vec/common/sort/sorter.h:
##
@@ -202,15 +202,17 @@ class FullSorter final : public Sorter {
 _max_buffered_block_bytes = max_buffered_block_bytes;
 }
 
+auto merge_sort_state() { return _state.get(); }
+
+Status _do_sort();

Review Comment:
   ```suggestion
   Status do_sort();
   ```



##
be/src/vec/sink/writer/iceberg/viceberg_partition_writer.cpp:
##
@@ -142,6 +147,17 @@ TIcebergCommitData 
VIcebergPartitionWriter::_build_iceberg_commit_data() {
 
iceberg_commit_data.__set_file_size(_file_format_transformer->written_len());
 iceberg_commit_data.__set_file_content(TFileContent::DATA);
 iceberg_commit_data.__set_partition_values(_partition_values);
+if (_file_format_type == TFileFormatType::FORMAT_PARQUET) {
+TIcebergColumnStats column_stats;
+auto st = 
static_cast(_file_format_transformer.get())

Review Comment:
   Do we need to check this `st`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


Copilot commented on code in PR #60540:
URL: https://github.com/apache/doris/pull/60540#discussion_r2772578172


##
be/src/vec/sink/writer/iceberg/viceberg_sort_writer.h:
##
@@ -0,0 +1,352 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include 
+#include 
+#include 
+#include 
+
+#include "common/config.h"
+#include "common/object_pool.h"
+#include "runtime/runtime_state.h"
+#include "util/runtime_profile.h"
+#include "vec/common/sort/sorter.h"
+#include "vec/core/block.h"
+#include "vec/exprs/vslot_ref.h"
+#include "vec/sink/writer/iceberg/viceberg_partition_writer.h"
+#include "vec/sink/writer/iceberg/vpartition_writer_base.h"
+#include "vec/spill/spill_stream.h"
+#include "vec/spill/spill_stream_manager.h"
+
+namespace doris {
+class RuntimeState;
+class RuntimeProfile;
+
+namespace vectorized {
+class VIcebergSortWriter : public IPartitionWriterBase {
+public:
+using CreateWriterLambda = 
std::function(
+const std::string* file_name, int file_name_index)>;
+
+VIcebergSortWriter(std::shared_ptr 
partition_writer,
+   TSortInfo sort_info, int64_t target_file_size_bytes,
+   CreateWriterLambda create_writer_lambda = nullptr)
+: _sort_info(std::move(sort_info)),
+  _iceberg_partition_writer(std::move(partition_writer)),
+  _create_writer_lambda(std::move(create_writer_lambda)),
+  _target_file_size_bytes(target_file_size_bytes) {}
+
+Status open(RuntimeState* state, RuntimeProfile* profile,
+const RowDescriptor* row_desc) override {
+DCHECK(row_desc != nullptr);
+_runtime_state = state;
+_profile = profile;
+_row_desc = row_desc;
+
+RETURN_IF_ERROR(_vsort_exec_exprs.init(_sort_info, &_pool));
+RETURN_IF_ERROR(_vsort_exec_exprs.prepare(state, *row_desc, 
*row_desc));
+RETURN_IF_ERROR(_vsort_exec_exprs.open(state));
+
+_sorter = vectorized::FullSorter::create_unique(
+_vsort_exec_exprs, -1, 0, &_pool, _sort_info.is_asc_order, 
_sort_info.nulls_first,
+*row_desc, state, _profile);
+_sorter->init_profile(_profile);
+_sorter->set_enable_spill();
+_do_spill_count_counter = ADD_COUNTER(_profile, "IcebergDoSpillCount", 
TUnit::UNIT);
+RETURN_IF_ERROR(_iceberg_partition_writer->open(state, profile, 
row_desc));
+return Status::OK();
+}
+
+Status write(vectorized::Block& block) override {
+RETURN_IF_ERROR(_sorter->append_block(&block));
+_update_spill_block_batch_row_count(block);
+// sort in memory and write directly to Parquet file

Review Comment:
   The comment on line 79 mentions "Parquet file" specifically, but this writer 
handles both Parquet and ORC formats based on the table configuration. The 
comment should be format-agnostic.
   ```suggestion
   // sort in memory and write directly to the output data file
   ```



##
regression-test/data/external_table_p0/iceberg/write/test_iceberg_write_stats2.out:
##
@@ -0,0 +1,33 @@
+-- This file is automatically generated. You should know what you did if you 
want to edit this
+-- !sql_0 --
+false  22  222 2.2 2.2 8765.4321   8765.432100 
987654321098765432.987654321099 bbb 2023-06-15  2023-06-15T23:45:01
+true   11  111 1.1 1.1 1234.5678   1234.567890 
123456789012345678.123456789012 aaa 2023-01-01  2023-01-01T12:34:56
+
+-- !sql_1 --
+0  PARQUET 2   {1:2, 2:2, 3:2, 4:2, 5:2, 6:2, 7:2, 8:2, 9:2, 10:2, 
11:2, 12:2} {1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:0, 12:0} 
{1:0x00, 2:0x0B00, 3:0x6F00, 4:0xCDCC8C3F, 
5:0x9A99F13F, 6:0x0457, 7:0x00BC614E, 8:0x499602D2, 
9:0x00018EE90FF6C373E0393713FA14, 10:0x616161, 11:0x9E4B, 
12:0x005CE70F33F10500} {1:0x01, 2:0x1600, 3:0xDE00, 
4:0xCDCC0C40, 5:0x9A990140, 6:0x08AE, 7:0x05397FB1, 
8:0x00020A75E124, 9:0x000C7748819DFFB62505316873CB, 10:0x626262, 
11:0x434C, 12:0x40D91FA833FE0500}
+
+-- !sql_2 --
+{"bigint_col":{"column_size":118,

Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3857882189

   # FE Regression Coverage Report
   Increment line coverage `  0.00% (0/46)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3857860969

   # BE Regression && UT Coverage Report
   Increment line coverage `40.41% (276/683)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.24% (26491/36172) |
   | Line Coverage | 56.43% (281430/498753) |
   | Region Coverage   | 54.31% (236553/435599) |
   | Branch Coverage   | 55.77% (101467/181932) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3854799370

   # FE Regression Coverage Report
   Increment line coverage `  0.00% (0/46)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3854711496

   # BE Regression && UT Coverage Report
   Increment line coverage `40.41% (276/683)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.21% (26482/36172) |
   | Line Coverage | 56.40% (281288/498753) |
   | Region Coverage   | 54.29% (236469/435599) |
   | Branch Coverage   | 55.75% (101422/181932) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3854145405

   # FE Regression Coverage Report
   Increment line coverage `  0.00% (0/46)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge_fe/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3854095155

   # BE Regression && UT Coverage Report
   Increment line coverage `40.41% (276/683)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/60540_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.24% (26491/36172) |
   | Line Coverage | 56.43% (281425/498753) |
   | Region Coverage   | 54.30% (236513/435599) |
   | Branch Coverage   | 55.77% (101465/181932) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3853702538

   # BE UT Coverage Report
   Increment line coverage `0.00% (0/684)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.48% (19372/36910) |
   | Line Coverage | 35.99% (179940/499942) |
   | Region Coverage   | 32.34% (139452/431182) |
   | Branch Coverage   | 33.33% (60401/181200) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3853304613

   
   
   ClickBench: Total hot run time: 28.15 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01, 
data reload: false
   
   query1   0.060.050.04
   query2   0.130.070.07
   query3   0.300.080.08
   query4   1.610.100.09
   query5   0.260.250.24
   query6   1.140.650.65
   query7   0.030.020.02
   query8   0.070.060.06
   query9   0.590.520.51
   query10  0.560.560.55
   query11  0.260.130.13
   query12  0.260.160.15
   query13  0.630.610.60
   query14  0.980.970.98
   query15  0.920.820.83
   query16  0.400.420.39
   query17  1.061.001.06
   query18  0.250.230.22
   query19  1.951.861.84
   query20  0.020.010.02
   query21  15.38   0.320.29
   query22  4.920.130.11
   query23  15.35   0.440.28
   query24  2.240.570.38
   query25  0.120.120.10
   query26  0.180.190.17
   query27  0.100.110.11
   query28  3.541.140.98
   query29  12.53   4.103.27
   query30  0.320.130.11
   query31  2.790.690.44
   query32  3.230.630.51
   query33  2.953.063.02
   query34  16.68   5.054.48
   query35  4.464.424.52
   query36  0.590.490.49
   query37  0.300.090.09
   query38  0.260.060.06
   query39  0.080.050.05
   query40  0.200.180.17
   query41  0.130.070.07
   query42  0.080.060.05
   query43  0.070.060.06
   Total cold run time: 97.98 s
   Total hot run time: 28.15 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


doris-robot commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3853209712

   
   
   TPC-H: Total hot run time: 31149 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01, 
data reload: false
   
   -- Round 1 --
   q1   17607   460243134313
   q2   2036383 227 227
   q3   10114   1287722 722
   q4   10205   834 326 326
   q5   7848221419131913
   q6   203 180 145 145
   q7   864 726 592 592
   q8   9278140611331133
   q9   5442491848424842
   q10  6864196615631563
   q11  529 324 282 282
   q12  391 382 219 219
   q13  17822   408032123212
   q14  238 232 221 221
   q15  910 814 810 810
   q16  697 665 609 609
   q17  678 881 450 450
   q18  7363669465306530
   q19  1344991 614 614
   q20  393 358 251 251
   q21  2733203419071907
   q22  355 319 268 268
   Total cold run time: 103914 ms
   Total hot run time: 31149 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4448429843734298
   q2   267 340 249 249
   q3   2141256822212221
   q4   1386173712871287
   q5   4306421842304218
   q6   219 183 137 137
   q7   1852175220741752
   q8   2666259324302430
   q9   7614768074787478
   q10  2953308526262626
   q11  567 486 490 486
   q12  665 738 600 600
   q13  3920460939523952
   q14  287 314 279 279
   q15  883 811 823 811
   q16  675 729 678 678
   q17  1164140914041404
   q18  8263769277257692
   q19  885 896 999 896
   q20  2159219520522052
   q21  4833451141204120
   q22  590 574 493 493
   Total cold run time: 52743 ms
   Total hot run time: 50159 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3852582448

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_2fa88d38b0e4e49a246d7e82567a2bf7fbd4ad01_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.29% (1792/2260) |
   | Line Coverage | 64.74% (31827/49158) |
   | Region Coverage   | 65.42% (15883/24280) |
   | Branch Coverage   | 55.94% (8435/15078) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


zhangstar333 commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3852344165

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [feature](iceberg) support insert into iceberg table with sort-order [doris]

2026-02-05 Thread via GitHub


hello-stephen commented on PR #60540:
URL: https://github.com/apache/doris/pull/60540#issuecomment-3852322632

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]