Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
github-actions[bot] commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3611071460 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3611070403 # FE Regression Coverage Report Increment line coverage ` 81.55% (535/656)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3611000196 # BE Regression && UT Coverage Report Increment line coverage `90.26% (454/503)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.18% (24752/34292) | | Line Coverage | 58.88% (259759/441141) | | Region Coverage | 53.75% (215585/401081) | | Branch Coverage | 55.25% (92099/166702) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610676894 run nonConcurrent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610676306 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610675924 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610664369 # FE Regression Coverage Report Increment line coverage ` 81.55% (535/656)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610613907 # BE Regression && UT Coverage Report Increment line coverage `90.24% (453/502)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_8e77c1231beedc26e8d8cb4159e3face9564ac1d_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.18% (24752/34292) | | Line Coverage | 58.88% (259759/441141) | | Region Coverage | 53.75% (215585/401081) | | Branch Coverage | 55.25% (92099/166702) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610393962 # BE UT Coverage Report Increment line coverage `32.87% (167/508)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/8e77c1231beedc26e8d8cb4159e3face9564ac1d_8e77c1231beedc26e8d8cb4159e3face9564ac1d/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/8e77c1231beedc26e8d8cb4159e3face9564ac1d_8e77c1231beedc26e8d8cb4159e3face9564ac1d/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.30% (18642/34975) | | Line Coverage | 39.00% (172198/441518) | | Region Coverage | 33.61% (133175/396273) | | Branch Coverage | 34.58% (57337/165803) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610074802 ClickBench: Total hot run time: 27.36 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8e77c1231beedc26e8d8cb4159e3face9564ac1d, data reload: false query1 0.060.060.05 query2 0.090.050.05 query3 0.260.090.08 query4 1.620.120.11 query5 0.260.260.27 query6 1.190.660.63 query7 0.040.030.03 query8 0.060.040.04 query9 0.570.520.51 query10 0.570.560.57 query11 0.150.110.11 query12 0.150.110.12 query13 0.610.610.61 query14 1.001.010.98 query15 0.820.810.81 query16 0.400.410.41 query17 0.990.991.00 query18 0.240.220.21 query19 1.861.861.85 query20 0.020.010.01 query21 15.44 0.320.14 query22 4.560.050.05 query23 15.96 0.300.12 query24 1.840.300.25 query25 0.090.060.07 query26 0.150.130.14 query27 0.100.050.05 query28 3.261.231.03 query29 12.61 3.973.18 query30 0.280.140.13 query31 2.820.660.41 query32 3.240.560.46 query33 3.063.023.02 query34 17.04 5.204.53 query35 4.574.594.53 query36 0.660.500.50 query37 0.110.070.07 query38 0.070.040.04 query39 0.050.030.03 query40 0.180.130.15 query41 0.090.040.03 query42 0.050.040.03 query43 0.040.040.03 Total cold run time: 97.23 s Total hot run time: 27.36 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610056427 TPC-DS: Total hot run time: 182905 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8e77c1231beedc26e8d8cb4159e3face9564ac1d, data reload: false query5 4398624 500 500 query6 340 263 226 226 query7 4652531 304 304 query8 300 264 266 264 query9 8727265826742658 query10 523 355 317 317 query11 15133 15214 14753 14753 query12 173 119 119 119 query13 1702597 458 458 query14 6414341030863086 query14_12955297729092909 query15 213 201 189 189 query16 7484688 542 542 query17 1261783 659 659 query18 2041438 354 354 query19 217 215 183 183 query20 134 129 126 126 query21 224 140 114 114 query22 3822402138243824 query23 17067 16132 16029 16029 query23_116130 16036 16094 16036 query24 6849164912091209 query24_11219120912211209 query25 647 551 498 498 query26 1273286 172 172 query27 2708510 352 352 query28 4344218121552155 query29 843 695 513 513 query30 318 244 229 229 query31 819 723 647 647 query32 84 79 76 76 query33 652 402 343 343 query34 837 935 550 550 query35 804 836 742 742 query36 885 936 825 825 query37 122 108 83 83 query38 3898387338043804 query39 757 735 726 726 query39_1710 710 697 697 query40 230 132 123 123 query41 69 62 63 62 query42 126 114 110 110 query43 454 440 414 414 query44 1340764 761 761 query45 202 191 189 189 query46 905 1018656 656 query47 1692176316391639 query48 417 427 328 328 query49 759 507 404 404 query50 694 703 421 421 query51 3881391639153915 query52 127 122 104 104 query53 239 263 189 189 query54 325 296 277 277 query55 99 97 91 91 query56 327 339 329 329 query57 1136118110861086 query58 290 313 273 273 query59 2242241023482348 query60 348 356 338 338 query61 167 195 157 157 query62 771 743 651 651 query63 232 186 196 186 query64 44501221891 891 query65 4044397239643964 query66 1164458 333 333 query67 15235 15042 15063 15042 query68 83291039652 652 query69 523 342 316 316 query70 1102103610481036 query71 486 351 333 333 query72 5809506648844884 query73 729 583 343 343 query74 8526884386528652 query75 3561307325702570 query76 36841158751 751 query77 821 405 313 313 query78 9480974189128912 query79 2026839 598 598 query80 652 588 487 487 query81 509 272 241 241 query82 430 143 113 113 query83 276 271 252 252 query84 257 119 99 99 query85 921 499 463 463 query86 342 304 277 277 query87 4038404239793979 query88 3837231323402313 query89 410 336 294 294 query90 1949229 224 224 query91 170 183 142 142 query92 77 70 67 67 query93 13211028686 686 query94 731 475 356 356 query95 508 419 428 419 query96 560 574 292 292 query97 2627267025982598 query98 242 218 210 210 query99 1393137012721272 Total cold run time: 269486 ms Total hot run time: 182905 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3610019380 TPC-H: Total hot run time: 34707 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8e77c1231beedc26e8d8cb4159e3face9564ac1d, data reload: false -- Round 1 -- q1 17674 504249464946 q2 2050320 208 208 q3 10258 1314740 740 q4 10227 890 327 327 q5 7527248021802180 q6 193 170 136 136 q7 987 806 649 649 q8 9391145712051205 q9 7211531253715312 q10 6874220018211821 q11 527 307 289 289 q12 389 387 229 229 q13 17811 370030053005 q14 239 231 215 215 q15 597 519 523 519 q16 880 892 863 863 q17 707 757 581 581 q18 7689709571947095 q19 1546983 617 617 q20 362 355 233 233 q21 4100332825822582 q22 10591014955 955 Total cold run time: 108298 ms Total hot run time: 34707 ms - Round 2, with runtime_filter_mode=off - q1 5046496649374937 q2 325 403 324 324 q3 2150268123422342 q4 1323174813271327 q5 4322460246004600 q6 236 184 139 139 q7 2035200218191819 q8 2644253124692469 q9 7604762376107610 q10 3049331228542854 q11 604 525 506 506 q12 835 837 632 632 q13 3511387134063406 q14 296 322 304 304 q15 571 512 499 499 q16 909 955 924 924 q17 1181144215051442 q18 7910776974337433 q19 928 861 959 861 q20 2097203919131913 q21 4882423741084108 q22 11031048961 961 Total cold run time: 53561 ms Total hot run time: 51410 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3609751719 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
924060929 commented on code in PR #58031:
URL: https://github.com/apache/doris/pull/58031#discussion_r2583941679
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -1135,7 +1144,7 @@ public void checkQuerySlotCount(String slotCnt) {
@VariableMgr.VarAttr(name = SQL_AUTO_IS_NULL)
public boolean sqlAutoIsNull = false;
[email protected](name = SQL_SELECT_LIMIT, needForward = true,
affectQueryResult = true)
[email protected](name = SQL_SELECT_LIMIT, needForward = true)
private long sqlSelectLimit = Long.MAX_VALUE;
Review Comment:
ditto
##
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContextUtil.java:
##
@@ -94,4 +95,11 @@ public static Optional>
initCatalogAndDb(ConnectContext
ctx.getState().setOk();
return Optional.empty();
}
+
+public static Map
getAffectQueryResultSessionVariables(ConnectContext ctx) {
Review Comment:
should be `getAffectQueryResultInPlanVariables`
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/ShowCreateMTMVInfo.java:
##
@@ -47,6 +47,7 @@ public class ShowCreateMTMVInfo {
private static final ShowResultSetMetaData META_DATA =
ShowResultSetMetaData.builder()
.addColumn(new Column("Materialized View",
ScalarType.createVarchar(20)))
.addColumn(new Column("Create Materialized View",
ScalarType.createVarchar(30)))
+.addColumn(new Column("var", ScalarType.createVarchar(1)))
Review Comment:
Keep the same camel case
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -1008,7 +1017,7 @@ public static double getHotValueThreshold() {
// By default, the number of Limit items after OrderBy is changed from
65535 items
// before v1.2.0 (not included), to return all items by default
[email protected](name = DEFAULT_ORDER_BY_LIMIT, affectQueryResult =
true)
[email protected](name = DEFAULT_ORDER_BY_LIMIT)
Review Comment:
should not remove it because make sql cache return wrong result
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionBottomUpRewriter.java:
##
@@ -73,7 +76,14 @@ private static Expression rewriteBottomUp(
Expression afterRewrite = expression;
try {
Expression beforeRewrite;
-afterRewrite = rewriteChildren(expression, context,
currentBatch, rules, listeners);
+if (expression instanceof SessionVarGuardExpr) {
+try (AutoCloseSessionVariable auto = new
AutoCloseSessionVariable(ConnectContext.get(),
Review Comment:
use connectContext from the `ExpressionRewriteContext context`
##
fe/fe-core/src/main/java/org/apache/doris/qe/AutoCloseSessionVariable.java:
##
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.qe;
+
+import com.google.common.collect.Maps;
+
+import java.util.Map;
+
+/**
+ * Used to generate new SessionVariables based on the persisted map,
+ * and automatically restore to the previous SessionVariables after use.
+ */
+public class AutoCloseSessionVariable implements AutoCloseable {
+private static final ConnectContext notNullContext = new ConnectContext();
+private ConnectContext connectContext;
+private boolean changed = false;
+private SessionVariable previousVariable;
+private ConnectContext previousConnectContext = notNullContext;
+
+public AutoCloseSessionVariable(ConnectContext connectContext, Map affectQueryResultVariables) {
+if (affectQueryResultVariables == null ||
affectQueryResultVariables.isEmpty()) {
+return;
+}
+if (connectContext == null) {
+previousConnectContext = null;
+this.connectContext = new ConnectContext();
+this.connectContext.setThreadLocalInfo();
Review Comment:
should use ThreadLocal's ConnectConext as the previousConnectContext if not
null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
github-actions[bot] commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604971138 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
github-actions[bot] commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604971196 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604878411 ClickBench: Total hot run time: 27.2 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b, data reload: false query1 0.060.050.06 query2 0.110.050.05 query3 0.270.090.09 query4 1.610.110.11 query5 0.300.270.26 query6 1.170.650.64 query7 0.040.030.02 query8 0.060.040.04 query9 0.580.510.50 query10 0.570.560.56 query11 0.160.100.10 query12 0.150.120.12 query13 0.620.590.60 query14 0.981.000.98 query15 0.820.810.82 query16 0.390.380.40 query17 1.081.050.99 query18 0.230.220.21 query19 1.891.871.85 query20 0.010.020.01 query21 15.45 0.300.13 query22 4.800.050.06 query23 16.12 0.300.10 query24 1.130.230.17 query25 0.060.070.06 query26 0.160.130.14 query27 0.080.070.04 query28 3.381.221.02 query29 12.60 3.863.26 query30 0.280.150.11 query31 2.810.630.40 query32 3.220.550.46 query33 2.963.093.05 query34 16.64 5.134.52 query35 4.564.544.50 query36 0.670.490.48 query37 0.100.080.07 query38 0.070.040.04 query39 0.050.030.03 query40 0.180.150.13 query41 0.080.040.03 query42 0.040.040.03 query43 0.040.040.03 Total cold run time: 96.58 s Total hot run time: 27.2 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604869118 TPC-DS: Total hot run time: 181679 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b, data reload: false query1 1091399 414 399 query2 6583115911461146 query3 6744231 228 228 query4 25409 23229 23029 23029 query5 5055651 497 497 query6 339 244 236 236 query7 4659527 311 311 query8 311 256 249 249 query9 8725264326052605 query10 542 350 302 302 query11 15408 15249 14574 14574 query12 185 115 118 115 query13 1683572 435 435 query14 9553595759245924 query15 203 199 178 178 query16 7627689 500 500 query17 1180756 605 605 query18 2068422 331 331 query19 207 197 174 174 query20 127 122 121 121 query21 217 138 112 112 query22 3842387738293829 query23 32708 31977 31874 31874 query24 8510243124022402 query25 612 505 489 489 query26 1242280 169 169 query27 2740503 345 345 query28 4377215521142114 query29 817 614 487 487 query30 316 240 211 211 query31 824 705 627 627 query32 86 73 75 73 query33 597 389 331 331 query34 826 888 552 552 query35 787 839 751 751 query36 920 932 855 855 query37 131 113 91 91 query38 3946388938173817 query39 1457141914081408 query40 226 135 122 122 query41 70 63 65 63 query42 125 117 125 117 query43 452 439 433 433 query44 1318756 758 756 query45 193 199 179 179 query46 895 1017648 648 query47 1679172616511651 query48 414 428 332 332 query49 808 514 439 439 query50 686 700 424 424 query51 3829395639013901 query52 119 117 112 112 query53 254 267 195 195 query54 327 311 290 290 query55 100 98 98 98 query56 376 340 347 340 query57 1124119310961096 query58 299 291 291 291 query59 2320236422252225 query60 372 369 358 358 query61 194 199 188 188 query62 801 724 662 662 query63 245 203 198 198 query64 4631132510011001 query65 4064395039673950 query66 1116461 378 378 query67 15410 15008 15019 15008 query68 8357991 632 632 query69 530 355 318 318 query70 1143999 1037999 query71 468 376 324 324 query72 5521479747454745 query73 668 572 346 346 query74 8845884185698569 query75 3265300525752575 query76 34551128742 742 query77 563 436 312 312 query78 9508975688398839 query79 2322908 594 594 query80 641 592 515 515 query81 520 269 234 234 query82 318 145 121 121 query83 267 266 255 255 query84 264 117 93 93 query85 935 489 441 441 query86 398 315 281 281 query87 4011406439603960 query88 4248231623282316 query89 398 329 294 294 query90 1950230 225 225 query91 176 170 146 146 query92 87 72 64 64 query93 18941037654 654 query94 720 453 357 357 query95 498 416 421 416 query96 555 564 296 296 query97 2626266925972597 query98 248 212 207 207 query99 1323139012611261 Total cold run time: 271823 ms Total hot run time: 181679 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604802320 # FE Regression Coverage Report Increment line coverage ` 81.08% (527/650)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604757830 # BE Regression && UT Coverage Report Increment line coverage `90.28% (455/504)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.26% (24833/34368) | | Line Coverage | 58.90% (260209/441778) | | Region Coverage | 53.66% (215489/401590) | | Branch Coverage | 55.21% (92207/167007) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604738479 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3604492425 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3603252770 # FE Regression Coverage Report Increment line coverage ` 81.08% (527/650)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3603177596 # BE Regression && UT Coverage Report Increment line coverage `90.28% (455/504)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.26% (24834/34368) | | Line Coverage | 58.91% (260233/441778) | | Region Coverage | 53.66% (215507/401590) | | Branch Coverage | 55.21% (92212/167007) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3602677803 # FE UT Coverage Report Increment line coverage ` 66.92% (435/650)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3602647645 # BE UT Coverage Report Increment line coverage `33.14% (169/510)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b_d4d1ab5868c73ae6c4f2ef2a417b7989af3a0c7b/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.45% (18737/35052) | | Line Coverage | 39.09% (172821/442160) | | Region Coverage | 33.70% (133709/396786) | | Branch Coverage | 34.65% (57555/166110) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3602322277 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3602259986 ClickBench: Total hot run time: 27.47 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1e53b30eb2e960417338d780bd6a2ee7daa6609d, data reload: false query1 0.060.050.05 query2 0.100.060.05 query3 0.260.090.08 query4 1.640.120.11 query5 0.270.270.26 query6 1.180.660.63 query7 0.040.030.03 query8 0.060.040.05 query9 0.580.510.51 query10 0.570.570.58 query11 0.170.110.11 query12 0.140.120.12 query13 0.650.620.60 query14 0.991.010.99 query15 0.840.810.80 query16 0.430.410.42 query17 0.991.081.09 query18 0.250.220.22 query19 1.961.901.76 query20 0.020.020.02 query21 15.44 0.330.14 query22 4.600.050.04 query23 15.87 0.290.11 query24 1.370.490.26 query25 0.090.050.05 query26 0.150.130.14 query27 0.060.070.05 query28 3.901.241.03 query29 12.66 3.983.25 query30 0.280.140.12 query31 2.860.640.39 query32 3.250.570.47 query33 3.153.053.14 query34 16.96 5.204.55 query35 4.564.534.60 query36 0.660.510.51 query37 0.110.070.06 query38 0.080.040.04 query39 0.050.030.04 query40 0.160.140.13 query41 0.090.030.03 query42 0.040.030.02 query43 0.050.040.04 Total cold run time: 97.64 s Total hot run time: 27.47 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3602239044 TPC-DS: Total hot run time: 182783 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1e53b30eb2e960417338d780bd6a2ee7daa6609d, data reload: false query1 1079415 387 387 query2 6577123411981198 query3 6743232 232 232 query4 25133 23338 22712 22712 query5 4842675 502 502 query6 338 248 233 233 query7 4666520 313 313 query8 303 281 264 264 query9 8770265226792652 query10 552 353 307 307 query11 15305 15073 14932 14932 query12 180 125 115 115 query13 1708587 454 454 query14 9284619860956095 query15 210 200 183 183 query16 7518705 518 518 query17 1200787 631 631 query18 2041430 331 331 query19 212 214 173 173 query20 132 126 124 124 query21 215 136 126 126 query22 3954393640203936 query23 32912 32072 31897 31897 query24 8558245724252425 query25 644 528 466 466 query26 1256304 170 170 query27 2737520 360 360 query28 4349219621942194 query29 869 671 523 523 query30 319 246 216 216 query31 848 702 664 664 query32 87 79 78 78 query33 618 412 358 358 query34 835 911 556 556 query35 823 842 757 757 query36 960 962 848 848 query37 127 107 94 94 query38 3905387138513851 query39 1511144814231423 query40 227 138 124 124 query41 68 63 63 63 query42 127 119 120 119 query43 426 446 447 446 query44 1349742 775 742 query45 199 195 183 183 query46 907 1015660 660 query47 1732172916801680 query48 417 434 339 339 query49 762 505 427 427 query50 704 726 419 419 query51 4030396238613861 query52 115 116 110 110 query53 245 265 194 194 query54 314 312 283 283 query55 99 97 93 93 query56 335 338 325 325 query57 1156119210731073 query58 303 279 282 279 query59 2299236223812362 query60 359 401 343 343 query61 168 167 165 165 query62 813 722 650 650 query63 230 201 200 200 query64 46271233921 921 query65 4046400539703970 query66 1151447 356 356 query67 15338 14797 14971 14797 query68 54641022638 638 query69 537 348 308 308 query70 1129990 989 989 query71 441 355 312 312 query72 5857502152195021 query73 709 628 350 350 query74 8941880387338733 query75 3076307825852585 query76 32961163775 775 query77 525 429 322 322 query78 9591963289228922 query79 2736861 589 589 query80 717 645 508 508 query81 505 271 236 236 query82 478 140 117 117 query83 275 282 253 253 query84 261 126 105 105 query85 972 525 454 454 query86 386 290 302 290 query87 4050421339233923 query88 4278234323712343 query89 393 337 300 300 query90 1927225 227 225 query91 174 178 147 147 query92 83 71 66 66 query93 24071054665 665 query94 790 448 357 357 query95 535 419 418 418 query96 540 577 295 295 query97 2649270025652565 query98 249 224 215 215 query99 1356140312751275 Total cold run time: 270193 ms Total hot run time: 182783 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3602194320 TPC-H: Total hot run time: 34777 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1e53b30eb2e960417338d780bd6a2ee7daa6609d, data reload: false -- Round 1 -- q1 17606 503049474947 q2 2063332 212 212 q3 10239 1313742 742 q4 10230 902 332 332 q5 7553248421902190 q6 187 167 138 138 q7 957 795 634 634 q8 9359148411811181 q9 7160541053865386 q10 6843223717731773 q11 538 320 292 292 q12 360 404 239 239 q13 17794 367830843084 q14 243 244 218 218 q15 596 536 524 524 q16 902 880 824 824 q17 714 847 513 513 q18 7456726471297129 q19 1010971 639 639 q20 377 374 244 244 q21 4084366125842584 q22 10451044952 952 Total cold run time: 107316 ms Total hot run time: 34777 ms - Round 2, with runtime_filter_mode=off - q1 4965500449244924 q2 340 401 331 331 q3 2133272223042304 q4 1346180013231323 q5 4287475645834583 q6 244 183 134 134 q7 2056196317971797 q8 2745257025882570 q9 7493750376977503 q10 3077339528472847 q11 596 515 492 492 q12 674 748 604 604 q13 3617392434053405 q14 287 300 312 300 q15 545 525 521 521 q16 894 935 868 868 q17 1204147014241424 q18 8049757877607578 q19 914 881 858 858 q20 1922198218401840 q21 4711424043004240 q22 11241040987 987 Total cold run time: 53223 ms Total hot run time: 51433 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3601980583 # FE UT Coverage Report Increment line coverage ` 66.92% (435/650)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_1e53b30eb2e960417338d780bd6a2ee7daa6609d/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_1e53b30eb2e960417338d780bd6a2ee7daa6609d/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3601708375 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3601162690 # FE Regression Coverage Report Increment line coverage ` 75.59% (483/639)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3601088673 # BE Regression && UT Coverage Report Increment line coverage `90.67% (457/504)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.29% (24843/34365) | | Line Coverage | 58.95% (260387/441724) | | Region Coverage | 53.86% (216291/401550) | | Branch Coverage | 55.35% (92426/166985) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3600862674 # FE Regression Coverage Report Increment line coverage ` 80.13% (512/639)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3600802872 # BE Regression && UT Coverage Report Increment line coverage `90.67% (457/504)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_65faa490e5fabacc47bde70d9d74f8241d4601f4_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 72.14% (24791/34365) | | Line Coverage | 58.80% (259714/441724) | | Region Coverage | 53.70% (215620/401550) | | Branch Coverage | 55.19% (92156/166985) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3600308930 # BE UT Coverage Report Increment line coverage `33.14% (169/510)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/65faa490e5fabacc47bde70d9d74f8241d4601f4_65faa490e5fabacc47bde70d9d74f8241d4601f4/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/65faa490e5fabacc47bde70d9d74f8241d4601f4_65faa490e5fabacc47bde70d9d74f8241d4601f4/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.46% (18739/35052) | | Line Coverage | 39.10% (172856/442128) | | Region Coverage | 33.71% (133745/396770) | | Branch Coverage | 34.66% (57560/166094) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3600143944 ClickBench: Total hot run time: 27.34 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 65faa490e5fabacc47bde70d9d74f8241d4601f4, data reload: false query1 0.060.050.06 query2 0.100.050.04 query3 0.260.090.09 query4 1.610.110.12 query5 0.280.270.26 query6 1.180.640.65 query7 0.030.030.03 query8 0.060.040.04 query9 0.550.520.51 query10 0.550.570.55 query11 0.150.110.12 query12 0.160.130.12 query13 0.620.620.61 query14 1.000.980.98 query15 0.840.790.81 query16 0.400.400.40 query17 1.041.061.03 query18 0.240.220.22 query19 1.851.841.80 query20 0.020.010.01 query21 15.44 0.250.13 query22 4.760.050.04 query23 15.87 0.280.11 query24 0.950.730.32 query25 0.100.060.05 query26 0.140.130.14 query27 0.070.070.04 query28 3.711.241.02 query29 12.54 4.033.26 query30 0.280.140.13 query31 2.820.610.39 query32 3.240.540.47 query33 3.053.033.15 query34 16.83 5.204.48 query35 4.564.544.50 query36 0.650.490.49 query37 0.110.070.07 query38 0.080.040.04 query39 0.050.030.04 query40 0.180.140.14 query41 0.090.030.02 query42 0.050.030.03 query43 0.040.030.03 Total cold run time: 96.61 s Total hot run time: 27.34 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3600134196 TPC-DS: Total hot run time: 182687 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 65faa490e5fabacc47bde70d9d74f8241d4601f4, data reload: false query1 1065414 395 395 query2 6613120011681168 query3 6741242 228 228 query4 25311 23468 23069 23069 query5 5112650 492 492 query6 334 245 220 220 query7 4660501 318 318 query8 303 252 245 245 query9 8717266726582658 query10 552 369 304 304 query11 15227 15126 14896 14896 query12 192 115 112 112 query13 1684576 441 441 query14 9617594259955942 query15 204 202 188 188 query16 7647689 529 529 query17 1194749 636 636 query18 2026421 341 341 query19 203 204 177 177 query20 134 126 120 120 query21 214 132 113 113 query22 4137396238863886 query23 32892 31878 32173 31878 query24 8555243024152415 query25 592 568 471 471 query26 951 273 175 175 query27 2718495 346 346 query28 4352216621262126 query29 731 621 502 502 query30 310 240 214 214 query31 821 725 627 627 query32 80 78 71 71 query33 585 400 338 338 query34 822 882 555 555 query35 784 840 773 773 query36 895 949 840 840 query37 123 115 99 99 query38 3939387838773877 query39 1444144014111411 query40 225 141 124 124 query41 66 63 65 63 query42 127 114 112 112 query43 441 449 415 415 query44 1292754 747 747 query45 198 198 191 191 query46 881 1000653 653 query47 1683174316651665 query48 405 423 339 339 query49 784 514 432 432 query50 674 706 421 421 query51 3993402239183918 query52 114 119 111 111 query53 255 260 197 197 query54 329 313 306 306 query55 101 100 98 98 query56 353 363 349 349 query57 1132119210771077 query58 293 288 287 287 query59 2271246322962296 query60 367 384 349 349 query61 198 190 198 190 query62 775 742 670 670 query63 229 196 210 196 query64 3887132510171017 query65 4076395739823957 query66 962 455 349 349 query67 15166 15254 14970 14970 query68 8275950 650 650 query69 529 352 321 321 query70 1058103010311030 query71 463 339 332 332 query72 5963483148904831 query73 680 577 348 348 query74 8527876085338533 query75 3301302125292529 query76 34251126745 745 query77 680 399 329 329 query78 9533981589288928 query79 2192810 574 574 query80 642 599 517 517 query81 520 272 236 236 query82 221 141 119 119 query83 260 266 255 255 query84 266 120 97 97 query85 884 492 457 457 query86 389 314 294 294 query87 4060400940214009 query88 4200232623352326 query89 386 335 309 309 query90 2000229 228 228 query91 169 175 139 139 query92 85 76 66 66 query93 1852990 661 661 query94 723 461 334 334 query95 504 414 413 413 query96 514 553 288 288 query97 2576268826102610 query98 246 236 213 213 query99 1313141212711271 Total cold run time: 270194 ms Total hot run time: 182687 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3600113748 TPC-H: Total hot run time: 34317 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 65faa490e5fabacc47bde70d9d74f8241d4601f4, data reload: false -- Round 1 -- q1 17607 500048594859 q2 2032319 208 208 q3 10258 1351758 758 q4 10234 921 333 333 q5 7517242421992199 q6 183 170 137 137 q7 997 791 649 649 q8 9349132410661066 q9 7055554253765376 q10 6857220818041804 q11 521 309 304 304 q12 378 367 228 228 q13 17767 366231183118 q14 241 240 223 223 q15 588 522 533 522 q16 882 869 824 824 q17 601 716 553 553 q18 7723717870807080 q19 1091962 587 587 q20 344 341 231 231 q21 3703259623152315 q22 1019987 943 943 Total cold run time: 106947 ms Total hot run time: 34317 ms - Round 2, with runtime_filter_mode=off - q1 4982494749404940 q2 336 388 325 325 q3 2117266623312331 q4 1324178613121312 q5 4253443845544438 q6 225 176 134 134 q7 2029199218951895 q8 2637255224962496 q9 7564748975147489 q10 3046322728262826 q11 609 540 502 502 q12 729 822 620 620 q13 3510396734873487 q14 310 310 279 279 q15 553 520 513 513 q16 898 969 864 864 q17 1174144614791446 q18 7769762875767576 q19 790 737 757 737 q20 1912197118421842 q21 4612431842194219 q22 10941024987 987 Total cold run time: 52473 ms Total hot run time: 51258 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3599888287 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3599839589 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3599616807 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3599614488 run complie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3596864631 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3596825426 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3596824360 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3596824853 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3596537546 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3596346903 # BE UT Coverage Report Increment line coverage `33.14% (169/510)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/3adc999a2aa71eff761d9914e07799134f8119ea_3adc999a2aa71eff761d9914e07799134f8119ea/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/3adc999a2aa71eff761d9914e07799134f8119ea_3adc999a2aa71eff761d9914e07799134f8119ea/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.77% (18495/35051) | | Line Coverage | 38.34% (169469/442011) | | Region Coverage | 33.14% (131458/396703) | | Branch Coverage | 34.09% (56606/166047) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595879673 ClickBench: Total hot run time: 27.47 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3adc999a2aa71eff761d9914e07799134f8119ea, data reload: false query1 0.050.050.05 query2 0.110.060.04 query3 0.260.090.08 query4 1.610.110.11 query5 0.260.250.26 query6 1.180.660.64 query7 0.030.030.03 query8 0.060.040.04 query9 0.590.530.50 query10 0.560.540.56 query11 0.150.100.11 query12 0.150.120.11 query13 0.620.610.61 query14 1.000.990.98 query15 0.830.830.81 query16 0.430.420.40 query17 1.031.011.02 query18 0.230.220.21 query19 1.831.721.89 query20 0.020.010.02 query21 15.46 0.270.13 query22 4.940.050.04 query23 16.04 0.270.10 query24 0.990.540.46 query25 0.100.070.05 query26 0.160.140.14 query27 0.060.050.04 query28 4.551.221.03 query29 12.59 4.033.33 query30 0.280.150.11 query31 2.840.620.40 query32 3.230.550.47 query33 3.092.993.12 query34 17.01 5.234.53 query35 4.574.574.59 query36 0.660.500.49 query37 0.100.070.07 query38 0.070.040.03 query39 0.050.030.04 query40 0.180.130.13 query41 0.090.030.03 query42 0.050.030.03 query43 0.040.030.04 Total cold run time: 98.15 s Total hot run time: 27.47 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595860191 TPC-DS: Total hot run time: 182548 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3adc999a2aa71eff761d9914e07799134f8119ea, data reload: false query1 1064426 394 394 query2 6630120811651165 query3 6749233 225 225 query4 25601 24046 22959 22959 query5 5784655 495 495 query6 350 239 234 234 query7 4650522 303 303 query8 303 250 246 246 query9 8718265226592652 query10 560 363 321 321 query11 15408 15158 14962 14962 query12 183 120 119 119 query13 1697570 453 453 query14 10954 604759825982 query15 275 212 190 190 query16 7795722 536 536 query17 1603810 649 649 query18 2049441 353 353 query19 311 209 189 189 query20 130 126 122 122 query21 220 139 123 123 query22 3923399638693869 query23 32835 32174 32183 32174 query24 8150247924282428 query25 617 562 482 482 query26 1241283 178 178 query27 2665505 391 391 query28 4327217221512151 query29 775 637 481 481 query30 312 240 205 205 query31 831 720 604 604 query32 85 76 81 76 query33 595 384 341 341 query34 811 870 542 542 query35 774 830 725 725 query36 884 919 838 838 query37 128 112 90 90 query38 3927381738573817 query39 1487139814031398 query40 221 133 123 123 query41 68 65 65 65 query42 134 122 112 112 query43 443 443 405 405 query44 1260758 734 734 query45 202 190 187 187 query46 878 1001634 634 query47 1673173516411641 query48 386 416 322 322 query49 784 491 428 428 query50 669 696 420 420 query51 3951404738513851 query52 110 112 103 103 query53 241 257 194 194 query54 318 292 286 286 query55 94 92 93 92 query56 322 332 356 332 query57 1167115310981098 query58 283 291 291 291 query59 2391243824172417 query60 351 353 361 353 query61 169 167 162 162 query62 776 730 651 651 query63 229 194 201 194 query64 45681214917 917 query65 4042395739833957 query66 1030437 341 341 query67 15478 15087 14872 14872 query68 8516960 622 622 query69 534 348 326 326 query70 1107980 1014980 query71 466 350 317 317 query72 5803489548994895 query73 673 573 352 352 query74 8827882185088508 query75 3112305025782578 query76 35151137739 739 query77 578 449 329 329 query78 9519955288568856 query79 2291851 591 591 query80 688 618 525 525 query81 495 279 248 248 query82 467 142 115 115 query83 274 267 254 254 query84 274 124 100 100 query85 917 514 473 473 query86 334 286 282 282 query87 4052409740034003 query88 4171232523342325 query89 395 363 303 303 query90 1947242 232 232 query91 169 174 144 144 query92 86 73 69 69 query93 20241007653 653 query94 774 428 340 340 query95 506 426 411 411 query96 529 568 294 294 query97 2678268725602560 query98 240 218 212 212 query99 1570140312681268 Total cold run time: 275170 ms Total hot run time: 182548 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595811773 TPC-H: Total hot run time: 34212 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3adc999a2aa71eff761d9914e07799134f8119ea, data reload: false -- Round 1 -- q1 17651 505149084908 q2 2085314 212 212 q3 10254 1328741 741 q4 10241 934 326 326 q5 7530241421702170 q6 187 171 135 135 q7 960 780 648 648 q8 9353139010321032 q9 7052525353185253 q10 6761220817741774 q11 530 319 287 287 q12 337 368 223 223 q13 17771 365030913091 q14 227 231 218 218 q15 581 520 528 520 q16 887 884 821 821 q17 611 724 556 556 q18 7411718370707070 q19 1081960 595 595 q20 349 336 231 231 q21 3548309424562456 q22 10211008945 945 Total cold run time: 106428 ms Total hot run time: 34212 ms - Round 2, with runtime_filter_mode=off - q1 4958494649374937 q2 337 401 335 335 q3 2140268323102310 q4 1299173313201320 q5 4242431046094310 q6 228 174 132 132 q7 2059203718481848 q8 2664254025082508 q9 7569742875367428 q10 3079327028082808 q11 613 530 489 489 q12 673 766 626 626 q13 3567392733903390 q14 290 302 280 280 q15 564 529 528 528 q16 902 913 891 891 q17 1173151114551455 q18 7926767975967596 q19 830 800 822 800 q20 2002206519921992 q21 4664423540104010 q22 10621032980 980 Total cold run time: 52841 ms Total hot run time: 50973 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595401655 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595290831 # BE UT Coverage Report Increment line coverage `33.14% (169/510)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/ddf4f079300f0d1e7e86f43e0a8ad81e9fff84e5_ddf4f079300f0d1e7e86f43e0a8ad81e9fff84e5/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/ddf4f079300f0d1e7e86f43e0a8ad81e9fff84e5_ddf4f079300f0d1e7e86f43e0a8ad81e9fff84e5/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.77% (18495/35051) | | Line Coverage | 38.34% (169468/442003) | | Region Coverage | 33.11% (131359/396698) | | Branch Coverage | 34.09% (56600/166041) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
morrySnow commented on code in PR #58031:
URL: https://github.com/apache/doris/pull/58031#discussion_r2576040695
##
fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java:
##
@@ -798,7 +798,12 @@ public synchronized void addFunction(Function function,
boolean ifNotExists) thr
function.checkWritable();
if (FunctionUtil.addFunctionImpl(function, ifNotExists, false,
name2Function)) {
Env.getCurrentEnv().getEditLog().logAddFunction(function);
-FunctionUtil.translateToNereids(this.getFullName(), function);
+try {
+FunctionUtil.translateToNereidsThrows(this.getFullName(),
function);
+} catch (Exception e) {
+name2Function.remove(function.getFunctionName().getFunction());
+throw e;
+}
Review Comment:
why throw exception here? we should not throw any exception after record
edit log
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/SlotReference.java:
##
@@ -220,6 +220,17 @@ public String toString() {
}
return name.get() + "['" + String.join("']['", subPath) + "']" + "#" +
exprId;
}
+// @Override
Review Comment:
? why comment these code blocks
##
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##
@@ -441,15 +441,15 @@ protected void addShadowIndexToCatalog(OlapTable tbl) {
partition.createRollupIndex(shadowIndex);
}
}
-
+// ?这里需要传入session variables吗？think
Review Comment:
remove this comment
##
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##
@@ -441,15 +441,15 @@ protected void addShadowIndexToCatalog(OlapTable tbl) {
partition.createRollupIndex(shadowIndex);
}
}
-
+// ?这里需要传入session variables吗？think
for (long shadowIdxId : indexIdMap.keySet()) {
MaterializedIndexMeta originalIndexMeta =
tbl.getIndexMetaByIndexId(indexIdMap.get(shadowIdxId));
tbl.setIndexMeta(shadowIdxId, indexIdToName.get(shadowIdxId),
indexSchemaMap.get(shadowIdxId),
indexSchemaVersionAndHashMap.get(shadowIdxId).schemaVersion,
indexSchemaVersionAndHashMap.get(shadowIdxId).schemaHash,
indexShortKeyMap.get(shadowIdxId), TStorageType.COLUMN,
tbl.getKeysTypeByIndexId(indexIdMap.get(shadowIdxId)),
originalIndexMeta.getDefineStmt(),
-indexChange ? indexes : originalIndexMeta.getIndexes());
+indexChange ? indexes : originalIndexMeta.getIndexes(),
null);
Review Comment:
why null? add comment to explain it
##
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/StructInfoMap.java:
##
@@ -80,8 +81,9 @@ public class StructInfoMap {
}
if (groupExpressionMap.containsKey(tableMap)) {
Pair> groupExpressionBitSetPair =
getGroupExpressionWithChildren(tableMap);
-structInfo = constructStructInfo(groupExpressionBitSetPair.first,
groupExpressionBitSetPair.second,
-originPlan, cascadesContext);
+structInfo = MoreFieldsThread.keepFunctionSignature(() ->
Review Comment:
add a NOTICE comment to explain why need to use `keepFunctionSignature`
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DecimalV3Literal.java:
##
@@ -62,6 +62,14 @@ public DecimalV3Literal(DecimalV3Type dataType, BigDecimal
value) {
this.value = Objects.requireNonNull(adjustedValue);
}
+public static DecimalV3Literal createWithCheck256(BigDecimal value) {
+return new DecimalV3Literal(DecimalV3Type.createDecimalV3Type(value),
value);
+}
+
+public static DecimalV3Literal createWithoutCheck256(BigDecimal value) {
+return new
DecimalV3Literal(DecimalV3Type.createDecimalV3TypeNotCheck256(value), value);
+}
Review Comment:
add comment to explain these two functions
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/NeedSessionVarGuard.java:
##
@@ -15,17 +15,10 @@
// specific language governing permissions and limitations
// under the License.
-suite("test_decimal_sum") {
-sql "set enable_agg_state=true"
-sql """ DROP TABLE IF EXISTS t01; """
-sql """
-create table t01(id int, decimal_col agg_state
generic) properties ("replication_num" = "1");
-"""
+package org.apache.doris.nereids.trees.expressions;
-sql """insert into t01 values (1, sum_state(10.1)), (1, sum_state(20.1)),
(2, sum_state(10.2)), (2, sum_state(11.0));
-"""
-
-
-qt_select """ select sum_merge(decimal_col) from t01 group by id order by
id;
- """
+/**
+ * expressions that need session variables guard
+ * */
+public interface NeedSessionVarGuard {
Review Comment:
add
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595070548 ClickBench: Total hot run time: 27.61 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ddf4f079300f0d1e7e86f43e0a8ad81e9fff84e5, data reload: false query1 0.060.050.05 query2 0.100.050.05 query3 0.260.080.08 query4 1.630.110.10 query5 0.280.270.26 query6 1.150.650.63 query7 0.030.020.03 query8 0.060.040.04 query9 0.570.500.50 query10 0.560.560.54 query11 0.160.110.11 query12 0.140.110.11 query13 0.630.610.61 query14 0.980.981.00 query15 0.820.790.80 query16 0.380.400.41 query17 1.001.051.08 query18 0.230.210.21 query19 1.871.851.74 query20 0.010.010.01 query21 15.44 0.240.14 query22 4.940.050.05 query23 15.88 0.260.11 query24 2.060.620.89 query25 0.100.060.05 query26 0.160.140.14 query27 0.080.080.05 query28 5.431.191.02 query29 12.57 4.033.23 query30 0.280.130.13 query31 2.820.610.40 query32 3.240.550.46 query33 3.053.103.09 query34 16.80 5.134.50 query35 4.534.594.54 query36 0.640.510.48 query37 0.110.060.06 query38 0.070.040.03 query39 0.040.020.02 query40 0.160.150.13 query41 0.090.030.04 query42 0.050.030.02 query43 0.040.040.03 Total cold run time: 99.5 s Total hot run time: 27.61 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595053137 TPC-DS: Total hot run time: 181550 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ddf4f079300f0d1e7e86f43e0a8ad81e9fff84e5, data reload: false query1 1054405 397 397 query2 6587117611631163 query3 6738234 227 227 query4 25153 23022 22980 22980 query5 5003657 475 475 query6 348 286 222 222 query7 4651504 308 308 query8 315 256 247 247 query9 8731264126492641 query10 548 351 304 304 query11 15332 15165 14884 14884 query12 184 120 117 117 query13 1677560 439 439 query14 9614591359615913 query15 203 198 192 192 query16 7666688 524 524 query17 1187776 607 607 query18 2041422 327 327 query19 201 201 175 175 query20 129 122 121 121 query21 221 134 115 115 query22 3883398439123912 query23 32699 32113 31720 31720 query24 8476239424112394 query25 643 523 464 464 query26 1237277 165 165 query27 2738498 348 348 query28 4367217621502150 query29 777 647 483 483 query30 312 246 233 233 query31 828 700 652 652 query32 87 77 78 77 query33 609 378 338 338 query34 812 864 555 555 query35 797 834 718 718 query36 893 925 838 838 query37 132 125 97 97 query38 3802384837453745 query39 1479142714781427 query40 236 138 120 120 query41 66 64 62 62 query42 125 116 117 116 query43 446 434 414 414 query44 1290767 751 751 query45 203 194 189 189 query46 885 1005653 653 query47 1696173816371637 query48 413 424 332 332 query49 783 520 416 416 query50 671 702 417 417 query51 3900404338733873 query52 113 118 111 111 query53 262 263 205 205 query54 322 314 306 306 query55 97 96 98 96 query56 352 358 347 347 query57 1130118411071107 query58 308 284 283 283 query59 2297238623772377 query60 382 369 356 356 query61 199 190 191 190 query62 789 751 657 657 query63 246 199 208 199 query64 4612134010241024 query65 4026400240354002 query66 1119446 343 343 query67 15002 14932 14691 14691 query68 8261960 624 624 query69 523 359 316 316 query70 1126100510001000 query71 491 392 314 314 query72 5764484348074807 query73 660 570 342 342 query74 8713881986338633 query75 3591301925122512 query76 36081139721 721 query77 804 402 319 319 query78 9519995787988798 query79 2048842 573 573 query80 649 599 482 482 query81 507 277 241 241 query82 478 161 132 132 query83 275 262 247 247 query84 257 118 99 99 query85 984 492 440 440 query86 342 296 292 292 query87 4086404139733973 query88 3936228922692269 query89 400 332 294 294 query90 1965225 227 225 query91 175 175 137 137 query92 84 73 66 66 query93 17161025660 660 query94 682 465 349 349 query95 505 426 405 405 query96 508 552 287 287 query97 2645269125752575 query98 248 219 212 212 query99 1353139812381238 Total cold run time: 271027 ms Total hot run time: 181550 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3595013517 TPC-H: Total hot run time: 34177 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ddf4f079300f0d1e7e86f43e0a8ad81e9fff84e5, data reload: false -- Round 1 -- q1 17630 511349694969 q2 2029311 207 207 q3 10266 1336757 757 q4 10212 831 323 323 q5 7530242421692169 q6 191 179 141 141 q7 956 791 652 652 q8 9348140510161016 q9 7045530754115307 q10 6873220917831783 q11 521 310 293 293 q12 389 373 234 234 q13 17771 368730563056 q14 240 257 210 210 q15 600 520 516 516 q16 891 851 804 804 q17 591 789 512 512 q18 7553711370727072 q19 1086961 592 592 q20 352 356 241 241 q21 3593378923722372 q22 1001988 951 951 Total cold run time: 106668 ms Total hot run time: 34177 ms - Round 2, with runtime_filter_mode=off - q1 4980496349634963 q2 338 412 322 322 q3 2178268923032303 q4 1328173113081308 q5 4214442946034429 q6 222 181 131 131 q7 2053204318961896 q8 2664255025612550 q9 7593750976057509 q10 3106328927822782 q11 587 532 529 529 q12 677 749 612 612 q13 3510397233593359 q14 302 303 290 290 q15 587 522 511 511 q16 903 938 883 883 q17 1188164814121412 q18 7792766275557555 q19 812 808 808 808 q20 2005206418261826 q21 4583429141774177 q22 11051048975 975 Total cold run time: 52727 ms Total hot run time: 51130 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594707960 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594572889 # BE UT Coverage Report Increment line coverage `33.14% (169/510)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/5e1a043076f25abe580b7480e4d52577c6683f55_5e1a043076f25abe580b7480e4d52577c6683f55/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/5e1a043076f25abe580b7480e4d52577c6683f55_5e1a043076f25abe580b7480e4d52577c6683f55/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.76% (18493/35049) | | Line Coverage | 38.34% (169471/441997) | | Region Coverage | 33.16% (131543/396678) | | Branch Coverage | 34.09% (56604/166037) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594433181 TPC-H: Total hot run time: 33910 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a69f042b50b3174f28e9cc1d879ddd4788962f16, data reload: false -- Round 1 -- q1 17619 508448654865 q2 2019323 203 203 q3 10261 1317713 713 q4 10221 847 375 375 q5 7599252022362236 q6 188 170 133 133 q7 969 806 648 648 q8 9361139110541054 q9 6948528352735273 q10 6889223918141814 q11 525 304 303 303 q12 335 360 233 233 q13 17801 370129982998 q14 228 236 212 212 q15 586 522 517 517 q16 888 865 830 830 q17 610 787 458 458 q18 7512706670107010 q19 1093938 549 549 q20 343 338 234 234 q21 3927320123162316 q22 10221032936 936 Total cold run time: 106944 ms Total hot run time: 33910 ms - Round 2, with runtime_filter_mode=off - q1 4959494449584944 q2 332 398 319 319 q3 2120263023092309 q4 1320177513451345 q5 4281441145424411 q6 218 171 133 133 q7 2030203417991799 q8 2682250025332500 q9 7557739774997397 q10 3094330427292729 q11 633 512 500 500 q12 768 823 718 718 q13 3561375133233323 q14 299 325 282 282 q15 588 528 520 520 q16 938 964 886 886 q17 1168139413821382 q18 7868763176837631 q19 836 774 821 774 q20 2069208619001900 q21 4805427641564156 q22 11011035993 993 Total cold run time: 53227 ms Total hot run time: 50951 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594432958 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
jacktengg commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594328114 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594316359 # BE UT Coverage Report Increment line coverage `33.27% (170/511)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c93d052ffbc8f9a11b7e00e06c1131462df85102_c93d052ffbc8f9a11b7e00e06c1131462df85102/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c93d052ffbc8f9a11b7e00e06c1131462df85102_c93d052ffbc8f9a11b7e00e06c1131462df85102/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.85% (18518/35037) | | Line Coverage | 38.45% (169800/441640) | | Region Coverage | 33.24% (131708/396249) | | Branch Coverage | 34.19% (56703/165839) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594296518 ClickBench: Total hot run time: 28.1 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c93d052ffbc8f9a11b7e00e06c1131462df85102, data reload: false query1 0.050.050.06 query2 0.100.050.06 query3 0.260.080.10 query4 1.600.110.11 query5 0.280.260.27 query6 1.160.660.63 query7 0.040.030.03 query8 0.050.040.04 query9 0.570.520.51 query10 0.550.560.56 query11 0.160.120.12 query12 0.150.120.12 query13 0.610.600.60 query14 1.000.991.00 query15 0.820.810.81 query16 0.450.400.41 query17 1.051.061.04 query18 0.230.210.22 query19 1.961.881.81 query20 0.020.020.02 query21 15.44 0.270.14 query22 4.780.050.05 query23 15.84 0.260.11 query24 2.200.751.15 query25 0.080.080.07 query26 0.140.140.13 query27 0.060.080.04 query28 6.431.191.02 query29 12.58 3.873.24 query30 0.300.140.11 query31 2.810.610.39 query32 3.220.550.46 query33 3.043.123.19 query34 16.91 5.144.57 query35 4.594.604.58 query36 0.660.510.50 query37 0.110.060.06 query38 0.060.040.04 query39 0.050.030.03 query40 0.180.160.15 query41 0.100.040.04 query42 0.050.030.03 query43 0.040.040.03 Total cold run time: 100.78 s Total hot run time: 28.1 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594287405 TPC-DS: Total hot run time: 182753 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c93d052ffbc8f9a11b7e00e06c1131462df85102, data reload: false query1 1087405 389 389 query2 6596117511571157 query3 6763238 222 222 query4 25472 23309 23174 23174 query5 5060661 518 518 query6 342 244 224 224 query7 4656498 303 303 query8 313 269 241 241 query9 8712262226152615 query10 560 341 307 307 query11 15416 14799 14782 14782 query12 174 118 110 110 query13 1692581 474 474 query14 9334594660645946 query15 211 198 192 192 query16 7473669 537 537 query17 1179748 615 615 query18 2011422 328 328 query19 217 199 176 176 query20 126 123 120 120 query21 219 136 114 114 query22 3986391539393915 query23 32915 31990 31879 31879 query24 8496244824562448 query25 669 558 490 490 query26 1256283 176 176 query27 2720503 352 352 query28 4372216821542154 query29 841 651 539 539 query30 315 244 214 214 query31 849 744 649 649 query32 86 81 79 79 query33 646 407 347 347 query34 828 899 536 536 query35 802 836 760 760 query36 902 945 856 856 query37 125 118 99 99 query38 3867388938123812 query39 1506142014251420 query40 237 142 128 128 query41 74 72 73 72 query42 131 119 124 119 query43 462 467 433 433 query44 1348773 752 752 query45 204 197 189 189 query46 880 1003659 659 query47 1695172816401640 query48 414 426 332 332 query49 798 523 441 441 query50 685 702 423 423 query51 3847394739103910 query52 121 117 112 112 query53 244 271 201 201 query54 344 327 319 319 query55 107 98 90 90 query56 362 350 364 350 query57 1119119711031103 query58 299 311 286 286 query59 2304239923072307 query60 363 369 363 363 query61 155 159 160 159 query62 766 696 661 661 query63 234 199 204 199 query64 44821200891 891 query65 4029394739973947 query66 1166450 329 329 query67 15272 15147 14801 14801 query68 8294952 622 622 query69 514 351 312 312 query70 1110998 1046998 query71 483 363 331 331 query72 5587480648374806 query73 713 570 347 347 query74 8786874188208741 query75 3783307225862586 query76 38181173770 770 query77 839 415 325 325 query78 9509987690159015 query79 2040855 586 586 query80 639 589 490 490 query81 489 271 247 247 query82 432 144 111 111 query83 271 266 247 247 query84 253 125 98 98 query85 917 514 451 451 query86 343 319 279 279 query87 4116412940184018 query88 3629229822952295 query89 388 329 295 295 query90 1976226 231 226 query91 181 168 145 145 query92 81 72 66 66 query93 11391012672 672 query94 722 448 337 337 query95 517 420 408 408 query96 504 558 291 291 query97 2655268326162616 query98 246 220 215 215 query99 1567139813221322 Total cold run time: 271477 ms Total hot run time: 182753 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594264978 TPC-H: Total hot run time: 34266 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c93d052ffbc8f9a11b7e00e06c1131462df85102, data reload: false -- Round 1 -- q1 17751 505149014901 q2 2102311 209 209 q3 10270 1397748 748 q4 10268 919 380 380 q5 7494244522302230 q6 186 163 137 137 q7 952 807 655 655 q8 9642135210051005 q9 7100528253145282 q10 7156225718601860 q11 542 304 291 291 q12 358 372 228 228 q13 17857 365931013101 q14 224 250 222 222 q15 581 511 520 511 q16 899 884 807 807 q17 588 734 518 518 q18 7306717971067106 q19 1106933 569 569 q20 341 343 230 230 q21 3561339423152315 q22 1010994 961 961 Total cold run time: 107294 ms Total hot run time: 34266 ms - Round 2, with runtime_filter_mode=off - q1 4943492348864886 q2 326 402 312 312 q3 2157261722402240 q4 1272172512861286 q5 4218451645964516 q6 212 168 126 126 q7 2127199918411841 q8 2678259624622462 q9 7502750774457445 q10 3123322027822782 q11 584 517 506 506 q12 677 782 849 782 q13 3439390333083308 q14 290 321 300 300 q15 569 543 505 505 q16 895 908 995 908 q17 1152140114441401 q18 7826764478237644 q19 787 791 817 791 q20 1963198819451945 q21 4539423341634163 q22 10681037962 962 Total cold run time: 52347 ms Total hot run time: 5 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594189838 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594161572 ClickBench: Total hot run time: 27.88 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3059599c339b36f891f3ce2324bba8a34faa5d3e, data reload: false query1 0.050.040.04 query2 0.150.050.05 query3 0.260.090.09 query4 1.610.110.11 query5 0.280.240.27 query6 1.160.640.63 query7 0.030.020.03 query8 0.050.040.05 query9 0.580.510.50 query10 0.560.560.55 query11 0.180.110.11 query12 0.150.120.12 query13 0.610.600.61 query14 0.990.970.98 query15 0.820.810.80 query16 0.400.410.43 query17 1.031.041.01 query18 0.230.220.22 query19 1.941.821.78 query20 0.020.020.01 query21 15.44 0.270.14 query22 4.780.060.05 query23 16.05 0.260.10 query24 2.200.901.04 query25 0.100.100.08 query26 0.140.140.13 query27 0.060.050.06 query28 5.651.221.03 query29 12.61 3.853.25 query30 0.290.130.13 query31 2.830.590.39 query32 3.230.540.46 query33 3.103.023.05 query34 16.94 5.164.49 query35 4.614.544.51 query36 0.660.490.52 query37 0.190.070.06 query38 0.090.040.04 query39 0.060.030.03 query40 0.190.150.14 query41 0.110.030.03 query42 0.060.030.03 query43 0.050.040.03 Total cold run time: 100.54 s Total hot run time: 27.88 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594152173 TPC-DS: Total hot run time: 181942 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3059599c339b36f891f3ce2324bba8a34faa5d3e, data reload: false query1 1103428 412 412 query2 6696118211581158 query3 7080233 225 225 query4 25534 23343 23099 23099 query5 5207650 501 501 query6 345 237 221 221 query7 4673509 317 317 query8 338 272 250 250 query9 8721262826192619 query10 562 361 320 320 query11 15438 15333 14619 14619 query12 210 122 114 114 query13 1702580 460 460 query14 9646607560206020 query15 217 203 186 186 query16 7679711 552 552 query17 1225775 652 652 query18 2067450 356 356 query19 212 203 186 186 query20 133 131 124 124 query21 464 139 127 127 query22 3840388738573857 query23 32826 31840 32167 31840 query24 7968235324242353 query25 653 564 491 491 query26 812 283 166 166 query27 2591498 355 355 query28 3799217021552155 query29 795 657 549 549 query30 332 232 210 210 query31 836 726 624 624 query32 92 82 78 78 query33 606 402 351 351 query34 808 880 549 549 query35 839 830 754 754 query36 890 949 828 828 query37 166 112 85 85 query38 3812386837943794 query39 1467140313931393 query40 228 136 121 121 query41 67 63 64 63 query42 124 115 112 112 query43 444 435 427 427 query44 1273752 758 752 query45 200 197 185 185 query46 874 1004638 638 query47 1720171616321632 query48 396 424 340 340 query49 740 513 432 432 query50 651 678 432 432 query51 3872400438263826 query52 112 115 116 115 query53 241 264 195 195 query54 314 329 292 292 query55 98 91 90 90 query56 348 346 314 314 query57 1123117910901090 query58 313 279 282 279 query59 2257248723582358 query60 356 373 344 344 query61 165 163 151 151 query62 760 701 657 657 query63 229 191 198 191 query64 33031263942 942 query65 4022399739623962 query66 890 449 346 346 query67 15291 14937 14789 14789 query68 8458957 619 619 query69 523 346 312 312 query70 11401035998 998 query71 512 356 326 326 query72 5870505048774877 query73 724 570 344 344 query74 8800887185858585 query75 3710299525092509 query76 37661123725 725 query77 827 400 320 320 query78 9633953189318931 query79 2180863 584 584 query80 728 572 513 513 query81 515 269 235 235 query82 205 145 109 109 query83 284 269 259 259 query84 259 112 102 102 query85 894 505 474 474 query86 399 302 278 278 query87 4049407839583958 query88 4140230323062303 query89 389 333 298 298 query90 1977231 228 228 query91 183 179 145 145 query92 84 70 71 70 query93 2214996 663 663 query94 693 467 352 352 query95 506 416 413 413 query96 502 555 292 292 query97 2611267826072607 query98 269 223 216 216 query99 1380139912721272 Total cold run time: 271219 ms Total hot run time: 181942 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594130013 TPC-H: Total hot run time: 34170 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3059599c339b36f891f3ce2324bba8a34faa5d3e, data reload: false -- Round 1 -- q1 17727 502148634863 q2 2233307 207 207 q3 10225 1290706 706 q4 10395 927 355 355 q5 7508237723212321 q6 182 177 137 137 q7 938 793 646 646 q8 9338131010891089 q9 6956531452385238 q10 7026223317921792 q11 515 310 286 286 q12 331 365 220 220 q13 17776 361730773077 q14 221 249 216 216 q15 598 522 501 501 q16 888 857 790 790 q17 586 703 524 524 q18 7377700770287007 q19 1092934 568 568 q20 348 342 231 231 q21 2951311924422442 q22 978 967 954 954 Total cold run time: 106189 ms Total hot run time: 34170 ms - Round 2, with runtime_filter_mode=off - q1 4934490548594859 q2 313 398 318 318 q3 2077265922832283 q4 1328176412791279 q5 4216430244084302 q6 211 170 143 143 q7 2074194618121812 q8 2584268825982598 q9 7450743274157415 q10 3031339328592859 q11 589 512 474 474 q12 712 760 639 639 q13 3531390432753275 q14 302 306 300 300 q15 557 508 510 508 q16 907 933 907 907 q17 1163143114471431 q18 7693781874237423 q19 833 806 800 800 q20 1990206421042064 q21 4722441841784178 q22 10501022973 973 Total cold run time: 52267 ms Total hot run time: 50840 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3594050107 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3593313061 # FE Regression Coverage Report Increment line coverage ` 81.16% (517/637)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_df95aa3bcc66acafdc404039f2de5bb09c083768_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_df95aa3bcc66acafdc404039f2de5bb09c083768_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3593273723 # BE Regression && UT Coverage Report Increment line coverage `90.69% (458/505)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_df95aa3bcc66acafdc404039f2de5bb09c083768_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_df95aa3bcc66acafdc404039f2de5bb09c083768_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.69% (24630/34355) | | Line Coverage | 58.25% (257039/441260) | | Region Coverage | 53.43% (214292/401055) | | Branch Coverage | 54.87% (91484/166736) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592810168 # FE UT Coverage Report Increment line coverage ` 66.88% (426/637)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_df95aa3bcc66acafdc404039f2de5bb09c083768/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_df95aa3bcc66acafdc404039f2de5bb09c083768/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592794959 # BE UT Coverage Report Increment line coverage `33.27% (170/511)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/df95aa3bcc66acafdc404039f2de5bb09c083768_df95aa3bcc66acafdc404039f2de5bb09c083768/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/df95aa3bcc66acafdc404039f2de5bb09c083768_df95aa3bcc66acafdc404039f2de5bb09c083768/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.85% (18518/35037) | | Line Coverage | 38.45% (169794/441640) | | Region Coverage | 33.24% (131703/396249) | | Branch Coverage | 34.19% (56704/165839) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592670492 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592271981 # FE Regression Coverage Report Increment line coverage ` 81.00% (516/637)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_fd6c170ef8f8226a11469c06bf02b3d6585f34b0_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_fd6c170ef8f8226a11469c06bf02b3d6585f34b0_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592267641 # BE Regression && UT Coverage Report Increment line coverage `90.69% (458/505)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_fd6c170ef8f8226a11469c06bf02b3d6585f34b0_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_fd6c170ef8f8226a11469c06bf02b3d6585f34b0_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.70% (24634/34355) | | Line Coverage | 58.23% (256952/441260) | | Region Coverage | 53.28% (213701/401055) | | Branch Coverage | 54.80% (91372/166736) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592153759 ClickBench: Total hot run time: 27.18 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit fd6c170ef8f8226a11469c06bf02b3d6585f34b0, data reload: false query1 0.060.050.04 query2 0.100.050.05 query3 0.260.080.08 query4 1.610.120.11 query5 0.270.250.26 query6 1.190.660.64 query7 0.030.020.03 query8 0.060.040.04 query9 0.580.510.50 query10 0.550.560.56 query11 0.150.120.11 query12 0.150.120.11 query13 0.630.600.61 query14 1.010.980.97 query15 0.820.810.80 query16 0.400.400.40 query17 1.001.041.09 query18 0.230.220.26 query19 1.831.791.78 query20 0.020.010.01 query21 15.48 0.290.14 query22 4.690.050.04 query23 16.13 0.260.10 query24 1.770.240.19 query25 0.090.070.06 query26 0.140.140.13 query27 0.060.040.06 query28 4.121.201.02 query29 12.59 3.903.23 query30 0.280.140.13 query31 2.820.610.40 query32 3.230.560.46 query33 3.023.043.02 query34 16.75 5.194.52 query35 4.544.524.57 query36 0.670.510.50 query37 0.110.070.06 query38 0.070.040.04 query39 0.040.040.03 query40 0.180.140.13 query41 0.080.030.03 query42 0.040.040.03 query43 0.040.040.03 Total cold run time: 97.89 s Total hot run time: 27.18 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592151499 TPC-DS: Total hot run time: 181536 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit fd6c170ef8f8226a11469c06bf02b3d6585f34b0, data reload: false query1 1072406 394 394 query2 6575121311781178 query3 6764231 224 224 query4 25102 23348 22780 22780 query5 4566647 513 513 query6 386 241 235 235 query7 4663511 314 314 query8 305 266 249 249 query9 8735260226352602 query10 517 367 308 308 query11 15573 15262 14644 14644 query12 187 122 117 117 query13 1695566 447 447 query14 10003 602159445944 query15 218 204 192 192 query16 7663715 539 539 query17 1262783 659 659 query18 2046446 348 348 query19 213 211 189 189 query20 136 125 125 125 query21 220 137 119 119 query22 4078390438053805 query23 33171 32034 31883 31883 query24 8542238524482385 query25 634 545 498 498 query26 1251275 178 178 query27 2710504 347 347 query28 4338215121352135 query29 830 664 534 534 query30 318 243 216 216 query31 847 722 626 626 query32 87 79 77 77 query33 624 380 345 345 query34 819 914 538 538 query35 811 829 743 743 query36 892 908 832 832 query37 113 107 86 86 query38 3908379437783778 query39 1457142914201420 query40 225 129 118 118 query41 67 63 65 63 query42 127 115 113 113 query43 440 442 426 426 query44 1268767 751 751 query45 197 190 186 186 query46 863 986 635 635 query47 1709172616551655 query48 389 414 333 333 query49 764 493 424 424 query50 655 676 428 428 query51 3904395638603860 query52 118 111 105 105 query53 235 263 190 190 query54 327 304 288 288 query55 96 90 90 90 query56 372 332 318 318 query57 1129120610921092 query58 284 283 276 276 query59 2316244323162316 query60 343 355 332 332 query61 169 159 160 159 query62 762 740 671 671 query63 228 200 193 193 query64 44371199913 913 query65 4001393939343934 query66 1117443 327 327 query67 15246 15155 14786 14786 query68 8313946 621 621 query69 536 351 307 307 query70 1128968 1015968 query71 471 339 325 325 query72 5977500650465006 query73 749 632 349 349 query74 8767874085788578 query75 3588303925362536 query76 37451124746 746 query77 797 411 310 310 query78 9378970588668866 query79 2024840 592 592 query80 687 575 492 492 query81 489 267 238 238 query82 450 144 116 116 query83 275 261 259 259 query84 256 123 104 104 query85 928 512 450 450 query86 343 308 280 280 query87 4101407339993999 query88 3908231122892289 query89 400 332 291 291 query90 2000231 226 226 query91 180 173 139 139 query92 85 71 68 68 query93 14201007652 652 query94 735 449 353 353 query95 507 413 434 413 query96 519 555 285 285 query97 2630272726642664 query98 241 214 208 208 query99 1671137412781278 Total cold run time: 272417 ms Total hot run time: 181536 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592143235 TPC-H: Total hot run time: 34233 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit fd6c170ef8f8226a11469c06bf02b3d6585f34b0, data reload: false -- Round 1 -- q1 17646 502949074907 q2 2028315 217 217 q3 10244 1307734 734 q4 10235 979 382 382 q5 7539250222422242 q6 194 178 147 147 q7 950 776 636 636 q8 9361153310781078 q9 7140525153295251 q10 6900221518361836 q11 509 304 280 280 q12 369 362 221 221 q13 17808 366830193019 q14 232 240 211 211 q15 596 537 514 514 q16 885 866 824 824 q17 580 764 507 507 q18 7977704471287044 q19 1083955 588 588 q20 351 344 238 238 q21 3546316824042404 q22 1027975 953 953 Total cold run time: 107200 ms Total hot run time: 34233 ms - Round 2, with runtime_filter_mode=off - q1 4955494748994899 q2 340 408 315 315 q3 2157270123082308 q4 1337174312831283 q5 4233444545474445 q6 217 176 132 132 q7 2024206118531853 q8 2700249224662466 q9 7491742173947394 q10 3125323227712771 q11 580 502 496 496 q12 710 735 588 588 q13 3486389834163416 q14 276 340 277 277 q15 565 525 503 503 q16 889 914 876 876 q17 1146144114161416 q18 8035777876467646 q19 776 733 763 733 q20 1943202218221822 q21 4580423241674167 q22 10691020966 966 Total cold run time: 52634 ms Total hot run time: 50772 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592131412 # FE UT Coverage Report Increment line coverage ` 66.88% (426/637)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_fd6c170ef8f8226a11469c06bf02b3d6585f34b0/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_fd6c170ef8f8226a11469c06bf02b3d6585f34b0/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592125857 # BE UT Coverage Report Increment line coverage `33.27% (170/511)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/fd6c170ef8f8226a11469c06bf02b3d6585f34b0_fd6c170ef8f8226a11469c06bf02b3d6585f34b0/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/fd6c170ef8f8226a11469c06bf02b3d6585f34b0_fd6c170ef8f8226a11469c06bf02b3d6585f34b0/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.84% (18515/35037) | | Line Coverage | 38.44% (169755/441640) | | Region Coverage | 33.22% (131647/396249) | | Branch Coverage | 34.18% (56687/165839) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3592084464 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3591693929 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3588265078 # FE Regression Coverage Report Increment line coverage ` 70.33% (448/637)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_6accee7e16cb0e677a18596597ddb1342f0b06db_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_6accee7e16cb0e677a18596597ddb1342f0b06db_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3588034457 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3587893589 ClickBench: Total hot run time: 27.44 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6accee7e16cb0e677a18596597ddb1342f0b06db, data reload: false query1 0.050.050.05 query2 0.100.050.05 query3 0.250.080.08 query4 1.600.110.11 query5 0.270.280.27 query6 1.190.640.64 query7 0.030.030.03 query8 0.060.040.05 query9 0.580.520.51 query10 0.550.560.55 query11 0.160.120.11 query12 0.140.120.12 query13 0.620.600.60 query14 1.001.000.99 query15 0.850.790.81 query16 0.400.410.38 query17 1.061.081.02 query18 0.240.220.21 query19 1.821.771.77 query20 0.020.020.01 query21 15.47 0.280.14 query22 4.810.050.05 query23 16.03 0.270.11 query24 0.940.460.24 query25 0.100.080.07 query26 0.140.140.14 query27 0.090.070.06 query28 3.661.221.02 query29 12.53 3.983.31 query30 0.290.130.12 query31 2.820.620.40 query32 3.230.540.47 query33 3.003.023.18 query34 17.01 5.184.57 query35 4.574.564.61 query36 0.650.500.48 query37 0.100.060.07 query38 0.070.040.04 query39 0.040.030.03 query40 0.180.150.13 query41 0.080.040.03 query42 0.050.030.03 query43 0.050.030.03 Total cold run time: 96.9 s Total hot run time: 27.44 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3587887112 TPC-DS: Total hot run time: 185822 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6accee7e16cb0e677a18596597ddb1342f0b06db, data reload: false query1 1098436 407 407 query2 6570158715741574 query3 6757231 229 229 query4 25485 23492 22963 22963 query5 4394627 526 526 query6 343 246 219 219 query7 4660527 310 310 query8 315 291 262 262 query9 8715264326332633 query10 511 357 302 302 query11 15288 15219 15033 15033 query12 185 124 123 123 query13 1705582 452 452 query14 10348 894290178942 query15 224 202 186 186 query16 7213714 544 544 query17 1273807 636 636 query18 2065457 361 361 query19 223 218 203 203 query20 136 134 129 129 query21 225 141 123 123 query22 4036392539203920 query23 33158 32171 32203 32171 query24 8637242224772422 query25 649 590 500 500 query26 1263280 173 173 query27 2742502 357 357 query28 4368217721772177 query29 884 660 522 522 query30 312 246 224 224 query31 833 720 623 623 query32 87 83 76 76 query33 630 402 396 396 query34 815 870 543 543 query35 850 848 753 753 query36 900 963 843 843 query37 127 113 88 88 query38 3374339233543354 query39 1472138514041385 query40 227 136 120 120 query41 68 64 67 64 query42 132 111 114 111 query43 452 470 422 422 query44 1336767 759 759 query45 206 192 188 188 query46 880 997 651 651 query47 1669172116191619 query48 392 431 330 330 query49 797 519 430 430 query50 670 680 421 421 query51 3930397438503850 query52 116 114 107 107 query53 248 266 199 199 query54 321 300 283 283 query55 101 95 97 95 query56 321 345 333 333 query57 1143119510961096 query58 292 285 280 280 query59 2341237424182374 query60 373 370 343 343 query61 164 156 156 156 query62 804 717 648 648 query63 234 199 203 199 query64 46221221921 921 query65 4012397239853972 query66 1193440 341 341 query67 15134 15202 14730 14730 query68 83841004635 635 query69 518 355 313 313 query70 1268124811411141 query71 478 338 320 320 query72 5855491247614761 query73 693 568 347 347 query74 8606889787468746 query75 3916333528272827 query76 37261147746 746 query77 835 418 317 317 query78 9520971688308830 query79 2375816 591 591 query80 679 595 514 514 query81 484 274 242 242 query82 443 164 134 134 query83 300 271 251 251 query84 309 124 93 93 query85 931 496 454 454 query86 338 318 256 256 query87 3632348233903390 query88 3822229423042294 query89 388 341 297 297 query90 1948226 226 226 query91 185 189 179 179 query92 88 70 72 70 query93 18711003657 657 query94 722 451 358 358 query95 520 415 424 415 query96 513 557 283 283 query97 2959299528712871 query98 254 220 213 213 query99 1424140513251325 Total cold run time: 273032 ms Total hot run time: 185822 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3587870116 TPC-H: Total hot run time: 34417 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6accee7e16cb0e677a18596597ddb1342f0b06db, data reload: false -- Round 1 -- q1 17644 504648914891 q2 2092319 208 208 q3 10252 1339755 755 q4 10235 942 403 403 q5 7574252622582258 q6 186 172 134 134 q7 951 787 651 651 q8 9359139010271027 q9 6954535252825282 q10 6868227218401840 q11 536 308 294 294 q12 347 379 240 240 q13 17799 367530573057 q14 237 249 213 213 q15 623 539 518 518 q16 10581051963 963 q17 600 794 506 506 q18 7345713771477137 q19 1033959 586 586 q20 344 344 236 236 q21 3665263722822282 q22 10401007936 936 Total cold run time: 106742 ms Total hot run time: 34417 ms - Round 2, with runtime_filter_mode=off - q1 4928494249434942 q2 335 401 319 319 q3 2102267922852285 q4 1298178413061306 q5 4245438446534384 q6 229 182 132 132 q7 2076200118371837 q8 2687251925042504 q9 7629742875377428 q10 3108321628412841 q11 628 520 493 493 q12 675 768 640 640 q13 3574395932663266 q14 282 322 297 297 q15 563 539 535 535 q16 1064119511121112 q17 1234143714421437 q18 7902761975987598 q19 816 848 790 790 q20 2025205519681968 q21 4905441041604160 q22 11071008963 963 Total cold run time: 53412 ms Total hot run time: 51237 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3587748088 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3584234209 ClickBench: Total hot run time: 27.39 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e62d2e4a5a25c9de7466832688b80c245cd400e3, data reload: false query1 0.060.050.05 query2 0.100.040.05 query3 0.260.080.08 query4 1.600.110.11 query5 0.270.250.25 query6 1.190.660.65 query7 0.030.030.03 query8 0.050.040.05 query9 0.580.520.51 query10 0.570.570.56 query11 0.160.100.11 query12 0.150.110.12 query13 0.620.600.60 query14 1.021.011.00 query15 0.840.830.84 query16 0.400.390.39 query17 1.051.021.02 query18 0.210.190.20 query19 1.891.851.77 query20 0.020.010.02 query21 15.44 0.180.13 query22 5.140.070.05 query23 15.66 0.250.10 query24 2.650.570.43 query25 0.080.060.06 query26 0.140.130.14 query27 0.060.060.05 query28 3.901.110.92 query29 12.55 3.893.22 query30 0.290.130.10 query31 2.830.600.39 query32 3.220.560.48 query33 3.023.123.03 query34 15.75 5.194.56 query35 4.544.574.55 query36 0.690.500.50 query37 0.100.070.06 query38 0.070.040.04 query39 0.040.030.03 query40 0.180.140.14 query41 0.100.030.03 query42 0.040.030.02 query43 0.040.040.03 Total cold run time: 97.6 s Total hot run time: 27.39 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3584224715 TPC-DS: Total hot run time: 184373 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e62d2e4a5a25c9de7466832688b80c245cd400e3, data reload: false query1 1064406 402 402 query2 6576157315721572 query3 6754226 223 223 query4 25732 23129 22360 22360 query5 4428616 475 475 query6 331 236 226 226 query7 4655509 302 302 query8 302 275 249 249 query9 8719259425962594 query10 524 352 306 306 query11 15422 14847 14560 14560 query12 188 122 112 112 query13 1695582 440 440 query14 10992 889988438843 query15 220 198 193 193 query16 7534707 542 542 query17 1262774 653 653 query18 2047443 334 334 query19 218 210 191 191 query20 140 121 121 121 query21 224 137 120 120 query22 4064413940264026 query23 33192 32044 32101 32044 query24 8449242023942394 query25 609 556 520 520 query26 806 285 168 168 query27 2718506 352 352 query28 4388216521472147 query29 783 647 521 521 query30 325 234 213 213 query31 862 705 640 640 query32 86 76 75 75 query33 600 405 346 346 query34 789 908 545 545 query35 812 837 753 753 query36 914 948 856 856 query37 122 108 89 89 query38 3365330131813181 query39 1507141213911391 query40 223 132 117 117 query41 65 64 64 64 query42 131 116 111 111 query43 461 458 430 430 query44 1244756 756 756 query45 200 191 178 178 query46 881 991 637 637 query47 1696171816621662 query48 384 426 337 337 query49 743 490 425 425 query50 652 679 404 404 query51 4060405438863886 query52 107 112 105 105 query53 231 260 196 196 query54 317 306 274 274 query55 94 91 95 91 query56 327 319 334 319 query57 1154115710781078 query58 288 279 270 270 query59 2552247523582358 query60 360 363 357 357 query61 159 160 152 152 query62 773 708 664 664 query63 228 191 193 191 query64 36181204888 888 query65 4030393939873939 query66 970 447 337 337 query67 15162 15109 14877 14877 query68 8450939 660 660 query69 515 346 303 303 query70 1323120412231204 query71 490 344 311 311 query72 5854496849414941 query73 688 599 350 350 query74 8535858787178587 query75 3946329828022802 query76 36691138700 700 query77 812 400 322 322 query78 9551976289308930 query79 2005839 582 582 query80 638 583 500 500 query81 500 270 236 236 query82 436 165 131 131 query83 269 267 255 255 query84 258 113 97 97 query85 918 483 448 448 query86 342 306 293 293 query87 3447345435803454 query88 3320231322642264 query89 391 325 303 303 query90 1940233 231 231 query91 166 175 142 142 query92 80 71 67 67 query93 1198976 651 651 query94 730 453 343 343 query95 502 407 405 405 query96 505 580 284 284 query97 2919300229002900 query98 233 216 212 212 query99 1668137612831283 Total cold run time: 270826 ms Total hot run time: 184373 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
doris-robot commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3584204766 TPC-H: Total hot run time: 34382 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e62d2e4a5a25c9de7466832688b80c245cd400e3, data reload: false -- Round 1 -- q1 17629 504348904890 q2 2093320 204 204 q3 10208 1337752 752 q4 10285 876 363 363 q5 8728238623642364 q6 212 170 135 135 q7 934 758 637 637 q8 9360136111711171 q9 7090528852735273 q10 6865221818241824 q11 494 297 281 281 q12 331 366 223 223 q13 17790 366430103010 q14 232 246 214 214 q15 599 515 503 503 q16 10271004959 959 q17 597 870 375 375 q18 7448717771827177 q19 1221958 543 543 q20 354 340 236 236 q21 3796323022822282 q22 10541017966 966 Total cold run time: 108347 ms Total hot run time: 34382 ms - Round 2, with runtime_filter_mode=off - q1 5055492449494924 q2 327 429 314 314 q3 2192268023122312 q4 1345175313021302 q5 4272457645254525 q6 212 171 126 126 q7 2122202318271827 q8 2681261525632563 q9 7627753875477538 q10 3096324428892889 q11 604 513 516 513 q12 842 768 612 612 q13 3450389234463446 q14 304 317 282 282 q15 556 501 515 501 q16 1112114110721072 q17 1205161613781378 q18 7957777375347534 q19 804 862 971 862 q20 2073198118161816 q21 4812433842654265 q22 1058103410041004 Total cold run time: 53706 ms Total hot run time: 51605 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3584143788 # FE UT Coverage Report Increment line coverage ` 66.88% (426/637)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_e62d2e4a5a25c9de7466832688b80c245cd400e3/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_e62d2e4a5a25c9de7466832688b80c245cd400e3/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3584045806 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
feiniaofeiafei commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3583910739 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [feature]enables views, materialized views, generated columns, and alias functions to persist session variables [doris]
hello-stephen commented on PR #58031: URL: https://github.com/apache/doris/pull/58031#issuecomment-3581210845 # FE Regression Coverage Report Increment line coverage ` 78.77% (501/636)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58031_d57be798afe5b0e6e21a1941e1e67e0ed8cfc6d9_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58031_d57be798afe5b0e6e21a1941e1e67e0ed8cfc6d9_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
