Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
yiguolei closed pull request #52780: [fix](be) core dump because of invalid bitmap data URL: https://github.com/apache/doris/pull/52780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
yiguolei merged PR #53088: URL: https://github.com/apache/doris/pull/53088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
hello-stephen commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3122054658 # BE Regression && UT Coverage Report Increment line coverage `100.00% (6/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/53088_a2e46312e91016034b11a8a08c5838433479ebbe_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/53088_a2e46312e91016034b11a8a08c5838433479ebbe_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.10% (22046/27184) | | Line Coverage | 73.68% (227532/308798) | | Region Coverage | 60.98% (188764/309533) | | Branch Coverage | 64.96% (81735/125816) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
hello-stephen commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3122012642 # BE Regression && UT Coverage Report Increment line coverage `100.00% (6/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/53088_a2e46312e91016034b11a8a08c5838433479ebbe_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/53088_a2e46312e91016034b11a8a08c5838433479ebbe_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.10% (22046/27184) | | Line Coverage | 73.68% (227532/308798) | | Region Coverage | 60.98% (188764/309533) | | Branch Coverage | 64.96% (81735/125816) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
doris-robot commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3121929343 # BE UT Coverage Report Increment line coverage `100.00% (6/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/a2e46312e91016034b11a8a08c5838433479ebbe_a2e46312e91016034b11a8a08c5838433479ebbe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/a2e46312e91016034b11a8a08c5838433479ebbe_a2e46312e91016034b11a8a08c5838433479ebbe/report/index.html) | Category | Coverage | |---|| | Function Coverage | 57.56% (15939/27690) | | Line Coverage | 46.35% (143325/309222) | | Region Coverage | 35.78% (107969/301781) | | Branch Coverage | 38.31% (47655/124408) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
doris-robot commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3121754631 ClickBench: Total hot run time: 33.19 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a2e46312e91016034b11a8a08c5838433479ebbe, data reload: false query1 0.040.030.04 query2 0.070.040.04 query3 0.240.060.07 query4 1.620.120.10 query5 0.430.440.45 query6 1.160.700.69 query7 0.030.020.02 query8 0.050.030.04 query9 0.540.490.47 query10 0.540.530.53 query11 0.150.110.10 query12 0.140.100.11 query13 0.650.670.67 query14 0.931.111.20 query15 0.910.910.90 query16 0.390.390.40 query17 1.071.041.03 query18 0.220.210.21 query19 2.041.891.94 query20 0.020.010.02 query21 15.37 0.850.56 query22 0.811.270.72 query23 14.78 1.130.62 query24 6.821.010.51 query25 0.500.240.18 query26 0.540.150.14 query27 0.070.050.05 query28 9.970.880.45 query29 12.59 3.863.36 query30 3.102.973.01 query31 2.810.580.39 query32 3.240.580.50 query33 3.023.223.23 query34 15.84 5.364.93 query35 4.854.894.98 query36 0.700.530.52 query37 0.090.080.07 query38 0.060.050.05 query39 0.030.030.04 query40 0.170.140.14 query41 0.080.030.02 query42 0.030.020.03 query43 0.050.040.03 Total cold run time: 106.76 s Total hot run time: 33.19 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
doris-robot commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3121744005 TPC-DS: Total hot run time: 172573 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a2e46312e91016034b11a8a08c5838433479ebbe, data reload: false query1 985 410 427 410 query2 6508179516771677 query3 6744235 227 227 query4 26877 23678 23538 23538 query5 4291637 546 546 query6 339 243 233 233 query7 4650535 298 298 query8 297 243 247 243 query9 8598300430333004 query10 465 351 299 299 query11 16121 15030 14873 14873 query12 189 137 132 132 query13 1690536 431 431 query14 8693594360005943 query15 210 199 172 172 query16 7114660 476 476 query17 1241746 599 599 query18 2070450 337 337 query19 221 208 198 198 query20 152 141 143 141 query21 216 124 111 111 query22 4070438438513851 query23 34391 34284 34376 34284 query24 8047245424762454 query25 575 506 432 432 query26 1230295 163 163 query27 2697504 369 369 query28 4418228522872285 query29 824 634 494 494 query30 297 235 208 208 query31 890 805 721 721 query32 92 76 79 76 query33 566 431 358 358 query34 844 840 541 541 query35 789 825 761 761 query36 10301048959 959 query37 138 110 96 96 query38 3997409239743974 query39 1437138513761376 query40 237 149 136 136 query41 61 58 55 55 query42 140 126 132 126 query43 532 520 477 477 query44 1405878 877 877 query45 200 188 187 187 query46 966 1054668 668 query47 1841183517531753 query48 402 451 333 333 query49 704 512 435 435 query50 674 684 432 432 query51 5604557955155515 query52 137 135 117 117 query53 266 292 213 213 query54 684 655 561 561 query55 95 92 87 87 query56 370 363 358 358 query57 1214122911461146 query58 346 343 338 338 query59 2651271524762476 query60 408 399 390 390 query61 125 129 124 124 query62 810 745 653 653 query63 251 219 224 219 query64 44111072821 821 query65 4228415141054105 query66 1119466 361 361 query67 query68 17753 1098682 682 query69 1004327 290 290 query70 1443105611001056 query71 722 341 333 333 query72 9172233824182338 query73 3003645 364 364 query74 9072892785048504 query75 7548317626822682 query76 88371216795 795 query77 1153418 351 351 query78 975610228 94739473 query79 14114 578 610 578 query80 1169635 481 481 query81 556 266 239 239 query82 308 149 115 115 query83 350 283 265 265 query84 305 119 91 91 query85 825 391 332 332 query86 347 302 299 299 query87 4265425342434243 query88 4120229322932293 query89 472 386 315 315 query90 2741231 239 231 query91 161 138 109 109 query92 88 74 66 66 query93 46511040656 656 query94 882 388 350 350 query95 412 338 336 336 query96 503 597 294 294 query97 2702273626612661 query98 246 229 231 229 query99 1480134512691269 Total cold run time: 304044 ms Total hot run time: 172573 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
doris-robot commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3121733093 TPC-H: Total hot run time: 34059 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a2e46312e91016034b11a8a08c5838433479ebbe, data reload: false -- Round 1 -- q1 17580 521851655165 q2 1922287 180 180 q3 10385 1354708 708 q4 10231 965 528 528 q5 7792246123522352 q6 182 165 128 128 q7 916 748 620 620 q8 9292134811201120 q9 6822508252075082 q10 6891236519651965 q11 471 277 273 273 q12 354 366 221 221 q13 17801 354631063106 q14 247 253 212 212 q15 546 472 470 470 q16 443 428 384 384 q17 589 859 360 360 q18 7527715971767159 q19 30081008547 547 q20 310 332 212 212 q21 3528300322652265 q22 1108105710021002 Total cold run time: 107945 ms Total hot run time: 34059 ms - Round 2, with runtime_filter_mode=off - q1 5583538554575385 q2 241 316 212 212 q3 2137258822492249 q4 1316170813431343 q5 4381443545114435 q6 221 180 134 134 q7 1876194318401840 q8 2595245924152415 q9 7319720775567207 q10 3226335928932893 q11 551 505 483 483 q12 709 849 632 632 q13 3505383633273327 q14 314 320 282 282 q15 498 456 452 452 q16 450 504 441 441 q17 1182165914011401 q18 7938790277917791 q19 10622 955 1001955 q20 2723203519381938 q21 11189 432442484248 q22 11271053964 964 Total cold run time: 69703 ms Total hot run time: 51027 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
yiguolei commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3121614384 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
github-actions[bot] commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3116195308 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
github-actions[bot] commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3116195273 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
zhangstar333 commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3116193716 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
Thearas commented on PR #53088: URL: https://github.com/apache/doris/pull/53088#issuecomment-3060145943 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
yiguolei commented on code in PR #52780:
URL: https://github.com/apache/doris/pull/52780#discussion_r2196753968
##
be/src/util/bitmap_value.h:
##
@@ -1908,7 +1908,12 @@ class BitmapValue {
case BitmapTypeCode::BITMAP64_V2:
_type = BITMAP;
_is_shared = false;
-_bitmap =
std::make_shared(detail::Roaring64Map::read(src));
+try {
Review Comment:
add no discard to the return value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
hello-stephen commented on PR #52780: URL: https://github.com/apache/doris/pull/52780#issuecomment-3055147351 # BE UT Coverage Report Increment line coverage `50.00% (3/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/b6f0e92873b20134f754d125a26f795161d9a15c_b6f0e92873b20134f754d125a26f795161d9a15c/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/b6f0e92873b20134f754d125a26f795161d9a15c_b6f0e92873b20134f754d125a26f795161d9a15c/report/index.html) | Category | Coverage | |---|| | Function Coverage | 39.07% (10343/26472) | | Line Coverage | 30.03% (85834/285808) | | Region Coverage | 28.73% (44327/154291) | | Branch Coverage | 25.43% (22676/89154) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
zhangstar333 commented on PR #52780: URL: https://github.com/apache/doris/pull/52780#issuecomment-3054889047 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
zhangstar333 commented on PR #52780:
URL: https://github.com/apache/doris/pull/52780#issuecomment-3051154599
the master branch is also need this fix
and u could add some regression test like, it's will return some error
`select bitmap_from_base64("Av8DCg==");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
github-actions[bot] commented on PR #52780: URL: https://github.com/apache/doris/pull/52780#issuecomment-3051152085 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
github-actions[bot] commented on PR #52780: URL: https://github.com/apache/doris/pull/52780#issuecomment-3051152143 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
doris-robot commented on PR #52780: URL: https://github.com/apache/doris/pull/52780#issuecomment-3051037471 # BE UT Coverage Report Increment line coverage `50.00% (3/6)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/b1526c7780a6f1594e7965894da210be3db66f3f_b1526c7780a6f1594e7965894da210be3db66f3f/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/b1526c7780a6f1594e7965894da210be3db66f3f_b1526c7780a6f1594e7965894da210be3db66f3f/report/index.html) | Category | Coverage | |---|| | Function Coverage | 39.07% (10345/26475) | | Line Coverage | 30.04% (85866/285842) | | Region Coverage | 28.73% (44327/154301) | | Branch Coverage | 25.43% (22673/89162) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
yiguolei commented on code in PR #52780:
URL: https://github.com/apache/doris/pull/52780#discussion_r2193902779
##
be/src/util/bitmap_value.h:
##
@@ -1908,7 +1908,12 @@ class BitmapValue {
case BitmapTypeCode::BITMAP64_V2:
_type = BITMAP;
_is_shared = false;
-_bitmap =
std::make_shared(detail::Roaring64Map::read(src));
+try {
Review Comment:
add beut for this case and submit this PR to master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
yiguolei commented on PR #52780: URL: https://github.com/apache/doris/pull/52780#issuecomment-3050944957 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](be) core dump because of invalid bitmap data [doris]
hello-stephen commented on PR #52780: URL: https://github.com/apache/doris/pull/52780#issuecomment-3034931063 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
