Re: [PR] [fix](catalog) fix refresh logic [doris]
morningman merged PR #52989: URL: https://github.com/apache/doris/pull/52989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](catalog) fix refresh logic [doris]
github-actions[bot] commented on PR #52989: URL: https://github.com/apache/doris/pull/52989#issuecomment-3064905085 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](catalog) fix refresh logic [doris]
github-actions[bot] commented on PR #52989: URL: https://github.com/apache/doris/pull/52989#issuecomment-3064905063 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](catalog) fix refresh logic [doris]
doris-robot commented on PR #52989: URL: https://github.com/apache/doris/pull/52989#issuecomment-3060524994 ClickBench: Total hot run time: 30.06 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 58326421b7a91d384f17b4f2bb2aef154e959ee6, data reload: false query1 0.040.030.03 query2 0.080.040.04 query3 0.250.080.08 query4 1.610.100.11 query5 0.440.410.43 query6 1.170.650.66 query7 0.020.020.01 query8 0.050.030.04 query9 0.590.510.52 query10 0.570.580.58 query11 0.160.110.11 query12 0.150.120.12 query13 0.620.610.60 query14 0.790.810.81 query15 0.890.900.87 query16 0.410.390.40 query17 1.071.041.08 query18 0.230.220.21 query19 1.991.811.87 query20 0.010.010.01 query21 15.40 0.910.55 query22 0.761.220.67 query23 14.90 1.410.67 query24 6.731.401.22 query25 0.500.210.15 query26 0.570.180.14 query27 0.070.060.05 query28 9.460.880.44 query29 12.58 4.083.36 query30 0.250.090.07 query31 2.850.580.39 query32 3.230.560.47 query33 3.063.063.17 query34 15.92 5.374.79 query35 4.804.854.82 query36 0.670.520.48 query37 0.090.070.07 query38 0.060.040.04 query39 0.030.030.02 query40 0.180.130.12 query41 0.080.030.02 query42 0.030.030.02 query43 0.040.030.03 Total cold run time: 103.4 s Total hot run time: 30.06 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](catalog) fix refresh logic [doris]
doris-robot commented on PR #52989: URL: https://github.com/apache/doris/pull/52989#issuecomment-3060512669 TPC-DS: Total hot run time: 188190 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 58326421b7a91d384f17b4f2bb2aef154e959ee6, data reload: false query1 1005383 382 382 query2 6512166916791669 query3 6736218 211 211 query4 26265 23711 23864 23711 query5 4328587 429 429 query6 305 197 188 188 query7 4611493 292 292 query8 278 220 209 209 query9 8621261926292619 query10 455 317 276 276 query11 15221 15000 14818 14818 query12 154 107 99 99 query13 1642515 418 418 query14 8627580757405740 query15 206 195 194 194 query16 7121611 487 487 query17 916 706 585 585 query18 1965404 307 307 query19 194 196 159 159 query20 124 113 114 113 query21 219 124 108 108 query22 4176422445224224 query23 34771 34029 33847 33847 query24 8446237824002378 query25 560 480 417 417 query26 1237263 157 157 query27 2768514 343 343 query28 4317213121132113 query29 812 602 455 455 query30 285 218 184 184 query31 917 868 752 752 query32 71 66 64 64 query33 562 382 323 323 query34 800 890 509 509 query35 768 842 725 725 query36 969 986 869 869 query37 112 97 75 75 query38 4119415840504050 query39 1458140314331403 query40 216 114 107 107 query41 54 54 50 50 query42 123 101 108 101 query43 488 499 481 481 query44 1337818 815 815 query45 175 163 159 159 query46 827 1014628 628 query47 1799182217541754 query48 372 413 310 310 query49 772 478 388 388 query50 634 688 414 414 query51 5610555454565456 query52 109 103 95 95 query53 218 250 187 187 query54 568 564 485 485 query55 82 81 79 79 query56 312 292 281 281 query57 1220118910951095 query58 266 250 254 250 query59 2642261825432543 query60 325 326 306 306 query61 128 121 122 121 query62 794 736 681 681 query63 225 190 185 185 query64 43421017692 692 query65 4262419541944194 query66 1127401 305 305 query67 15941 16158 15675 15675 query68 8609884 529 529 query69 484 321 279 279 query70 1244118411611161 query71 499 335 299 299 query72 5432476349054763 query73 745 629 344 344 query74 8952919188058805 query75 3927316927302730 query76 37621134723 723 query77 794 382 289 289 query78 10170 10266 93479347 query79 2682843 576 576 query80 624 516 444 444 query81 482 251 216 216 query82 463 125 96 96 query83 275 243 237 237 query84 287 118 85 85 query85 779 376 325 325 query86 348 325 285 285 query87 4461442443714371 query88 3149223122472231 query89 404 321 278 278 query90 1926198 201 198 query91 151 144 112 112 query92 71 61 53 53 query93 1178973 590 590 query94 680 391 299 299 query95 375 283 289 283 query96 495 574 280 280 query97 2783279527092709 query98 226 200 208 200 query99 1449140513141314 Total cold run time: 275527 ms Total hot run time: 188190 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [fix](catalog) fix refresh logic [doris]
doris-robot commented on PR #52989: URL: https://github.com/apache/doris/pull/52989#issuecomment-3060489428 TPC-H: Total hot run time: 33420 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 58326421b7a91d384f17b4f2bb2aef154e959ee6, data reload: false -- Round 1 -- q1 17554 517450905090 q2 1924287 201 201 q3 10535 1338734 734 q4 10313 1033522 522 q5 9021242424142414 q6 212 158 128 128 q7 929 762 615 615 q8 9338129311101110 q9 7448510051155100 q10 6902237619701970 q11 495 290 276 276 q12 343 359 220 220 q13 17765 362530363036 q14 225 239 212 212 q15 550 486 478 478 q16 432 426 375 375 q17 607 887 379 379 q18 7762729171027102 q19 1257953 541 541 q20 353 363 222 222 q21 4098325623882388 q22 365 314 307 307 Total cold run time: 108428 ms Total hot run time: 33420 ms - Round 2, with runtime_filter_mode=off - q1 5135507550845075 q2 251 326 228 228 q3 2173269723002300 q4 1378178813311331 q5 4236456845794568 q6 217 170 122 122 q7 2030195118251825 q8 2667262325882588 q9 7376721075447210 q10 3051334028782878 q11 565 515 491 491 q12 663 764 615 615 q13 3601401533273327 q14 308 318 285 285 q15 538 478 472 472 q16 488 497 437 437 q17 1172165113611361 q18 8091779876777677 q19 819 797 867 797 q20 2028208319261926 q21 5070457645174517 q22 635 592 552 552 Total cold run time: 52492 ms Total hot run time: 50582 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](catalog) fix refresh logic [doris]
morningman commented on PR #52989: URL: https://github.com/apache/doris/pull/52989#issuecomment-3060412123 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](catalog) fix refresh logic [doris]
Copilot commented on code in PR #52989:
URL: https://github.com/apache/doris/pull/52989#discussion_r2199511391
##
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetadataOps.java:
##
@@ -319,8 +321,14 @@ public void dropTableImpl(ExternalTable dorisTable,
boolean ifExists) throws Ddl
public void afterDropTable(String dbName, String tblName) {
Optional> db = catalog.getDbForReplay(dbName);
if (db.isPresent()) {
-db.get().setUnInitialized(true);
+Optional table = db.get().getTableForReplay(tblName);
+if (table.isPresent()) {
+
Env.getCurrentEnv().getRefreshManager().refreshTableInternal(db.get(),
(ExternalTable) table.get(), 0);
+}
+db.get().setUnInitialized();
}
+LOG.info("after drop table {}.{}.{}, is db exists: {}",
Review Comment:
[nitpick] The log message reads "is db exists" which is grammatically
awkward. Consider rephrasing to something like "db exists: {}" or "does db
exist: {}".
```suggestion
LOG.info("after drop table {}.{}.{}, db exists: {}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
