Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-17 Thread via GitHub 


dataroaring merged PR #44074:
URL: https://github.com/apache/doris/pull/44074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-16 Thread via GitHub 


github-actions[bot] commented on code in PR #44074:
URL: https://github.com/apache/doris/pull/44074#discussion_r1844977782


##
cloud/test/meta_service_test.cpp:
##
@@ -5211,6 +5211,171 @@ TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest) {
 SyncPoint::get_instance()->clear_all_call_backs();
 }
 
+TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {

Review Comment:
   warning: function 'TEST' exceeds recommended size/complexity thresholds 
[readability-function-size]
   ```cpp
   TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {
   ^
   ```
   
   Additional context
   
   **cloud/test/meta_service_test.cpp:5213:** 83 lines including whitespace and 
comments (threshold 80)
   ```cpp
   TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {
   ^
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-16 Thread via GitHub 


hust-hhb commented on PR #44074:
URL: https://github.com/apache/doris/pull/44074#issuecomment-2480558860

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-16 Thread via GitHub 


doris-robot commented on PR #44074:
URL: https://github.com/apache/doris/pull/44074#issuecomment-2480558827

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-13 Thread via GitHub 


gavinchou merged PR #43509:
URL: https://github.com/apache/doris/pull/43509


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-13 Thread via GitHub 


github-actions[bot] commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2473823830

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-13 Thread via GitHub 


hust-hhb commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2472601606

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-12 Thread via GitHub 


github-actions[bot] commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1839589272


##
cloud/test/meta_service_test.cpp:
##
@@ -5211,6 +5211,171 @@ TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest) {
 SyncPoint::get_instance()->clear_all_call_backs();
 }
 
+TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {

Review Comment:
   warning: function 'TEST' exceeds recommended size/complexity thresholds 
[readability-function-size]
   ```cpp
   TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {
   ^
   ```
   
   Additional context
   
   **cloud/test/meta_service_test.cpp:5213:** 83 lines including whitespace and 
comments (threshold 80)
   ```cpp
   TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {
   ^
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-12 Thread via GitHub 


github-actions[bot] commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2470118308

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-11 Thread via GitHub 


hust-hhb commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2469568615

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-11 Thread via GitHub 


gavinchou commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1836510076


##
cloud/src/meta-service/meta_service.cpp:
##
@@ -1923,11 +1930,40 @@ void 
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
 std::unique_ptr it;
 int64_t last_ver = -1;
 int64_t last_seg_id = -1;
+int64_t round = 0;
 do {
-err = txn->get(start_key, end_key, &it);
+if (test) {

Review Comment:
   https://github.com/user-attachments/assets/60f88a81-2929-4d5e-b6f4-029bef4519c8";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-11 Thread via GitHub 


gavinchou commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1836510076


##
cloud/src/meta-service/meta_service.cpp:
##
@@ -1923,11 +1930,40 @@ void 
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
 std::unique_ptr it;
 int64_t last_ver = -1;
 int64_t last_seg_id = -1;
+int64_t round = 0;
 do {
-err = txn->get(start_key, end_key, &it);
+if (test) {

Review Comment:
   ![Uploading image.png…]()
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-10 Thread via GitHub 


github-actions[bot] commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2467389434

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-10 Thread via GitHub 


github-actions[bot] commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2467389389

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-10 Thread via GitHub 


github-actions[bot] commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1835868345


##
cloud/test/meta_service_test.cpp:
##
@@ -5195,6 +5195,171 @@ TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest) {
 SyncPoint::get_instance()->clear_all_call_backs();
 }
 
+TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {

Review Comment:
   warning: function 'TEST' exceeds recommended size/complexity thresholds 
[readability-function-size]
   ```cpp
   TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {
   ^
   ```
   
   Additional context
   
   **cloud/test/meta_service_test.cpp:5197:** 83 lines including whitespace and 
comments (threshold 80)
   ```cpp
   TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {
   ^
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-10 Thread via GitHub 


hust-hhb commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1835868401


##
cloud/src/meta-service/meta_service.cpp:
##
@@ -1923,11 +1925,37 @@ void 
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
 std::unique_ptr it;
 int64_t last_ver = -1;
 int64_t last_seg_id = -1;
+int64_t round = 0;
 do {
-err = txn->get(start_key, end_key, &it);
+#ifdef UNIT_TEST
+err = txn->get(start_key, end_key, &it, true, 2);
+#else
+err = txn->get(start_key, end_key, &it, true);
+#endif
+TEST_SYNC_POINT_CALLBACK("get_delete_bitmap_err", &round, &err);
+while (err == TxnErrorCode::TXN_TOO_OLD &&
+   retry < config::max_get_delete_bitmap_retry_times) {
+LOG(INFO) << "retry get delete bitmap, code=" << 
MetaServiceCode_Name(code)
+  << ", retry=" << retry << ", internal round=" << 
round;
+txn = nullptr;
+err = txn_kv_->create_txn(&txn);
+if (err != TxnErrorCode::TXN_OK) {
+code = cast_as(err);
+ss << "failed to init txn, retry=" << retry << ", internal 
round=" << round;
+msg = ss.str();
+return;
+}
+#ifdef UNIT_TEST
+err = txn->get(start_key, end_key, &it, true, 2);

Review Comment:
   Using snapshot read is a big change, i think it's beeter not change it in 
this pr, we should do enough test before using snapshot read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-10 Thread via GitHub 


hust-hhb commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2467079846

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-08 Thread via GitHub 


zhannngchen commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1834164438


##
cloud/src/meta-service/meta_service.cpp:
##
@@ -1923,11 +1925,37 @@ void 
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
 std::unique_ptr it;
 int64_t last_ver = -1;
 int64_t last_seg_id = -1;
+int64_t round = 0;
 do {
-err = txn->get(start_key, end_key, &it);
+#ifdef UNIT_TEST
+err = txn->get(start_key, end_key, &it, true, 2);
+#else
+err = txn->get(start_key, end_key, &it, true);
+#endif
+TEST_SYNC_POINT_CALLBACK("get_delete_bitmap_err", &round, &err);
+while (err == TxnErrorCode::TXN_TOO_OLD &&
+   retry < config::max_get_delete_bitmap_retry_times) {
+LOG(INFO) << "retry get delete bitmap, code=" << 
MetaServiceCode_Name(code)
+  << ", retry=" << retry << ", internal round=" << 
round;
+txn = nullptr;
+err = txn_kv_->create_txn(&txn);
+if (err != TxnErrorCode::TXN_OK) {
+code = cast_as(err);
+ss << "failed to init txn, retry=" << retry << ", internal 
round=" << round;
+msg = ss.str();
+return;
+}
+#ifdef UNIT_TEST
+err = txn->get(start_key, end_key, &it, true, 2);
+#else
+err = txn->get(start_key, end_key, &it, true);
+#endif
+retry++;

Review Comment:
   print the delete bitmap count and size once you have retry, which means 
there are too many delete bitmaps ,we may need log to debug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-08 Thread via GitHub 


zhannngchen commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1834163153


##
cloud/src/meta-service/meta_service.cpp:
##
@@ -1923,11 +1925,37 @@ void 
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
 std::unique_ptr it;
 int64_t last_ver = -1;
 int64_t last_seg_id = -1;
+int64_t round = 0;
 do {
-err = txn->get(start_key, end_key, &it);
+#ifdef UNIT_TEST
+err = txn->get(start_key, end_key, &it, true, 2);
+#else
+err = txn->get(start_key, end_key, &it, true);
+#endif
+TEST_SYNC_POINT_CALLBACK("get_delete_bitmap_err", &round, &err);
+while (err == TxnErrorCode::TXN_TOO_OLD &&
+   retry < config::max_get_delete_bitmap_retry_times) {
+LOG(INFO) << "retry get delete bitmap, code=" << 
MetaServiceCode_Name(code)
+  << ", retry=" << retry << ", internal round=" << 
round;
+txn = nullptr;
+err = txn_kv_->create_txn(&txn);
+if (err != TxnErrorCode::TXN_OK) {
+code = cast_as(err);
+ss << "failed to init txn, retry=" << retry << ", internal 
round=" << round;
+msg = ss.str();
+return;
+}
+#ifdef UNIT_TEST
+err = txn->get(start_key, end_key, &it, true, 2);

Review Comment:
   make sure all delete bitmap keys are committed before rowset keys, so that 
the snapshot read won't miss data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-08 Thread via GitHub 


zhannngchen commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1834034139


##
cloud/src/common/config.h:
##
@@ -211,6 +211,9 @@ CONF_Validator(s3_client_http_scheme, [](const std::string& 
config) -> bool {
 // Max retry times for object storage request
 CONF_mInt64(max_s3_client_retry, "10");
 
+// Max retry times for get delete bitmap
+CONF_mInt64(max_get_delete_bitmap_retry_times, "120");

Review Comment:
   Do we really need to retry so many times?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-08 Thread via GitHub 


gavinchou commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1833947326


##
cloud/src/common/config.h:
##
@@ -211,6 +211,9 @@ CONF_Validator(s3_client_http_scheme, [](const std::string& 
config) -> bool {
 // Max retry times for object storage request
 CONF_mInt64(max_s3_client_retry, "10");
 
+// Max retry times for get delete bitmap
+CONF_mInt64(max_get_delete_bitmap_retry_times, "120");

Review Comment:
   suggest naming `max_get_delete_bitmap_iterations`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-08 Thread via GitHub 


gavinchou commented on code in PR #43509:
URL: https://github.com/apache/doris/pull/43509#discussion_r1833946075


##
cloud/src/meta-service/meta_service.cpp:
##
@@ -1923,11 +1925,37 @@ void 
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
 std::unique_ptr it;
 int64_t last_ver = -1;
 int64_t last_seg_id = -1;
+int64_t round = 0;
 do {
-err = txn->get(start_key, end_key, &it);
+#ifdef UNIT_TEST

Review Comment:
   use syncpoint instead of MACRO, or change 
config::max_get_delete_bitmap_retry_times before testing
   ```
   int n = 1;
   syncpoint(&n);
   err = txn->get(start_key, end_key, &it, true, n);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-07 Thread via GitHub 


github-actions[bot] commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2463980400

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-07 Thread via GitHub 


hust-hhb commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2463973897

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD [doris]

2024-11-07 Thread via GitHub 


doris-robot commented on PR #43509:
URL: https://github.com/apache/doris/pull/43509#issuecomment-2463973447

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org