Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
zhannngchen merged PR #49889: URL: https://github.com/apache/doris/pull/49889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
hello-stephen commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2823527882 # BE Regression P0 && UT Coverage Report Increment line coverage `0.00% (0/14)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/49889_6be70e0068dd67c31a13b76f8da29209af558d13_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/49889_6be70e0068dd67c31a13b76f8da29209af558d13_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage || | Line Coverage || | Region Coverage || | Branch Coverage || -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
github-actions[bot] commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2823454962 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2823202533 # BE UT Coverage Report Increment line coverage `0.00% (0/14)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6be70e0068dd67c31a13b76f8da29209af558d13_6be70e0068dd67c31a13b76f8da29209af558d13/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6be70e0068dd67c31a13b76f8da29209af558d13_6be70e0068dd67c31a13b76f8da29209af558d13/report/index.html) | Category | Coverage | |---|| | Function Coverage | 53.54% (14536/27150) | | Line Coverage | 42.37% (126011/297419) | | Region Coverage | 41.18% (64401/156378) | | Branch Coverage | 35.76% (32372/90526) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2823022898 ClickBench: Total hot run time: 30 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6be70e0068dd67c31a13b76f8da29209af558d13, data reload: false query1 0.030.040.02 query2 0.130.100.11 query3 0.260.190.19 query4 1.600.190.20 query5 0.600.590.60 query6 1.160.720.71 query7 0.020.020.02 query8 0.040.030.04 query9 0.570.530.52 query10 0.570.590.57 query11 0.150.110.11 query12 0.140.110.11 query13 0.610.600.59 query14 1.191.241.19 query15 0.860.850.85 query16 0.390.390.38 query17 1.021.011.03 query18 0.210.200.20 query19 2.001.781.79 query20 0.020.020.01 query21 15.41 0.880.53 query22 0.751.270.74 query23 14.79 1.370.64 query24 7.211.531.10 query25 0.550.160.09 query26 0.570.160.16 query27 0.060.050.04 query28 10.25 0.850.44 query29 12.52 3.933.30 query30 0.240.080.06 query31 2.830.590.39 query32 3.230.540.46 query33 3.013.073.13 query34 15.77 5.084.49 query35 4.554.564.52 query36 0.660.490.49 query37 0.080.060.06 query38 0.050.040.04 query39 0.040.030.02 query40 0.170.140.13 query41 0.080.030.02 query42 0.030.020.02 query43 0.040.030.02 Total cold run time: 104.46 s Total hot run time: 30 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2823017820 TPC-DS: Total hot run time: 184559 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6be70e0068dd67c31a13b76f8da29209af558d13, data reload: false query1 1019492 495 492 query2 6545176518131765 query3 6751233 216 216 query4 26596 23541 22969 22969 query5 4337609 468 468 query6 324 201 196 196 query7 4617484 285 285 query8 300 249 237 237 query9 8633256325762563 query10 496 330 259 259 query11 15611 15094 14800 14800 query12 161 109 104 104 query13 1635528 391 391 query14 8569607860566056 query15 195 185 172 172 query16 7129661 484 484 query17 962 705 579 579 query18 1974396 310 310 query19 197 189 165 165 query20 125 118 116 116 query21 213 135 105 105 query22 4090415940304030 query23 34011 32983 32992 32983 query24 8401234623232323 query25 517 443 379 379 query26 1258269 149 149 query27 2767490 337 337 query28 4347208320732073 query29 756 543 434 434 query30 328 212 190 190 query31 932 835 784 784 query32 74 62 64 62 query33 551 364 294 294 query34 770 830 506 506 query35 776 830 727 727 query36 937 975 873 873 query37 113 105 97 97 query38 4108410341014101 query39 1428140313951395 query40 208 123 117 117 query41 58 56 55 55 query42 124 100 106 100 query43 486 503 444 444 query44 1346798 792 792 query45 178 171 166 166 query46 839 1017617 617 query47 1752181117191719 query48 382 415 301 301 query49 776 499 409 409 query50 644 684 387 387 query51 4102410139923992 query52 103 100 102 100 query53 225 257 182 182 query54 580 568 496 496 query55 85 76 80 76 query56 316 298 302 298 query57 1123113410661066 query58 263 256 254 254 query59 2541263125432543 query60 326 338 316 316 query61 131 126 121 121 query62 828 759 654 654 query63 224 192 187 187 query64 43501002667 667 query65 4318422642214221 query66 1136409 308 308 query67 15941 15637 15264 15264 query68 7775874 508 508 query69 484 293 260 260 query70 1221115110801080 query71 407 320 297 297 query72 5700468247474682 query73 622 596 342 342 query74 8979902985678567 query75 3287320226512651 query76 32291193755 755 query77 524 377 284 284 query78 9842973092459245 query79 2453802 562 562 query80 631 509 446 446 query81 500 245 219 219 query82 480 127 98 98 query83 254 241 229 229 query84 301 104 95 95 query85 844 419 372 372 query86 376 308 293 293 query87 4295433343524333 query88 3826221922252219 query89 382 312 283 283 query90 1878221 220 220 query91 140 146 112 112 query92 71 59 58 58 query93 2072933 573 573 query94 713 423 313 313 query95 376 293 275 275 query96 492 555 278 278 query97 3078320431083108 query98 247 213 206 206 query99 1313138812751275 Total cold run time: 272730 ms Total hot run time: 184559 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2823006298 TPC-H: Total hot run time: 33763 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6be70e0068dd67c31a13b76f8da29209af558d13, data reload: false -- Round 1 -- q1 26050 514150065006 q2 2075281 179 179 q3 10387 1247694 694 q4 10227 993 533 533 q5 7566228623682286 q6 179 164 133 133 q7 916 746 601 601 q8 9304130211431143 q9 6825507451125074 q10 6792229718821882 q11 485 278 269 269 q12 352 355 213 213 q13 17780 366730633063 q14 219 220 205 205 q15 535 482 484 482 q16 451 450 397 397 q17 594 859 367 367 q18 7881719671377137 q19 1223937 545 545 q20 326 338 208 208 q21 4109265624032403 q22 10821028943 943 Total cold run time: 115358 ms Total hot run time: 33763 ms - Round 2, with runtime_filter_mode=off - q1 5100505450485048 q2 233 323 231 231 q3 2200262823132313 q4 1417179814171417 q5 4520443143874387 q6 214 165 127 127 q7 1970188017641764 q8 2562255724862486 q9 7165714972007149 q10 2941315927952795 q11 587 500 507 500 q12 719 756 607 607 q13 3509390932333233 q14 285 285 270 270 q15 539 466 473 466 q16 454 508 468 468 q17 1178156013631363 q18 7762749373537353 q19 810 803 844 803 q20 1987209418271827 q21 5066476446674667 q22 10381043997 997 Total cold run time: 52256 ms Total hot run time: 50271 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2823005042 TeamCity cloud ut coverage result: Function Coverage: 82.93% (1093/1318) Line Coverage: 65.68% (18267/27813) Region Coverage: 65.07% (9046/13903) Branch Coverage: 55.03% (4870/8850) Coverage Report: http://coverage.selectdb-in.cc/coverage/6be70e0068dd67c31a13b76f8da29209af558d13_6be70e0068dd67c31a13b76f8da29209af558d13_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
hust-hhb commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822985474 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822978732 ClickBench: Total hot run time: 29.15 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 36fe8eb17ad12eacbf549259f25ce82086cf9c19, data reload: false query1 0.040.030.03 query2 0.140.110.12 query3 0.260.190.19 query4 1.600.200.21 query5 0.580.580.59 query6 1.180.720.72 query7 0.020.010.02 query8 0.040.040.04 query9 0.580.540.50 query10 0.570.570.56 query11 0.150.110.11 query12 0.140.120.12 query13 0.620.590.60 query14 1.151.171.19 query15 0.870.850.84 query16 0.370.380.38 query17 1.051.041.03 query18 0.210.190.19 query19 1.831.771.80 query20 0.020.020.01 query21 15.40 0.910.55 query22 0.761.070.64 query23 15.09 1.390.65 query24 8.000.800.38 query25 0.480.210.16 query26 0.600.160.13 query27 0.050.060.05 query28 9.310.880.43 query29 12.59 4.033.35 query30 0.250.100.07 query31 2.810.590.38 query32 3.230.550.46 query33 3.012.993.06 query34 15.84 5.094.47 query35 4.514.514.51 query36 0.670.500.48 query37 0.090.060.06 query38 0.050.040.03 query39 0.030.020.03 query40 0.180.130.12 query41 0.080.030.02 query42 0.030.030.02 query43 0.030.030.03 Total cold run time: 104.51 s Total hot run time: 29.15 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822973894 TPC-DS: Total hot run time: 191919 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 36fe8eb17ad12eacbf549259f25ce82086cf9c19, data reload: false query1 1424106910371037 query2 6343181018051805 query3 10996 469944294429 query4 54291 25911 23418 23418 query5 4997522 443 443 query6 342 196 190 190 query7 4904496 278 278 query8 333 256 236 236 query9 5723258925722572 query10 431 315 250 250 query11 15160 15027 14741 14741 query12 158 110 107 107 query13 1032521 379 379 query14 10184 632263736322 query15 203 206 186 186 query16 7124660 507 507 query17 1113768 599 599 query18 1556415 319 319 query19 217 198 171 171 query20 131 129 124 124 query21 208 122 108 108 query22 4337437442634263 query23 34014 33588 33530 33530 query24 6395242423922392 query25 505 463 417 417 query26 707 281 159 159 query27 2535516 338 338 query28 2896214521232123 query29 603 553 434 434 query30 265 280 191 191 query31 864 873 786 786 query32 72 65 64 64 query33 435 386 309 309 query34 1054855 506 506 query35 789 850 778 778 query36 968 999 900 900 query37 122 102 81 81 query38 4215430842014201 query39 1474144314121412 query40 216 127 106 106 query41 60 85 52 52 query42 119 108 120 108 query43 502 523 473 473 query44 1358837 820 820 query45 182 179 176 176 query46 849 1021637 637 query47 1811188918271827 query48 382 416 311 311 query49 699 512 418 418 query50 655 701 418 418 query51 4260427841674167 query52 107 104 101 101 query53 258 270 196 196 query54 578 566 503 503 query55 86 77 78 77 query56 290 302 317 302 query57 1162117311231123 query58 275 256 267 256 query59 2582275226752675 query60 350 334 309 309 query61 132 128 127 127 query62 750 782 698 698 query63 225 186 186 186 query64 20491026673 673 query65 4451427342514251 query66 827 397 298 298 query67 15796 15312 15186 15186 query68 7450885 514 514 query69 544 296 251 251 query70 1203107310611061 query71 505 304 298 298 query72 5534483448324832 query73 1400607 345 345 query74 9206885886828682 query75 3927318626982698 query76 42401194761 761 query77 627 366 265 265 query78 10163 10098 92089208 query79 2570818 554 554 query80 637 501 434 434 query81 485 249 217 217 query82 446 127 96 96 query83 340 250 240 240 query84 293 111 85 85 query85 843 357 312 312 query86 371 322 304 304 query87 4449438943094309 query88 364122102210 query89 405 331 276 276 query90 1796204 203 203 query91 140 144 116 116 query92 72 64 56 56 query93 1977934 575 575 query94 660 408 300 300 query95 372 292 284 284 query96 489 560 267 267 query97 3185317331223122 query98 233 204 277 204 query99 1426140112611261 Total cold run time: 299760 ms Total hot run time: 191919 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822962365 TPC-H: Total hot run time: 34211 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 36fe8eb17ad12eacbf549259f25ce82086cf9c19, data reload: false -- Round 1 -- q1 26411 506250705062 q2 2061273 190 190 q3 10397 1249705 705 q4 10230 998 553 553 q5 7503238023762376 q6 184 160 136 136 q7 911 731 599 599 q8 9311125310721072 q9 6715507350885073 q10 6816229118981898 q11 469 279 266 266 q12 352 357 213 213 q13 17764 368631673167 q14 228 234 212 212 q15 541 475 480 475 q16 445 456 410 410 q17 630 873 353 353 q18 7691718771757175 q19 1219935 572 572 q20 324 339 231 231 q21 4231341524772477 q22 1025999 996 996 Total cold run time: 115458 ms Total hot run time: 34211 ms - Round 2, with runtime_filter_mode=off - q1 5109511050905090 q2 238 333 227 227 q3 2171271023212321 q4 1425180114361436 q5 4479440144364401 q6 213 167 129 129 q7 2010193317641764 q8 2598262625832583 q9 7239714270897089 q10 3012318827532753 q11 577 498 466 466 q12 701 746 603 603 q13 3534390733693369 q14 283 322 289 289 q15 528 487 462 462 q16 468 504 468 468 q17 1136142614131413 q18 7809756874607460 q19 884 892 1102892 q20 2028197218301830 q21 5226491848264826 q22 1103102810311028 Total cold run time: 52771 ms Total hot run time: 50899 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822949457 TeamCity cloud ut coverage result: Function Coverage: 82.93% (1093/1318) Line Coverage: 65.64% (18258/27814) Region Coverage: 65.04% (9043/13904) Branch Coverage: 55.01% (4868/8850) Coverage Report: http://coverage.selectdb-in.cc/coverage/36fe8eb17ad12eacbf549259f25ce82086cf9c19_36fe8eb17ad12eacbf549259f25ce82086cf9c19_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
github-actions[bot] commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822941422 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
github-actions[bot] commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822941346 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
zhannngchen commented on code in PR #49889:
URL: https://github.com/apache/doris/pull/49889#discussion_r2055172769
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -541,6 +542,9 @@ Status CloudSchemaChangeJob::_process_delete_bitmap(int64_t
alter_version,
}
void CloudSchemaChangeJob::clean_up_on_failed() {
+_cloud_storage_engine.meta_mgr().remove_delete_bitmap_update_lock(
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
hust-hhb commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2822926599 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
mymeiyi commented on code in PR #49889:
URL: https://github.com/apache/doris/pull/49889#discussion_r2055154524
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -541,6 +542,9 @@ Status CloudSchemaChangeJob::_process_delete_bitmap(int64_t
alter_version,
}
void CloudSchemaChangeJob::clean_up_on_failed() {
+_cloud_storage_engine.meta_mgr().remove_delete_bitmap_update_lock(
Review Comment:
call remove_delete_bitmap_update_lock only when this is a mow tablet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
hust-hhb commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2789188300 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2789599037 # BE UT Coverage Report Increment line coverage `0.00% (0/9)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/349c226f587e134759b0873ee1ee955043ed262e_349c226f587e134759b0873ee1ee955043ed262e/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/349c226f587e134759b0873ee1ee955043ed262e_349c226f587e134759b0873ee1ee955043ed262e/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.34% (14070/26881) | | Line Coverage | 41.13% (121545/295517) | | Region Coverage | 39.86% (61845/155152) | | Branch Coverage | 34.52% (30960/89694) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2789328529 ClickBench: Total hot run time: 31.06 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 349c226f587e134759b0873ee1ee955043ed262e, data reload: false query1 0.040.030.04 query2 0.130.110.10 query3 0.240.190.20 query4 1.590.190.19 query5 0.590.560.59 query6 1.210.730.71 query7 0.020.010.02 query8 0.040.030.04 query9 0.600.520.52 query10 0.580.600.57 query11 0.150.110.11 query12 0.140.110.11 query13 0.610.610.59 query14 2.772.712.80 query15 0.920.860.85 query16 0.390.390.39 query17 1.031.091.06 query18 0.210.200.20 query19 1.941.991.75 query20 0.010.010.01 query21 15.38 0.900.55 query22 0.761.090.69 query23 15.02 1.390.60 query24 7.031.960.73 query25 0.480.240.08 query26 0.630.170.15 query27 0.060.050.06 query28 9.780.900.42 query29 12.53 4.023.36 query30 0.240.090.06 query31 2.840.580.37 query32 3.240.550.47 query33 3.053.063.08 query34 15.55 5.084.48 query35 4.514.534.51 query36 0.660.500.49 query37 0.090.070.06 query38 0.060.040.04 query39 0.030.020.02 query40 0.170.120.13 query41 0.090.030.02 query42 0.040.030.02 query43 0.040.030.02 Total cold run time: 105.49 s Total hot run time: 31.06 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2789313095 TPC-DS: Total hot run time: 193360 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 349c226f587e134759b0873ee1ee955043ed262e, data reload: false query1 1411108010431043 query2 6016196519561956 query3 11021 427344034273 query4 53198 25483 23238 23238 query5 5108557 454 454 query6 334 197 189 189 query7 4882500 278 278 query8 306 253 247 247 query9 5510262426062606 query10 468 321 277 277 query11 15112 15164 14883 14883 query12 168 115 106 106 query13 1044525 390 390 query14 10163 635663936356 query15 188 200 182 182 query16 7116701 501 501 query17 1097791 608 608 query18 1565427 324 324 query19 212 204 177 177 query20 136 136 127 127 query21 219 135 111 111 query22 4279438844694388 query23 34171 33350 33399 33350 query24 6875241924282419 query25 458 470 406 406 query26 734 282 162 162 query27 2426508 347 347 query28 3130250424672467 query29 582 579 427 427 query30 274 274 202 202 query31 869 897 820 820 query32 73 63 63 63 query33 463 377 339 339 query34 791 891 523 523 query35 794 837 769 769 query36 954 990 896 896 query37 117 103 73 73 query38 4156426841484148 query39 1521147214451445 query40 215 121 109 109 query41 54 55 51 51 query42 119 101 101 101 query43 505 522 496 496 query44 1343839 820 820 query45 178 180 165 165 query46 845 1036646 646 query47 1876191318571857 query48 407 417 314 314 query49 681 520 454 454 query50 669 693 404 404 query51 4331425542284228 query52 114 110 101 101 query53 228 262 196 196 query54 592 585 516 516 query55 84 86 83 83 query56 309 312 291 291 query57 1151121911661166 query58 283 267 269 267 query59 2857280226822682 query60 349 323 304 304 query61 135 131 125 125 query62 735 752 704 704 query63 226 195 188 188 query64 19531064733 733 query65 4449444743544354 query66 763 407 316 316 query67 16004 15896 15284 15284 query68 7504892 514 514 query69 537 298 261 261 query70 1219113910761076 query71 495 334 296 296 query72 5903474848384748 query73 1447637 344 344 query74 8999913889208920 query75 4010323928092809 query76 42941200762 762 query77 712 365 283 283 query78 10215 10104 92779277 query79 6632808 547 547 query80 649 521 436 436 query81 483 255 217 217 query82 735 134 103 103 query83 325 258 237 237 query84 297 107 84 84 query85 779 351 311 311 query86 358 291 288 288 query87 4388446444434443 query88 3612220021882188 query89 464 319 285 285 query90 1991208 208 208 query91 136 140 107 107 query92 73 57 60 57 query93 3604952 573 573 query94 677 424 298 298 query95 363 298 290 290 query96 477 575 269 269 query97 3172322631233123 query98 236 206 202 202 query99 1410140412791279 Total cold run time: 305592 ms Total hot run time: 193360 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2789264993 TPC-H: Total hot run time: 34364 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 349c226f587e134759b0873ee1ee955043ed262e, data reload: false -- Round 1 -- q1 26061 508749754975 q2 2064273 186 186 q3 10431 1267671 671 q4 10232 990 520 520 q5 7624244823752375 q6 186 164 135 135 q7 929 727 606 606 q8 9317129011191119 q9 6789516651185118 q10 6851232318651865 q11 487 287 281 281 q12 353 354 218 218 q13 17947 386332553255 q14 226 233 217 217 q15 539 500 489 489 q16 643 619 600 600 q17 629 871 386 386 q18 7680729871497149 q19 1702931 540 540 q20 331 350 239 239 q21 4551355524862486 q22 10351026934 934 Total cold run time: 116607 ms Total hot run time: 34364 ms - Round 2, with runtime_filter_mode=off - q1 5172503850275027 q2 237 318 226 226 q3 2151261422412241 q4 1421184914931493 q5 4460447544214421 q6 220 175 131 131 q7 1979190217301730 q8 2567241924712419 q9 7266703770537037 q10 2992318827522752 q11 562 512 485 485 q12 658 768 619 619 q13 3564386433973397 q14 284 307 276 276 q15 535 494 486 486 q16 671 692 633 633 q17 1139155213741374 q18 7711765075327532 q19 833 821 811 811 q20 1909198118151815 q21 5381483049044830 q22 1126106110181018 Total cold run time: 52838 ms Total hot run time: 50753 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2789211542 TeamCity cloud ut coverage result: Function Coverage: 83.07% (1089/1311) Line Coverage: 66.09% (18167/27488) Region Coverage: 65.54% (8951/13657) Branch Coverage: 55.35% (4820/8708) Coverage Report: http://coverage.selectdb-in.cc/coverage/349c226f587e134759b0873ee1ee955043ed262e_349c226f587e134759b0873ee1ee955043ed262e_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
doris-robot commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2787398724 TeamCity cloud ut coverage result: Function Coverage: 83.07% (1089/1311) Line Coverage: 66.08% (18166/27493) Region Coverage: 65.52% (8950/13659) Branch Coverage: 55.33% (4819/8710) Coverage Report: http://coverage.selectdb-in.cc/coverage/886e2b0e5bd9d1ee24d0755a5b39eba38669e611_886e2b0e5bd9d1ee24d0755a5b39eba38669e611_cloud/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
Thearas commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2787355394 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
hust-hhb commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2787377155 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud-mow)Schema change fail should release delete bitmap lock [doris]
hust-hhb commented on PR #49889: URL: https://github.com/apache/doris/pull/49889#issuecomment-2787355753 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
