Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
dataroaring merged PR #45085: URL: https://github.com/apache/doris/pull/45085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
TangSiyang2001 commented on code in PR #45085:
URL: https://github.com/apache/doris/pull/45085#discussion_r1873250125
##
be/src/olap/olap_server.cpp:
##
@@ -1071,7 +1071,8 @@ Status
StorageEngine::_submit_compaction_task(TabletSharedPtr tablet,
if (!tablet->can_do_compaction(tablet->data_dir()->path_hash(),
compaction_type)) {
LOG(INFO) << "Tablet state has been changed, no need to begin
this compaction "
"task, tablet_id="
- << tablet->tablet_id() << "tablet_state=" <<
tablet->tablet_state();
+ << tablet->tablet_id() << ", tablet_state=" <<
tablet->tablet_state();
+_pop_tablet_from_submitted_compaction(tablet, compaction_type);
Review Comment:
Could we use a Defer to call `_pop_tablet_from_submitted_compaction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
doris-robot commented on PR #45085: URL: https://github.com/apache/doris/pull/45085#issuecomment-2522883608 ClickBench: Total hot run time: 32.81 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e3efafc781593bbc1c56193913c2aaf3ae92706d, data reload: false query1 0.030.030.04 query2 0.060.030.03 query3 0.240.070.07 query4 1.630.100.11 query5 0.420.390.42 query6 1.140.660.66 query7 0.020.020.01 query8 0.040.030.03 query9 0.580.510.51 query10 0.560.570.55 query11 0.150.110.11 query12 0.140.120.12 query13 0.610.610.59 query14 2.872.862.71 query15 0.910.830.82 query16 0.410.390.40 query17 1.071.031.06 query18 0.220.210.21 query19 1.941.842.03 query20 0.010.010.02 query21 15.38 0.590.58 query22 2.662.541.88 query23 16.98 0.860.89 query24 3.431.121.40 query25 0.200.250.04 query26 0.590.140.14 query27 0.050.040.04 query28 10.01 1.111.07 query29 12.56 3.243.21 query30 0.250.070.06 query31 2.870.390.38 query32 3.260.470.47 query33 3.103.133.02 query34 17.22 4.444.47 query35 4.544.504.50 query36 0.650.480.50 query37 0.090.060.06 query38 0.040.040.04 query39 0.030.020.03 query40 0.170.140.12 query41 0.080.020.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 107.27 s Total hot run time: 32.81 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
doris-robot commented on PR #45085: URL: https://github.com/apache/doris/pull/45085#issuecomment-2522859723 TPC-DS: Total hot run time: 197283 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e3efafc781593bbc1c56193913c2aaf3ae92706d, data reload: false query1 1501982 987 982 query2 6230211920022002 query3 10998 432944104329 query4 66199 28318 23510 23510 query5 5043460 474 460 query6 400 197 175 175 query7 5493320 292 292 query8 329 226 236 226 query9 8514260225722572 query10 412 250 237 237 query11 16980 15250 16014 15250 query12 166 109 103 103 query13 1449430 423 423 query14 10658 718974357189 query15 215 190 188 188 query16 7056428 460 428 query17 1248552 587 552 query18 1774298 306 298 query19 202 162 185 162 query20 126 115 114 114 query21 206 106 101 101 query22 4838467145204520 query23 35015 34635 34500 34500 query24 5426245724812457 query25 496 377 411 377 query26 672 156 164 156 query27 2009284 292 284 query28 4154250124422442 query29 697 449 437 437 query30 210 156 155 155 query31 988 865 857 857 query32 75 59 64 59 query33 426 303 294 294 query34 937 504 520 504 query35 899 798 793 793 query36 1097983 966 966 query37 125 76 77 76 query38 4490441043854385 query39 1515148114661466 query40 208 97 100 97 query41 45 41 44 41 query42 109 96 99 96 query43 537 507 505 505 query44 1185847 816 816 query45 185 166 169 166 query46 1180707 729 707 query47 2047196219361936 query48 402 320 333 320 query49 710 372 400 372 query50 852 391 380 380 query51 7346721171267126 query52 98 92 89 89 query53 253 175 174 174 query54 502 394 383 383 query55 77 75 79 75 query56 248 233 227 227 query57 1294110511041104 query58 232 214 203 203 query59 3257312731353127 query60 267 246 245 245 query61 112 105 105 105 query62 785 662 652 652 query63 210 182 182 182 query64 1345717 622 622 query65 3281323932153215 query66 713 302 303 302 query67 16322 15772 15707 15707 query68 3793579 559 559 query69 423 255 249 249 query70 1136113011331130 query71 357 240 254 240 query72 6386412439633963 query73 773 354 356 354 query74 10224 895689658956 query75 3399263826892638 query76 1942116810691069 query77 483 327 279 279 query78 10560 950694569456 query79 1478593 605 593 query80 890 423 425 423 query81 506 227 228 227 query82 1261117 118 117 query83 252 144 144 144 query84 279 71 68 68 query85 893 298 290 290 query86 330 298 310 298 query87 4735463645794579 query88 3628217721272127 query89 421 309 302 302 query90 2015182 218 182 query91 134 106 100 100 query92 65 50 49 49 query93 1887546 548 546 query94 775 298 294 294 query95 345 243 243 243 query96 596 271 276 271 query97 2827273627202720 query98 216 190 192 190 query99 1620133213351332 Total cold run time: 317699 ms Total hot run time: 197283 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
doris-robot commented on PR #45085: URL: https://github.com/apache/doris/pull/45085#issuecomment-2522804440 TPC-H: Total hot run time: 39884 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e3efafc781593bbc1c56193913c2aaf3ae92706d, data reload: false -- Round 1 -- q1 17586 744972637263 q2 2054175 171 171 q3 10620 107312071073 q4 10591 792 721 721 q5 7610269326392639 q6 240 148 151 148 q7 982 628 607 607 q8 9242181919131819 q9 6546642363826382 q10 7053229722872287 q11 467 257 261 257 q12 438 224 220 220 q13 17804 304530323032 q14 240 217 208 208 q15 579 531 530 530 q16 669 582 587 582 q17 957 591 532 532 q18 7278682367666766 q19 1337921 880 880 q20 456 179 179 179 q21 3984333232743274 q22 380 314 315 314 Total cold run time: 107113 ms Total hot run time: 39884 ms - Round 2, with runtime_filter_mode=off - q1 7258727772237223 q2 325 233 229 229 q3 2920281429162814 q4 2071183818031803 q5 5676563955775577 q6 229 141 137 137 q7 2302181918101810 q8 3374355734793479 q9 8922897889968978 q10 3611357335543554 q11 599 509 502 502 q12 827 623 630 623 q13 12437 320932573209 q14 306 280 268 268 q15 571 531 517 517 q16 681 643 632 632 q17 1852160015851585 q18 8152776076337633 q19 1644160215021502 q20 2108190818581858 q21 5529565254845484 q22 641 596 569 569 Total cold run time: 72035 ms Total hot run time: 59986 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
doris-robot commented on PR #45085: URL: https://github.com/apache/doris/pull/45085#issuecomment-2522779086 TeamCity be ut coverage result: Function Coverage: 38.48% (10007/26004) Line Coverage: 29.50% (83881/284374) Region Coverage: 28.60% (43118/150737) Branch Coverage: 25.20% (21919/86974) Coverage Report: http://coverage.selectdb-in.cc/coverage/e3efafc781593bbc1c56193913c2aaf3ae92706d_e3efafc781593bbc1c56193913c2aaf3ae92706d/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
github-actions[bot] commented on PR #45085: URL: https://github.com/apache/doris/pull/45085#issuecomment-2522730614 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) tablet is not removed in compaction queue if dropped [doris]
github-actions[bot] commented on PR #45085: URL: https://github.com/apache/doris/pull/45085#issuecomment-2522730670 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
