Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
github-actions[bot] commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3388177730 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
github-actions[bot] commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3388177678 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
hello-stephen commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3091514529 # FE UT Coverage Report Increment line coverage ` 54.55% (12/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51619_171e8ef969821868e92f171e4c407f4bc4b09556/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51619_171e8ef969821868e92f171e4c407f4bc4b09556/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
doris-robot commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3091502152 ClickBench: Total hot run time: 33.69 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 171e8ef969821868e92f171e4c407f4bc4b09556, data reload: false query1 0.040.040.04 query2 0.110.060.05 query3 0.290.060.07 query4 1.610.090.09 query5 0.430.410.41 query6 1.160.660.66 query7 0.020.020.01 query8 0.060.060.05 query9 0.640.520.52 query10 0.580.600.59 query11 0.250.140.13 query12 0.260.140.15 query13 0.650.640.63 query14 0.810.840.83 query15 0.990.930.89 query16 0.390.390.39 query17 1.061.081.04 query18 0.240.220.23 query19 2.061.851.94 query20 0.020.020.02 query21 15.40 0.970.68 query22 0.921.080.82 query23 14.72 1.570.78 query24 5.580.540.28 query25 0.170.090.09 query26 0.570.230.18 query27 0.100.090.09 query28 11.00 1.230.59 query29 12.58 4.073.42 query30 3.233.123.13 query31 2.820.630.43 query32 3.260.610.51 query33 3.253.263.13 query34 16.75 5.494.84 query35 4.814.854.90 query36 0.660.520.52 query37 0.200.190.18 query38 0.190.170.17 query39 0.060.050.05 query40 0.210.190.17 query41 0.120.060.07 query42 0.070.060.06 query43 0.060.060.05 Total cold run time: 108.4 s Total hot run time: 33.69 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
doris-robot commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3091496623 TPC-DS: Total hot run time: 189659 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 171e8ef969821868e92f171e4c407f4bc4b09556, data reload: false query1 1044402 403 402 query2 6546184417941794 query3 6756229 228 228 query4 26230 23664 22912 22912 query5 664 519 519 query6 302 223 213 213 query7 4628500 294 294 query8 359 346 324 324 query9 8663264426942644 query10 528 362 307 307 query11 15847 15101 14952 14952 query12 177 128 129 128 query13 1699554 449 449 query14 8804593359875933 query15 230 203 192 192 query16 7699665 531 531 query17 1216731 589 589 query18 2046459 329 329 query19 196 196 179 179 query20 186 135 127 127 query21 230 149 127 127 query22 4208433141454145 query23 34038 33296 33344 33296 query24 8466236923962369 query25 521 500 422 422 query26 731 282 161 161 query27 2681513 350 350 query28 4332219021502150 query29 653 584 449 449 query30 311 239 205 205 query31 971 906 781 781 query32 91 78 72 72 query33 594 386 349 349 query34 804 849 537 537 query35 833 847 762 762 query36 10121039945 945 query37 125 108 85 85 query38 4272414140394039 query39 1527146814521452 query40 236 141 126 126 query41 106 106 102 102 query42 126 118 117 117 query43 531 516 472 472 query44 1314835 840 835 query45 191 182 179 179 query46 844 1032674 674 query47 1829187818271827 query48 405 442 325 325 query49 771 565 475 475 query50 650 722 427 427 query51 5463555654535453 query52 126 123 112 112 query53 245 277 207 207 query54 608 597 528 528 query55 94 87 89 87 query56 337 343 326 326 query57 1237124111861186 query58 313 296 294 294 query59 2661273525972597 query60 366 359 333 333 query61 157 149 150 149 query62 803 742 679 679 query63 245 212 240 212 query64 31961070706 706 query65 4262421042204210 query66 1091584 507 507 query67 15824 15723 15760 15723 query68 7918914 549 549 query69 508 327 287 287 query70 1261118511381138 query71 518 347 334 334 query72 5780492350494923 query73 741 710 366 366 query74 8934933886928692 query75 3882323827782778 query76 36441154727 727 query77 854 443 384 384 query78 10168 10272 93379337 query79 2212847 603 603 query80 677 684 515 515 query81 514 288 250 250 query82 468 137 108 108 query83 287 292 269 269 query84 258 110 95 95 query85 860 404 353 353 query86 402 316 286 286 query87 4498446143554355 query88 3707236723232323 query89 406 337 308 308 query90 1869230 224 224 query91 206 155 128 128 query92 84 76 70 70 query93 1643956 603 603 query94 696 431 289 289 query95 401 321 305 305 query96 491 577 286 286 query97 2721283126822682 query98 245 221 220 220 query99 1489142712621262 Total cold run time: 276373 ms Total hot run time: 189659 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
doris-robot commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3091476448 TPC-H: Total hot run time: 34218 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 171e8ef969821868e92f171e4c407f4bc4b09556, data reload: false -- Round 1 -- q1 17678 521751225122 q2 1938296 199 199 q3 10589 1311707 707 q4 10322 1008515 515 q5 9237236723472347 q6 205 168 139 139 q7 932 785 645 645 q8 9360131411181118 q9 6898515151605151 q10 6944238019741974 q11 506 313 292 292 q12 363 372 235 235 q13 17779 369230343034 q14 238 239 217 217 q15 571 515 514 514 q16 435 428 387 387 q17 588 867 370 370 q18 7488726171267126 q19 1147959 579 579 q20 363 364 242 242 q21 3655315522972297 q22 1095104510081008 Total cold run time: 108331 ms Total hot run time: 34218 ms - Round 2, with runtime_filter_mode=off - q1 5178509751695097 q2 252 329 228 228 q3 2203265422412241 q4 1295176713341334 q5 4446447844144414 q6 216 175 136 136 q7 2025195817781778 q8 2651249725522497 q9 7218735173297329 q10 3134329028192819 q11 589 527 508 508 q12 695 788 640 640 q13 3701396333893389 q14 316 306 278 278 q15 569 507 511 507 q16 452 514 429 429 q17 1174161113941394 q18 7792803077337733 q19 786 876 936 876 q20 2021208020302030 q21 5101455843044304 q22 1088106910001000 Total cold run time: 52902 ms Total hot run time: 50961 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
dataroaring commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3091454651 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
BiteThet commented on code in PR #51619:
URL: https://github.com/apache/doris/pull/51619#discussion_r2217118969
##
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##
@@ -919,6 +928,57 @@ public static boolean parsePattern(String pattern) {
return true;
}
+public static FunctionCallExpr createMergeAggCall(
+FunctionCallExpr agg, List intermediateParams, List
realParams) {
Review Comment:
where does 'createMergeAggCall' be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
dataroaring commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-3091445645 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
doris-robot commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2964872258 ClickBench: Total hot run time: 29.94 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit d7bff8b41ec070bf370ed053caf767856976e772, data reload: false query1 0.030.030.03 query2 0.150.110.11 query3 0.340.200.20 query4 1.600.200.20 query5 0.480.450.47 query6 1.170.660.67 query7 0.020.020.02 query8 0.060.050.05 query9 0.610.520.52 query10 0.560.580.58 query11 0.260.120.12 query12 0.250.130.15 query13 0.640.630.63 query14 0.800.840.82 query15 0.970.870.89 query16 0.380.360.38 query17 1.071.061.07 query18 0.170.180.18 query19 1.931.861.84 query20 0.020.020.01 query21 15.39 0.990.68 query22 0.951.020.84 query23 14.71 1.510.77 query24 4.840.630.32 query25 0.170.090.08 query26 0.540.210.19 query27 0.080.090.09 query28 11.01 1.220.58 query29 12.54 4.053.37 query30 0.280.100.06 query31 2.830.620.45 query32 3.240.600.51 query33 3.063.163.14 query34 16.41 5.134.42 query35 4.484.444.50 query36 0.620.500.50 query37 0.210.170.16 query38 0.170.160.16 query39 0.050.050.04 query40 0.180.170.15 query41 0.110.050.05 query42 0.060.050.05 query43 0.060.050.05 Total cold run time: 103.5 s Total hot run time: 29.94 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
doris-robot commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2964854601 TPC-DS: Total hot run time: 194190 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d7bff8b41ec070bf370ed053caf767856976e772, data reload: false query1 1441110610691069 query2 6331179917741774 query3 11017 442243384338 query4 54678 25391 23165 23165 query5 5105547 467 467 query6 362 231 228 228 query7 4906521 311 311 query8 327 273 256 256 query9 5535268126892681 query10 470 345 278 278 query11 15050 15074 14888 14888 query12 169 113 111 111 query13 1061544 418 418 query14 10228 646864526452 query15 212 218 187 187 query16 7099692 536 536 query17 1116796 633 633 query18 1640461 355 355 query19 235 222 185 185 query20 133 131 126 126 query21 224 134 117 117 query22 4605446342894289 query23 34548 33719 33983 33719 query24 6622244725112447 query25 537 507 458 458 query26 722 286 156 156 query27 2286523 351 351 query28 2965217121642164 query29 645 620 476 476 query30 302 230 194 194 query31 862 865 768 768 query32 73 65 64 64 query33 484 395 333 333 query34 792 868 563 563 query35 823 850 747 747 query36 961 978 906 906 query37 118 101 82 82 query38 4223429641774177 query39 1542145014851450 query40 217 128 119 119 query41 83 77 75 75 query42 135 122 114 114 query43 510 501 509 501 query44 1364855 832 832 query45 185 185 176 176 query46 865 1027649 649 query47 1854186318061806 query48 413 449 339 339 query49 679 509 466 466 query50 659 692 428 428 query51 4259425542874255 query52 114 112 100 100 query53 229 269 193 193 query54 602 608 529 529 query55 86 85 90 85 query56 342 333 324 324 query57 1220124411861186 query58 286 276 281 276 query59 2612276426472647 query60 344 341 337 337 query61 159 174 159 159 query62 736 760 678 678 query63 237 198 201 198 query64 20261169904 904 query65 4221419641894189 query66 766 436 336 336 query67 16048 15780 15544 15544 query68 7170898 520 520 query69 548 305 283 283 query70 1149108710931087 query71 496 341 311 311 query72 5701493948844884 query73 1421571 349 349 query74 9031919088458845 query75 3900324227572757 query76 42691220745 745 query77 662 380 306 306 query78 10063 10050 94099409 query79 4785775 565 565 query80 668 541 491 491 query81 491 266 226 226 query82 612 131 97 97 query83 344 260 241 241 query84 301 111 88 88 query85 942 440 404 404 query86 343 301 283 283 query87 4449443443704370 query88 2927229922972297 query89 447 326 293 293 query90 1963211 207 207 query91 164 154 129 129 query92 75 64 63 63 query93 2415916 568 568 query94 703 439 321 321 query95 393 303 374 303 query96 500 577 273 273 query97 2748285326362636 query98 228 212 205 205 query99 1442141312701270 Total cold run time: 303050 ms Total hot run time: 194190 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
doris-robot commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2964835903 TPC-H: Total hot run time: 33784 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d7bff8b41ec070bf370ed053caf767856976e772, data reload: false -- Round 1 -- q1 26073 507449884988 q2 1928275 189 189 q3 10421 1266680 680 q4 10222 999 523 523 q5 7756240722982298 q6 188 161 135 135 q7 909 742 603 603 q8 9304129310921092 q9 6825509052105090 q10 6852234019331933 q11 508 285 279 279 q12 344 357 211 211 q13 17787 370230763076 q14 235 246 217 217 q15 562 490 488 488 q16 425 438 378 378 q17 599 856 368 368 q18 7811711471717114 q19 1537976 570 570 q20 327 334 223 223 q21 3763266423802380 q22 10361041949 949 Total cold run time: 115412 ms Total hot run time: 33784 ms - Round 2, with runtime_filter_mode=off - q1 5237504150885041 q2 243 324 222 222 q3 2179263323132313 q4 1356176413411341 q5 4462437644614376 q6 210 171 130 130 q7 2036195017741774 q8 2648256125832561 q9 7218729370147014 q10 3037319927552755 q11 572 520 492 492 q12 687 767 612 612 q13 3645385733253325 q14 299 288 281 281 q15 523 474 499 474 q16 463 518 452 452 q17 1132155513861386 q18 7791763174027402 q19 808 774 970 774 q20 1956205819451945 q21 4839445444934454 q22 1123106710071007 Total cold run time: 52464 ms Total hot run time: 50131 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
hello-stephen commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2961808524 # FE UT Coverage Report Increment line coverage ` 54.55% (12/22)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51619_d7bff8b41ec070bf370ed053caf767856976e772/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51619_d7bff8b41ec070bf370ed053caf767856976e772/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
Copilot commented on code in PR #51619:
URL: https://github.com/apache/doris/pull/51619#discussion_r2139448761
##
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##
@@ -2338,6 +2347,44 @@ public static FunctionCallExpr createMergeAggCall(
return result;
}
+public static class FunctionCallExprSerializer
+implements JsonSerializer,
JsonDeserializer {
+@Override
+public JsonElement serialize(FunctionCallExpr value,
java.lang.reflect.Type reflectType,
+ JsonSerializationContext context) {
+JsonObject jsonObject = new JsonObject();
+jsonObject.add("clazz",
context.serialize(value.getClass().getSimpleName()));
+jsonObject.add("iafc", context.serialize(value.isAnalyticFnCall));
+jsonObject.add("itfc", context.serialize(value.isTableFnCall));
Review Comment:
The serializer writes a "clazz" field using `getSimpleName()`, but the
deserializer never reads this property. Either remove this redundant field or
update `deserialize()` to validate or use it, ensuring symmetry between
serialization and deserialization.
```suggestion
jsonObject.add("iafc",
context.serialize(value.isAnalyticFnCall));
jsonObject.add("itfc", context.serialize(value.isTableFnCall));
jsonObject.add("itfc", context.serialize(value.isTableFnCall));
```
##
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##
@@ -2338,6 +2347,44 @@ public static FunctionCallExpr createMergeAggCall(
return result;
}
+public static class FunctionCallExprSerializer
+implements JsonSerializer,
JsonDeserializer {
+@Override
+public JsonElement serialize(FunctionCallExpr value,
java.lang.reflect.Type reflectType,
+ JsonSerializationContext context) {
+JsonObject jsonObject = new JsonObject();
+jsonObject.add("clazz",
context.serialize(value.getClass().getSimpleName()));
+jsonObject.add("iafc", context.serialize(value.isAnalyticFnCall));
+jsonObject.add("itfc", context.serialize(value.isTableFnCall));
+jsonObject.add("fnn", context.serialize(value.fnName));
+jsonObject.add("fnp", context.serialize(value.fnParams));
+return jsonObject;
+}
+
+@Override
+public FunctionCallExpr deserialize(JsonElement json,
java.lang.reflect.Type typeOfT,
+JsonDeserializationContext
context) throws JsonParseException {
+JsonObject jsonObject = json.getAsJsonObject();
+FunctionName fnName = context.deserialize(jsonObject.get("fnn"),
FunctionName.class);
+FunctionParams fnParams =
context.deserialize(jsonObject.get("fnp"), FunctionParams.class);
+boolean isAnalyticFnCall = jsonObject.get("iafc").getAsBoolean();
+boolean isTableFnCall = jsonObject.get("itfc").getAsBoolean();
+FunctionCallExpr expr = new FunctionCallExpr(fnName, fnParams);
+expr.setIsAnalyticFnCall(isAnalyticFnCall);
+expr.setTableFnCall(isTableFnCall);
Review Comment:
After deserializing `FunctionCallExpr`, `gsonPostProcess()` is not invoked,
so children from `fnParams.exprs()` won't be populated. Call
`expr.gsonPostProcess()` before returning to ensure the post-processing logic
runs.
```suggestion
expr.setTableFnCall(isTableFnCall);
expr.gsonPostProcess(); // Ensure post-processing logic runs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
dataroaring commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2961591466 This pull request introduces several key updates, including adding a new meta version, enhancing serialization and deserialization of the `FunctionCallExpr` class, and expanding a regression test for alias functions. Below are the most important changes grouped by theme: ### Meta Version Update: * Added `VERSION_141` to `FeMetaVersion` and updated `VERSION_CURRENT` to reflect the new version. (`fe/fe-common/src/main/java/org/apache/doris/common/FeMetaVersion.java`) ### Serialization Enhancements: * Implemented a custom serializer and deserializer (`FunctionCallExprSerializer`) for the `FunctionCallExpr` class, enabling Gson-based serialization and deserialization. (`fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java`) * Registered the `FunctionCallExprSerializer` in `GsonUtils` to handle `FunctionCallExpr` objects during serialization. (`fe/fe-core/src/main/java/org/apache/doris/persist/gson/GsonUtils.java`) ### Codebase Improvements: * Updated the `FunctionCallExpr` class to implement the `GsonPostProcessable` interface, adding a `gsonPostProcess` method for post-deserialization logic. (`fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java`) [[1]](diffhunk://#diff-1b13fe18507780e1e19df79df1322a0308794b9794790eb9af996ab95a9bccacL78-R86) [[2]](diffhunk://#diff-1b13fe18507780e1e19df79df1322a0308794b9794790eb9af996ab95a9bccacR267) ### Regression Test Expansion: * Extended the `test_alias_function` regression test to include a more complex alias function definition using nested `IF` statements for different ranges of `level_score`. (`regression-test/suites/ddl_p0/test_alias_function.groovy`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
dataroaring commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2961502733 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
dataroaring commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2961030873 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
hello-stephen commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2959767383 # FE UT Coverage Report Increment line coverage ` 60.00% (9/15)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/51619_d7b746b68132ae6b30f1736c075f3ff1543833fb/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/51619_d7b746b68132ae6b30f1736c075f3ff1543833fb/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
doris-robot commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2959515813 TPC-H: Total hot run time: 33657 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d7b746b68132ae6b30f1736c075f3ff1543833fb, data reload: false -- Round 1 -- q1 25978 507949844984 q2 1942274 172 172 q3 10645 1227692 692 q4 10263 1010517 517 q5 8769238223342334 q6 184 165 134 134 q7 913 758 623 623 q8 9330130411181118 q9 6787511951395119 q10 6862231219161916 q11 494 289 272 272 q12 337 337 218 218 q13 17774 367630673067 q14 231 230 212 212 q15 555 479 493 479 q16 442 420 365 365 q17 582 857 352 352 q18 7585718970447044 q19 1635957 558 558 q20 321 327 215 215 q21 3827250223082308 q22 10391021958 958 Total cold run time: 116495 ms Total hot run time: 33657 ms - Round 2, with runtime_filter_mode=off - q1 5136500650085006 q2 227 313 215 215 q3 2159266122482248 q4 1308173913451345 q5 4457435744354357 q6 215 173 128 128 q7 1989190617481748 q8 2601253425192519 q9 7192722269436943 q10 3038319827512751 q11 581 516 485 485 q12 674 764 645 645 q13 3455395737763776 q14 284 303 277 277 q15 537 472 475 472 q16 440 484 445 445 q17 1144153613991399 q18 7667750274197419 q19 764 800 831 800 q20 2040200018131813 q21 4778446845224468 q22 1117109310081008 Total cold run time: 51803 ms Total hot run time: 50267 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
dataroaring commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2959380100 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
dataroaring commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2959289736 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](expr) avoid explode serialize in gson [doris]
hello-stephen commented on PR #51619: URL: https://github.com/apache/doris/pull/51619#issuecomment-2959289055 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
