Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
morningman merged PR #44311: URL: https://github.com/apache/doris/pull/44311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
github-actions[bot] commented on PR #44311: URL: https://github.com/apache/doris/pull/44311#issuecomment-2490252127 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
github-actions[bot] commented on PR #44311: URL: https://github.com/apache/doris/pull/44311#issuecomment-2490252078 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
doris-robot commented on PR #44311: URL: https://github.com/apache/doris/pull/44311#issuecomment-2487368121 ClickBench: Total hot run time: 32.15 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 2cbc1124bb708318ba8a5714386ab7fe143f481f, data reload: false query1 0.030.030.03 query2 0.070.030.03 query3 0.250.070.07 query4 1.620.100.10 query5 0.410.430.40 query6 1.190.650.66 query7 0.020.010.02 query8 0.040.040.03 query9 0.600.490.51 query10 0.570.540.56 query11 0.150.110.12 query12 0.140.110.11 query13 0.610.600.61 query14 2.842.862.86 query15 0.900.840.83 query16 0.390.400.38 query17 1.040.991.02 query18 0.200.210.21 query19 1.981.861.99 query20 0.010.020.01 query21 15.37 0.590.58 query22 2.592.471.80 query23 17.02 1.070.69 query24 2.840.591.63 query25 0.150.260.05 query26 0.490.140.14 query27 0.050.050.03 query28 10.70 1.101.08 query29 12.55 3.273.22 query30 0.260.060.06 query31 2.850.370.38 query32 3.270.460.49 query33 3.022.973.05 query34 17.13 4.504.49 query35 4.584.574.52 query36 0.660.500.47 query37 0.090.070.06 query38 0.050.040.04 query39 0.040.020.03 query40 0.160.130.13 query41 0.080.040.02 query42 0.040.030.02 query43 0.030.040.03 Total cold run time: 107.08 s Total hot run time: 32.15 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
doris-robot commented on PR #44311: URL: https://github.com/apache/doris/pull/44311#issuecomment-2487275932 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
doris-robot commented on PR #44311: URL: https://github.com/apache/doris/pull/44311#issuecomment-2487362936 TPC-H: Total hot run time: 45171 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2cbc1124bb708318ba8a5714386ab7fe143f481f, data reload: false -- Round 1 -- q1 17566 749473217321 q2 2259116611791166 q3 9962116211611161 q4 10234 769 700 700 q5 7606273327352733 q6 238 151 146 146 q7 980 643 604 604 q8 9348235823682358 q9 6596641364636413 q10 7069228723252287 q11 489 265 252 252 q12 459 221 219 219 q13 1 303630823036 q14 241 209 213 209 q15 588 521 519 519 q16 653 591 582 582 q17 994 570 508 508 q18 7197678266546654 q19 13391027983 983 q20 2907270326602660 q21 3930343133143314 q22 1399135513461346 Total cold run time: 109831 ms Total hot run time: 45171 ms - Round 2, with runtime_filter_mode=off - q1 7342729974217299 q2 333 231 241 231 q3 3063303329772977 q4 2082181117881788 q5 5608566457295664 q6 219 143 138 138 q7 2194179818801798 q8 3314353235183518 q9 8930888088898880 q10 3613360735863586 q11 591 515 520 515 q12 831 632 635 632 q13 10045 328232783278 q14 300 284 270 270 q15 570 533 503 503 q16 684 657 650 650 q17 1883164016171617 q18 8329765477947654 q19 1696155614981498 q20 2091189619641896 q21 5678542954145414 q22 674 566 551 551 Total cold run time: 70070 ms Total hot run time: 60357 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
github-actions[bot] commented on PR #44311: URL: https://github.com/apache/doris/pull/44311#issuecomment-2487280078 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
hubgeter commented on PR #44311: URL: https://github.com/apache/doris/pull/44311#issuecomment-2487277243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
morningman merged PR #44218: URL: https://github.com/apache/doris/pull/44218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
morningman commented on code in PR #44218:
URL: https://github.com/apache/doris/pull/44218#discussion_r1847580206
##
be/src/util/jvm_metrics.cpp:
##
@@ -485,7 +485,7 @@ Status JvmStats::refresh(JvmMetrics* jvm_metrics) const {
jvm_metrics->jvm_thread_count->set_value(threadCount < 0 ? 0 :
threadCount);
for (int i = 0; i < threadCount; i++) {
-JNI_CALL_METHOD_CHECK_EXCEPTION(jobject, threadInfo, env,
Review Comment:
will pick to all branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
cambyzju commented on code in PR #44218:
URL: https://github.com/apache/doris/pull/44218#discussion_r1847567876
##
be/src/util/jvm_metrics.cpp:
##
@@ -485,7 +485,7 @@ Status JvmStats::refresh(JvmMetrics* jvm_metrics) const {
jvm_metrics->jvm_thread_count->set_value(threadCount < 0 ? 0 :
threadCount);
for (int i = 0; i < threadCount; i++) {
-JNI_CALL_METHOD_CHECK_EXCEPTION(jobject, threadInfo, env,
Review Comment:
Why only 3.0 have this problem? It seems line 488 is the same in branch
master & 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
github-actions[bot] commented on PR #44218: URL: https://github.com/apache/doris/pull/44218#issuecomment-2484572716 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
hubgeter commented on PR #44218: URL: https://github.com/apache/doris/pull/44218#issuecomment-2484566644 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
cambyzju commented on code in PR #44218:
URL: https://github.com/apache/doris/pull/44218#discussion_r1847522826
##
be/src/util/jvm_metrics.cpp:
##
@@ -485,7 +485,7 @@ Status JvmStats::refresh(JvmMetrics* jvm_metrics) const {
jvm_metrics->jvm_thread_count->set_value(threadCount < 0 ? 0 :
threadCount);
for (int i = 0; i < threadCount; i++) {
-JNI_CALL_METHOD_CHECK_EXCEPTION(jobject, threadInfo, env,
Review Comment:
Why not fix branch master at first, then auto pick to 3.0 and 2.1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
hubgeter commented on code in PR #44218:
URL: https://github.com/apache/doris/pull/44218#discussion_r1847536244
##
be/src/util/jvm_metrics.cpp:
##
@@ -485,7 +485,7 @@ Status JvmStats::refresh(JvmMetrics* jvm_metrics) const {
jvm_metrics->jvm_thread_count->set_value(threadCount < 0 ? 0 :
threadCount);
for (int i = 0; i < threadCount; i++) {
-JNI_CALL_METHOD_CHECK_EXCEPTION(jobject, threadInfo, env,
Review Comment:
for version 3.0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
github-actions[bot] commented on PR #44218: URL: https://github.com/apache/doris/pull/44218#issuecomment-2483482282 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
hubgeter commented on PR #44218: URL: https://github.com/apache/doris/pull/44218#issuecomment-2483475162 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jvm)fix jvm metrics memory leak. [doris]
doris-robot commented on PR #44218: URL: https://github.com/apache/doris/pull/44218#issuecomment-2483465336 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
