Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly merged PR #58683: URL: https://github.com/apache/doris/pull/58683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
github-actions[bot] commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3652592299 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
hello-stephen commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3616681382 # FE Regression Coverage Report Increment line coverage ` 100.00% (2/2)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58683_8d5ec7c1b4a81c9dc2d56f7989cfc639acb86571_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58683_8d5ec7c1b4a81c9dc2d56f7989cfc639acb86571_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
doris-robot commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3615931447 ClickBench: Total hot run time: 27.79 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8d5ec7c1b4a81c9dc2d56f7989cfc639acb86571, data reload: false query1 0.060.050.05 query2 0.090.050.05 query3 0.250.090.08 query4 1.600.110.11 query5 0.270.250.26 query6 1.170.650.64 query7 0.030.020.02 query8 0.050.050.04 query9 0.580.500.52 query10 0.570.560.57 query11 0.180.110.11 query12 0.150.120.10 query13 0.610.600.59 query14 0.990.990.98 query15 0.820.800.80 query16 0.390.390.40 query17 1.091.021.06 query18 0.230.210.22 query19 1.931.841.83 query20 0.020.010.01 query21 15.44 0.310.14 query22 4.870.050.04 query23 15.94 0.280.10 query24 1.030.640.62 query25 0.070.060.08 query26 0.140.140.13 query27 0.090.040.05 query28 4.271.221.03 query29 12.57 3.993.23 query30 0.270.130.12 query31 2.820.620.39 query32 3.230.550.46 query33 3.003.103.11 query34 16.84 5.224.59 query35 4.564.574.58 query36 0.650.530.49 query37 0.110.070.06 query38 0.080.040.04 query39 0.050.030.03 query40 0.170.140.13 query41 0.080.040.03 query42 0.040.020.02 query43 0.040.040.03 Total cold run time: 97.44 s Total hot run time: 27.79 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
doris-robot commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3615911655 TPC-DS: Total hot run time: 180436 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8d5ec7c1b4a81c9dc2d56f7989cfc639acb86571, data reload: false query5 4855644 514 514 query6 346 225 211 211 query7 4652471 270 270 query8 317 245 247 245 query9 8747264826432643 query10 544 330 272 272 query11 15398 15320 14906 14906 query12 185 117 113 113 query13 1683471 358 358 query14 6419320629942994 query14_12877290228942894 query15 210 197 193 193 query16 7621489 440 440 query17 1193707 596 596 query18 2047430 363 363 query19 212 187 163 163 query20 130 123 117 117 query21 221 138 114 114 query22 3901402338583858 query23 16519 16153 15887 15887 query23_116019 16038 15964 15964 query24 7215161911971197 query24_11223119312231193 query25 605 485 411 411 query26 1249285 170 170 query27 2915469 309 309 query28 4421217521482148 query29 859 563 449 449 query30 314 244 217 217 query31 863 729 620 620 query32 88 70 73 70 query33 648 352 302 302 query34 858 892 541 541 query35 801 825 742 742 query36 879 908 850 850 query37 130 92 80 80 query38 3850383538033803 query39 788 738 719 719 query39_1701 707 691 691 query40 229 132 126 126 query41 67 64 63 63 query42 135 105 96 96 query43 448 419 399 399 query44 1338773 764 764 query45 197 195 184 184 query46 912 980 598 598 query47 1689172116461646 query48 409 316 239 239 query49 751 441 361 361 query50 695 321 233 233 query51 3926394438603860 query52 119 103 86 86 query53 240 231 178 178 query54 329 292 262 262 query55 96 83 77 77 query56 355 318 312 312 query57 1177117611121112 query58 318 285 277 277 query59 2399239622752275 query60 383 333 317 317 query61 198 189 190 189 query62 789 687 655 655 query63 232 184 182 182 query64 4746129710581058 query65 4038401039923992 query66 1218481 367 367 query67 15109 15013 14696 14696 query68 6354937 670 670 query69 520 317 277 277 query70 1106991 995 991 query71 444 309 279 279 query72 6208499848994899 query73 703 559 308 308 query74 8812893787838783 query75 3051306225712571 query76 33321145746 746 query77 513 412 300 300 query78 9587957689368936 query79 1916852 573 573 query80 709 557 467 467 query81 508 268 247 247 query82 193 128 106 106 query83 280 280 267 267 query84 258 129 94 94 query85 896 487 462 462 query86 383 278 296 278 query87 4061403040114011 query88 4259216021052105 query89 393 323 281 281 query90 2089175 169 169 query91 176 171 146 146 query92 92 65 71 65 query93 23061047687 687 query94 793 323 296 296 query95 561 336 372 336 query96 546 509 213 213 query97 2620271025912591 query98 246 209 204 204 query99 1342133412131213 Total cold run time: 270339 ms Total hot run time: 180436 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
doris-robot commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3615880160 TPC-H: Total hot run time: 34827 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8d5ec7c1b4a81c9dc2d56f7989cfc639acb86571, data reload: false -- Round 1 -- q1 17618 516249814981 q2 2016310 192 192 q3 10265 1327767 767 q4 10208 821 327 327 q5 7507249621712171 q6 202 179 146 146 q7 972 799 664 664 q8 9369141111891189 q9 7261536954245369 q10 6889221718001800 q11 553 314 290 290 q12 399 398 235 235 q13 17772 371130573057 q14 241 237 217 217 q15 592 526 514 514 q16 910 854 814 814 q17 688 799 539 539 q18 7637714471177117 q19 1105963 644 644 q20 395 351 222 222 q21 4059378726262626 q22 10731000946 946 Total cold run time: 107731 ms Total hot run time: 34827 ms - Round 2, with runtime_filter_mode=off - q1 5015498649574957 q2 318 376 317 317 q3 2178264423032303 q4 1321178212921292 q5 4290462245794579 q6 228 175 136 136 q7 2025195918461846 q8 2673257625882576 q9 7669749275777492 q10 3161325428312831 q11 596 513 490 490 q12 711 766 635 635 q13 3630392233713371 q14 306 301 281 281 q15 551 529 497 497 q16 940 928 916 916 q17 1224140513871387 q18 7972783077767776 q19 971 890 890 890 q20 1941203718041804 q21 4692429042364236 q22 1106102410191019 Total cold run time: 53518 ms Total hot run time: 51631 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3615691448 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3615685396 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
hello-stephen commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3610203803 # FE Regression Coverage Report Increment line coverage ` 100.00% (4/4)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58683_9d96ee4ae3e1052d5aa662f45a6524a1ac34f69a_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58683_9d96ee4ae3e1052d5aa662f45a6524a1ac34f69a_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
github-actions[bot] commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3609901103 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
yujun777 commented on code in PR #58683:
URL: https://github.com/apache/doris/pull/58683#discussion_r2587298339
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/Scope.java:
##
@@ -82,13 +83,17 @@ public Scope(List slots, List asteriskSlots) {
/** Scope */
public Scope(Optional outerScope, List slots, List
asteriskSlots) {
this.outerScope = Objects.requireNonNull(outerScope, "outerScope can
not be null");
-this.slots = Utils.fastToImmutableList(Objects.requireNonNull(slots,
"slots can not be null"));
+this.slots = Utils.fastToImmutableList(Objects.requireNonNull(
Review Comment:
change this.slot / this.asteriskSlots to Set, this.slots =
Utils.fastToImmutableSet ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
yujun777 commented on code in PR #58683:
URL: https://github.com/apache/doris/pull/58683#discussion_r2587298339
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/Scope.java:
##
@@ -82,13 +83,17 @@ public Scope(List slots, List asteriskSlots) {
/** Scope */
public Scope(Optional outerScope, List slots, List
asteriskSlots) {
this.outerScope = Objects.requireNonNull(outerScope, "outerScope can
not be null");
-this.slots = Utils.fastToImmutableList(Objects.requireNonNull(slots,
"slots can not be null"));
+this.slots = Utils.fastToImmutableList(Objects.requireNonNull(
Review Comment:
change this.slot / this.asteriskSlots to Set, this.slots =
Utils.fastToImmutableSet ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
doris-robot commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3609732105 TPC-DS: Total hot run time: 181781 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9d96ee4ae3e1052d5aa662f45a6524a1ac34f69a, data reload: false query5 5570646 487 487 query6 340 246 233 233 query7 4666520 324 324 query8 310 273 252 252 query9 8736262326322623 query10 593 383 324 324 query11 15479 15129 14890 14890 query12 186 118 115 115 query13 1699581 466 466 query14 7781338231743174 query14_13003308929952995 query15 269 206 186 186 query16 7806697 504 504 query17 1609810 655 655 query18 2050441 329 329 query19 287 215 174 174 query20 134 123 124 123 query21 218 136 114 114 query22 3936400438623862 query23 16672 16242 15904 15904 query23_116009 15907 16017 15907 query24 6517160612061206 query24_11197123912231223 query25 577 517 461 461 query26 1227281 176 176 query27 2687502 341 341 query28 4338217821592159 query29 795 629 505 505 query30 314 243 219 219 query31 841 747 670 670 query32 87 77 70 70 query33 599 378 334 334 query34 838 902 546 546 query35 795 819 753 753 query36 892 942 848 848 query37 123 119 89 89 query38 3839390837783778 query39 778 752 705 705 query39_1707 702 699 699 query40 222 132 120 120 query41 71 65 64 64 query42 133 116 117 116 query43 456 452 433 433 query44 1360775 761 761 query45 201 196 187 187 query46 929 1032670 670 query47 1710172716401640 query48 409 444 351 351 query49 809 528 432 432 query50 750 717 428 428 query51 3951386139813861 query52 120 114 106 106 query53 249 255 191 191 query54 322 312 288 288 query55 94 99 97 97 query56 340 334 320 320 query57 1149116410671067 query58 293 282 273 273 query59 2299244223012301 query60 364 350 345 345 query61 164 162 172 162 query62 765 711 656 656 query63 244 196 197 196 query64 44981225972 972 query65 4054394539683945 query66 1045437 335 335 query67 15359 14910 14697 14697 query68 49191024663 663 query69 530 347 310 310 query70 1129105010231023 query71 440 350 330 330 query72 5901488449494884 query73 669 578 343 343 query74 8555879686098609 query75 3031303324922492 query76 32161156765 765 query77 516 417 313 313 query78 9522970389608960 query79 1294876 582 582 query80 694 603 506 506 query81 488 276 250 250 query82 197 136 117 117 query83 272 276 257 257 query84 265 118 93 93 query85 888 497 455 455 query86 344 289 277 277 query87 4024410139403940 query88 2945231222482248 query89 377 330 295 295 query90 1852230 230 230 query91 183 183 145 145 query92 75 73 70 70 query93 11881054680 680 query94 675 446 355 355 query95 492 426 413 413 query96 544 546 287 287 query97 2615271625492549 query98 249 219 216 216 query99 1344141012751275 Total cold run time: 265044 ms Total hot run time: 181781 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
doris-robot commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3609687424 TPC-H: Total hot run time: 34756 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 9d96ee4ae3e1052d5aa662f45a6524a1ac34f69a, data reload: false -- Round 1 -- q1 17643 506749164916 q2 2074318 207 207 q3 10241 1426754 754 q4 10222 860 334 334 q5 7526239622352235 q6 191 170 138 138 q7 937 808 634 634 q8 9355143211131113 q9 7036530553235305 q10 6796221917961796 q11 524 321 307 307 q12 347 366 228 228 q13 17770 370930873087 q14 232 248 218 218 q15 571 520 513 513 q16 917 872 812 812 q17 679 779 599 599 q18 7293717870947094 q19 1089959 627 627 q20 368 354 226 226 q21 4034350826572657 q22 1019992 956 956 Total cold run time: 106864 ms Total hot run time: 34756 ms - Round 2, with runtime_filter_mode=off - q1 4961495049074907 q2 336 390 316 316 q3 2135262922992299 q4 1321175812991299 q5 4244454046254540 q6 214 174 126 126 q7 2067198118351835 q8 2675248225652482 q9 7614759775187518 q10 3280323627782778 q11 588 506 504 504 q12 737 789 630 630 q13 3553395533893389 q14 302 307 263 263 q15 560 522 536 522 q16 893 940 910 910 q17 1221143314131413 q18 8047774174667466 q19 902 847 938 847 q20 2059210119611961 q21 4982448241784178 q22 10991031956 956 Total cold run time: 53790 ms Total hot run time: 51139 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3609624480 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3609619736 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
hello-stephen commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3606948427 # FE Regression Coverage Report Increment line coverage ` 100.00% (4/4)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58683_a0475bb9c7f3fbc6e60ca1b506a8eb9c9639701c_merge_fe/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58683_a0475bb9c7f3fbc6e60ca1b506a8eb9c9639701c_merge_fe/report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
doris-robot commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3606449955 TPC-DS: Total hot run time: 182790 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a0475bb9c7f3fbc6e60ca1b506a8eb9c9639701c, data reload: false query1 1066398 399 398 query2 6569121311701170 query3 6736236 226 226 query4 25527 23321 22831 22831 query5 5068642 518 518 query6 350 257 243 243 query7 4669544 312 312 query8 326 263 247 247 query9 8729266726632663 query10 540 403 320 320 query11 15371 14940 15239 14940 query12 192 118 118 118 query13 1695596 474 474 query14 10028 610560906090 query15 214 198 187 187 query16 7683686 541 541 query17 1242779 687 687 query18 2052430 341 341 query19 216 209 176 176 query20 130 126 120 120 query21 215 137 113 113 query22 3864397238463846 query23 33016 32181 31997 31997 query24 8425242424372424 query25 620 503 464 464 query26 1242278 180 180 query27 2717506 337 337 query28 4333219921742174 query29 835 637 501 501 query30 304 249 221 221 query31 832 710 614 614 query32 83 80 78 78 query33 609 388 345 345 query34 854 886 538 538 query35 795 842 750 750 query36 923 913 830 830 query37 128 116 106 106 query38 3894386537793779 query39 1551143614191419 query40 239 134 124 124 query41 71 66 63 63 query42 131 122 118 118 query43 440 449 434 434 query44 1362778 756 756 query45 200 191 193 191 query46 909 1027652 652 query47 1699172316261626 query48 421 436 334 334 query49 787 509 416 416 query50 715 709 429 429 query51 3893401738693869 query52 118 116 112 112 query53 244 273 189 189 query54 317 305 287 287 query55 96 99 93 93 query56 335 340 323 323 query57 1134116910711071 query58 288 283 276 276 query59 2284240023252325 query60 364 377 358 358 query61 166 168 166 166 query62 776 712 653 653 query63 239 202 192 192 query64 4526132610301030 query65 4080397639713971 query66 1086471 341 341 query67 15243 15168 14918 14918 query68 83981007639 639 query69 526 351 315 315 query70 11421024985 985 query71 439 368 323 323 query72 5762493748514851 query73 680 592 350 350 query74 8915888786818681 query75 3053309125582558 query76 33111164753 753 query77 548 430 342 342 query78 9381963388578857 query79 1477872 591 591 query80 644 597 494 494 query81 514 272 235 235 query82 227 145 118 118 query83 282 267 253 253 query84 265 118 101 101 query85 903 481 538 481 query86 376 299 272 272 query87 4053404040074007 query88 3070234223332333 query89 397 344 312 312 query90 1882237 233 233 query91 197 210 165 165 query92 82 81 72 72 query93 12221045685 685 query94 725 487 346 346 query95 542 415 419 415 query96 563 562 295 295 query97 2607270925872587 query98 241 215 209 209 query99 1298138212971297 Total cold run time: 269528 ms Total hot run time: 182790 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
doris-robot commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3606409308 TPC-H: Total hot run time: 34435 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a0475bb9c7f3fbc6e60ca1b506a8eb9c9639701c, data reload: false -- Round 1 -- q1 17676 523350085008 q2 2087318 216 216 q3 10199 1300740 740 q4 10215 828 322 322 q5 7535241021472147 q6 187 174 146 146 q7 947 802 646 646 q8 9352141410871087 q9 6969529552845284 q10 6798217817891789 q11 525 318 294 294 q12 337 368 228 228 q13 17763 367030803080 q14 247 236 228 228 q15 582 505 514 505 q16 892 887 824 824 q17 668 824 472 472 q18 7449720171167116 q19 1104961 590 590 q20 373 354 230 230 q21 3953336225302530 q22 10391009953 953 Total cold run time: 106897 ms Total hot run time: 34435 ms - Round 2, with runtime_filter_mode=off - q1 5000497949474947 q2 333 385 312 312 q3 2186273523022302 q4 1329173712871287 q5 4250453546504535 q6 212 170 130 130 q7 2030201918331833 q8 2670266225702570 q9 7473767273947394 q10 3058332129012901 q11 600 506 500 500 q12 703 775 613 613 q13 3675388433353335 q14 291 318 294 294 q15 594 505 532 505 q16 897 927 921 921 q17 1208149915281499 q18 7672770175437543 q19 879 889 913 889 q20 1995207219231923 q21 4962461545574557 q22 10701077978 978 Total cold run time: 53087 ms Total hot run time: 51768 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly commented on code in PR #58683:
URL: https://github.com/apache/doris/pull/58683#discussion_r2584649620
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/Scope.java:
##
@@ -82,13 +83,17 @@ public Scope(List slots, List asteriskSlots) {
/** Scope */
public Scope(Optional outerScope, List slots, List
asteriskSlots) {
this.outerScope = Objects.requireNonNull(outerScope, "outerScope can
not be null");
-this.slots = Utils.fastToImmutableList(Objects.requireNonNull(slots,
"slots can not be null"));
+this.slots = Utils.fastToImmutableList(Objects.requireNonNull(
Review Comment:
调用处拿到的也是list, 所以这里把签名改了也没有用,相当于把这个转换放到调用者那里执行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly commented on PR #58683: URL: https://github.com/apache/doris/pull/58683#issuecomment-3606290348 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](nereids) deduplicate scope slots [doris]
englefly commented on code in PR #58683:
URL: https://github.com/apache/doris/pull/58683#discussion_r2584649620
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/Scope.java:
##
@@ -82,13 +83,17 @@ public Scope(List slots, List asteriskSlots) {
/** Scope */
public Scope(Optional outerScope, List slots, List
asteriskSlots) {
this.outerScope = Objects.requireNonNull(outerScope, "outerScope can
not be null");
-this.slots = Utils.fastToImmutableList(Objects.requireNonNull(slots,
"slots can not be null"));
+this.slots = Utils.fastToImmutableList(Objects.requireNonNull(
Review Comment:
调用出拿到的也是list, 所以这里把签名改了也没有用,相当于把这个转换放到调用者那里执行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
